Chris Smowton
9e584eb241
Upgrade Go extractor compiler and dependency versions
2023-02-14 17:34:47 +00:00
Owen Mansel-Chan
4fa484dad2
Merge pull request #12130 from owen-mc/go/port-integration-tests
...
Go: port integration tests
2023-02-13 13:49:59 +00:00
Anders Schack-Mulligen
e877b161d8
Merge pull request #12124 from hvitved/dataflow/stage1-dispatch
...
Data flow: Call context virtual dispatch pruning in stage 1
2023-02-13 13:13:43 +01:00
Owen Mansel-Chan
7ebe472cfe
Move repo files into subfolder
...
This is so that the test-db doesn't get moved when all the repo files
are moved, which was causing some problems.
2023-02-13 11:59:38 +00:00
Owen Mansel-Chan
37d3793e87
Set LGTM_INDEX_IMPORT_PATH in two tests
...
This is needed for Dep and Glide
2023-02-13 11:59:38 +00:00
Owen Mansel-Chan
1f1e2dbf98
Make dep integration test linux-only
...
This is because there is no release of Dep for
MacOS (Arm).
2023-02-13 11:59:38 +00:00
Owen Mansel-Chan
3ee3acd8fd
Make Glide integration test linux-only
...
This is because it is hard to install Glide on the other platforms.
2023-02-13 11:59:37 +00:00
Owen Mansel-Chan
e635140eae
Add files needed for tests
2023-02-13 11:59:37 +00:00
Owen Mansel-Chan
f2c541a461
Delete build-sample test
...
This is adequately tested elsewhere.
2023-02-13 11:59:37 +00:00
Owen Mansel-Chan
f062a8d204
Copy LGTM integration tests over
2023-02-13 11:59:36 +00:00
Owen Mansel-Chan
947a9f12a1
Make DiagnosticsReporting.qll a library
2023-02-13 11:59:36 +00:00
Tom Hvitved
f7a5a33474
Address review comment
2023-02-13 09:01:15 +01:00
Owen Mansel-Chan
685b8b4abd
Tests are no longer fooled by type aliases
2023-02-10 22:09:21 +00:00
Owen Mansel-Chan
7042f67375
Refactor code to be simpler
2023-02-10 22:09:20 +00:00
Owen Mansel-Chan
778826b528
Accept test changes
...
Note that
go/ql/test/library-tests/semmle/go/Types/QualifiedNames.expected and
go/ql/test/library-tests/semmle/go/Types/Types.expected gain two lines.
In both cases this is because GenericArray and GenericSignature are
each instantiated twice, so they appear with two different locations.
2023-02-10 22:09:20 +00:00
Owen Mansel-Chan
202c0be303
Add hasLocationInfo for Types
...
It returns a dummy location except for named types with a type
declaration in the source.
2023-02-10 22:09:20 +00:00
Michael B. Gale
ad4ae1c331
Merge pull request #12132 from github/mbg/fix/log-injection-precision
...
Go: Downgrade `go/log-injection` precision to medium
2023-02-09 10:29:24 +00:00
Michael B. Gale
70a6ff84af
Add change note
2023-02-09 09:56:36 +00:00
Chris Smowton
f113eaa77d
Merge pull request #12059 from pwntester/go_twirp_support
...
[GoLang] Add support for Twirp framework
2023-02-08 21:55:56 +00:00
Michael B. Gale
46d49cd66f
Downgrade log injection precision to medium
...
This is in line with the precision of this query for other languages
2023-02-08 15:49:06 +00:00
Owen Mansel-Chan
18335854b6
Update go/ql/lib/semmle/go/frameworks/Twirp.qll
...
Co-authored-by: Michael B. Gale <mbg@github.com >
2023-02-08 15:33:35 +00:00
Chris Smowton
99bed0b089
Merge pull request #12127 from smowton/smowton/perf/golang-less-string-construction
...
Go: Consolidate repeated calls to `matches` and `regexpMatch`
2023-02-08 11:07:39 +00:00
Alvaro Muñoz
764155ce97
remove bracket
2023-02-08 11:57:03 +01:00
Michael B. Gale
3abf321071
Merge pull request #11496 from github/mbg/add/writable-file-closed-error-query
...
Go: Add query to detect lack of error handling for `os.File.Close` on writable handles
2023-02-08 10:53:44 +00:00
Owen Mansel-Chan
931c683146
Use regex for case-insensitive string comparisons
...
This is slightly more efficient.
2023-02-08 10:45:07 +00:00
Owen Mansel-Chan
c427f8fc95
Do not import file defining a Configuration
2023-02-08 06:31:25 +00:00
Chris Smowton
99d3f689dc
Consolidate repeated calls to matches and regexpMatch
...
This is especially useful if it avoids temporary string construction, such as toLowerCase().matches(...)
2023-02-07 19:22:49 +00:00
Tom Hvitved
8e8897b08b
Data flow: Sync files
2023-02-07 15:15:04 +01:00
Chris Smowton
cd2fc6566f
Merge pull request #12101 from owen-mc/go/gofmt-remove-confusing-error-message
...
Fix files that gofmt can't parse
2023-02-06 10:58:54 +00:00
Mathias Vorreiter Pedersen
00fe448e3a
Merge pull request #12072 from aschackmull/dataflow/stage3-perf
...
Dataflow: Fix join in `fwdFlowRead` (take 2)
2023-02-06 10:43:11 +00:00
Michael B. Gale
f7a2a8677a
Rename change note file
2023-02-06 09:13:11 +00:00
Michael B. Gale
6c0d2bdee1
Add example without defer statement
2023-02-06 09:10:41 +00:00
Michael B. Gale
25f907867b
Update expected test output
2023-02-06 08:51:46 +00:00
Michael B. Gale
abe38373da
Inline precededBySync
2023-02-06 08:47:47 +00:00
Michael B. Gale
c252ec0414
Add test for deferred close that returns error
2023-02-06 08:47:47 +00:00
Michael B. Gale
e05bce9863
Update expected test results
2023-02-06 08:47:46 +00:00
Michael B. Gale
314ecab90a
Use dominatesNode and improve variable naming
2023-02-06 08:47:46 +00:00
Michael B. Gale
85a339030b
Make the query a path-problem
2023-02-06 08:47:46 +00:00
Michael B. Gale
199c8641ec
Rename close to sink in query
2023-02-06 08:47:46 +00:00
Michael B. Gale
f648b021a9
Despecialise parameter names for precededBySync
2023-02-06 08:47:46 +00:00
Michael B. Gale
bd6c167be6
Fixup: more docs improvements
2023-02-06 08:47:46 +00:00
Michael B. Gale
f866e16679
Use any instead of exists for isCloseSink
2023-02-06 08:47:45 +00:00
Michael B. Gale
5ab6056b26
Fixup: docs comment
2023-02-06 08:47:45 +00:00
Michael B. Gale
3f446bc76e
Use three-argument hasQualifiedName
2023-02-06 08:47:45 +00:00
Michael B. Gale
07041bb659
Use Method instead of Function where able
2023-02-06 08:47:45 +00:00
Michael B. Gale
416ed57583
Fix qldoc comments
2023-02-06 08:47:45 +00:00
Michael B. Gale
f321adf9f4
Fix typo
...
Co-authored-by: Owen Mansel-Chan <62447351+owen-mc@users.noreply.github.com >
2023-02-06 08:47:44 +00:00
Michael B. Gale
10109b4925
Fix class comments
2023-02-06 08:47:44 +00:00
Michael B. Gale
49ce91fd5b
Update precision to high
2023-02-06 08:47:44 +00:00
Michael B. Gale
7e9617f3ce
Detect lack of error handling for os.File.Close
2023-02-06 08:47:43 +00:00