hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-28 18:25:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

Use any instead of exists for isCloseSink

Browse Source
This commit is contained in:
Michael B. Gale
2022-12-08 13:55:32 +00:00
parent 5ab6056b26
commit f866e16679
1 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
go/ql/src/InconsistentCode/UnhandledCloseWritableHandle.ql
View File

@@ -90,14 +90,12 @@ predicate isWritableFileHandle(DataFlow::Node source, DataFlow::CallNode call) {
* Determines whether `os.File.Close` is called on `sink`.
*/
predicate isCloseSink(DataFlow::Node sink, DataFlow::CallNode call) {
exists(CloseFileFun f |
// find calls to the os.File.Close function
f.getACall() = call and
// that are deferred
unhandledCall(call) and
// where the function is called on the sink
call.getReceiver() = sink
)
// find calls to the os.File.Close function
call = any(CloseFileFun f).getACall() and
// that are deferred
unhandledCall(call) and
// where the function is called on the sink
call.getReceiver() = sink
}
/**