hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 19:26:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

Use regex for case-insensitive string comparisons

Browse Source 
This is slightly more efficient.
This commit is contained in:
Owen Mansel-Chan
2023-02-08 10:45:07 +00:00
committed by GitHub
parent c427f8fc95
commit 931c683146
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
go/ql/lib/semmle/go/frameworks/Twirp.qll
View File

@@ -80,7 +80,7 @@ module Twirp {
exists(ServiceInterfaceType i, PointerType p, TypeEntity te |
p.implements(i) and
this = p.getBaseType() and
this.getName().toLowerCase() = i.getName().toLowerCase() + ["protobuf", "json"] + "client" and
this.getName().regexpMatch("(?i)" + i.getName() + ["(protobuf|json)" + "client") and
te.getType() = this and
te.getDeclaration().getLocation().getFile() instanceof ServicesGeneratedFile
)
@@ -94,7 +94,7 @@ module Twirp {
ServiceServerType() {
exists(ServiceInterfaceType i, TypeEntity te |
this.implements(i) and
this.getName().toLowerCase() = i.getName().toLowerCase() + "server" and
this.getName().regexpMatch("(?i)" + i.getName() + "server") and
te.getType() = this and
te.getDeclaration().getLocation().getFile() instanceof ServicesGeneratedFile
)
@@ -107,7 +107,7 @@ module Twirp {
class ClientConstructor extends Function {
ClientConstructor() {
exists(ServiceClientType c |
this.getName().toLowerCase() = "new" + c.getName().toLowerCase() and
this.getName().regexpMatch("(?i)new" + c.getName()) and
this.getParameterType(0) instanceof StringType and
this.getParameterType(1).getName() = "HTTPClient" and
this.getDeclaration().getLocation().getFile() instanceof ServicesGeneratedFile
@@ -123,7 +123,7 @@ module Twirp {
class ServerConstructor extends Function {
ServerConstructor() {
exists(ServiceServerType c, ServiceInterfaceType i |
this.getName().toLowerCase() = "new" + c.getName().toLowerCase() and
this.getName().regexpMatch("(?i)new" + c.getName()) and
this.getParameterType(0) = i.getNamedType() and
this.getDeclaration().getLocation().getFile() instanceof ServicesGeneratedFile
)