hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-16 16:53:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #716 from xiemaisi/js/cosmetics

Browse Source 
Approved by esben-semmle
This commit is contained in:
semmle-qlci
2019-01-03 16:11:50 +00:00
committed by GitHub
parent 9b8bf96a6f 5ccad6ffc2
commit 6c768263d2
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
javascript/ql/src/semmle/javascript/frameworks/Express.qll
View File

@@ -851,12 +851,11 @@ module Express {
}
/** A call to `response.sendFile`, considered as a file system access. */
private class ResponseSendFileAsFileSystemAccess extends FileSystemReadAccess, DataFlow::ValueNode {
override MethodCallExpr astNode;
private class ResponseSendFileAsFileSystemAccess extends FileSystemReadAccess, DataFlow::MethodCallNode {
ResponseSendFileAsFileSystemAccess() {
exists (string name | name = "sendFile" or name = "sendfile" |
asExpr().(MethodCallExpr).calls(any(ResponseExpr res), name))
calls(any(ResponseExpr res).flow(), name)
)
}
override DataFlow::Node getADataNode() {
@@ -864,7 +863,7 @@ module Express {
}
override DataFlow::Node getAPathArgument() {
result = DataFlow::valueNode(astNode.getArgument(0))
result = getArgument(0)
}
override DataFlow::Node getRootPathArgument() {