From 5ccad6ffc206985626cd94669c2804634c805ab1 Mon Sep 17 00:00:00 2001 From: Max Schaefer Date: Fri, 14 Dec 2018 11:56:59 +0000 Subject: [PATCH] JavaScript: Minor improvements. --- .../ql/src/semmle/javascript/frameworks/Express.qll | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/javascript/ql/src/semmle/javascript/frameworks/Express.qll b/javascript/ql/src/semmle/javascript/frameworks/Express.qll index 09ac3cdce2e..4940dddd2ab 100644 --- a/javascript/ql/src/semmle/javascript/frameworks/Express.qll +++ b/javascript/ql/src/semmle/javascript/frameworks/Express.qll @@ -851,12 +851,11 @@ module Express { } /** A call to `response.sendFile`, considered as a file system access. */ - private class ResponseSendFileAsFileSystemAccess extends FileSystemReadAccess, DataFlow::ValueNode { - override MethodCallExpr astNode; - + private class ResponseSendFileAsFileSystemAccess extends FileSystemReadAccess, DataFlow::MethodCallNode { ResponseSendFileAsFileSystemAccess() { exists (string name | name = "sendFile" or name = "sendfile" | - asExpr().(MethodCallExpr).calls(any(ResponseExpr res), name)) + calls(any(ResponseExpr res).flow(), name) + ) } override DataFlow::Node getADataNode() { @@ -864,7 +863,7 @@ module Express { } override DataFlow::Node getAPathArgument() { - result = DataFlow::valueNode(astNode.getArgument(0)) + result = getArgument(0) } }