hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-02-09 19:51:07 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add check for predicates with an override annotation

Browse Source
This commit is contained in:
Joe Farebrother
2021-10-13 12:22:46 +01:00
parent 33bd267eb0
commit 1b4130fe97
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
ql/src/queries/performance/ClassPredicateDoesntMentionThis.ql
View File

@@ -81,5 +81,6 @@ where
not usesThis(pred) and
not isTrivialImplementation(pred) and
not isSingleton(pred.getDeclaringType()) and
not exists(ClassPredicate other | pred.overrides(other) or other.overrides(pred))
not exists(ClassPredicate other | pred.overrides(other) or other.overrides(pred)) and
not pred.isOverride()
select pred, "This predicate could be a classless predicate, as it doesn't depend on `this`."