From 1b4130fe972074ad844d5426fe12ddc1c5ded91c Mon Sep 17 00:00:00 2001 From: Joe Farebrother Date: Wed, 13 Oct 2021 12:22:46 +0100 Subject: [PATCH] Add check for predicates with an override annotation --- ql/src/queries/performance/ClassPredicateDoesntMentionThis.ql | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ql/src/queries/performance/ClassPredicateDoesntMentionThis.ql b/ql/src/queries/performance/ClassPredicateDoesntMentionThis.ql index 978c486bb17..3bd8237d798 100644 --- a/ql/src/queries/performance/ClassPredicateDoesntMentionThis.ql +++ b/ql/src/queries/performance/ClassPredicateDoesntMentionThis.ql @@ -81,5 +81,6 @@ where not usesThis(pred) and not isTrivialImplementation(pred) and not isSingleton(pred.getDeclaringType()) and - not exists(ClassPredicate other | pred.overrides(other) or other.overrides(pred)) + not exists(ClassPredicate other | pred.overrides(other) or other.overrides(pred)) and + not pred.isOverride() select pred, "This predicate could be a classless predicate, as it doesn't depend on `this`."