Commit Graph

3745 Commits

Author SHA1 Message Date
Robert
e55fb8c7a7 Merge pull request #2191 from github/robertbrignull/variant_analysis_commands
Convert all variant analysis commands to typed commands
2023-03-22 11:56:31 +00:00
Robert
a6fefdbabb Merge branch 'main' into robertbrignull/variant_analysis_commands 2023-03-22 11:44:25 +00:00
Robert
2334e4e7b2 Merge pull request #2192 from github/robertbrignull/export_selected_results_command
Move codeQL.exportSelectedVariantAnalysisResults to query history manager
2023-03-22 11:41:13 +00:00
Koen Vlaswinkel
3240809d11 Merge pull request #2200 from github/koesie10/restart-typed-command
Convert codeQL.restartQueryServer to a typed command
2023-03-22 12:37:20 +01:00
Koen Vlaswinkel
3e66e7aaf3 Merge remote-tracking branch 'origin/main' into koesie10/restart-typed-command 2023-03-22 12:10:54 +01:00
Koen Vlaswinkel
71831fe460 Merge pull request #2201 from github/koesie10/eval-log-viewer-typed-command
Convert codeQLEvalLogViewer.clear to a typed command
2023-03-22 12:07:34 +01:00
Robert
0983733a67 fix typo 2023-03-22 10:51:03 +00:00
Robert
0166f9a557 Merge branch 'main' into robertbrignull/variant_analysis_commands 2023-03-22 10:50:17 +00:00
Robert
5af0ebcb24 convert to type imports 2023-03-22 10:49:50 +00:00
Koen Vlaswinkel
56c83eb480 Merge pull request #2195 from github/koesie10/move-database-commands
Move remaining local database commands to databases UI
2023-03-22 11:36:56 +01:00
Koen Vlaswinkel
aa0d011daa Convert codeQLEvalLogViewer.clear to a typed command 2023-03-22 11:34:39 +01:00
Koen Vlaswinkel
76558b8d41 Merge pull request #2194 from github/koesie10/typed-local-query-commands
Convert local query commands to typed commands
2023-03-22 11:34:34 +01:00
Koen Vlaswinkel
eb5659a628 Merge branch 'main' into koesie10/move-database-commands 2023-03-22 11:22:48 +01:00
Koen Vlaswinkel
11b4de1820 Merge branch 'main' into koesie10/typed-local-query-commands 2023-03-22 11:20:02 +01:00
Koen Vlaswinkel
2c8c7cec8f Convert codeQL.restartQueryServer to a typed command 2023-03-22 10:29:09 +01:00
Koen Vlaswinkel
1c6d9f3f22 Use commandRunner for codeQL.restartQueryServer 2023-03-22 10:26:29 +01:00
Elena Tanasoiu
f196e34fa5 Merge pull request #2188 from github/elena/force-workspace-in-codespace
Codespace: Open tutorial workspace on extension start
2023-03-22 08:30:31 +00:00
Elena Tanasoiu
a7800ce3bc Merge branch 'main' into elena/force-workspace-in-codespace 2023-03-22 07:46:19 +00:00
github-actions[bot]
168af11e00 Bump CLI version from v2.12.4 to v2.12.5 for integration tests (#2197)
Co-authored-by: github-actions[bot] <github-actions@github.com>
2023-03-21 16:27:58 +00:00
Elena Tanasoiu
8fd9ebf2d8 Limit comparison to Uri path
We attempted to specify exactly which URI we're expecting here.

However, `Uri.parse` behaves differently in the test than it does in
the code so we've inadvertently created a flakey test [1]. The URI we
generate in the test has a `scheme: 'c'` while the one in the code has
a `scheme: 'C'` property.

This only happens on windows, not ubuntu.

Let's narrow the comparison to just the path of the URI.

[1]: https://github.com/github/vscode-codeql/actions/runs/4478429334/jobs/7871178529#step:7:231
2023-03-21 14:26:22 +00:00
Koen Vlaswinkel
bed56ef648 Make public methods private in local databases UI
Some of the methods in the `DatabaseUI` were public because they were
used in the `extension.ts` file. We have moved these method calls into
this file, so they do not need to be public anymore. We can also get rid
of the separation between some of these methods, so I've moved them into
the function that calls them.
2023-03-21 14:50:24 +01:00
Koen Vlaswinkel
7ab986fabe Move codeQL.chooseDatabaseGithub command 2023-03-21 14:48:14 +01:00
Koen Vlaswinkel
15d30d5342 Move codeQL.chooseDatabaseInternet command 2023-03-21 14:47:26 +01:00
Koen Vlaswinkel
71f22b9a7a Move codeQL.chooseDatabaseArchive command 2023-03-21 14:45:54 +01:00
Koen Vlaswinkel
32b6ad53cf Move codeQL.chooseDatabaseFolder command 2023-03-21 14:44:46 +01:00
Koen Vlaswinkel
ac2f4475c0 Group local database commands by type 2023-03-21 14:40:04 +01:00
Elena Tanasoiu
108943d135 existsSync -> pathExists
Use async version of file check.
2023-03-21 13:19:33 +00:00
Gulshan Singh
bb0c53d65d Display EntityValue labels in CSV export (#2170) 2023-03-21 11:59:18 +00:00
Nora
82d03091d0 Merge pull request #2193 from github/nora/query-history-data-model
Move query-serialization
2023-03-21 12:23:18 +01:00
Elena Tanasoiu
c1a515ed82 Open tutorial before extension activation
To reduce lag when checking for the existence of the tutorial workspace.
2023-03-21 11:20:14 +00:00
Elena Tanasoiu
0368d537ad Ask the user for permission to reload workspace
To make this a nicer experience for the user, we're adding a prompt
to let them know we're about to reload the workspace.
2023-03-21 11:20:14 +00:00
Elena Tanasoiu
7059802a25 Add more logging before attempting to open tutorial workspace 2023-03-21 11:20:14 +00:00
Elena Tanasoiu
0f4fcdf676 Add comment with PR description
This adds the explanation from the PR description in a comment and
removes comment that's no longer helpful.
2023-03-21 11:20:14 +00:00
Elena Tanasoiu
ce413a6385 Stub isCodespaceTemplate correctly
Now that we fixed our expectation in the previous commit, we could see we
were stubbing this to false instead of true.

So now the test is checking the right scenario.
2023-03-21 11:20:13 +00:00
Elena Tanasoiu
8db9f52df3 Adjust the rest of the test expectations
Our expectation was quite narrow: we expect to not call an `openFolder`
command. We didn't specify any params for it, which might mean this
expectation wasn't working like it should.

Let's just check that `executeCommand` isn't called at all.
2023-03-21 11:20:13 +00:00
Elena Tanasoiu
782e413c64 Add workspace filepath to test expectation 2023-03-21 11:20:13 +00:00
Elena Tanasoiu
fade710f95 Call it commandSpy everywhere 2023-03-21 11:20:13 +00:00
Elena Tanasoiu
737a1f5c37 Use existing file path consistently 2023-03-21 11:19:56 +00:00
Koen Vlaswinkel
7950c1c982 Convert local query commands to typed commands
The local query commands are using a separate logger, and this is not
supported by the command manager because it is quite specific to this
extension. Therefore, we create a separate command manager which uses
a different logger to separate the commands.
2023-03-21 12:08:44 +01:00
Koen Vlaswinkel
f37a6c5e9e Convert commandRunnerWithProgress to commandRunner 2023-03-21 12:08:44 +01:00
Koen Vlaswinkel
649179f62e Rename local queries manager variable names 2023-03-21 12:08:44 +01:00
Koen Vlaswinkel
8a2630d1b7 Move local queries commands to separate file 2023-03-21 12:08:44 +01:00
Nora
fa29bcc5fd Rename serializer 2023-03-21 11:03:58 +00:00
Nora
5cd50a67e7 Move query-serialization 2023-03-21 10:39:02 +00:00
Koen Vlaswinkel
f7b6d4c4a4 Merge pull request #2189 from github/koesie10/typed-local-database-ui-commands
Convert local database commands to typed commands
2023-03-21 10:39:57 +01:00
Koen Vlaswinkel
58bffe1edf Merge remote-tracking branch 'origin/main' into koesie10/typed-local-database-ui-commands 2023-03-21 10:27:31 +01:00
Robert
0c9df6edba Convert the codeQL.openVariantAnalysisView command 2023-03-20 17:41:23 +00:00
Robert
ac0d920156 Convert the codeQL.loadVariantAnalysisRepoResults command 2023-03-20 17:41:23 +00:00
Robert
5f2a8fa1d5 Convert the codeQL.autoDownloadVariantAnalysisResult command 2023-03-20 17:41:21 +00:00
Robert
b55910d2b9 Convert the codeQL.monitorVariantAnalysis command 2023-03-20 17:32:35 +00:00