Elena Tanasoiu
d49bffe98e
Decouple VariantAnalysisManager from VariantAnalysisResultsManager
...
At the moment we create the results manager as a private property on the `VariantAnalysisManager`.
If we instead created it at the extension level and passed it to the `VariantAnalysisManager`, we would have more freedom to write unit tests for the `VariantAnalysisManager` without needing to reach into a private results manager property.
2022-10-26 13:47:52 +01:00
Shati Patel
50ec71893c
Implement openQueryResults for variant analysis items ( #1654 )
2022-10-26 10:20:23 +01:00
Andrew Eisenberg
56af69e58d
Merge pull request #1638 from github/aeisenberg/persist-dbs
...
Fix bug where dbs are lost on restart
2022-10-25 10:28:58 -07:00
Andrew Eisenberg
d209e52a0b
Merge branch 'main' into aeisenberg/persist-dbs
2022-10-25 08:54:31 -07:00
Andrew Eisenberg
09b30fe5a3
Merge pull request #1568 from asgerf/asgerf/navigate-alerts
...
Add commands for navigation of alerts
2022-10-25 08:51:38 -07:00
Andrew Eisenberg
c6d54de748
Update extensions/ql-vscode/CHANGELOG.md
...
Co-authored-by: Edoardo Pirovano <6748066+edoardopirovano@users.noreply.github.com >
2022-10-25 08:42:27 -07:00
Andrew Eisenberg
a3fafc8e59
Merge pull request #1611 from github/aeisenberg/fix-flakes
...
Test cleanups
2022-10-25 08:26:26 -07:00
Charis Kyriakou
6a636baa21
Remove historyItemId for variant analyses ( #1651 )
2022-10-25 12:57:48 +00:00
Charis Kyriakou
9e92d0c4a7
Allow multiple query history items for a single variant analysis ( #1653 )
2022-10-25 13:47:53 +01:00
Shati Patel
78a0a4e580
Bump CLI version to 2.11.2 for integration tests
2022-10-25 11:30:04 +01:00
Koen Vlaswinkel
f0f01720f1
Merge pull request #1648 from github/koesie10/store-scenario-bodies-as-files
...
Store binary scenario bodies as files
2022-10-25 11:18:38 +02:00
Elena Tanasoiu
c8b0461f7f
Merge pull request #1620 from github/mob/consume-update-event
...
QueryHistory: Consume event when variant analysis status is updated
2022-10-25 09:20:31 +01:00
Koen Vlaswinkel
00de0820fb
Add proper handling of binary responses
...
msw doesn't seem to support binary responses because it decodes them to
a UTF-8 string. To work around that, we will do a separate fetch of the
file and save that.
2022-10-25 10:07:43 +02:00
Koen Vlaswinkel
5a76df8489
Load response bodies from files
2022-10-25 10:07:16 +02:00
Koen Vlaswinkel
9764a93900
Store ZIP bodies as files
2022-10-25 10:06:50 +02:00
Charis Kyriakou
130d8efe35
Tidy up msw handlers used for scenario replay ( #1649 )
2022-10-25 08:44:29 +01:00
Angela P Wen
63a5021e5e
Use sarif parser for reopened results ( #1457 )
2022-10-24 12:31:35 -07:00
Edoardo Pirovano
e891169ca3
MRVA: Use QLX to precompile queries
...
Co-authored-by: Henning Makholm <hmakholm@github.com >
2022-10-24 17:33:25 +01:00
Charis Kyriakou
98284d9b2c
Add loading of mock scenarios ( #1641 )
2022-10-24 16:27:37 +01:00
Asger F
b480f8f375
Fix incorrect merge resolution in changelog
2022-10-24 13:20:42 +02:00
Asger F
ead1fb4cd9
Merge branch 'main' into asgerf/navigate-alerts
2022-10-24 13:19:05 +02:00
Asger F
0acf9f7b66
Fix bad suggestion merge in package.json
2022-10-24 13:18:33 +02:00
Asger F
9cb4b9d372
Update extensions/ql-vscode/package.json
...
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com >
2022-10-24 13:13:57 +02:00
Shati Patel
8a10a49f66
Merge pull request #1639 from github/shati-patel/repo-count
...
Implement query history label for variant analysis items
2022-10-24 11:29:09 +01:00
Koen Vlaswinkel
40d281aa3f
Merge pull request #1646 from github/koesie10/fix-command-visibility
...
Fix scenario commands visibility
2022-10-24 12:17:42 +02:00
Elena Tanasoiu
b25cb8adbe
Merge branch 'main' into mob/consume-update-event
2022-10-24 11:13:41 +01:00
Nora
88edcaf067
Merge pull request #1621 from github/norascheuch/variant-analysis-rehydrate-and-remove-event
...
Implement rehydration for variant analysis
2022-10-24 11:47:44 +02:00
shati-patel
8737cfde0b
Add undefined case to pluralize unit tests
2022-10-24 10:44:16 +01:00
shati-patel
593ca57497
Cover more cases in buildRepoLabel unit tests
2022-10-24 10:30:56 +01:00
Koen Vlaswinkel
471ead37c0
Fix scenario commands visibility
...
When the mock GitHub API server setting was moved to the top-level, we
forgot the comamnds in the `package.json`. This updates the commands to
have the correct visibility.
See: https://github.com/github/vscode-codeql/pull/1643
2022-10-24 11:30:09 +02:00
shati-patel
436af066fc
Add unit tests for pluralize
2022-10-24 10:17:03 +01:00
shati-patel
c85338d11a
refactor: move pluralize into its own module
2022-10-24 10:08:49 +01:00
Nora
1523babcb3
Implement new filePath method suggestion
...
Co-authored-by: Robert <robertbrignull@github.com >
2022-10-24 10:40:03 +02:00
Nora
4ed0e0fa09
Implement find-method suggestion
...
Co-authored-by: Robert <robertbrignull@github.com >
2022-10-24 10:40:03 +02:00
Nora
79bb894a7d
Implement rehydration for variant analysis and introduce onRemoveVariantAnalysis event
2022-10-24 10:40:03 +02:00
Charis Kyriakou
da63b99a94
Update mock GitHub API request models to support failures ( #1644 )
2022-10-24 08:02:36 +00:00
Koen Vlaswinkel
c325a725ea
Merge pull request #1642 from github/koesie10/validate-mocks
...
Add linter for scenario files
2022-10-24 10:01:44 +02:00
Charis Kyriakou
6c8c15155b
Restructure configuration around mock GitHub API ( #1643 )
2022-10-24 08:44:32 +01:00
shati-patel
3cd025f879
Add a unit test for building repo labels
2022-10-21 17:01:46 +01:00
Charis Kyriakou
6b1fce9cd5
Revert to previously used version of husky ( #1640 )
2022-10-21 14:51:56 +00:00
Koen Vlaswinkel
104055e703
Add linter for scenario files
...
This adds a linter for JSON scenario files which will validate the JSON
files in the scenarios directory against the TypeScript types. It will
convert the TypeScript types to JSON schema to simplify this process.
Unfortunately, this will not currently allow adding scenarios with
failing requests since the types do not allow this. Rather than removing
this validation, we should fix the types. This can be done in a follow-up
PR.
2022-10-21 16:41:01 +02:00
shati-patel
add5417a42
Move pluralize method into "pure" helpers file (since we don't require vscode)
2022-10-21 15:04:01 +01:00
Shati Patel
31ef6aef29
Implement buildRepoLabel for variant analysis items
2022-10-21 14:18:53 +01:00
Shati Patel
bd81d3c4a7
Fix bug in pluralize helper method
...
Correctly handle the zero case
2022-10-21 14:17:40 +01:00
Koen Vlaswinkel
4e5abee2ea
Merge pull request #1634 from github/koesie10/record-scenario
...
Add recording of mock scenarios
2022-10-21 14:52:29 +02:00
Asger F
bdf7208476
Mention keyboard navigation in README
2022-10-21 14:26:54 +02:00
Asger F
e1a56dd91d
Update a new more nullish checks
2022-10-21 14:26:37 +02:00
Asger F
d4a58a64ee
Consistently check for undefined rather than nullish
2022-10-21 14:17:06 +02:00
Koen Vlaswinkel
71b1b49502
Fix incorrect development scenarios path
...
Co-authored-by: Charis Kyriakou <charisk@users.noreply.github.com >
2022-10-21 14:12:35 +02:00
Asger F
65777b5e60
Use null-aware accessors in getResult
2022-10-21 13:56:30 +02:00
