mrva/vscode-codeql
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
4,129 Commits 3 Branches 107 Tags
8c0d0d800dee88b05ebd729da9cf4236555c4f7a
Commit Graph

4129 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Elena Tanasoiu
8c0d0d800d Merge pull request #2305 from github/elena/yer-a-progress-query 
Small fixes to skeleton query wizard
 2023-04-13 09:09:19 +01:00
Elena Tanasoiu
03adb70e45 Merge pull request #2298 from github/elena/yer-a-windows-query 
Fix problem with detecting storage folder on windows
 2023-04-13 08:54:56 +01:00
Koen Vlaswinkel
e15f01c4a3 Merge pull request #2295 from github/koesie10/pick-extension-model-file 
Add configurable model filename to data extension editor
 2023-04-13 08:55:32 +02:00
Elena Tanasoiu
7f8f0653b0 Merge branch 'main' into elena/yer-a-windows-query 2023-04-12 18:08:43 +01:00
Elena Tanasoiu
eabcd00e75 Merge pull request #2297 from github/elena/improvements-to-wizard 
Refactor `digForDatabaseItem` and `digForDatabaseWithSameLanguage` methods for skeleton wizard
 2023-04-12 18:08:30 +01:00
Elena Tanasoiu
3627139c8a Hide command behind canary flag 
Adding this temporarily
 2023-04-12 16:52:05 +00:00
Elena Tanasoiu
77bffd5bb1 Correct error messages to indicate ql pack storage path 2023-04-12 16:52:04 +00:00
Elena Tanasoiu
e981530b20 Import methods instead of whole databaseFetcher object 2023-04-12 16:52:04 +00:00
Elena Tanasoiu
b00e2aa09f Rename codeQL.createSkeletonQuery -> codeQL.createQuery 2023-04-12 16:52:04 +00:00
Elena Tanasoiu
c9f7860621 Move try/catch into execute command 
So that we're able to catch any errors when this fails.
 2023-04-12 16:52:04 +00:00
Elena Tanasoiu
eff5f1f197 Fix regex expression 2023-04-12 16:52:04 +00:00
Elena Tanasoiu
9f04c712e0 Use progress correctly 
By setting maxSteps to the correct number of steps.
 2023-04-12 16:52:04 +00:00
Elena Tanasoiu
4c04daafb7 Merge branch 'main' into elena/improvements-to-wizard 2023-04-12 17:40:08 +01:00
Elena Tanasoiu
a48b1f823a Merge pull request #2256 from github/elena/yer-a-lizard-query 
Improvements to skeleton query flow
 2023-04-12 17:39:47 +01:00
Elena Tanasoiu
e298f2ba09 Take storage path off App instead of extension context 2023-04-12 16:39:14 +00:00
Elena Tanasoiu
b4468d612a Download databases into extension storage path 
Now that we've figured out how to set the storage path for both Mac &
Windows, we also want to make sure we're consistent with the location
where we save databases.

At the moment, our change will download databases directly in the
workspace folder.

When we call `downloadGitHubDatabase()` in other places outside the
wizard, we provide `ctx.storageUri.fsPath` as the location. [1] [2] [3]

Let's do the same here.

I've tested this on Mac for the codespaces-codeql & starter workspaces.

[1]: c7bb22c312/extensions/ql-vscode/src/local-databases-ui.ts (L476)
[2]: c7bb22c312/extensions/ql-vscode/src/extension.ts (L710)
[3]: c7bb22c312/extensions/ql-vscode/src/extension.ts (L1120)
 2023-04-12 16:30:41 +00:00
Elena Tanasoiu
f8b0ecafcc Merge branch 'main' into elena/yer-a-lizard-query 2023-04-12 17:24:19 +01:00
Elena Tanasoiu
6fc6f399fd Shorten check for progress 
Co-authored-by: Koen Vlaswinkel <koesie10@users.noreply.github.com>
 2023-04-12 16:11:17 +00:00
Elena Tanasoiu
f377bb93ac Merge pull request #2250 from github/elena/yer-a-wizard-query 
Adapt skeleton pack generation to work with new queries panel
 2023-04-12 17:07:12 +01:00
Andrew Eisenberg
b3ff1ed52f Merge pull request #2289 from github/aeisenberg/watch-external-config 
Restart query server when external config changes
 2023-04-12 08:27:27 -07:00
Shati Patel
b5c65b5189 Minor: fix typo in changelog (#2303) 2023-04-12 15:18:19 +00:00
Andrew Eisenberg
6de58ec19d Address review comments 2023-04-12 15:14:54 +00:00
Anders Starcke Henriksen
b3e78c33e5 Merge pull request #2301 from github/version/bump-to-v1.8.3 
Bump version to v1.8.3
 2023-04-12 16:35:25 +02:00
Elena Tanasoiu
785c8c1f22 Rename storagePath -> qlPackStoragePath 2023-04-12 14:25:43 +00:00
shati-patel
4b01374a6f Use path.join in folder paths 2023-04-12 14:12:33 +01:00
github-actions[bot]
341e0375a6 Bump version to v1.8.3 2023-04-12 12:58:18 +00:00
Anders Starcke Henriksen
c7bb22c312 Merge pull request #2299 from github/v1.8.2
Some checks failed
Release / Release (push) Has been cancelled
Details
Release / Publish to VS Code Marketplace (push) Has been cancelled
Details
Release / Publish to Open VSX Registry (push) Has been cancelled
Details 
v1.8.2
v1.8.2 		2023-04-12 14:52:57 +02:00
shati-patel
a968aab209 Remove explicit Windows test 
This should be covered by running the general test suite in CI (on windows-latest)
 2023-04-12 13:26:23 +01:00
Anders Starcke Henriksen
3c8dc04845 v1.8.2 2023-04-12 14:26:17 +02:00
shati-patel
1e1594b2a7 Use fsPath instead of path everywhere 2023-04-12 13:14:20 +01:00
shati-patel
636be05f2b Fix "invalid characters" bug on Windows 
We now use `fsPath` instead of `path`.

Note: I haven't yet fixed the tests, nor checked manually on mac/linux

Tangential change: we now use the `dirname` method, instead of manually splitting paths to get a parent folder.
 2023-04-12 12:51:13 +01:00
Koen Vlaswinkel
5cdf7ed76f Fix model file label on Windows 2023-04-12 12:04:17 +02:00
Elena Tanasoiu
3087886400 Fix problem with detecting storage folder on windows 
The `getFirstStoragePath()` method would break on windows:

```
Path contains invalid characters: /c:/git-repo/codespaces-codeql (codeQL.createSkeletonQuery)
```

This makes sense, since we're looking to get the parent folder by splitting for `/`.

In windows, paths use `\` instead of `/`.

So let's detect the platform and add a test for this case.
 2023-04-12 09:47:00 +00:00
Elena Tanasoiu
a6ffb6b020 Move back mockCli into beforeEach 
This was an attempt to make the tests run in a shorter timeframe, but
we've gone with increasing the timeout to 40s.
 2023-04-12 09:38:43 +00:00
Elena Tanasoiu
72b2080b02 Rename search methods 
To be consistent with other database item search methods, we're renaming
ours:

`digForDatabaseItem` -> `findDatabaseItemByNwo`
and
`digForDatabaseItemSameLanguage` -> `findDatabaseItemByLanguage`
 2023-04-12 09:38:43 +00:00
Elena Tanasoiu
6b26323ee0 Move database Item search methods into skeleton wizard 
And the tests for it. We can now re-use the factory from the previous commit.
 2023-04-12 09:38:43 +00:00
Elena Tanasoiu
0ff2e83fde Move db mocking into factory file 
So we can re-use it.
 2023-04-12 09:38:43 +00:00
Koen Vlaswinkel
89c318bdc6 Rename extensions-packs.ts to extension-pack-picker.ts 2023-04-12 11:38:07 +02:00
Elena Tanasoiu
de4afae0a0 Don't track when user doesn't provide repo 2023-04-12 09:17:01 +00:00
Elena Tanasoiu
389d8f04d9 Don't show progress when choosing repo 2023-04-12 09:17:01 +00:00
Koen Vlaswinkel
a876c2ddb7 Add tests for extension pack and model file selection 2023-04-12 11:12:05 +02:00
Elena Tanasoiu
e4406f4c07 Merge branch 'main' into elena/yer-a-wizard-query 2023-04-12 09:47:11 +01:00
Koen Vlaswinkel
cdb6e8a3d3 Move all progress reporting into extension packs file 2023-04-12 10:13:08 +02:00
Koen Vlaswinkel
035456cd31 Rename resolve extensions results 2023-04-12 10:10:41 +02:00
Koen Vlaswinkel
649a47d966 Show all found locations in output log 2023-04-12 08:50:51 +02:00
Elena Tanasoiu
919219c084 Show the user a selection box before downloading database 
At the moment, we're always deciding which database to download for the
user for an example query.

We'd like to give them a chance to change the database, so here we're
adding a step where we're showing the user a selection box with the
suggested database pre-filled.

They can choose to type in a different database before continuing the
skeleton generation process.
 2023-04-11 16:54:09 +00:00
Elena Tanasoiu
3e3eb0da0a Re-use existing database if one for the same language is already downloaded 
We'd like to select an existing database for our query, if on is
already downloaded and matches the query language.

Previously we were re-using the database if the language and name
matched (e.g. the name would be `github/codeql`).
 2023-04-11 16:53:00 +00:00
Koen Vlaswinkel
b0940e6da9 Merge pull request #2279 from github/koesie10/fix-result-view-selected 
Fix empty result view when switching between queries
 2023-04-11 17:33:58 +02:00
Robert
048428b237 Merge pull request #2294 from github/robertbrignull/no_distribution_install 
Don't rate limit if no CLI is installed
 2023-04-11 16:18:55 +01:00
Elena Tanasoiu
460da1ea08 Add language to list of params 2023-04-11 15:00:00 +00:00