Commit Graph

8152 Commits

Author SHA1 Message Date
Asger F
8b8d174781 Clean up some more TODOs 2025-01-17 11:36:08 +01:00
Asger F
370b17c0f5 Remove TODOs 2025-01-17 11:35:16 +01:00
Asger F
37dcd0822b Remove TODO that was just resolved 2025-01-17 11:34:54 +01:00
Asger F
f09210b033 Only record cache hits prior to first evaluation 2025-01-17 11:26:40 +01:00
Asger F
44d33d6d31 Merge branch 'asgerf/compare-perf-view' of github.com:asgerf/vscode-codeql into asgerf/compare-perf-view 2025-01-17 10:53:03 +01:00
Asger F
08bffab05f Add more description of the "struct of arrays" layout 2025-01-17 10:51:49 +01:00
Asger F
2293cc3537 Update extensions/ql-vscode/src/log-insights/log-scanner.ts
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
2025-01-17 10:43:15 +01:00
Asger F
6f461e75a7 Update extensions/ql-vscode/package.json
Restrict to Canary

Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
2025-01-17 10:40:09 +01:00
Asger F
aa528c6037 Remove unused export 2024-11-27 14:14:52 +01:00
Asger F
c99bf5bb9f Only warn about cache hits in comparison mode 2024-11-27 14:14:52 +01:00
Asger F
afa3d558c6 Factor header rows into a component 2024-11-27 14:14:51 +01:00
Asger F
b9d15511cb Hide "sort by" dropdown when there is no delta to sort by 2024-11-27 14:14:51 +01:00
Asger F
8a58279e67 Move "total" row to the top and render the metric 2024-11-27 14:14:51 +01:00
Asger F
d37469fc94 Add 'per evaluation' option next to metric 2024-11-27 14:14:51 +01:00
Asger F
2cae71c657 Add predicate-renaming support 2024-11-27 14:14:51 +01:00
Asger F
568f0827b2 Fix some crashes when pretty-printing an empty name
Predicate names can't be empty, but it can happen with the renaming feature added in the next commit.
2024-11-27 13:47:57 +01:00
Asger F
4a835b8711 Factor out rendering of table body to a memoized component 2024-11-27 13:47:57 +01:00
Asger F
ab00152ce2 Group together rows by fingerprinting 2024-11-27 13:47:57 +01:00
Asger F
48954c7d22 Rename TRow -> Row 2024-11-27 13:47:57 +01:00
Asger F
9a0699f50a Refactor predicate row into a separate component 2024-11-27 13:47:57 +01:00
Asger F
eec42c5532 Split renderAbsoluteValue into renderOptionalValue and renderPredicateMetric 2024-11-27 13:47:57 +01:00
Asger F
d008963602 Refactor OptionalValue 2024-11-27 13:47:57 +01:00
Asger F
9800fa1333 Use interface instead of type alias for TRow 2024-11-27 13:47:57 +01:00
Asger F
62f3b4f696 Reformat code again
Only contains formatting changes
2024-11-27 13:47:57 +01:00
Asger F
6f7eb74496 Reset hasCacheMismatch when rebuilding 'rows' 2024-11-27 13:47:57 +01:00
Asger F
6568b569a1 Also useMemo the 'total' row computation 2024-11-27 13:47:57 +01:00
Asger F
558d957eb7 Reformat code 2024-11-27 13:47:57 +01:00
Asger F
20f6e3d45c Use useMemo a few places to speed up UI interactions 2024-11-27 13:47:57 +01:00
Asger F
b05ec33ba3 Use useMemo for 'nameSet' 2024-11-27 13:47:57 +01:00
Asger F
1d2c2cfcf9 Allow word wrap to break anywhere 2024-11-27 13:47:56 +01:00
Taus
e039f6bc52 Simplify view when not in comparison mode 2024-11-27 13:47:56 +01:00
Taus
6d4427e59c compare-perf: Add support for selecting a single run as input
A very hacky implementation that simply instantiates an empty
`PerformanceOverviewScanner` as the "from" column (i.e. with all values
empty). To see it in action, select a single query run in the query
history and pick "Compare Performance" from the context menu. Then
select the "Single run" option when prompted.
2024-11-27 13:47:56 +01:00
Esben Sparre Andreasen
412338c717 feat: parallel log scanning 2024-11-27 13:47:56 +01:00
Asger F
ccf2dc64ac Simplify datasets assignment 2024-11-27 13:47:56 +01:00
Asger F
453aa833f2 Check for nullness of 'data' in a separate component
This ensures we can use hooks after the check in the main component
2024-11-27 13:47:56 +01:00
Asger F
260bf0e8d1 Add option to choose metric 2024-11-27 13:47:56 +01:00
Taus
876c5b6091 Colorize positive/negative deltas 2024-11-27 13:47:56 +01:00
Asger F
317e52c0e7 Also abbreviate RA names in predicate overview 2024-11-27 13:47:56 +01:00
Asger F
03ca407713 Make "..." clickable to reveal abbreviated name 2024-11-27 13:47:56 +01:00
Asger F
58afeba1ac Apply a background color to the pipeline header rows 2024-11-27 13:47:56 +01:00
Asger F
8268d6812f Apply styling to RA predicate names 2024-11-27 13:47:56 +01:00
Asger F
70ec5704c8 Make RAPrettyPrinter generate JSX fragments 2024-11-27 13:47:55 +01:00
Taus
aaf23eae72 compare-perf: Add support for sorting options
Adds a dropdown with (at present) two options: sorting by delta and
sorting by absolute delta.
2024-11-27 13:47:55 +01:00
Asger F
96aa770e85 Show evaluation and iteration counts in table 2024-11-27 13:47:55 +01:00
Asger F
3b0697771d Add Compare Performance command (WIP) 2024-11-27 13:47:55 +01:00
Stephan Brandauer
60c15a0eb2 Merge pull request #3842 from github/update-docs
update ambiguous docs
2024-11-26 10:39:32 +01:00
Stephan Brandauer
f5cd48d9d9 update ambiguous docs 2024-11-26 09:26:48 +00:00
Koen Vlaswinkel
94434f4397 Merge pull request #3841 from github/koesie10/bump-cross-spawn
Bump cross-spawn version
2024-11-26 09:21:36 +01:00
Koen Vlaswinkel
f77ae4cd69 Bump cross-spawn version 2024-11-25 14:02:01 +01:00
Koen Vlaswinkel
5a3aeb6332 Merge pull request #3839 from github/koesie10/switch-to-execa
Remove unmaintained child-process-promise
2024-11-25 14:00:45 +01:00