Robert
1f18cc3f2c
Use Readonly and ReadonlyArray
2023-06-19 10:58:26 +01:00
Robert
989ef8b681
Fix typo
2023-06-19 10:57:20 +01:00
Robert
70681253eb
Only expose event to subclasses, instead of event emitter
2023-06-19 10:57:10 +01:00
Robert
af62a92c5b
Make pathData private to FilePathDiscovery
2023-06-16 16:40:11 +01:00
Robert
da92a67834
Introduce recomputeAllData to avoid mutating pathData from outside of FilePathDiscovery
2023-06-16 16:35:58 +01:00
Robert
c6a7e1fb3c
Rename from path to pathData where appropriate
2023-06-16 16:23:39 +01:00
Robert
d626cea837
Use getOnDiskWorkspaceFolders instead of getOnDiskWorkspaceFoldersObjects when all we need is the path
2023-06-16 16:14:08 +01:00
Robert
bdea0c2c20
Use one lstat call instead of calling exists first
2023-06-16 16:12:29 +01:00
Robert
44327cac23
Use sets instead of custom expectArraysEqual
2023-06-16 15:23:32 +01:00
Robert
3a0aaa0ae9
Use jest.SpiedFunction instead of jest.SpyInstance
2023-06-16 12:35:59 +01:00
Robert
18e7431a44
Make conditional easier to read
2023-06-16 12:33:21 +01:00
Robert
6504e46011
Invert condition to reduce nesting
2023-06-16 12:31:12 +01:00
Robert
ce6a21c65a
Use pathExists instead of exists
2023-06-16 12:21:36 +01:00
Robert
fce27d02dc
Use a plain Set intead of custom FilePathSet
2023-06-16 11:29:38 +01:00
Robert
f7a72c6d45
Use QueryLanguage where possible
2023-06-16 11:29:28 +01:00
Robert
959c3fbcb8
Fix typos
2023-06-16 10:47:07 +01:00
Robert
5cbb7b49d7
Update QueryDiscovery to use FilePathDiscovery and QueryPackDiscovery
2023-06-14 17:30:40 +01:00
Robert
a9d59aecb8
Add QueryPackDiscovery
2023-06-14 17:30:37 +01:00
Robert
17b5e000f8
Add FilePathDiscovery
2023-06-14 17:30:33 +01:00
Robert
790c33c661
Add silent arg to resolveLibraryPath
2023-06-14 16:09:42 +01:00
Robert
51b94e3fed
Add FilePathSet
2023-06-14 16:09:42 +01:00
Robert
b0441956df
Remove the update method from the Discovery class
...
See https://github.com/github/vscode-codeql/pull/2490#discussion_r1226437598
for more explanation. This will make the class more useful for future usecases
where we don't want the behaviour of only calling update when there isn't
another refresh scheduled. I also think it doesn't negatively affect other
users such as the query test discovery. The effect should be that we'll see
more updates to the UI. These updates will get overwritten quickly, but they
are all genuine snapshots of the filesystem at the point the discovery process
ran, so they aren't incorrect, or aren't more incorrect than continuing to show
the old state before any discovery ran.
2023-06-14 16:09:42 +01:00
Koen Vlaswinkel
8803433fa4
Merge pull request #2515 from github/version/bump-to-v1.8.7
...
Bump version to v1.8.7
2023-06-14 14:53:24 +02:00
github-actions[bot]
ab448e51d5
Bump version to v1.8.7
2023-06-14 12:20:00 +00:00
Koen Vlaswinkel
2905f5340a
Merge pull request #2514 from github/v1.8.6
...
Release / Release (push) Has been cancelled
Release / Publish to VS Code Marketplace (push) Has been cancelled
Release / Publish to Open VSX Registry (push) Has been cancelled
v1.8.6
2023-06-14 13:51:21 +02:00
Koen Vlaswinkel
170fce8815
v1.8.6
2023-06-14 13:17:03 +02:00
Koen Vlaswinkel
d54ee0c0e5
Merge pull request #2508 from github/koesie10/split-helpers-4
...
Split helpers.ts [Part 4]
2023-06-14 11:15:04 +02:00
Nora
fa7d85ea58
Merge pull request #2512 from github/nora/remove-code-search-flag
...
Remove code search feature flag
2023-06-14 10:41:19 +02:00
Koen Vlaswinkel
179942680e
Merge pull request #2506 from github/koesie10/split-helpers-3
...
Move show and log functions out of helpers
2023-06-14 10:28:43 +02:00
Koen Vlaswinkel
f67f53dd68
Merge remote-tracking branch 'origin/main' into koesie10/split-helpers-3
2023-06-14 09:30:41 +02:00
Koen Vlaswinkel
c6c56284ff
Merge pull request #2505 from github/koesie10/split-helpers-2
...
Split `helpers.ts` [Part 2]
2023-06-14 09:29:58 +02:00
Nora
afa2f426b8
Update Changelog
2023-06-13 14:55:14 +00:00
Nora
fd381640a0
Remove feature flag
2023-06-13 14:55:02 +00:00
Robert
019e3772ef
Merge pull request #2510 from github/robertbrignull/use_contains_path
...
Use containsPath where possible
2023-06-13 10:19:01 +01:00
Nora
a03b3dca86
Merge pull request #2507 from github/nora/remove-1000-list-limit
...
Remove limit of 1000 repos per list
2023-06-13 09:57:16 +02:00
Robert
cad651d6bd
Use containsPath where possible
2023-06-12 16:33:35 +01:00
Robert
400bde6e03
Merge pull request #2509 from github/robertbrignull/contains_path
...
Fix containsPath for paths that share a prefix
2023-06-12 16:17:39 +01:00
Robert
3a9fa42790
Merge branch 'main' into robertbrignull/contait push origin robertbrignull/contains_pathns_path
2023-06-12 15:39:47 +01:00
Robert
c920b7e49e
Remove explicit check for windows
2023-06-12 15:16:43 +01:00
Koen Vlaswinkel
ccf38a98fb
Move incorrectly named helpers.test.ts
2023-06-12 15:55:10 +02:00
Koen Vlaswinkel
00240e56f4
Rename helpers.ts to tmp-dir.ts
2023-06-12 15:55:10 +02:00
Koen Vlaswinkel
1096ed8bf5
Move upgradesTmpDir out of helpers
2023-06-12 15:55:10 +02:00
Koen Vlaswinkel
61ac19f715
Move createTimestampFile out of helpers
2023-06-12 15:55:09 +02:00
Koen Vlaswinkel
9a32556b4d
Move query language functions out of helpers
2023-06-12 15:55:09 +02:00
Koen Vlaswinkel
2cd88cecde
Move tryGetQueryMetadata out of helpers
2023-06-12 15:55:09 +02:00
Robert
6dbbd22c0a
Merge pull request #2497 from github/robertbrignull/cleanup_workspace_folders
...
Remove workspaceFolders from app because it turned out not to be useful
2023-06-12 14:50:00 +01:00
Robert
aa4c459cdd
Use relative instead of startsWith to handle paths with the same prefix
2023-06-12 14:41:31 +01:00
Robert
f7c1f06354
Add another test case for case insensitivity on windows
2023-06-12 14:41:31 +01:00
Robert
6e3d0147c9
Add test cases for paths with the same prefix
2023-06-12 14:41:31 +01:00
Robert
300503e1c9
Remove platform arg as it's never not the process.platform
2023-06-12 14:41:31 +01:00
