mrva/vscode-codeql
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Change parameter type + extract local variable

Browse Source
This commit is contained in:
shati-patel
2022-06-01 20:47:25 +01:00
committed by Shati Patel
parent a3bbdafabb
commit d41c63bf7d
2 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
extensions/ql-vscode/src/pure/bqrs-utils.ts
View File

@@ -98,7 +98,7 @@ export function isStringLoc(loc: UrlValue): loc is string {
export function tryGetRemoteLocation( export function tryGetRemoteLocation(
loc: UrlValue | undefined, loc: UrlValue | undefined,
fileLinkPrefix: string, fileLinkPrefix: string,
sourceLocationPrefix: string, sourceLocationPrefix: string | undefined,
): string | undefined { ): string | undefined {
const resolvableLocation = tryGetResolvableLocation(loc); const resolvableLocation = tryGetResolvableLocation(loc);
if (!resolvableLocation) { if (!resolvableLocation) {

5
extensions/ql-vscode/src/remote-queries/view/RawResultsTable.tsx
View File

@@ -48,10 +48,11 @@ const Cell = ({
return <span>{convertNonPrintableChars(value.toString())}</span>; return <span>{convertNonPrintableChars(value.toString())}</span>;
case 'object': { case 'object': {
const url = tryGetRemoteLocation(value.url, fileLinkPrefix, sourceLocationPrefix); const url = tryGetRemoteLocation(value.url, fileLinkPrefix, sourceLocationPrefix);
const safeLabel = convertNonPrintableChars(value.label);
if (url) { if (url) {
return <Link href={url}>{convertNonPrintableChars(value.label)}</Link>; return <Link href={url}>{safeLabel}</Link>;
} else { } else {
return <span>{convertNonPrintableChars(value.label)}</span>; return <span>{safeLabel}</span>;
} }
} }
} }