mrva/vscode-codeql
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Rename function

Browse Source
This commit is contained in:
shati-patel
2021-09-14 17:33:14 +01:00
committed by Shati Patel
parent b59638bd2e
commit a2b8e7d193
2 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
extensions/ql-vscode/src/run-remote-query.ts
View File

@@ -130,11 +130,12 @@ async function runRemoteQueriesApiRequest(credentials: Credentials, ref: string,
void showAndLogInformationMessage(`Successfully scheduled runs. [Click here to see the progress](https://github.com/${OWNER}/${REPO}/actions).`);
} catch (error) {
await validateRepositories(error, credentials, ref, language, repositories, query);
await attemptRerun(error, credentials, ref, language, repositories, query);
}
}
export async function validateRepositories(error: any, credentials: Credentials, ref: string, language: string, repositories: string[], query: string) {
/** Attempts to rerun the query on only the valid repositories */
export async function attemptRerun(error: any, credentials: Credentials, ref: string, language: string, repositories: string[], query: string) {
if (typeof error.message === 'string' && error.message.includes('Some repositories were invalid')) {
const invalidRepos = error?.response?.data?.invalid_repos || [];
const reposWithoutDbUploads = error?.response?.data?.repos_without_db_uploads || [];

6
extensions/ql-vscode/src/vscode-tests/no-workspace/run-remote-query.test.ts
View File

@@ -105,7 +105,7 @@ describe('run-remote-query', function() {
});
describe('validateRepositories', () => {
describe('attemptRerun', () => {
let sandbox: sinon.SinonSandbox;
let showAndLogErrorMessageSpy: sinon.SinonStub;
let showInformationMessageWithActionSpy: sinon.SinonStub;
@@ -152,7 +152,7 @@ describe('run-remote-query', function() {
const repositories = ['abc/def', 'ghi/jkl', 'mno/pqr', 'stu/vwx'];
// make the function call
await mod.validateRepositories(error, credentials, ref, language, repositories, query);
await mod.attemptRerun(error, credentials, ref, language, repositories, query);
// check logging output
expect(logSpy.firstCall.args[0]).to.contain('Unable to run query');
@@ -168,7 +168,7 @@ describe('run-remote-query', function() {
showInformationMessageWithActionSpy.resolves(true);
// make the function call
await mod.validateRepositories(error, credentials, ref, language, repositories, query);
await mod.attemptRerun(error, credentials, ref, language, repositories, query);
// check logging output
expect(logSpy.firstCall.args[0]).to.contain('Unable to run query');