mrva/vscode-codeql
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Merge pull request #2950 from github/koesie10/variant-analysis-save-before-start

Browse Source 
Use `saveBeforeStart` setting when running a variant analysis
This commit is contained in:
Koen Vlaswinkel
2023-10-11 14:34:08 +02:00
committed by GitHub
parent 3a035708c5 11218522e7
commit 918362f39e
2 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
extensions/ql-vscode/CHANGELOG.md
View File

@@ -8,6 +8,7 @@
- Fix a bug where the query server was restarted twice after configuration changes. [#2884](https://github.com/github/vscode-codeql/pull/2884). - Fix a bug where the query server was restarted twice after configuration changes. [#2884](https://github.com/github/vscode-codeql/pull/2884).
- Add support for the `telemetry.telemetryLevel` setting. For more information, see the [telemetry documentation](https://codeql.github.com/docs/codeql-for-visual-studio-code/about-telemetry-in-codeql-for-visual-studio-code). [#2824](https://github.com/github/vscode-codeql/pull/2824). - Add support for the `telemetry.telemetryLevel` setting. For more information, see the [telemetry documentation](https://codeql.github.com/docs/codeql-for-visual-studio-code/about-telemetry-in-codeql-for-visual-studio-code). [#2824](https://github.com/github/vscode-codeql/pull/2824).
- Fix syntax highlighting directly after import statements with instantiation arguments. [#2792](https://github.com/github/vscode-codeql/pull/2792) - Fix syntax highlighting directly after import statements with instantiation arguments. [#2792](https://github.com/github/vscode-codeql/pull/2792)
- The `debug.saveBeforeStart` setting is now respected when running variant analyses. [#2950](https://github.com/github/vscode-codeql/pull/2950)
## 1.9.1 - 29 September 2023 ## 1.9.1 - 29 September 2023

4
extensions/ql-vscode/src/variant-analysis/variant-analysis-manager.ts
View File

@@ -42,7 +42,7 @@ import {
processVariantAnalysisRepositoryTask, processVariantAnalysisRepositoryTask,
} from "./variant-analysis-processor"; } from "./variant-analysis-processor";
import PQueue from "p-queue"; import PQueue from "p-queue";
import { createTimestampFile } from "../run-queries-shared"; import { createTimestampFile, saveBeforeStart } from "../run-queries-shared";
import { readFile, remove, pathExists } from "fs-extra"; import { readFile, remove, pathExists } from "fs-extra";
import { EOL } from "os"; import { EOL } from "os";
import { cancelVariantAnalysis } from "./gh-api/gh-actions-api-client"; import { cancelVariantAnalysis } from "./gh-api/gh-actions-api-client";
@@ -199,6 +199,8 @@ export class VariantAnalysisManager
progress: ProgressCallback, progress: ProgressCallback,
token: CancellationToken, token: CancellationToken,
): Promise<void> { ): Promise<void> {
await saveBeforeStart();
progress({ progress({
maxStep: 5, maxStep: 5,
step: 0, step: 0,