From 0bdd44176799eae918a2a8f6b0f188e01564b4b2 Mon Sep 17 00:00:00 2001 From: Koen Vlaswinkel Date: Wed, 11 Oct 2023 13:33:24 +0200 Subject: [PATCH 1/2] Use `saveBeforeStart` setting when running a variant analysis This will respect the user's `saveBeforeStart` setting when running a variant analysis. This re-uses the existing `saveBeforeStart` function that is used when running local queries. The default behavior if the setting is not set is to save all open named files. --- .../src/variant-analysis/variant-analysis-manager.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/extensions/ql-vscode/src/variant-analysis/variant-analysis-manager.ts b/extensions/ql-vscode/src/variant-analysis/variant-analysis-manager.ts index 411186bb1..8ff46901f 100644 --- a/extensions/ql-vscode/src/variant-analysis/variant-analysis-manager.ts +++ b/extensions/ql-vscode/src/variant-analysis/variant-analysis-manager.ts @@ -42,7 +42,7 @@ import { processVariantAnalysisRepositoryTask, } from "./variant-analysis-processor"; import PQueue from "p-queue"; -import { createTimestampFile } from "../run-queries-shared"; +import { createTimestampFile, saveBeforeStart } from "../run-queries-shared"; import { readFile, remove, pathExists } from "fs-extra"; import { EOL } from "os"; import { cancelVariantAnalysis } from "./gh-api/gh-actions-api-client"; @@ -199,6 +199,8 @@ export class VariantAnalysisManager progress: ProgressCallback, token: CancellationToken, ): Promise { + await saveBeforeStart(); + progress({ maxStep: 5, step: 0, From 11218522e79cbd42661ca0bce80587a742ba7c5e Mon Sep 17 00:00:00 2001 From: Koen Vlaswinkel Date: Wed, 11 Oct 2023 13:35:11 +0200 Subject: [PATCH 2/2] Update CHANGELOG --- extensions/ql-vscode/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/extensions/ql-vscode/CHANGELOG.md b/extensions/ql-vscode/CHANGELOG.md index 56c1e2a9c..48554b650 100644 --- a/extensions/ql-vscode/CHANGELOG.md +++ b/extensions/ql-vscode/CHANGELOG.md @@ -8,6 +8,7 @@ - Fix a bug where the query server was restarted twice after configuration changes. [#2884](https://github.com/github/vscode-codeql/pull/2884). - Add support for the `telemetry.telemetryLevel` setting. For more information, see the [telemetry documentation](https://codeql.github.com/docs/codeql-for-visual-studio-code/about-telemetry-in-codeql-for-visual-studio-code). [#2824](https://github.com/github/vscode-codeql/pull/2824). - Fix syntax highlighting directly after import statements with instantiation arguments. [#2792](https://github.com/github/vscode-codeql/pull/2792) +- The `debug.saveBeforeStart` setting is now respected when running variant analyses. [#2950](https://github.com/github/vscode-codeql/pull/2950) ## 1.9.1 - 29 September 2023