mrva/vscode-codeql
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Remove debug log entry (#1616)

Browse Source
This commit is contained in:
Charis Kyriakou
2022-10-17 15:52:26 +01:00
committed by GitHub
parent 3b644fea7b
commit 4fd9b54c58
3 changed files with 2 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
extensions/ql-vscode/src/remote-queries/variant-analysis-manager.ts
View File

@@ -39,7 +39,7 @@ export class VariantAnalysisManager extends DisposableObject implements VariantA
logger: Logger, logger: Logger,
) { ) {
super(); super();
this.variantAnalysisMonitor = this.push(new VariantAnalysisMonitor(ctx, logger)); this.variantAnalysisMonitor = this.push(new VariantAnalysisMonitor(ctx));
this.variantAnalysisMonitor.onVariantAnalysisChange(this.onVariantAnalysisUpdated.bind(this)); this.variantAnalysisMonitor.onVariantAnalysisChange(this.onVariantAnalysisUpdated.bind(this));
this.variantAnalysisResultsManager = this.push(new VariantAnalysisResultsManager(cliServer, storagePath, logger)); this.variantAnalysisResultsManager = this.push(new VariantAnalysisResultsManager(cliServer, storagePath, logger));

4
extensions/ql-vscode/src/remote-queries/variant-analysis-monitor.ts
View File

@@ -1,6 +1,5 @@
import { ExtensionContext, CancellationToken, commands, EventEmitter } from 'vscode'; import { ExtensionContext, CancellationToken, commands, EventEmitter } from 'vscode';
import { Credentials } from '../authentication'; import { Credentials } from '../authentication';
import { Logger } from '../logging';
import * as ghApiClient from './gh-api/gh-api-client'; import * as ghApiClient from './gh-api/gh-api-client';
import { VariantAnalysis, VariantAnalysisStatus } from './shared/variant-analysis'; import { VariantAnalysis, VariantAnalysisStatus } from './shared/variant-analysis';
@@ -22,7 +21,6 @@ export class VariantAnalysisMonitor extends DisposableObject {
constructor( constructor(
private readonly extensionContext: ExtensionContext, private readonly extensionContext: ExtensionContext,
private readonly logger: Logger
) { ) {
super(); super();
} }
@@ -73,8 +71,6 @@ export class VariantAnalysisMonitor extends DisposableObject {
this._onVariantAnalysisChange.fire(variantAnalysis); this._onVariantAnalysisChange.fire(variantAnalysis);
void this.logger.log('****** Retrieved variant analysis' + JSON.stringify(variantAnalysisSummary));
if (variantAnalysisSummary.scanned_repositories) { if (variantAnalysisSummary.scanned_repositories) {
variantAnalysisSummary.scanned_repositories.forEach(scannedRepo => { variantAnalysisSummary.scanned_repositories.forEach(scannedRepo => {
if (!scannedReposDownloaded.includes(scannedRepo.repository.id) && scannedRepo.analysis_status === 'succeeded') { if (!scannedReposDownloaded.includes(scannedRepo.repository.id) && scannedRepo.analysis_status === 'succeeded') {

4
extensions/ql-vscode/src/vscode-tests/cli-integration/remote-queries/variant-analysis-monitor.test.ts
View File

@@ -2,7 +2,6 @@ import * as sinon from 'sinon';
import { expect } from 'chai'; import { expect } from 'chai';
import { CancellationTokenSource, extensions } from 'vscode'; import { CancellationTokenSource, extensions } from 'vscode';
import { CodeQLExtensionInterface } from '../../../extension'; import { CodeQLExtensionInterface } from '../../../extension';
import { logger } from '../../../logging';
import * as config from '../../../config'; import * as config from '../../../config';
import * as ghApiClient from '../../../remote-queries/gh-api/gh-api-client'; import * as ghApiClient from '../../../remote-queries/gh-api/gh-api-client';
@@ -30,7 +29,6 @@ describe('Variant Analysis Monitor', async function() {
beforeEach(async () => { beforeEach(async () => {
sandbox = sinon.createSandbox(); sandbox = sinon.createSandbox();
sandbox.stub(logger, 'log');
sandbox.stub(config, 'isVariantAnalysisLiveResultsEnabled').returns(false); sandbox.stub(config, 'isVariantAnalysisLiveResultsEnabled').returns(false);
cancellationTokenSource = new CancellationTokenSource(); cancellationTokenSource = new CancellationTokenSource();
@@ -39,7 +37,7 @@ describe('Variant Analysis Monitor', async function() {
try { try {
const extension = await extensions.getExtension<CodeQLExtensionInterface | Record<string, never>>('GitHub.vscode-codeql')!.activate(); const extension = await extensions.getExtension<CodeQLExtensionInterface | Record<string, never>>('GitHub.vscode-codeql')!.activate();
variantAnalysisMonitor = new VariantAnalysisMonitor(extension.ctx, logger); variantAnalysisMonitor = new VariantAnalysisMonitor(extension.ctx);
} catch (e) { } catch (e) {
fail(e as Error); fail(e as Error);
} }