diff --git a/extensions/ql-vscode/src/remote-queries/variant-analysis-manager.ts b/extensions/ql-vscode/src/remote-queries/variant-analysis-manager.ts index 6978efb05..a4673b203 100644 --- a/extensions/ql-vscode/src/remote-queries/variant-analysis-manager.ts +++ b/extensions/ql-vscode/src/remote-queries/variant-analysis-manager.ts @@ -39,7 +39,7 @@ export class VariantAnalysisManager extends DisposableObject implements VariantA logger: Logger, ) { super(); - this.variantAnalysisMonitor = this.push(new VariantAnalysisMonitor(ctx, logger)); + this.variantAnalysisMonitor = this.push(new VariantAnalysisMonitor(ctx)); this.variantAnalysisMonitor.onVariantAnalysisChange(this.onVariantAnalysisUpdated.bind(this)); this.variantAnalysisResultsManager = this.push(new VariantAnalysisResultsManager(cliServer, storagePath, logger)); diff --git a/extensions/ql-vscode/src/remote-queries/variant-analysis-monitor.ts b/extensions/ql-vscode/src/remote-queries/variant-analysis-monitor.ts index 2aaa91a70..33c16853f 100644 --- a/extensions/ql-vscode/src/remote-queries/variant-analysis-monitor.ts +++ b/extensions/ql-vscode/src/remote-queries/variant-analysis-monitor.ts @@ -1,6 +1,5 @@ import { ExtensionContext, CancellationToken, commands, EventEmitter } from 'vscode'; import { Credentials } from '../authentication'; -import { Logger } from '../logging'; import * as ghApiClient from './gh-api/gh-api-client'; import { VariantAnalysis, VariantAnalysisStatus } from './shared/variant-analysis'; @@ -22,7 +21,6 @@ export class VariantAnalysisMonitor extends DisposableObject { constructor( private readonly extensionContext: ExtensionContext, - private readonly logger: Logger ) { super(); } @@ -73,8 +71,6 @@ export class VariantAnalysisMonitor extends DisposableObject { this._onVariantAnalysisChange.fire(variantAnalysis); - void this.logger.log('****** Retrieved variant analysis' + JSON.stringify(variantAnalysisSummary)); - if (variantAnalysisSummary.scanned_repositories) { variantAnalysisSummary.scanned_repositories.forEach(scannedRepo => { if (!scannedReposDownloaded.includes(scannedRepo.repository.id) && scannedRepo.analysis_status === 'succeeded') { diff --git a/extensions/ql-vscode/src/vscode-tests/cli-integration/remote-queries/variant-analysis-monitor.test.ts b/extensions/ql-vscode/src/vscode-tests/cli-integration/remote-queries/variant-analysis-monitor.test.ts index 7e2932975..1b1f87429 100644 --- a/extensions/ql-vscode/src/vscode-tests/cli-integration/remote-queries/variant-analysis-monitor.test.ts +++ b/extensions/ql-vscode/src/vscode-tests/cli-integration/remote-queries/variant-analysis-monitor.test.ts @@ -2,7 +2,6 @@ import * as sinon from 'sinon'; import { expect } from 'chai'; import { CancellationTokenSource, extensions } from 'vscode'; import { CodeQLExtensionInterface } from '../../../extension'; -import { logger } from '../../../logging'; import * as config from '../../../config'; import * as ghApiClient from '../../../remote-queries/gh-api/gh-api-client'; @@ -30,7 +29,6 @@ describe('Variant Analysis Monitor', async function() { beforeEach(async () => { sandbox = sinon.createSandbox(); - sandbox.stub(logger, 'log'); sandbox.stub(config, 'isVariantAnalysisLiveResultsEnabled').returns(false); cancellationTokenSource = new CancellationTokenSource(); @@ -39,7 +37,7 @@ describe('Variant Analysis Monitor', async function() { try { const extension = await extensions.getExtension>('GitHub.vscode-codeql')!.activate(); - variantAnalysisMonitor = new VariantAnalysisMonitor(extension.ctx, logger); + variantAnalysisMonitor = new VariantAnalysisMonitor(extension.ctx); } catch (e) { fail(e as Error); }