mirror of
https://github.com/github/codeql.git
synced 2025-12-24 04:36:35 +01:00
e2b78df5ad
Although this is a breaking change, as explained in the change-note, it should onyl affect peopel that have created their own HTTP client request modeling, which I assume is none. The alternative would have been to keep the old class/module as deprecated, and introduce a `HTTP::Client::Requestv2` class/module that is based on `DataFlow::Node` instead. The old class could then be deprecated in 1 year, and we could do a rename from `HTTP::Client::Requestv2` -> `HTTP::Client::Request` at the same time. (and then wait 1 more year before being able to delete `HTTP::Client::Requestv2`) All in all, I think this is the right tradeoff, given that CodeQL Ruby is still in beta.
5 lines
318 B
Markdown
5 lines
318 B
Markdown
---
|
|
category: breaking
|
|
---
|
|
* Changed the `HTTP::Client::Request` concept from using `MethodCall` as base class, to using `DataFlow::Node` as base class. Any class that extend `HTTP::Client::Request::Range` must be changed, but if you only uses the member predicates of `HTTP::Client::Request` no changes are required.
|