codeql/java/ql/src/Performance/StringReplaceAllWithNonRegex.md

Overview

The String#replaceAll method is designed to work with regular expressions as its first parameter. When you use a simple string without any regex patterns (like special characters or syntax), it's more efficient to use String#replace instead. This is because replaceAll has to compile the input as a regular expression first, which adds unnecessary overhead when you are just replacing literal text.

Recommendation

Use String#replace instead where a replaceAll call uses a trivial string as its first argument.

Example

public class Test {
    void f() {
        String s1 = "test";
        s1 = s1.replaceAll("t", "x"); // NON_COMPLIANT
        s1 = s1.replaceAll(".*", "x"); // COMPLIANT
        s1 = s1.replace("t", "x"); // COMPLIANT
    }
}

References

• Java SE Documentation: String.replaceAll.
• Common Weakness Enumeration: CWE-1176.