Files
codeql/javascript/ql/test/query-tests/Security/CWE-598/tst.js
2021-11-08 12:25:45 +01:00

35 lines
1.1 KiB
JavaScript

const express = require('express');
const app = express();
const bodyParser = require('body-parser');
app.use(bodyParser.urlencoded({extended: true}));
app.get("/login", (req, res) => {
const username = req.query.username; // OK - usernames are fine
const password = req.query.password; // NOT OK - password read
checkUser(username, password, (result) => {
res.send(result);
});
doThing(req.query.userId); // OK - userId
});
app.post("/login", (req, res) => {
const username = req.body.username; // OK - usernames are fine
const password = req.body.password; // OK - not a query parameter
checkUser(username, password, (result) => {
res.send(result);
});
});
app.get("/login2", (req, res) => {
const username = req.param('username'); // NOT OK - usernames are fine
const password = req.param('password'); // NOT OK - password read
checkUser(username, password, (result) => {
res.send(result);
});
const myPassword = req.param('word'); // NOT OK - is used in a sensitive write below.
checkUser(username, myPassword, (result) => {
res.send(result);
});
});