hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-03 12:45:27 +02:00
Code Issues Packages Projects Releases Wiki Activity

add test that requires flowToExpr

Browse Source
This commit is contained in:
Erik Krogh Kristensen
2021-11-08 12:25:45 +01:00
parent 3d6a5263e0
commit 0ab510f543
2 changed files with 15 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
javascript/ql/test/query-tests/Security/CWE-598/SensitiveGetQuery.expected
View File

@@ -1 +1,3 @@
| tst.js:8:22:8:39 | req.query.password | $@ for GET requests uses query parameter as sensitive data. | tst.js:6:19:14:1 | (req, r ... serId\\n} | Route handler |
| tst.js:26:22:26:42 | req.par ... sword') | $@ for GET requests uses query parameter as sensitive data. | tst.js:24:20:35:1 | (req, r ... });\\n} | Route handler |
| tst.js:31:24:31:40 | req.param('word') | $@ for GET requests uses query parameter as sensitive data. | tst.js:24:20:35:1 | (req, r ... });\\n} | Route handler |

13
javascript/ql/test/query-tests/Security/CWE-598/tst.js
View File

@@ -19,4 +19,17 @@ app.post("/login", (req, res) => {
checkUser(username, password, (result) => {
res.send(result);
});
});
app.get("/login2", (req, res) => {
const username = req.param('username'); // NOT OK - usernames are fine
const password = req.param('password'); // NOT OK - password read
checkUser(username, password, (result) => {
res.send(result);
});
const myPassword = req.param('word'); // NOT OK - is used in a sensitive write below.
checkUser(username, myPassword, (result) => {
res.send(result);
});
});