exclude intermediary data flow nodes from sinks

2026-05-18 21:27:08 +02:00 · 2022-03-16 08:03:05 +01:00
1 changed files with 6 additions and 0 deletions
--- a/javascript/ql/experimental/adaptivethreatmodeling/lib/experimental/adaptivethreatmodeling/StandardEndpointFilters.qll
+++ b/javascript/ql/experimental/adaptivethreatmodeling/lib/experimental/adaptivethreatmodeling/StandardEndpointFilters.qll
@@ -11,8 +11,14 @@ private import semmle.javascript.filters.ClassifyFiles as ClassifyFiles
 private import semmle.javascript.heuristics.SyntacticHeuristics
 private import CoreKnowledge as CoreKnowledge

+predicate isIntermediaryDataflowNode(DataFlow::Node n) {
+  n instanceof DataFlow::ExceptionalInvocationReturnNode
+}
+
 /** Provides a set of reasons why a given data flow node should be excluded as a sink candidate. */
 string getAReasonSinkExcluded(DataFlow::Node n) {
+  isIntermediaryDataflowNode(n) and result = "intermediary dataflow node"
+  or
  isArgumentToModeledFunction(n) and result = "argument to modeled function"
  or
  isArgumentToSinklessLibrary(n) and result = "argument to sinkless library"