Merge branch 'main' into copilot/automate-go-version-updates-again

Shared: Remove deprecated code

.github/workflows/go-version-update.yml

@@ -0,0 +1,206 @@
+name: Update Go version
+
+on:
+  workflow_dispatch:
+  schedule:
+    - cron: "0 3 * * 1"  # Run weekly on Mondays at 3 AM UTC (1 = Monday)
+
+permissions:
+  contents: write
+  pull-requests: write
+
+jobs:
+  update-go-version:
+    name: Check and update Go version
+    if: github.repository == 'github/codeql'
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v5
+        with:
+          fetch-depth: 0
+
+      - name: Set up Git
+        run: |
+          git config user.name "github-actions[bot]"
+          git config user.email "41898282+github-actions[bot]@users.noreply.github.com"
+
+      - name: Fetch latest Go version
+        id: fetch-version
+        run: |
+          LATEST_GO_VERSION=$(curl -s https://go.dev/dl/?mode=json | jq -r '.[0].version')
+          
+          if [ -z "$LATEST_GO_VERSION" ] || [ "$LATEST_GO_VERSION" = "null" ]; then
+            echo "Error: Failed to fetch latest Go version from go.dev"
+            exit 1
+          fi
+          
+          echo "Latest Go version from go.dev: $LATEST_GO_VERSION"
+          echo "version=$LATEST_GO_VERSION" >> $GITHUB_OUTPUT
+          
+          # Extract version numbers (e.g., go1.26.0 -> 1.26.0)
+          LATEST_VERSION_NUM=$(echo $LATEST_GO_VERSION | sed 's/^go//')
+          echo "version_num=$LATEST_VERSION_NUM" >> $GITHUB_OUTPUT
+          
+          # Extract major.minor version (e.g., 1.26.0 -> 1.26)
+          LATEST_MAJOR_MINOR=$(echo $LATEST_VERSION_NUM | sed -E 's/^([0-9]+\.[0-9]+).*/\1/')
+          echo "major_minor=$LATEST_MAJOR_MINOR" >> $GITHUB_OUTPUT
+
+      - name: Check current Go version
+        id: current-version
+        run: |
+          CURRENT_VERSION=$(sed -n 's/.*go_sdk\.download(version = \"\([^\"]*\)\".*/\1/p' MODULE.bazel)
+          
+          if [ -z "$CURRENT_VERSION" ]; then
+            echo "Error: Could not extract Go version from MODULE.bazel"
+            exit 1
+          fi
+          
+          echo "Current Go version in MODULE.bazel: $CURRENT_VERSION"
+          echo "version=$CURRENT_VERSION" >> $GITHUB_OUTPUT
+          
+          # Extract major.minor version
+          CURRENT_MAJOR_MINOR=$(echo $CURRENT_VERSION | sed -E 's/^([0-9]+\.[0-9]+).*/\1/')
+          echo "major_minor=$CURRENT_MAJOR_MINOR" >> $GITHUB_OUTPUT
+
+      - name: Compare versions
+        id: compare
+        run: |
+          LATEST="${{ steps.fetch-version.outputs.version_num }}"
+          CURRENT="${{ steps.current-version.outputs.version }}"
+          
+          echo "Latest: $LATEST"
+          echo "Current: $CURRENT"
+          
+          if [ "$LATEST" = "$CURRENT" ]; then
+            echo "Go version is up to date"
+            echo "needs_update=false" >> $GITHUB_OUTPUT
+          else
+            echo "Go version needs update from $CURRENT to $LATEST"
+            echo "needs_update=true" >> $GITHUB_OUTPUT
+          fi
+
+      - name: Update Go version in files
+        if: steps.compare.outputs.needs_update == 'true'
+        run: |
+          LATEST_VERSION_NUM="${{ steps.fetch-version.outputs.version_num }}"
+          LATEST_MAJOR_MINOR="${{ steps.fetch-version.outputs.major_minor }}"
+          CURRENT_VERSION="${{ steps.current-version.outputs.version }}"
+          CURRENT_MAJOR_MINOR="${{ steps.current-version.outputs.major_minor }}"
+          
+          echo "Updating from $CURRENT_VERSION to $LATEST_VERSION_NUM"
+          
+          # Escape dots in current version strings for use in sed patterns
+          CURRENT_VERSION_ESCAPED=$(echo "$CURRENT_VERSION" | sed 's/\./\\./g')
+          CURRENT_MAJOR_MINOR_ESCAPED=$(echo "$CURRENT_MAJOR_MINOR" | sed 's/\./\\./g')
+          
+          # Update MODULE.bazel
+          if ! sed -i "s/go_sdk\.download(version = \"$CURRENT_VERSION_ESCAPED\")/go_sdk.download(version = \"$LATEST_VERSION_NUM\")/" MODULE.bazel; then
+            echo "Warning: Failed to update MODULE.bazel"
+          fi
+          
+          # Update go/extractor/go.mod
+          if ! sed -i "s/^go $CURRENT_MAJOR_MINOR_ESCAPED\$/go $LATEST_MAJOR_MINOR/" go/extractor/go.mod; then
+            echo "Warning: Failed to update go directive in go.mod"
+          fi
+          if ! sed -i "s/^toolchain go$CURRENT_VERSION_ESCAPED\$/toolchain go$LATEST_VERSION_NUM/" go/extractor/go.mod; then
+            echo "Warning: Failed to update toolchain in go.mod"
+          fi
+          
+          # Update go/extractor/autobuilder/build-environment.go
+          if ! sed -i "s/var maxGoVersion = util\.NewSemVer(\"$CURRENT_MAJOR_MINOR_ESCAPED\")/var maxGoVersion = util.NewSemVer(\"$LATEST_MAJOR_MINOR\")/" go/extractor/autobuilder/build-environment.go; then
+            echo "Warning: Failed to update build-environment.go"
+          fi
+          
+          # Update go/actions/test/action.yml
+          if ! sed -i "s/default: \"~$CURRENT_VERSION_ESCAPED\"/default: \"~$LATEST_VERSION_NUM\"/" go/actions/test/action.yml; then
+            echo "Warning: Failed to update action.yml"
+          fi
+          
+          # Show what changed
+          git diff
+
+      - name: Check for changes
+        id: check-changes
+        if: steps.compare.outputs.needs_update == 'true'
+        run: |
+          if git diff --quiet; then
+            echo "No changes detected"
+            echo "has_changes=false" >> $GITHUB_OUTPUT
+          else
+            echo "Changes detected"
+            echo "has_changes=true" >> $GITHUB_OUTPUT
+          fi
+
+      - name: Check for existing PR
+        if: steps.check-changes.outputs.has_changes == 'true'
+        id: check-pr
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          BRANCH_NAME="workflow/go-version-update"
+          PR_NUMBER=$(gh pr list --head "$BRANCH_NAME" --state open --json number --jq '.[0].number')
+          
+          if [ -n "$PR_NUMBER" ]; then
+            echo "Existing PR found: #$PR_NUMBER"
+            echo "pr_exists=true" >> $GITHUB_OUTPUT
+            echo "pr_number=$PR_NUMBER" >> $GITHUB_OUTPUT
+          else
+            echo "No existing PR found"
+            echo "pr_exists=false" >> $GITHUB_OUTPUT
+          fi
+
+      - name: Commit and push changes
+        if: steps.check-changes.outputs.has_changes == 'true'
+        run: |
+          BRANCH_NAME="workflow/go-version-update"
+          LATEST_VERSION_NUM="${{ steps.fetch-version.outputs.version_num }}"
+          LATEST_MAJOR_MINOR="${{ steps.fetch-version.outputs.major_minor }}"
+          
+          # Create or switch to branch
+          git checkout -B "$BRANCH_NAME"
+          
+          # Stage and commit changes
+          git add MODULE.bazel go/extractor/go.mod go/extractor/autobuilder/build-environment.go go/actions/test/action.yml
+          git commit -m "Go: Update to $LATEST_MAJOR_MINOR"
+          
+          # Push changes
+          git push -f origin "$BRANCH_NAME"
+
+      - name: Create or update PR
+        if: steps.check-changes.outputs.has_changes == 'true'
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          BRANCH_NAME="workflow/go-version-update"
+          LATEST_MAJOR_MINOR="${{ steps.fetch-version.outputs.major_minor }}"
+          CURRENT_MAJOR_MINOR="${{ steps.current-version.outputs.major_minor }}"
+          
+          PR_TITLE="Go: Update to $LATEST_MAJOR_MINOR"
+          
+          PR_BODY=$(cat <<EOF
+          This PR updates Go from $CURRENT_MAJOR_MINOR to $LATEST_MAJOR_MINOR.
+
+          Updated files:
+          - \`MODULE.bazel\` - go_sdk.download version
+          - \`go/extractor/go.mod\` - go directive and toolchain
+          - \`go/extractor/autobuilder/build-environment.go\` - maxGoVersion
+          - \`go/actions/test/action.yml\` - default go-test-version
+
+          This PR was automatically created by the [Go version update workflow](https://github.com/${{ github.repository }}/blob/main/.github/workflows/go-version-update.yml).
+          EOF
+          )
+          
+          if [ "${{ steps.check-pr.outputs.pr_exists }}" = "true" ]; then
+            echo "Updating existing PR #${{ steps.check-pr.outputs.pr_number }}"
+            gh pr edit "${{ steps.check-pr.outputs.pr_number }}" --title "$PR_TITLE" --body "$PR_BODY"
+          else
+            echo "Creating new PR"
+            gh pr create \
+              --title "$PR_TITLE" \
+              --body "$PR_BODY" \
+              --base main \
+              --head "$BRANCH_NAME" \
+              --label "Go"
+          fi

MODULE.bazel

@@ -27,7 +27,7 @@ bazel_dep(name = "abseil-cpp", version = "20260107.1", repo_name = "absl")
 bazel_dep(name = "nlohmann_json", version = "3.11.3", repo_name = "json")
 bazel_dep(name = "fmt", version = "12.1.0-codeql.1")
 bazel_dep(name = "rules_kotlin", version = "2.2.2-codeql.1")
-bazel_dep(name = "gazelle", version = "0.47.0")
+bazel_dep(name = "gazelle", version = "0.50.0")
 bazel_dep(name = "rules_dotnet", version = "0.21.5-codeql.1")
 bazel_dep(name = "googletest", version = "1.17.0.bcr.2")
 bazel_dep(name = "rules_rust", version = "0.69.0")

actions/ql/lib/CHANGELOG.md

@@ -1,3 +1,9 @@
+## 0.4.34
+
+### Minor Analysis Improvements
+
+* Removed false positive injection sink models for the `context` input of `docker/build-push-action` and the `allowed-endpoints` input of `step-security/harden-runner`.
+
 ## 0.4.33
 
 No user-facing changes.

actions/ql/lib/change-notes/released/0.4.34.md

@@ -0,0 +1,5 @@
+## 0.4.34
+
+### Minor Analysis Improvements
+
+* Removed false positive injection sink models for the `context` input of `docker/build-push-action` and the `allowed-endpoints` input of `step-security/harden-runner`.

actions/ql/lib/codeql-pack.release.yml

@@ -1,2 +1,2 @@
 ---
-lastReleaseVersion: 0.4.33
+lastReleaseVersion: 0.4.34

actions/ql/lib/ext/manual/docker_build-push-action.model.yml

@@ -1,6 +0,0 @@
-extensions:
-  - addsTo:
-      pack: codeql/actions-all
-      extensible: actionsSinkModel
-    data:
-      - ["docker/build-push-action", "*", "input.context", "code-injection", "manual"]

actions/ql/lib/ext/manual/step-security_harden-runner.model.yml

@@ -1,6 +0,0 @@
-extensions:
-  - addsTo:
-      pack: codeql/actions-all
-      extensible: actionsSinkModel
-    data:
-      - ["step-security/harden-runner", "*", "input.allowed-endpoints", "command-injection", "manual"]

actions/ql/lib/qlpack.yml

@@ -1,5 +1,5 @@
 name: codeql/actions-all
-version: 0.4.33
+version: 0.4.35-dev
 library: true
 warnOnImplicitThis: true
 dependencies:

actions/ql/src/CHANGELOG.md

@@ -1,3 +1,13 @@
+## 0.6.26
+
+### Major Analysis Improvements
+
+* Fixed alert messages in `actions/artifact-poisoning/critical` and `actions/artifact-poisoning/medium` as they previously included a redundant placeholder in the alert message that would on occasion contain a long block of yml that makes the alert difficult to understand. Also improved the wording to make it clearer that it is not the artifact that is being poisoned, but instead a potentially untrusted artifact that is consumed. Finally, changed the alert location to be the source, to align more with other queries reporting an artifact (e.g. zipslip) which is more useful.
+
+### Minor Analysis Improvements
+
+* The query `actions/missing-workflow-permissions` no longer produces false positive results on reusable workflows where all callers set permissions.
+
 ## 0.6.25
 
 No user-facing changes.
@@ -163,7 +173,7 @@ No user-facing changes.
   * `actions/if-expression-always-true/critical`
   * `actions/if-expression-always-true/high`
   * `actions/unnecessary-use-of-advanced-config`
-  
+
 * The following query has been moved from the `code-scanning` suite to the `security-extended`
   suite. Any existing alerts for this query will be closed automatically unless the analysis is
   configured to use the `security-extended` suite.

actions/ql/src/Security/CWE-275/MissingActionsPermissions.ql

@@ -26,10 +26,23 @@ string permissionsForJob(Job job) {
     "{" + concat(string permission | permission = jobNeedsPermission(job) | permission, ", ") + "}"
 }
 
+predicate jobHasPermissions(Job job) {
+  exists(job.getPermissions())
+  or
+  exists(job.getEnclosingWorkflow().getPermissions())
+  or
+  // The workflow is reusable and cannot be triggered in any other way; check callers
+  exists(ReusableWorkflow r | r = job.getEnclosingWorkflow() |
+    not exists(Event e | e = r.getOn().getAnEvent() | e.getName() != "workflow_call") and
+    forall(Job caller | caller = job.getEnclosingWorkflow().(ReusableWorkflow).getACaller() |
+      jobHasPermissions(caller)
+    )
+  )
+}
+
 from Job job, string permissions
 where
-  not exists(job.getPermissions()) and
-  not exists(job.getEnclosingWorkflow().getPermissions()) and
+  not jobHasPermissions(job) and
   // exists a trigger event that is not a workflow_call
   exists(Event e |
     e = job.getATriggerEvent() and

actions/ql/src/Security/CWE-829/ArtifactPoisoningCritical.ql

@@ -20,6 +20,6 @@ from ArtifactPoisoningFlow::PathNode source, ArtifactPoisoningFlow::PathNode sin
 where
   ArtifactPoisoningFlow::flowPath(source, sink) and
   event = getRelevantEventInPrivilegedContext(sink.getNode())
-select sink.getNode(), source, sink,
-  "Potential artifact poisoning in $@, which may be controlled by an external user ($@).", sink,
-  sink.getNode().toString(), event, event.getName()
+select source.getNode(), source, sink,
+  "Potential artifact poisoning; the artifact being consumed has contents that may be controlled by an external user ($@).",
+  event, event.getName()

actions/ql/src/Security/CWE-829/ArtifactPoisoningMedium.ql

@@ -20,6 +20,5 @@ from ArtifactPoisoningFlow::PathNode source, ArtifactPoisoningFlow::PathNode sin
 where
   ArtifactPoisoningFlow::flowPath(source, sink) and
   inNonPrivilegedContext(sink.getNode().asExpr())
-select sink.getNode(), source, sink,
-  "Potential artifact poisoning in $@, which may be controlled by an external user.", sink,
-  sink.getNode().toString()
+select source.getNode(), source, sink,
+  "Potential artifact poisoning; the artifact being consumed has contents that may be controlled by an external user."

actions/ql/src/change-notes/released/0.6.26.md

@@ -0,0 +1,9 @@
+## 0.6.26
+
+### Major Analysis Improvements
+
+* Fixed alert messages in `actions/artifact-poisoning/critical` and `actions/artifact-poisoning/medium` as they previously included a redundant placeholder in the alert message that would on occasion contain a long block of yml that makes the alert difficult to understand. Also improved the wording to make it clearer that it is not the artifact that is being poisoned, but instead a potentially untrusted artifact that is consumed. Finally, changed the alert location to be the source, to align more with other queries reporting an artifact (e.g. zipslip) which is more useful.
+
+### Minor Analysis Improvements
+
+* The query `actions/missing-workflow-permissions` no longer produces false positive results on reusable workflows where all callers set permissions.

actions/ql/src/codeql-pack.release.yml

@@ -1,2 +1,2 @@
 ---
-lastReleaseVersion: 0.6.25
+lastReleaseVersion: 0.6.26

actions/ql/src/qlpack.yml

@@ -1,5 +1,5 @@
 name: codeql/actions-queries
-version: 0.6.25
+version: 0.6.27-dev
 library: false
 warnOnImplicitThis: true
 groups: [actions, queries]

actions/ql/test/query-tests/Security/CWE-275/.github/workflows/perms11.yml

@@ -0,0 +1,9 @@
+on:
+  workflow_call:
+
+jobs:
+  build:
+    name: Build and test
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/deploy-pages

actions/ql/test/query-tests/Security/CWE-275/.github/workflows/perms12.yml

@@ -0,0 +1,11 @@
+on:
+  workflow_dispatch:
+
+permissions:
+  contents: read
+  id-token: write
+  pages: write
+
+jobs:
+  call-workflow:
+    uses: ./.github/workflows/perms11.yml

actions/ql/test/query-tests/Security/CWE-829/ArtifactPoisoningCritical.expected

@@ -55,21 +55,21 @@ nodes
 | .github/workflows/test25.yml:39:14:40:45 | ./gradlew buildScanPublishPrevious\n | semmle.label | ./gradlew buildScanPublishPrevious\n |
 subpaths
 #select
-| .github/workflows/artifactpoisoning11.yml:38:11:38:77 | ./sonarcloud-data/x.py build -j$(nproc) --compiler gcc --skip-build | .github/workflows/artifactpoisoning11.yml:13:9:32:6 | Uses Step | .github/workflows/artifactpoisoning11.yml:38:11:38:77 | ./sonarcloud-data/x.py build -j$(nproc) --compiler gcc --skip-build | Potential artifact poisoning in $@, which may be controlled by an external user ($@). | .github/workflows/artifactpoisoning11.yml:38:11:38:77 | ./sonarcloud-data/x.py build -j$(nproc) --compiler gcc --skip-build | ./sonarcloud-data/x.py build -j$(nproc) --compiler gcc --skip-build | .github/workflows/artifactpoisoning11.yml:4:3:4:14 | workflow_run | workflow_run |
-| .github/workflows/artifactpoisoning12.yml:38:11:38:25 | python foo/x.py | .github/workflows/artifactpoisoning12.yml:13:9:32:6 | Uses Step | .github/workflows/artifactpoisoning12.yml:38:11:38:25 | python foo/x.py | Potential artifact poisoning in $@, which may be controlled by an external user ($@). | .github/workflows/artifactpoisoning12.yml:38:11:38:25 | python foo/x.py | python foo/x.py | .github/workflows/artifactpoisoning12.yml:4:3:4:14 | workflow_run | workflow_run |
-| .github/workflows/artifactpoisoning21.yml:19:14:20:21 | sh foo/cmd\n | .github/workflows/artifactpoisoning21.yml:13:9:18:6 | Uses Step | .github/workflows/artifactpoisoning21.yml:19:14:20:21 | sh foo/cmd\n | Potential artifact poisoning in $@, which may be controlled by an external user ($@). | .github/workflows/artifactpoisoning21.yml:19:14:20:21 | sh foo/cmd\n | sh foo/cmd\n | .github/workflows/artifactpoisoning21.yml:4:3:4:14 | workflow_run | workflow_run |
-| .github/workflows/artifactpoisoning22.yml:18:14:18:19 | sh cmd | .github/workflows/artifactpoisoning22.yml:13:9:17:6 | Uses Step | .github/workflows/artifactpoisoning22.yml:18:14:18:19 | sh cmd | Potential artifact poisoning in $@, which may be controlled by an external user ($@). | .github/workflows/artifactpoisoning22.yml:18:14:18:19 | sh cmd | sh cmd | .github/workflows/artifactpoisoning22.yml:4:3:4:14 | workflow_run | workflow_run |
-| .github/workflows/artifactpoisoning31.yml:19:14:19:22 | ./foo/cmd | .github/workflows/artifactpoisoning31.yml:13:9:15:6 | Run Step | .github/workflows/artifactpoisoning31.yml:19:14:19:22 | ./foo/cmd | Potential artifact poisoning in $@, which may be controlled by an external user ($@). | .github/workflows/artifactpoisoning31.yml:19:14:19:22 | ./foo/cmd | ./foo/cmd | .github/workflows/artifactpoisoning31.yml:4:3:4:14 | workflow_run | workflow_run |
-| .github/workflows/artifactpoisoning32.yml:17:14:18:20 | ./bar/cmd\n | .github/workflows/artifactpoisoning32.yml:13:9:16:6 | Run Step | .github/workflows/artifactpoisoning32.yml:17:14:18:20 | ./bar/cmd\n | Potential artifact poisoning in $@, which may be controlled by an external user ($@). | .github/workflows/artifactpoisoning32.yml:17:14:18:20 | ./bar/cmd\n | ./bar/cmd\n | .github/workflows/artifactpoisoning32.yml:4:3:4:14 | workflow_run | workflow_run |
-| .github/workflows/artifactpoisoning33.yml:17:14:18:20 | ./bar/cmd\n | .github/workflows/artifactpoisoning33.yml:13:9:16:6 | Run Step | .github/workflows/artifactpoisoning33.yml:17:14:18:20 | ./bar/cmd\n | Potential artifact poisoning in $@, which may be controlled by an external user ($@). | .github/workflows/artifactpoisoning33.yml:17:14:18:20 | ./bar/cmd\n | ./bar/cmd\n | .github/workflows/artifactpoisoning33.yml:4:3:4:14 | workflow_run | workflow_run |
-| .github/workflows/artifactpoisoning34.yml:20:14:22:23 | npm install\nnpm run lint\n | .github/workflows/artifactpoisoning34.yml:13:9:16:6 | Run Step | .github/workflows/artifactpoisoning34.yml:20:14:22:23 | npm install\nnpm run lint\n | Potential artifact poisoning in $@, which may be controlled by an external user ($@). | .github/workflows/artifactpoisoning34.yml:20:14:22:23 | npm install\nnpm run lint\n | npm install\nnpm run lint\n | .github/workflows/artifactpoisoning34.yml:4:3:4:14 | workflow_run | workflow_run |
-| .github/workflows/artifactpoisoning41.yml:22:14:22:22 | ./foo/cmd | .github/workflows/artifactpoisoning41.yml:13:9:21:6 | Run Step | .github/workflows/artifactpoisoning41.yml:22:14:22:22 | ./foo/cmd | Potential artifact poisoning in $@, which may be controlled by an external user ($@). | .github/workflows/artifactpoisoning41.yml:22:14:22:22 | ./foo/cmd | ./foo/cmd | .github/workflows/artifactpoisoning41.yml:4:3:4:14 | workflow_run | workflow_run |
-| .github/workflows/artifactpoisoning42.yml:22:14:22:18 | ./cmd | .github/workflows/artifactpoisoning42.yml:13:9:21:6 | Run Step | .github/workflows/artifactpoisoning42.yml:22:14:22:18 | ./cmd | Potential artifact poisoning in $@, which may be controlled by an external user ($@). | .github/workflows/artifactpoisoning42.yml:22:14:22:18 | ./cmd | ./cmd | .github/workflows/artifactpoisoning42.yml:4:3:4:14 | workflow_run | workflow_run |
-| .github/workflows/artifactpoisoning71.yml:17:14:18:40 | sed -f config foo.md > bar.md\n | .github/workflows/artifactpoisoning71.yml:9:9:16:6 | Uses Step | .github/workflows/artifactpoisoning71.yml:17:14:18:40 | sed -f config foo.md > bar.md\n | Potential artifact poisoning in $@, which may be controlled by an external user ($@). | .github/workflows/artifactpoisoning71.yml:17:14:18:40 | sed -f config foo.md > bar.md\n | sed -f config foo.md > bar.md\n | .github/workflows/artifactpoisoning71.yml:4:5:4:16 | workflow_run | workflow_run |
-| .github/workflows/artifactpoisoning81.yml:31:14:31:27 | python test.py | .github/workflows/artifactpoisoning81.yml:28:9:31:6 | Uses Step | .github/workflows/artifactpoisoning81.yml:31:14:31:27 | python test.py | Potential artifact poisoning in $@, which may be controlled by an external user ($@). | .github/workflows/artifactpoisoning81.yml:31:14:31:27 | python test.py | python test.py | .github/workflows/artifactpoisoning81.yml:3:5:3:23 | pull_request_target | pull_request_target |
-| .github/workflows/artifactpoisoning92.yml:28:9:29:6 | Uses Step | .github/actions/download-artifact-2/action.yaml:6:7:25:4 | Uses Step | .github/workflows/artifactpoisoning92.yml:28:9:29:6 | Uses Step | Potential artifact poisoning in $@, which may be controlled by an external user ($@). | .github/workflows/artifactpoisoning92.yml:28:9:29:6 | Uses Step | Uses Step | .github/workflows/artifactpoisoning92.yml:3:3:3:14 | workflow_run | workflow_run |
-| .github/workflows/artifactpoisoning92.yml:29:14:29:26 | make snapshot | .github/actions/download-artifact-2/action.yaml:6:7:25:4 | Uses Step | .github/workflows/artifactpoisoning92.yml:29:14:29:26 | make snapshot | Potential artifact poisoning in $@, which may be controlled by an external user ($@). | .github/workflows/artifactpoisoning92.yml:29:14:29:26 | make snapshot | make snapshot | .github/workflows/artifactpoisoning92.yml:3:3:3:14 | workflow_run | workflow_run |
-| .github/workflows/artifactpoisoning96.yml:18:14:18:24 | npm install | .github/workflows/artifactpoisoning96.yml:13:9:18:6 | Uses Step | .github/workflows/artifactpoisoning96.yml:18:14:18:24 | npm install | Potential artifact poisoning in $@, which may be controlled by an external user ($@). | .github/workflows/artifactpoisoning96.yml:18:14:18:24 | npm install | npm install | .github/workflows/artifactpoisoning96.yml:2:3:2:14 | workflow_run | workflow_run |
-| .github/workflows/artifactpoisoning101.yml:17:14:19:59 | PR_NUMBER=$(./get_pull_request_number.sh pr_number.txt)\necho "PR_NUMBER=$PR_NUMBER" >> $GITHUB_OUTPUT \n | .github/workflows/artifactpoisoning101.yml:10:9:16:6 | Uses Step | .github/workflows/artifactpoisoning101.yml:17:14:19:59 | PR_NUMBER=$(./get_pull_request_number.sh pr_number.txt)\necho "PR_NUMBER=$PR_NUMBER" >> $GITHUB_OUTPUT \n | Potential artifact poisoning in $@, which may be controlled by an external user ($@). | .github/workflows/artifactpoisoning101.yml:17:14:19:59 | PR_NUMBER=$(./get_pull_request_number.sh pr_number.txt)\necho "PR_NUMBER=$PR_NUMBER" >> $GITHUB_OUTPUT \n | PR_NUMBER=$(./get_pull_request_number.sh pr_number.txt)\necho "PR_NUMBER=$PR_NUMBER" >> $GITHUB_OUTPUT \n | .github/workflows/artifactpoisoning101.yml:4:3:4:21 | pull_request_target | pull_request_target |
-| .github/workflows/test18.yml:36:15:40:58 | Uses Step | .github/workflows/test18.yml:12:15:33:12 | Uses Step | .github/workflows/test18.yml:36:15:40:58 | Uses Step | Potential artifact poisoning in $@, which may be controlled by an external user ($@). | .github/workflows/test18.yml:36:15:40:58 | Uses Step | Uses Step | .github/workflows/test18.yml:3:5:3:16 | workflow_run | workflow_run |
-| .github/workflows/test25.yml:39:14:40:45 | ./gradlew buildScanPublishPrevious\n | .github/workflows/test25.yml:22:9:32:6 | Uses Step: downloadBuildScan | .github/workflows/test25.yml:39:14:40:45 | ./gradlew buildScanPublishPrevious\n | Potential artifact poisoning in $@, which may be controlled by an external user ($@). | .github/workflows/test25.yml:39:14:40:45 | ./gradlew buildScanPublishPrevious\n | ./gradlew buildScanPublishPrevious\n | .github/workflows/test25.yml:2:3:2:14 | workflow_run | workflow_run |
+| .github/actions/download-artifact-2/action.yaml:6:7:25:4 | Uses Step | .github/actions/download-artifact-2/action.yaml:6:7:25:4 | Uses Step | .github/workflows/artifactpoisoning92.yml:28:9:29:6 | Uses Step | Potential artifact poisoning; the artifact being consumed has contents that may be controlled by an external user ($@). | .github/workflows/artifactpoisoning92.yml:3:3:3:14 | workflow_run | workflow_run |
+| .github/actions/download-artifact-2/action.yaml:6:7:25:4 | Uses Step | .github/actions/download-artifact-2/action.yaml:6:7:25:4 | Uses Step | .github/workflows/artifactpoisoning92.yml:29:14:29:26 | make snapshot | Potential artifact poisoning; the artifact being consumed has contents that may be controlled by an external user ($@). | .github/workflows/artifactpoisoning92.yml:3:3:3:14 | workflow_run | workflow_run |
+| .github/workflows/artifactpoisoning11.yml:13:9:32:6 | Uses Step | .github/workflows/artifactpoisoning11.yml:13:9:32:6 | Uses Step | .github/workflows/artifactpoisoning11.yml:38:11:38:77 | ./sonarcloud-data/x.py build -j$(nproc) --compiler gcc --skip-build | Potential artifact poisoning; the artifact being consumed has contents that may be controlled by an external user ($@). | .github/workflows/artifactpoisoning11.yml:4:3:4:14 | workflow_run | workflow_run |
+| .github/workflows/artifactpoisoning12.yml:13:9:32:6 | Uses Step | .github/workflows/artifactpoisoning12.yml:13:9:32:6 | Uses Step | .github/workflows/artifactpoisoning12.yml:38:11:38:25 | python foo/x.py | Potential artifact poisoning; the artifact being consumed has contents that may be controlled by an external user ($@). | .github/workflows/artifactpoisoning12.yml:4:3:4:14 | workflow_run | workflow_run |
+| .github/workflows/artifactpoisoning21.yml:13:9:18:6 | Uses Step | .github/workflows/artifactpoisoning21.yml:13:9:18:6 | Uses Step | .github/workflows/artifactpoisoning21.yml:19:14:20:21 | sh foo/cmd\n | Potential artifact poisoning; the artifact being consumed has contents that may be controlled by an external user ($@). | .github/workflows/artifactpoisoning21.yml:4:3:4:14 | workflow_run | workflow_run |
+| .github/workflows/artifactpoisoning22.yml:13:9:17:6 | Uses Step | .github/workflows/artifactpoisoning22.yml:13:9:17:6 | Uses Step | .github/workflows/artifactpoisoning22.yml:18:14:18:19 | sh cmd | Potential artifact poisoning; the artifact being consumed has contents that may be controlled by an external user ($@). | .github/workflows/artifactpoisoning22.yml:4:3:4:14 | workflow_run | workflow_run |
+| .github/workflows/artifactpoisoning31.yml:13:9:15:6 | Run Step | .github/workflows/artifactpoisoning31.yml:13:9:15:6 | Run Step | .github/workflows/artifactpoisoning31.yml:19:14:19:22 | ./foo/cmd | Potential artifact poisoning; the artifact being consumed has contents that may be controlled by an external user ($@). | .github/workflows/artifactpoisoning31.yml:4:3:4:14 | workflow_run | workflow_run |
+| .github/workflows/artifactpoisoning32.yml:13:9:16:6 | Run Step | .github/workflows/artifactpoisoning32.yml:13:9:16:6 | Run Step | .github/workflows/artifactpoisoning32.yml:17:14:18:20 | ./bar/cmd\n | Potential artifact poisoning; the artifact being consumed has contents that may be controlled by an external user ($@). | .github/workflows/artifactpoisoning32.yml:4:3:4:14 | workflow_run | workflow_run |
+| .github/workflows/artifactpoisoning33.yml:13:9:16:6 | Run Step | .github/workflows/artifactpoisoning33.yml:13:9:16:6 | Run Step | .github/workflows/artifactpoisoning33.yml:17:14:18:20 | ./bar/cmd\n | Potential artifact poisoning; the artifact being consumed has contents that may be controlled by an external user ($@). | .github/workflows/artifactpoisoning33.yml:4:3:4:14 | workflow_run | workflow_run |
+| .github/workflows/artifactpoisoning34.yml:13:9:16:6 | Run Step | .github/workflows/artifactpoisoning34.yml:13:9:16:6 | Run Step | .github/workflows/artifactpoisoning34.yml:20:14:22:23 | npm install\nnpm run lint\n | Potential artifact poisoning; the artifact being consumed has contents that may be controlled by an external user ($@). | .github/workflows/artifactpoisoning34.yml:4:3:4:14 | workflow_run | workflow_run |
+| .github/workflows/artifactpoisoning41.yml:13:9:21:6 | Run Step | .github/workflows/artifactpoisoning41.yml:13:9:21:6 | Run Step | .github/workflows/artifactpoisoning41.yml:22:14:22:22 | ./foo/cmd | Potential artifact poisoning; the artifact being consumed has contents that may be controlled by an external user ($@). | .github/workflows/artifactpoisoning41.yml:4:3:4:14 | workflow_run | workflow_run |
+| .github/workflows/artifactpoisoning42.yml:13:9:21:6 | Run Step | .github/workflows/artifactpoisoning42.yml:13:9:21:6 | Run Step | .github/workflows/artifactpoisoning42.yml:22:14:22:18 | ./cmd | Potential artifact poisoning; the artifact being consumed has contents that may be controlled by an external user ($@). | .github/workflows/artifactpoisoning42.yml:4:3:4:14 | workflow_run | workflow_run |
+| .github/workflows/artifactpoisoning71.yml:9:9:16:6 | Uses Step | .github/workflows/artifactpoisoning71.yml:9:9:16:6 | Uses Step | .github/workflows/artifactpoisoning71.yml:17:14:18:40 | sed -f config foo.md > bar.md\n | Potential artifact poisoning; the artifact being consumed has contents that may be controlled by an external user ($@). | .github/workflows/artifactpoisoning71.yml:4:5:4:16 | workflow_run | workflow_run |
+| .github/workflows/artifactpoisoning81.yml:28:9:31:6 | Uses Step | .github/workflows/artifactpoisoning81.yml:28:9:31:6 | Uses Step | .github/workflows/artifactpoisoning81.yml:31:14:31:27 | python test.py | Potential artifact poisoning; the artifact being consumed has contents that may be controlled by an external user ($@). | .github/workflows/artifactpoisoning81.yml:3:5:3:23 | pull_request_target | pull_request_target |
+| .github/workflows/artifactpoisoning96.yml:13:9:18:6 | Uses Step | .github/workflows/artifactpoisoning96.yml:13:9:18:6 | Uses Step | .github/workflows/artifactpoisoning96.yml:18:14:18:24 | npm install | Potential artifact poisoning; the artifact being consumed has contents that may be controlled by an external user ($@). | .github/workflows/artifactpoisoning96.yml:2:3:2:14 | workflow_run | workflow_run |
+| .github/workflows/artifactpoisoning101.yml:10:9:16:6 | Uses Step | .github/workflows/artifactpoisoning101.yml:10:9:16:6 | Uses Step | .github/workflows/artifactpoisoning101.yml:17:14:19:59 | PR_NUMBER=$(./get_pull_request_number.sh pr_number.txt)\necho "PR_NUMBER=$PR_NUMBER" >> $GITHUB_OUTPUT \n | Potential artifact poisoning; the artifact being consumed has contents that may be controlled by an external user ($@). | .github/workflows/artifactpoisoning101.yml:4:3:4:21 | pull_request_target | pull_request_target |
+| .github/workflows/test18.yml:12:15:33:12 | Uses Step | .github/workflows/test18.yml:12:15:33:12 | Uses Step | .github/workflows/test18.yml:36:15:40:58 | Uses Step | Potential artifact poisoning; the artifact being consumed has contents that may be controlled by an external user ($@). | .github/workflows/test18.yml:3:5:3:16 | workflow_run | workflow_run |
+| .github/workflows/test25.yml:22:9:32:6 | Uses Step: downloadBuildScan | .github/workflows/test25.yml:22:9:32:6 | Uses Step: downloadBuildScan | .github/workflows/test25.yml:39:14:40:45 | ./gradlew buildScanPublishPrevious\n | Potential artifact poisoning; the artifact being consumed has contents that may be controlled by an external user ($@). | .github/workflows/test25.yml:2:3:2:14 | workflow_run | workflow_run |

cpp/ql/integration-tests/query-suite/cpp-code-scanning.qls.expected

@@ -7,10 +7,12 @@ ql/cpp/ql/src/Diagnostics/ExtractedFiles.ql
 ql/cpp/ql/src/Diagnostics/ExtractionWarnings.ql
 ql/cpp/ql/src/Diagnostics/FailedExtractorInvocations.ql
 ql/cpp/ql/src/Likely Bugs/Arithmetic/BadAdditionOverflowCheck.ql
+ql/cpp/ql/src/Likely Bugs/Arithmetic/IntMultToLong.ql
 ql/cpp/ql/src/Likely Bugs/Arithmetic/SignedOverflowCheck.ql
 ql/cpp/ql/src/Likely Bugs/Conversion/CastArrayPointerArithmetic.ql
 ql/cpp/ql/src/Likely Bugs/Format/SnprintfOverflow.ql
 ql/cpp/ql/src/Likely Bugs/Format/WrongNumberOfFormatArguments.ql
+ql/cpp/ql/src/Likely Bugs/Format/WrongTypeFormatArguments.ql
 ql/cpp/ql/src/Likely Bugs/Memory Management/AllocaInLoop.ql
 ql/cpp/ql/src/Likely Bugs/Memory Management/PointerOverflow.ql
 ql/cpp/ql/src/Likely Bugs/Memory Management/ReturnStackAllocatedMemory.ql
@@ -28,6 +30,7 @@ ql/cpp/ql/src/Security/CWE/CWE-120/VeryLikelyOverrunWrite.ql
 ql/cpp/ql/src/Security/CWE/CWE-131/NoSpaceForZeroTerminator.ql
 ql/cpp/ql/src/Security/CWE/CWE-134/UncontrolledFormatString.ql
 ql/cpp/ql/src/Security/CWE/CWE-190/ArithmeticUncontrolled.ql
+ql/cpp/ql/src/Security/CWE/CWE-190/ComparisonWithWiderType.ql
 ql/cpp/ql/src/Security/CWE/CWE-191/UnsignedDifferenceExpressionComparedZero.ql
 ql/cpp/ql/src/Security/CWE/CWE-253/HResultBooleanConversion.ql
 ql/cpp/ql/src/Security/CWE/CWE-311/CleartextFileWrite.ql
@@ -40,6 +43,7 @@ ql/cpp/ql/src/Security/CWE/CWE-367/TOCTOUFilesystemRace.ql
 ql/cpp/ql/src/Security/CWE/CWE-416/IteratorToExpiredContainer.ql
 ql/cpp/ql/src/Security/CWE/CWE-416/UseOfStringAfterLifetimeEnds.ql
 ql/cpp/ql/src/Security/CWE/CWE-416/UseOfUniquePointerAfterLifetimeEnds.ql
+ql/cpp/ql/src/Security/CWE/CWE-468/SuspiciousAddWithSizeof.ql
 ql/cpp/ql/src/Security/CWE/CWE-497/ExposedSystemData.ql
 ql/cpp/ql/src/Security/CWE/CWE-611/XXE.ql
 ql/cpp/ql/src/Security/CWE/CWE-676/DangerousFunctionOverflow.ql

cpp/ql/lib/CHANGELOG.md

@@ -1,3 +1,14 @@
+## 10.0.0
+
+### Breaking Changes
+
+* The deprecated `NonThrowingFunction` class has been removed, use `NonCppThrowingFunction` instead.
+* The deprecated `ThrowingFunction` class has been removed, use `AlwaysSehThrowingFunction` instead.
+
+### New Features
+
+* Added a subclass `AutoconfConfigureTestFile` of `ConfigurationTestFile` that represents files created by GNU autoconf configure scripts to test the build configuration.
+
 ## 9.0.0
 
 ### Breaking Changes

cpp/ql/lib/change-notes/2026-03-20-data-extensions-barriers.md

@@ -0,0 +1,4 @@
+---
+category: feature
+---
+* Data flow barriers and barrier guards can now be added using data extensions. For more information see [Customizing library models for C and C++](https://codeql.github.com/docs/codeql-language-guides/customizing-library-models-for-cpp/).

cpp/ql/lib/change-notes/released/10.0.0.md

@@ -0,0 +1,10 @@
+## 10.0.0
+
+### Breaking Changes
+
+* The deprecated `NonThrowingFunction` class has been removed, use `NonCppThrowingFunction` instead.
+* The deprecated `ThrowingFunction` class has been removed, use `AlwaysSehThrowingFunction` instead.
+
+### New Features
+
+* Added a subclass `AutoconfConfigureTestFile` of `ConfigurationTestFile` that represents files created by GNU autoconf configure scripts to test the build configuration.

cpp/ql/lib/codeql-pack.release.yml

@@ -1,2 +1,2 @@
 ---
-lastReleaseVersion: 9.0.0
+lastReleaseVersion: 10.0.0

cpp/ql/lib/ext/allocation/Std.allocation.model.yml

@@ -12,4 +12,7 @@ extensions:
       - ["", "", False, "_malloca", "0", "", "", False]
       - ["", "", False, "calloc", "1", "0", "", True]
       - ["std", "", False, "calloc", "1", "0", "", True]
-      - ["bsl", "", False, "calloc", "1", "0", "", True]
+      - ["bsl", "", False, "calloc", "1", "0", "", True]
+      - ["", "", False, "aligned_alloc", "1", "", "", True]
+      - ["std", "", False, "aligned_alloc", "1", "", "", True]
+      - ["bsl", "", False, "aligned_alloc", "1", "", "", True]

cpp/ql/lib/qlpack.yml

@@ -1,5 +1,5 @@
 name: codeql/cpp-all
-version: 9.0.0
+version: 10.0.1-dev
 groups: cpp
 dbscheme: semmlecode.cpp.dbscheme
 extractor: cpp

cpp/ql/lib/semmle/code/cpp/ConfigurationTestFile.qll

@@ -42,3 +42,10 @@ class MesonPrivateTestFile extends ConfigurationTestFile {
     )
   }
 }
+
+/**
+ * A file created by a GNU autoconf configure script to test the system configuration.
+ */
+class AutoconfConfigureTestFile extends ConfigurationTestFile {
+  AutoconfConfigureTestFile() { this.getBaseName().regexpMatch("conftest[0-9]*\\.c(pp)?") }
+}

cpp/ql/lib/semmle/code/cpp/commons/Printf.qll

@@ -459,6 +459,13 @@ class FormatLiteral extends Literal instanceof StringLiteral {
    */
   int getConvSpecOffset(int n) { result = this.getFormat().indexOf("%", n, 0) }
 
+  /**
+   * Gets the nth conversion specifier string.
+   */
+  private string getConvSpecString(int n) {
+    n >= 0 and result = "%" + this.getFormat().splitAt("%", n + 1)
+  }
+
   /*
    * Each of these predicates gets a regular expressions to match each individual
    * parts of a conversion specifier.
@@ -524,22 +531,20 @@ class FormatLiteral extends Literal instanceof StringLiteral {
     int n, string spec, string params, string flags, string width, string prec, string len,
     string conv
   ) {
-    exists(int offset, string fmt, string rst, string regexp |
-      offset = this.getConvSpecOffset(n) and
-      fmt = this.getFormat() and
-      rst = fmt.substring(offset, fmt.length()) and
+    exists(string convSpec, string regexp |
+      convSpec = this.getConvSpecString(n) and
       regexp = this.getConvSpecRegexp() and
       (
-        spec = rst.regexpCapture(regexp, 1) and
-        params = rst.regexpCapture(regexp, 2) and
-        flags = rst.regexpCapture(regexp, 3) and
-        width = rst.regexpCapture(regexp, 4) and
-        prec = rst.regexpCapture(regexp, 5) and
-        len = rst.regexpCapture(regexp, 6) and
-        conv = rst.regexpCapture(regexp, 7)
+        spec = convSpec.regexpCapture(regexp, 1) and
+        params = convSpec.regexpCapture(regexp, 2) and
+        flags = convSpec.regexpCapture(regexp, 3) and
+        width = convSpec.regexpCapture(regexp, 4) and
+        prec = convSpec.regexpCapture(regexp, 5) and
+        len = convSpec.regexpCapture(regexp, 6) and
+        conv = convSpec.regexpCapture(regexp, 7)
         or
-        spec = rst.regexpCapture(regexp, 1) and
-        not exists(rst.regexpCapture(regexp, 2)) and
+        spec = convSpec.regexpCapture(regexp, 1) and
+        not exists(convSpec.regexpCapture(regexp, 2)) and
         params = "" and
         flags = "" and
         width = "" and
@@ -554,12 +559,10 @@ class FormatLiteral extends Literal instanceof StringLiteral {
    * Gets the nth conversion specifier (including the initial `%`).
    */
   string getConvSpec(int n) {
-    exists(int offset, string fmt, string rst, string regexp |
-      offset = this.getConvSpecOffset(n) and
-      fmt = this.getFormat() and
-      rst = fmt.substring(offset, fmt.length()) and
+    exists(string convSpec, string regexp |
+      convSpec = this.getConvSpecString(n) and
       regexp = this.getConvSpecRegexp() and
-      result = rst.regexpCapture(regexp, 1)
+      result = convSpec.regexpCapture(regexp, 1)
     )
   }
 

cpp/ql/lib/semmle/code/cpp/commons/Scanf.qll

@@ -194,6 +194,13 @@ class ScanfFormatLiteral extends Expr {
     )
   }
 
+  /**
+   * Gets the nth conversion specifier string.
+   */
+  private string getConvSpecString(int n) {
+    n >= 0 and result = "%" + this.getFormat().splitAt("%", n + 1)
+  }
+
   /**
    * Gets the regular expression to match each individual part of a conversion specifier.
    */
@@ -227,16 +234,14 @@ class ScanfFormatLiteral extends Expr {
    * specifier.
    */
   predicate parseConvSpec(int n, string spec, string width, string len, string conv) {
-    exists(int offset, string fmt, string rst, string regexp |
-      offset = this.getConvSpecOffset(n) and
-      fmt = this.getFormat() and
-      rst = fmt.substring(offset, fmt.length()) and
+    exists(string convSpec, string regexp |
+      convSpec = this.getConvSpecString(n) and
       regexp = this.getConvSpecRegexp() and
       (
-        spec = rst.regexpCapture(regexp, 1) and
-        width = rst.regexpCapture(regexp, 2) and
-        len = rst.regexpCapture(regexp, 3) and
-        conv = rst.regexpCapture(regexp, 4)
+        spec = convSpec.regexpCapture(regexp, 1) and
+        width = convSpec.regexpCapture(regexp, 2) and
+        len = convSpec.regexpCapture(regexp, 3) and
+        conv = convSpec.regexpCapture(regexp, 4)
       )
     )
   }

cpp/ql/lib/semmle/code/cpp/dataflow/ExternalFlow.qll

@@ -6,11 +6,15 @@
  *
  * The extensible relations have the following columns:
  * - Sources:
- *   `namespace; type; subtypes; name; signature; ext; output; kind`
+ *   `namespace; type; subtypes; name; signature; ext; output; kind; provenance`
  * - Sinks:
- *   `namespace; type; subtypes; name; signature; ext; input; kind`
+ *   `namespace; type; subtypes; name; signature; ext; input; kind; provenance`
  * - Summaries:
- *   `namespace; type; subtypes; name; signature; ext; input; output; kind`
+ *   `namespace; type; subtypes; name; signature; ext; input; output; kind; provenance`
+ * - Barriers:
+ *   `namespace; type; subtypes; name; signature; ext; output; kind; provenance`
+ * - BarrierGuards:
+ *   `namespace; type; subtypes; name; signature; ext; input; acceptingValue; kind; provenance`
  *
  * The interpretation of a row is similar to API-graphs with a left-to-right
  * reading.
@@ -87,11 +91,23 @@
  *    value, and
  *    - flow from the _second_ indirection of the 0th argument to the first
  *    indirection of the return value, etc.
- * 8. The `kind` column is a tag that can be referenced from QL to determine to
+ * 8. The `acceptingValue` column of barrier guard models specifies the condition
+ *    under which the guard blocks flow. It can be one of "true" or "false". In
+ *    the future "no-exception", "not-zero", "null", "not-null" may be supported.
+ * 9. The `kind` column is a tag that can be referenced from QL to determine to
  *    which classes the interpreted elements should be added. For example, for
  *    sources "remote" indicates a default remote flow source, and for summaries
  *    "taint" indicates a default additional taint step and "value" indicates a
  *    globally applicable value-preserving step.
+ * 10. The `provenance` column is a tag to indicate the origin and verification of a model.
+ *    The format is {origin}-{verification} or just "manual" where the origin describes
+ *    the origin of the model and verification describes how the model has been verified.
+ *    Some examples are:
+ *    - "df-generated": The model has been generated by the model generator tool.
+ *    - "df-manual": The model has been generated by the model generator and verified by a human.
+ *    - "manual": The model has been written by hand.
+ *    This information is used in a heuristic for dataflow analysis to determine, if a
+ *    model or source code should be used for determining flow.
  */
 
 import cpp
@@ -931,13 +947,13 @@ private module Cached {
 
   private predicate barrierGuardChecks(IRGuardCondition g, Expr e, boolean gv, TKindModelPair kmp) {
     exists(
-      SourceSinkInterpretationInput::InterpretNode n, Public::AcceptingValue acceptingvalue,
+      SourceSinkInterpretationInput::InterpretNode n, Public::AcceptingValue acceptingValue,
       string kind, string model
     |
-      isBarrierGuardNode(n, acceptingvalue, kind, model) and
+      isBarrierGuardNode(n, acceptingValue, kind, model) and
       n.asNode().asExpr() = e and
       kmp = TMkPair(kind, model) and
-      gv = convertAcceptingValue(acceptingvalue).asBooleanValue() and
+      gv = convertAcceptingValue(acceptingValue).asBooleanValue() and
       n.asNode().(Private::ArgumentNode).getCall().asCallInstruction() = g
     )
   }
@@ -954,14 +970,14 @@ private module Cached {
   ) {
     exists(
       SourceSinkInterpretationInput::InterpretNode interpretNode,
-      Public::AcceptingValue acceptingvalue, string kind, string model, int indirectionIndex,
+      Public::AcceptingValue acceptingValue, string kind, string model, int indirectionIndex,
       Private::ArgumentNode arg
     |
-      isBarrierGuardNode(interpretNode, acceptingvalue, kind, model) and
+      isBarrierGuardNode(interpretNode, acceptingValue, kind, model) and
       arg = interpretNode.asNode() and
       arg.asIndirectExpr(indirectionIndex) = e and
       kmp = MkKindModelPairIntPair(TMkPair(kind, model), indirectionIndex) and
-      gv = convertAcceptingValue(acceptingvalue).asBooleanValue() and
+      gv = convertAcceptingValue(acceptingValue).asBooleanValue() and
       arg.getCall().asCallInstruction() = g
     )
   }

cpp/ql/lib/semmle/code/cpp/dataflow/internal/ExternalFlowExtensions.qll

@@ -33,7 +33,7 @@ extensible predicate barrierModel(
  */
 extensible predicate barrierGuardModel(
   string namespace, string type, boolean subtypes, string name, string signature, string ext,
-  string input, string acceptingvalue, string kind, string provenance, QlBuiltins::ExtensionId madId
+  string input, string acceptingValue, string kind, string provenance, QlBuiltins::ExtensionId madId
 );
 
 /**

cpp/ql/lib/semmle/code/cpp/dataflow/internal/FlowSummaryImpl.qll

@@ -162,13 +162,13 @@ module SourceSinkInterpretationInput implements
   }
 
   predicate barrierGuardElement(
-    Element e, string input, Public::AcceptingValue acceptingvalue, string kind,
+    Element e, string input, Public::AcceptingValue acceptingValue, string kind,
     Public::Provenance provenance, string model
   ) {
     exists(
       string package, string type, boolean subtypes, string name, string signature, string ext
     |
-      barrierGuardModel(package, type, subtypes, name, signature, ext, input, acceptingvalue, kind,
+      barrierGuardModel(package, type, subtypes, name, signature, ext, input, acceptingValue, kind,
         provenance, model) and
       e = interpretElement(package, type, subtypes, name, signature, ext)
     )

cpp/ql/lib/semmle/code/cpp/models/interfaces/NonThrowing.qll

@@ -11,10 +11,3 @@ import semmle.code.cpp.models.Models
  * The function may still raise a structured exception handling (SEH) exception.
  */
 abstract class NonCppThrowingFunction extends Function { }
-
-/**
- * A function that is guaranteed to never throw.
- *
- * DEPRECATED: use `NonCppThrowingFunction` instead.
- */
-deprecated class NonThrowingFunction = NonCppThrowingFunction;

cpp/ql/lib/semmle/code/cpp/models/interfaces/Throwing.qll

@@ -10,19 +10,6 @@ import semmle.code.cpp.Function
 import semmle.code.cpp.models.Models
 import semmle.code.cpp.models.interfaces.FunctionInputsAndOutputs
 
-/**
- * A function that is known to raise an exception.
- *
- * DEPRECATED: use `AlwaysSehThrowingFunction` instead.
- */
-abstract deprecated class ThrowingFunction extends Function {
-  /**
-   * Holds if this function may throw an exception during evaluation.
-   * If `unconditional` is `true` the function always throws an exception.
-   */
-  abstract predicate mayThrowException(boolean unconditional);
-}
-
 /**
  * A function that unconditionally raises a structured exception handling (SEH) exception.
  */

cpp/ql/src/CHANGELOG.md

@@ -1,3 +1,14 @@
+## 1.6.1
+
+### Minor Analysis Improvements
+
+* Added `AllocationFunction` models for `aligned_alloc`, `std::aligned_alloc`, and `bsl::aligned_alloc`.
+* The "Comparison of narrow type with wide type in loop condition" (`cpp/comparison-with-wider-type`) query has been upgraded to `high` precision. This query will now run in the default code scanning suite.
+* The "Multiplication result converted to larger type" (`cpp/integer-multiplication-cast-to-long`) query has been upgraded to `high` precision. This query will now run in the default code scanning suite.
+* The "Suspicious add with sizeof" (`cpp/suspicious-add-sizeof`) query has been upgraded to `high` precision. This query will now run in the default code scanning suite.
+* The "Wrong type of arguments to formatting function" (`cpp/wrong-type-format-argument`) query has been upgraded to `high` precision. This query will now run in the default code scanning suite.
+* The "Implicit function declaration" (`cpp/implicit-function-declaration`) query has been upgraded to `high` precision. However, for `build mode: none` databases, it no longer produces any results. The results in this mode were found to be very noisy and fundamentally imprecise.
+
 ## 1.6.0
 
 ### Query Metadata Changes
@@ -355,7 +366,7 @@ No user-facing changes.
 ### Minor Analysis Improvements
 
 * The "non-constant format string" query (`cpp/non-constant-format`) has been updated to produce fewer false positives.
-* Added dataflow models for the `gettext` function variants. 
+* Added dataflow models for the `gettext` function variants.
 
 ## 0.9.4
 

cpp/ql/src/Likely Bugs/Arithmetic/IntMultToLong.ql

@@ -5,7 +5,7 @@
  * @kind problem
  * @problem.severity warning
  * @security-severity 8.1
- * @precision medium
+ * @precision high
  * @id cpp/integer-multiplication-cast-to-long
  * @tags reliability
  *       security

cpp/ql/src/Likely Bugs/Format/WrongTypeFormatArguments.ql

@@ -5,7 +5,7 @@
  * @kind problem
  * @problem.severity error
  * @security-severity 7.5
- * @precision medium
+ * @precision high
  * @id cpp/wrong-type-format-argument
  * @tags reliability
  *       correctness

cpp/ql/src/Likely Bugs/Underspecified Functions/ImplicitFunctionDeclaration.qhelp

@@ -14,6 +14,9 @@ function may behave unpredictably.</p>
 <p>This may indicate a misspelled function name, or that the required header containing
 the function declaration has not been included.</p>
 
+<p>Note: This query is not compatible with <code>build mode: none</code> databases, and produces
+no results on those databases.</p>
+
 </overview>
 <recommendation>
 <p>Provide an explicit declaration of the function before invoking it.</p>
@@ -26,4 +29,4 @@ the function declaration has not been included.</p>
 <references>
 <li>SEI CERT C Coding Standard: <a href="https://wiki.sei.cmu.edu/confluence/display/c/DCL31-C.+Declare+identifiers+before+using+them">DCL31-C. Declare identifiers before using them</a></li>
 </references>
-</qhelp>
+</qhelp>

cpp/ql/src/Likely Bugs/Underspecified Functions/ImplicitFunctionDeclaration.ql

@@ -5,7 +5,7 @@
  * may lead to unpredictable behavior.
  * @kind problem
  * @problem.severity warning
- * @precision medium
+ * @precision high
  * @id cpp/implicit-function-declaration
  * @tags correctness
  *       maintainability
@@ -17,6 +17,11 @@ import TooFewArguments
 import TooManyArguments
 import semmle.code.cpp.commons.Exclusions
 
+/*
+ * This query is not compatible with build mode: none databases, and produces
+ * no results on those databases.
+ */
+
 predicate locInfo(Locatable e, File file, int line, int col) {
   e.getFile() = file and
   e.getLocation().getStartLine() = line and
@@ -39,6 +44,7 @@ predicate isCompiledAsC(File f) {
 from FunctionDeclarationEntry fdeIm, FunctionCall fc
 where
   isCompiledAsC(fdeIm.getFile()) and
+  not any(Compilation c).buildModeNone() and
   not isFromMacroDefinition(fc) and
   fdeIm.isImplicit() and
   sameLocation(fdeIm, fc) and

cpp/ql/src/Likely Bugs/Underspecified Functions/MistypedFunctionArguments.qll

@@ -79,9 +79,7 @@ private predicate hasZeroParamDecl(Function f) {
 
 // True if this file (or header) was compiled as a C file
 private predicate isCompiledAsC(File f) {
-  f.compiledAsC()
-  or
-  exists(File src | isCompiledAsC(src) | src.getAnIncludedFile() = f)
+  exists(File src | src.compiledAsC() | src.getAnIncludedFile*() = f)
 }
 
 predicate mistypedFunctionArguments(FunctionCall fc, Function f, Parameter p) {

cpp/ql/src/Likely Bugs/Underspecified Functions/TooFewArguments.qll

@@ -28,9 +28,7 @@ private predicate hasZeroParamDecl(Function f) {
 
 /* Holds if this file (or header) was compiled as a C file. */
 private predicate isCompiledAsC(File f) {
-  f.compiledAsC()
-  or
-  exists(File src | isCompiledAsC(src) | src.getAnIncludedFile() = f)
+  exists(File src | src.compiledAsC() | src.getAnIncludedFile*() = f)
 }
 
 /** Holds if `fc` is a call to `f` with too few arguments. */

cpp/ql/src/Likely Bugs/Underspecified Functions/TooManyArguments.qll

@@ -19,9 +19,7 @@ private predicate hasZeroParamDecl(Function f) {
 
 // True if this file (or header) was compiled as a C file
 private predicate isCompiledAsC(File f) {
-  f.compiledAsC()
-  or
-  exists(File src | isCompiledAsC(src) | src.getAnIncludedFile() = f)
+  exists(File src | src.compiledAsC() | src.getAnIncludedFile*() = f)
 }
 
 predicate tooManyArguments(FunctionCall fc, Function f) {

cpp/ql/src/Security/CWE/CWE-190/ComparisonWithWiderType.ql

@@ -6,7 +6,7 @@
  * @kind problem
  * @problem.severity warning
  * @security-severity 7.8
- * @precision medium
+ * @precision high
  * @tags reliability
  *       security
  *       external/cwe/cwe-190

cpp/ql/src/Security/CWE/CWE-468/SuspiciousAddWithSizeof.ql

@@ -6,7 +6,7 @@
  * @kind problem
  * @problem.severity warning
  * @security-severity 8.8
- * @precision medium
+ * @precision high
  * @id cpp/suspicious-add-sizeof
  * @tags security
  *       external/cwe/cwe-468

cpp/ql/src/change-notes/released/1.6.1.md

@@ -0,0 +1,10 @@
+## 1.6.1
+
+### Minor Analysis Improvements
+
+* Added `AllocationFunction` models for `aligned_alloc`, `std::aligned_alloc`, and `bsl::aligned_alloc`.
+* The "Comparison of narrow type with wide type in loop condition" (`cpp/comparison-with-wider-type`) query has been upgraded to `high` precision. This query will now run in the default code scanning suite.
+* The "Multiplication result converted to larger type" (`cpp/integer-multiplication-cast-to-long`) query has been upgraded to `high` precision. This query will now run in the default code scanning suite.
+* The "Suspicious add with sizeof" (`cpp/suspicious-add-sizeof`) query has been upgraded to `high` precision. This query will now run in the default code scanning suite.
+* The "Wrong type of arguments to formatting function" (`cpp/wrong-type-format-argument`) query has been upgraded to `high` precision. This query will now run in the default code scanning suite.
+* The "Implicit function declaration" (`cpp/implicit-function-declaration`) query has been upgraded to `high` precision. However, for `build mode: none` databases, it no longer produces any results. The results in this mode were found to be very noisy and fundamentally imprecise.

cpp/ql/src/codeql-pack.release.yml

@@ -1,2 +1,2 @@
 ---
-lastReleaseVersion: 1.6.0
+lastReleaseVersion: 1.6.1

cpp/ql/src/qlpack.yml

@@ -1,5 +1,5 @@
 name: codeql/cpp-queries
-version: 1.6.0
+version: 1.6.2-dev
 groups:
   - cpp
   - queries

cpp/ql/test/query-tests/Likely Bugs/Likely Typos/ExprHasNoEffect/autoconf/ExprHasNoEffect.expected

@@ -0,0 +1,2 @@
+| conftest.c.c:4:3:4:8 | call to strlen | This expression has no effect (because $@ has no external side effects). | conftest.h:3:8:3:13 | strlen | strlen |
+| conftest_abc.c:4:3:4:8 | call to strlen | This expression has no effect (because $@ has no external side effects). | conftest.h:3:8:3:13 | strlen | strlen |

cpp/ql/test/query-tests/Likely Bugs/Likely Typos/ExprHasNoEffect/autoconf/ExprHasNoEffect.qlref

@@ -0,0 +1 @@
+Likely Bugs/Likely Typos/ExprHasNoEffect.ql

cpp/ql/test/query-tests/Likely Bugs/Likely Typos/ExprHasNoEffect/autoconf/conftest.c

@@ -0,0 +1,6 @@
+#include "conftest.h"
+
+int main2() {
+  strlen(""); // GOOD: conftest files are ignored
+  return 0;
+}

cpp/ql/test/query-tests/Likely Bugs/Likely Typos/ExprHasNoEffect/autoconf/conftest.c.c

@@ -0,0 +1,6 @@
+#include "conftest.h"
+
+int main3() {
+  strlen(""); // BAD: not a `conftest` file, as `conftest` is not directly followed by the extension or a sequence of numbers.
+  return 0;
+}

cpp/ql/test/query-tests/Likely Bugs/Likely Typos/ExprHasNoEffect/autoconf/conftest.cpp

@@ -0,0 +1,6 @@
+#include "conftest.h"
+
+int main4() {
+  strlen(""); // GOOD: conftest files are ignored
+  return 0;
+}

cpp/ql/test/query-tests/Likely Bugs/Likely Typos/ExprHasNoEffect/autoconf/conftest.h

@@ -0,0 +1,3 @@
+typedef long long size_t;
+
+size_t strlen(const char *s);

cpp/ql/test/query-tests/Likely Bugs/Likely Typos/ExprHasNoEffect/autoconf/conftest123.c

@@ -0,0 +1,6 @@
+#include "conftest.h"
+
+int main5() {
+  strlen(""); // GOOD: conftest files are ignored
+  return 0;
+}

cpp/ql/test/query-tests/Likely Bugs/Likely Typos/ExprHasNoEffect/autoconf/conftest_abc.c

@@ -0,0 +1,6 @@
+#include "conftest.h"
+
+int main1() {
+  strlen(""); // BAD: not a `conftest` file, as `conftest` is not directly followed by the extension or a sequence of numbers.
+  return 0;
+}

csharp/ql/campaigns/Solorigate/lib/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 1.7.65
+
+No user-facing changes.
+
 ## 1.7.64
 
 No user-facing changes.

csharp/ql/campaigns/Solorigate/lib/change-notes/released/1.7.65.md

@@ -0,0 +1,3 @@
+## 1.7.65
+
+No user-facing changes.

csharp/ql/campaigns/Solorigate/lib/codeql-pack.release.yml

@@ -1,2 +1,2 @@
 ---
-lastReleaseVersion: 1.7.64
+lastReleaseVersion: 1.7.65

csharp/ql/campaigns/Solorigate/lib/qlpack.yml

@@ -1,5 +1,5 @@
 name: codeql/csharp-solorigate-all
-version: 1.7.64
+version: 1.7.66-dev
 groups:
   - csharp
   - solorigate

csharp/ql/campaigns/Solorigate/src/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 1.7.65
+
+No user-facing changes.
+
 ## 1.7.64
 
 No user-facing changes.

csharp/ql/campaigns/Solorigate/src/ModifiedFnvFunctionDetection.ql

@@ -13,11 +13,13 @@ import csharp
 import Solorigate
 import experimental.code.csharp.Cryptography.NonCryptographicHashes
 
+ControlFlowNode loopExitNode(LoopStmt loop) { result.isAfter(loop) }
+
 from Variable v, Literal l, LoopStmt loop, Expr additional_xor
 where
   maybeUsedInFnvFunction(v, _, _, loop) and
   exists(BitwiseXorOperation xor2 | xor2.getAnOperand() = l and additional_xor = xor2 |
-    loop.getAControlFlowExitNode().getASuccessor*() = xor2.getAControlFlowNode() and
+    loopExitNode(loop).getASuccessor*() = xor2.getControlFlowNode() and
     xor2.getAnOperand() = v.getAnAccess()
   )
 select l, "This literal is used in an $@ after an FNV-like hash calculation with variable $@.",

csharp/ql/campaigns/Solorigate/src/change-notes/released/1.7.65.md

@@ -0,0 +1,3 @@
+## 1.7.65
+
+No user-facing changes.

csharp/ql/campaigns/Solorigate/src/codeql-pack.release.yml

@@ -1,2 +1,2 @@
 ---
-lastReleaseVersion: 1.7.64
+lastReleaseVersion: 1.7.65

csharp/ql/campaigns/Solorigate/src/qlpack.yml

@@ -1,5 +1,5 @@
 name: codeql/csharp-solorigate-queries
-version: 1.7.64
+version: 1.7.66-dev
 groups:
   - csharp
   - solorigate

csharp/ql/consistency-queries/CfgConsistency.ql

@@ -1,5 +1,2 @@
 import csharp
-import semmle.code.csharp.controlflow.internal.Completion
-import ControlFlow
-import semmle.code.csharp.controlflow.internal.ControlFlowGraphImpl::Consistency
-import semmle.code.csharp.controlflow.internal.Splitting
+import ControlFlow::Consistency

csharp/ql/consistency-queries/DataFlowConsistency.ql

@@ -1,5 +1,4 @@
 import csharp
-private import semmle.code.csharp.controlflow.internal.ControlFlowGraphImpl as ControlFlowGraphImpl
 private import semmle.code.csharp.dataflow.internal.DataFlowImplSpecific
 private import semmle.code.csharp.dataflow.internal.TaintTrackingImplSpecific
 private import codeql.dataflow.internal.DataFlowImplConsistency
@@ -7,20 +6,6 @@ private import codeql.dataflow.internal.DataFlowImplConsistency
 private module Input implements InputSig<Location, CsharpDataFlow> {
   private import CsharpDataFlow
 
-  private predicate isStaticAssignable(Assignable a) { a.(Modifiable).isStatic() }
-
-  predicate uniqueEnclosingCallableExclude(Node node) {
-    // TODO: Remove once static initializers are folded into the
-    // static constructors
-    isStaticAssignable(ControlFlowGraphImpl::getNodeCfgScope(node.getControlFlowNode()))
-  }
-
-  predicate uniqueCallEnclosingCallableExclude(DataFlowCall call) {
-    // TODO: Remove once static initializers are folded into the
-    // static constructors
-    isStaticAssignable(ControlFlowGraphImpl::getNodeCfgScope(call.getControlFlowNode()))
-  }
-
   predicate uniqueNodeLocationExclude(Node n) {
     // Methods with multiple implementations
     n instanceof ParameterNode
@@ -70,17 +55,14 @@ private module Input implements InputSig<Location, CsharpDataFlow> {
           init.getInitializer().getNumberOfChildren() > 1
         )
       or
-      exists(ControlFlow::Nodes::ElementNode cfn, ControlFlow::Nodes::Split split |
-        exists(arg.asExprAtNode(cfn))
-      |
-        split = cfn.getASplit() and
-        not split = call.getControlFlowNode().getASplit()
-        or
-        split = call.getControlFlowNode().getASplit() and
-        not split = cfn.getASplit()
-      )
-      or
       call.(NonDelegateDataFlowCall).getDispatchCall().isReflection()
+      or
+      // Exclude calls that are both getter and setter calls, as they share the same argument nodes.
+      exists(AccessorCall ac |
+        call.(NonDelegateDataFlowCall).getDispatchCall().getCall() = ac and
+        ac instanceof AssignableRead and
+        ac instanceof AssignableWrite
+      )
     )
   }
 }

csharp/ql/consistency-queries/VariableCaptureConsistency.ql

@@ -1,13 +1,6 @@
 import csharp
 import semmle.code.csharp.dataflow.internal.DataFlowPrivate::VariableCapture::Flow::ConsistencyChecks
 private import semmle.code.csharp.dataflow.internal.DataFlowPrivate::VariableCapture::Flow::ConsistencyChecks as ConsistencyChecks
-private import semmle.code.csharp.controlflow.BasicBlocks
-private import semmle.code.csharp.controlflow.internal.ControlFlowGraphImpl
-
-query predicate uniqueEnclosingCallable(BasicBlock bb, string msg) {
-  ConsistencyChecks::uniqueEnclosingCallable(bb, msg) and
-  getNodeCfgScope(bb.getFirstNode()) instanceof Callable
-}
 
 query predicate consistencyOverview(string msg, int n) { none() }
 

csharp/ql/examples/snippets/integer_literal.ql

@@ -9,5 +9,5 @@
 import csharp
 
 from IntegerLiteral literal
-where literal.getValue().toInt() = 0
+where literal.getIntValue() = 0
 select literal

csharp/ql/lib/CHANGELOG.md

@@ -1,3 +1,9 @@
+## 5.5.0
+
+### Deprecated APIs
+
+* The predicates `get[L|R]Value` in the class `Assignment` have been deprecated. Use `get[Left|Right]Operand` instead.
+
 ## 5.4.12
 
 ### Minor Analysis Improvements

csharp/ql/lib/Linq/Helpers.qll

@@ -77,7 +77,7 @@ predicate missedAllOpportunity(ForeachStmtGenericEnumerable fes) {
     // The then case of the if assigns false to something and breaks out of the loop.
     exists(Assignment a, BoolLiteral bl |
       a = is.getThen().getAChild*() and
-      bl = a.getRValue() and
+      bl = a.getRightOperand() and
       bl.toString() = "false"
     ) and
     is.getThen().getAChild*() instanceof BreakStmt
@@ -121,15 +121,17 @@ predicate missedOfTypeOpportunity(ForeachStmtEnumerable fes, LocalVariableDeclSt
 /**
  * Holds if `foreach` statement `fes` can be converted to a `.Select()` call.
  * That is, the loop variable is accessed only in the first statement of the
- * block, the access is not a cast, and the first statement is a
- * local variable declaration statement `s`.
+ * block, the access is not a cast, the first statement is a
+ * local variable declaration statement `s`, and the initializer does not
+ * contain an `await` expression (since `Select` does not support async lambdas).
  */
 predicate missedSelectOpportunity(ForeachStmtGenericEnumerable fes, LocalVariableDeclStmt s) {
   s = firstStmt(fes) and
   forex(VariableAccess va | va = fes.getVariable().getAnAccess() |
     va = s.getAVariableDeclExpr().getAChildExpr*()
   ) and
-  not s.getAVariableDeclExpr().getInitializer() instanceof Cast
+  not s.getAVariableDeclExpr().getInitializer() instanceof Cast and
+  not s.getAVariableDeclExpr().getInitializer().getAChildExpr*() instanceof AwaitExpr
 }
 
 /**

csharp/ql/lib/change-notes/2026-03-20-data-extensions-barriers.md

@@ -0,0 +1,4 @@
+---
+category: feature
+---
+* Data flow barriers and barrier guards can now be added using data extensions. For more information see [Customizing library models for C#](https://codeql.github.com/docs/codeql-language-guides/customizing-library-models-for-csharp/).

csharp/ql/lib/change-notes/2026-04-01-asp-remote-sources.md

@@ -0,0 +1,4 @@
+---
+category: minorAnalysis
+---
+* Expanded ASP and ASP.NET remote source modeling to cover additional sources, including fields of tainted parameters as well as properties and fields that become tainted transitively.

csharp/ql/lib/change-notes/2026-04-13-cfg.md

@@ -0,0 +1,20 @@
+---
+category: breaking
+---
+* The C# control flow graph (CFG) implementation has been completely
+  rewritten. The CFG now includes additional nodes to more accurately represent
+  certain constructs. This also means that any existing code that implicitly
+  relies on very specific details about the CFG may need to be updated.
+  The CFG no longer uses splitting, which means that AST nodes now have a unique
+  CFG node representation.
+  Additionally, the following breaking changes have been made:
+  - `ControlFlow::Node` has been renamed to `ControlFlowNode`.
+  - `ControlFlow::Nodes` has been renamed to `ControlFlowNodes`.
+  - `BasicBlock.getCallable` has been renamed to `BasicBlock.getEnclosingCallable`.
+  - `BasicBlocks.qll` has been deleted.
+  - `ControlFlowNode.getAstNode` has changed its meaning. The AST-to-CFG
+    mapping remains one-to-many, but now for a different reason. It used to be
+    because of splitting, but now it's because of additional "helper" CFG
+    nodes. To get the (now canonical) CFG node for a given AST node, use
+    `ControlFlowNode.asExpr()` or `ControlFlowNode.asStmt()` or
+    `ControlFlowElement.getControlFlowNode()` instead.

csharp/ql/lib/change-notes/released/5.5.0.md

@@ -0,0 +1,5 @@
+## 5.5.0
+
+### Deprecated APIs
+
+* The predicates `get[L|R]Value` in the class `Assignment` have been deprecated. Use `get[Left|Right]Operand` instead.

csharp/ql/lib/codeql-pack.release.yml

@@ -1,2 +1,2 @@
 ---
-lastReleaseVersion: 5.4.12
+lastReleaseVersion: 5.5.0

csharp/ql/lib/definitions.qll

@@ -96,7 +96,7 @@ private class MethodUse extends Use, QualifiableExpr {
 private class AccessUse extends Access, Use {
   AccessUse() {
     not this.getTarget().(Parameter).getCallable() instanceof Accessor and
-    not this = any(LocalVariableDeclAndInitExpr d).getLValue() and
+    not this = any(LocalVariableDeclAndInitExpr d).getLeftOperand() and
     not this.isImplicit() and
     not this instanceof MethodAccess and // handled by `MethodUse`
     not this instanceof TypeAccess and // handled by `TypeMentionUse`

csharp/ql/lib/experimental/code/csharp/Cryptography/NonCryptographicHashes.qll

@@ -30,7 +30,7 @@ predicate maybeUsedInFnvFunction(Variable v, Operation xor, Operation mul, LoopS
     e2.getAChild*() = v.getAnAccess() and
     e1 = xor.getAnOperand() and
     e2 = mul.getAnOperand() and
-    xor.getAControlFlowNode().getASuccessor*() = mul.getAControlFlowNode() and
+    xor.getControlFlowNode().getASuccessor*() = mul.getControlFlowNode() and
     (xor instanceof AssignXorExpr or xor instanceof BitwiseXorExpr) and
     (mul instanceof AssignMulExpr or mul instanceof MulExpr)
   ) and
@@ -55,11 +55,11 @@ private predicate maybeUsedInElfHashFunction(Variable v, Operation xor, Operatio
     v = addAssign.getTargetVariable() and
     addAssign.getAChild*() = add and
     (xor instanceof BitwiseXorExpr or xor instanceof AssignXorExpr) and
-    addAssign.getAControlFlowNode().getASuccessor*() = xor.getAControlFlowNode() and
+    addAssign.getControlFlowNode().getASuccessor*() = xor.getControlFlowNode() and
     xorAssign.getAChild*() = xor and
     v = xorAssign.getTargetVariable() and
     (notOp instanceof UnaryBitwiseOperation or notOp instanceof AssignBitwiseOperation) and
-    xor.getAControlFlowNode().getASuccessor*() = notOp.getAControlFlowNode() and
+    xor.getControlFlowNode().getASuccessor*() = notOp.getControlFlowNode() and
     notAssign.getAChild*() = notOp and
     v = notAssign.getTargetVariable() and
     loop.getAChild*() = add.getEnclosingStmt() and

csharp/ql/lib/printCfg.ql

@@ -7,7 +7,7 @@
  * @tags ide-contextual-queries/print-cfg
  */
 
-private import semmle.code.csharp.controlflow.internal.ControlFlowGraphImpl
+import csharp
 
 external string selectedSourceFile();
 
@@ -21,7 +21,7 @@ external int selectedSourceColumn();
 
 private predicate selectedSourceColumnAlias = selectedSourceColumn/0;
 
-module ViewCfgQueryInput implements ViewCfgQueryInputSig<File> {
+module ViewCfgQueryInput implements ControlFlow::ViewCfgQueryInputSig<File> {
   predicate selectedSourceFile = selectedSourceFileAlias/0;
 
   predicate selectedSourceLine = selectedSourceLineAlias/0;
@@ -29,7 +29,7 @@ module ViewCfgQueryInput implements ViewCfgQueryInputSig<File> {
   predicate selectedSourceColumn = selectedSourceColumnAlias/0;
 
   predicate cfgScopeSpan(
-    CfgScope scope, File file, int startLine, int startColumn, int endLine, int endColumn
+    Callable scope, File file, int startLine, int startColumn, int endLine, int endColumn
   ) {
     file = scope.getFile() and
     scope.getLocation().getStartLine() = startLine and
@@ -40,11 +40,20 @@ module ViewCfgQueryInput implements ViewCfgQueryInputSig<File> {
     |
       loc = scope.(Callable).getBody().getLocation()
       or
-      loc = scope.(Field).getInitializer().getLocation()
+      loc = any(AssignExpr init | scope.(ObjectInitMethod).initializes(init)).getLocation()
       or
-      loc = scope.(Property).getInitializer().getLocation()
+      exists(AssignableMember a, Constructor ctor |
+        scope = ctor and
+        ctor.isStatic() and
+        a.isStatic() and
+        a.getDeclaringType() = ctor.getDeclaringType()
+      |
+        loc = a.(Field).getInitializer().getLocation()
+        or
+        loc = a.(Property).getInitializer().getLocation()
+      )
     )
   }
 }
 
-import ViewCfgQuery<File, ViewCfgQueryInput>
+import ControlFlow::ViewCfgQuery<File, ViewCfgQueryInput>

csharp/ql/lib/qlpack.yml

@@ -1,5 +1,5 @@
 name: codeql/csharp-all
-version: 5.4.12
+version: 5.5.1-dev
 groups: csharp
 dbscheme: semmlecode.csharp.dbscheme
 extractor: csharp

csharp/ql/lib/semmle/code/csharp/Assignable.qll

@@ -85,8 +85,8 @@ class AssignableRead extends AssignableAccess {
   }
 
   pragma[noinline]
-  private ControlFlow::Node getAnAdjacentReadSameVar() {
-    SsaImpl::adjacentReadPairSameVar(_, this.getAControlFlowNode(), result)
+  private ControlFlowNode getAnAdjacentReadSameVar() {
+    SsaImpl::adjacentReadPairSameVar(_, this.getControlFlowNode(), result)
   }
 
   /**
@@ -114,11 +114,7 @@ class AssignableRead extends AssignableAccess {
    * - The read of `this.Field` on line 11 is next to the read on line 10.
    */
   pragma[nomagic]
-  AssignableRead getANextRead() {
-    forex(ControlFlow::Node cfn | cfn = result.getAControlFlowNode() |
-      cfn = this.getAnAdjacentReadSameVar()
-    )
-  }
+  AssignableRead getANextRead() { result.getControlFlowNode() = this.getAnAdjacentReadSameVar() }
 }
 
 /**
@@ -235,7 +231,7 @@ private class RefArg extends AssignableAccess {
 module AssignableInternal {
   private predicate tupleAssignmentDefinition(AssignExpr ae, Expr leaf) {
     exists(TupleExpr te |
-      ae.getLValue() = te and
+      ae.getLeftOperand() = te and
       te.getAnArgument+() = leaf and
       // `leaf` is either an assignable access or a local variable declaration
       not leaf instanceof TupleExpr
@@ -249,8 +245,8 @@ module AssignableInternal {
    */
   private predicate tupleAssignmentPair(AssignExpr ae, Expr left, Expr right) {
     tupleAssignmentDefinition(ae, _) and
-    left = ae.getLValue() and
-    right = ae.getRValue()
+    left = ae.getLeftOperand() and
+    right = ae.getRightOperand()
     or
     exists(TupleExpr l, TupleExpr r, int i | tupleAssignmentPair(ae, l, r) |
       left = l.getArgument(i) and
@@ -291,7 +287,7 @@ module AssignableInternal {
     cached
     newtype TAssignableDefinition =
       TAssignmentDefinition(Assignment a) {
-        not a.getLValue() instanceof TupleExpr and
+        not a.getLeftOperand() instanceof TupleExpr and
         not a instanceof AssignCallOperation and
         not a instanceof AssignCoalesceExpr
       } or
@@ -358,7 +354,7 @@ module AssignableInternal {
     // Not defined by dispatch in order to avoid too conservative negative recursion error
     cached
     AssignableAccess getTargetAccess(AssignableDefinition def) {
-      def = TAssignmentDefinition(any(Assignment a | a.getLValue() = result))
+      def = TAssignmentDefinition(any(Assignment a | a.getLeftOperand() = result))
       or
       def = TTupleAssignmentDefinition(_, result)
       or
@@ -381,8 +377,8 @@ module AssignableInternal {
         tupleAssignmentPair(ae, ac, result)
       )
       or
-      exists(Assignment ass | ac = ass.getLValue() |
-        result = ass.getRValue() and
+      exists(Assignment ass | ac = ass.getLeftOperand() |
+        result = ass.getRightOperand() and
         not ass instanceof AssignOperation
       )
       or
@@ -410,7 +406,7 @@ private import AssignableInternal
  */
 class AssignableDefinition extends TAssignableDefinition {
   /**
-   * DEPRECATED: Use `this.getExpr().getAControlFlowNode()` instead.
+   * DEPRECATED: Use `this.getExpr().getControlFlowNode()` instead.
    *
    * Gets a control flow node that updates the targeted assignable when
    * reached.
@@ -419,9 +415,7 @@ class AssignableDefinition extends TAssignableDefinition {
    * the definitions of `x` and `y` in `M(out x, out y)` and `(x, y) = (0, 1)`
    * relate to the same call to `M` and assignment node, respectively.
    */
-  deprecated ControlFlow::Node getAControlFlowNode() {
-    result = this.getExpr().getAControlFlowNode()
-  }
+  deprecated ControlFlowNode getAControlFlowNode() { result = this.getExpr().getControlFlowNode() }
 
   /**
    * Gets the underlying expression that updates the targeted assignable when
@@ -494,7 +488,7 @@ class AssignableDefinition extends TAssignableDefinition {
    */
   pragma[nomagic]
   AssignableRead getAFirstRead() {
-    forex(ControlFlow::Node cfn | cfn = result.getAControlFlowNode() |
+    exists(ControlFlowNode cfn | cfn = result.getControlFlowNode() |
       exists(Ssa::ExplicitDefinition def | result = def.getAFirstReadAtNode(cfn) |
         this = def.getADefinition()
       )
@@ -527,7 +521,7 @@ module AssignableDefinitions {
     Assignment getAssignment() { result = a }
 
     override Expr getSource() {
-      result = a.getRValue() and
+      result = a.getRightOperand() and
       not a instanceof AddOrRemoveEventExpr
     }
 
@@ -572,11 +566,9 @@ module AssignableDefinitions {
   }
 
   /** Holds if a node in basic block `bb` assigns to `ref` parameter `p` via definition `def`. */
-  private predicate basicBlockRefParamDef(
-    ControlFlow::BasicBlock bb, Parameter p, AssignableDefinition def
-  ) {
+  private predicate basicBlockRefParamDef(BasicBlock bb, Parameter p, AssignableDefinition def) {
     def = any(RefArg arg).getAnAnalyzableRefDef(p) and
-    bb.getANode() = def.getExpr().getAControlFlowNode()
+    bb.getANode() = def.getExpr().getControlFlowNode()
   }
 
   /**
@@ -585,7 +577,7 @@ module AssignableDefinitions {
    * any assignments to `p`.
    */
   pragma[nomagic]
-  private predicate parameterReachesWithoutDef(Parameter p, ControlFlow::BasicBlock bb) {
+  private predicate parameterReachesWithoutDef(Parameter p, BasicBlock bb) {
     forall(AssignableDefinition def | basicBlockRefParamDef(bb, p, def) |
       isUncertainRefCall(def.getTargetAccess())
     ) and
@@ -593,9 +585,7 @@ module AssignableDefinitions {
       any(RefArg arg).isAnalyzable(p) and
       p.getCallable().getEntryPoint() = bb.getFirstNode()
       or
-      exists(ControlFlow::BasicBlock mid | parameterReachesWithoutDef(p, mid) |
-        bb = mid.getASuccessor()
-      )
+      exists(BasicBlock mid | parameterReachesWithoutDef(p, mid) | bb = mid.getASuccessor())
     )
   }
 
@@ -607,7 +597,7 @@ module AssignableDefinitions {
   cached
   predicate isUncertainRefCall(RefArg arg) {
     arg.isPotentialAssignment() and
-    exists(ControlFlow::BasicBlock bb, Parameter p | arg.isAnalyzable(p) |
+    exists(BasicBlock bb, Parameter p | arg.isAnalyzable(p) |
       parameterReachesWithoutDef(p, bb) and
       bb.getLastNode() = p.getCallable().getExitPoint()
     )
@@ -688,7 +678,7 @@ module AssignableDefinitions {
     /** Gets the underlying parameter. */
     Parameter getParameter() { result = p }
 
-    deprecated override ControlFlow::Node getAControlFlowNode() {
+    deprecated override ControlFlowNode getAControlFlowNode() {
       result = p.getCallable().getEntryPoint()
     }
 

csharp/ql/lib/semmle/code/csharp/Caching.qll

@@ -7,23 +7,6 @@ private import csharp
  * in the same stage across different files.
  */
 module Stages {
-  cached
-  module ControlFlowStage {
-    private import semmle.code.csharp.controlflow.internal.Splitting
-
-    cached
-    predicate forceCachingInSameStage() { any() }
-
-    cached
-    private predicate forceCachingInSameStageRev() {
-      exists(Split s)
-      or
-      exists(ControlFlow::Node n)
-      or
-      forceCachingInSameStageRev()
-    }
-  }
-
   cached
   module GuardsStage {
     private import semmle.code.csharp.controlflow.Guards

csharp/ql/lib/semmle/code/csharp/Callable.qll

@@ -22,7 +22,7 @@ private import TypeRef
  * an anonymous function (`AnonymousFunctionExpr`), or a local function
  * (`LocalFunction`).
  */
-class Callable extends Parameterizable, ExprOrStmtParent, @callable {
+class Callable extends Parameterizable, ControlFlowElementOrCallable, @callable {
   /** Gets the return type of this callable. */
   Type getReturnType() { none() }
 
@@ -157,10 +157,10 @@ class Callable extends Parameterizable, ExprOrStmtParent, @callable {
   final predicate hasExpressionBody() { exists(this.getExpressionBody()) }
 
   /** Gets the entry point in the control graph for this callable. */
-  ControlFlow::Nodes::EntryNode getEntryPoint() { result.getCallable() = this }
+  ControlFlow::EntryNode getEntryPoint() { result.getEnclosingCallable() = this }
 
   /** Gets the exit point in the control graph for this callable. */
-  ControlFlow::Nodes::ExitNode getExitPoint() { result.getCallable() = this }
+  ControlFlow::ExitNode getExitPoint() { result.getEnclosingCallable() = this }
 
   /**
    * Gets the enclosing callable of this callable, if any.

csharp/ql/lib/semmle/code/csharp/Conversion.qll

@@ -232,14 +232,9 @@ private module Identity {
    */
   pragma[nomagic]
   private predicate convTypeArguments(Type fromTypeArgument, Type toTypeArgument, int i) {
-    exists(int j |
-      fromTypeArgument = getTypeArgumentRanked(_, _, i) and
-      toTypeArgument = getTypeArgumentRanked(_, _, j) and
-      i <= j and
-      j <= i
-    |
-      convIdentity(fromTypeArgument, toTypeArgument)
-    )
+    fromTypeArgument = getTypeArgumentRanked(_, _, pragma[only_bind_into](i)) and
+    toTypeArgument = getTypeArgumentRanked(_, _, pragma[only_bind_into](i)) and
+    convIdentity(fromTypeArgument, toTypeArgument)
   }
 
   pragma[nomagic]
@@ -718,7 +713,7 @@ private class SignedIntegralConstantExpr extends Expr {
 }
 
 private predicate convConstantIntExpr(SignedIntegralConstantExpr e, SimpleType toType) {
-  exists(int n | n = e.getValue().toInt() |
+  exists(int n | n = e.getIntValue() |
     toType = any(SByteType t | n in [t.minValue() .. t.maxValue()])
     or
     toType = any(ByteType t | n in [t.minValue() .. t.maxValue()])
@@ -735,7 +730,7 @@ private predicate convConstantIntExpr(SignedIntegralConstantExpr e, SimpleType t
 
 private predicate convConstantLongExpr(SignedIntegralConstantExpr e) {
   e.getType() instanceof LongType and
-  e.getValue().toInt() >= 0
+  e.getIntValue() >= 0
 }
 
 /** 6.1.10: Implicit reference conversions involving type parameters. */
@@ -929,19 +924,16 @@ private module Variance {
   private predicate convTypeArguments(
     TypeArgument fromTypeArgument, TypeArgument toTypeArgument, int i, TVariance v
   ) {
-    exists(int j |
-      fromTypeArgument = getTypeArgumentRanked(_, _, i, _) and
-      toTypeArgument = getTypeArgumentRanked(_, _, j, _) and
-      i <= j and
-      j <= i
-    |
+    fromTypeArgument = getTypeArgumentRanked(_, _, pragma[only_bind_into](i), _) and
+    toTypeArgument = getTypeArgumentRanked(_, _, pragma[only_bind_into](i), _) and
+    (
       convIdentity(fromTypeArgument, toTypeArgument) and
       v = TNone()
       or
-      convRefTypeTypeArgumentOut(fromTypeArgument, toTypeArgument, j) and
+      convRefTypeTypeArgumentOut(fromTypeArgument, toTypeArgument, i) and
       v = TOut()
       or
-      convRefTypeTypeArgumentIn(toTypeArgument, fromTypeArgument, j) and
+      convRefTypeTypeArgumentIn(toTypeArgument, fromTypeArgument, i) and
       v = TIn()
     )
   }

csharp/ql/lib/semmle/code/csharp/ExprOrStmtParent.qll

@@ -129,13 +129,6 @@ private module Cached {
     result = parent.getAChildStmt()
   }
 
-  pragma[inline]
-  private ControlFlowElement enclosingStart(ControlFlowElement cfe) {
-    result = cfe
-    or
-    getAChild(result).(AnonymousFunctionExpr) = cfe
-  }
-
   private predicate parent(ControlFlowElement child, ExprOrStmtParent parent) {
     child = getAChild(parent) and
     not child = getBody(_)
@@ -145,7 +138,7 @@ private module Cached {
   cached
   predicate enclosingBody(ControlFlowElement cfe, ControlFlowElement body) {
     body = getBody(_) and
-    parent*(enclosingStart(cfe), body)
+    parent*(cfe, body)
   }
 
   /** Holds if the enclosing callable of `cfe` is `c`. */
@@ -153,7 +146,7 @@ private module Cached {
   predicate enclosingCallable(ControlFlowElement cfe, Callable c) {
     enclosingBody(cfe, getBody(c))
     or
-    parent*(enclosingStart(cfe), c.(Constructor).getInitializer())
+    parent*(cfe, c.(Constructor).getInitializer())
     or
     parent*(cfe, c.(Constructor).getObjectInitializerCall())
     or

csharp/ql/lib/semmle/code/csharp/PrintAst.qll

@@ -343,10 +343,10 @@ final class AssignmentNode extends ControlFlowElementNode {
     result.(TypeMentionNode).getTarget() = controlFlowElement
     or
     childIndex = 0 and
-    result.(ElementNode).getElement() = assignment.getLValue()
+    result.(ElementNode).getElement() = assignment.getLeftOperand()
     or
     childIndex = 1 and
-    result.(ElementNode).getElement() = assignment.getRValue()
+    result.(ElementNode).getElement() = assignment.getRightOperand()
   }
 }
 

csharp/ql/lib/semmle/code/csharp/Property.qll

@@ -535,8 +535,8 @@ class Setter extends Accessor, @setter {
     exists(AssignExpr assign |
       this.getStatementBody().getNumberOfStmts() = 1 and
       assign.getParent() = this.getStatementBody().getAChild() and
-      assign.getLValue() = result.getAnAccess() and
-      assign.getRValue() = accessToValue()
+      assign.getLeftOperand() = result.getAnAccess() and
+      assign.getRightOperand() = accessToValue()
     )
   }
 

csharp/ql/lib/semmle/code/csharp/commons/Collections.qll

@@ -54,21 +54,44 @@ private string genericCollectionTypeName() {
     ]
 }
 
-/** A collection type. */
-class CollectionType extends RefType {
-  CollectionType() {
-    exists(RefType base | base = this.getABaseType*() |
-      base.hasFullyQualifiedName(collectionNamespaceName(), collectionTypeName())
-      or
-      base.(ConstructedType)
-          .getUnboundGeneric()
-          .hasFullyQualifiedName(genericCollectionNamespaceName(), genericCollectionTypeName())
-    )
-    or
-    this instanceof ArrayType
+/** A collection type */
+abstract private class CollectionTypeImpl extends RefType {
+  /**
+   * Gets the element type of this collection, for example `int` in `List<int>`.
+   */
+  abstract Type getElementType();
+}
+
+private class GenericCollectionType extends CollectionTypeImpl {
+  private ConstructedType base;
+
+  GenericCollectionType() {
+    base = this.getABaseType*() and
+    base.getUnboundGeneric()
+        .hasFullyQualifiedName(genericCollectionNamespaceName(), genericCollectionTypeName())
+  }
+
+  override Type getElementType() {
+    result = base.getTypeArgument(0) and base.getNumberOfTypeArguments() = 1
   }
 }
 
+private class NonGenericCollectionType extends CollectionTypeImpl {
+  NonGenericCollectionType() {
+    exists(RefType base | base = this.getABaseType*() |
+      base.hasFullyQualifiedName(collectionNamespaceName(), collectionTypeName())
+    )
+  }
+
+  override Type getElementType() { none() }
+}
+
+private class ArrayCollectionType extends CollectionTypeImpl instanceof ArrayType {
+  override Type getElementType() { result = ArrayType.super.getElementType() }
+}
+
+final class CollectionType = CollectionTypeImpl;
+
 /**
  * A collection type that can be used as a `params` parameter type.
  */

csharp/ql/lib/semmle/code/csharp/commons/ComparisonTest.qll

@@ -161,7 +161,7 @@ private newtype TComparisonTest =
       compare.getComparisonKind().isCompare() and
       outerKind = outer.getComparisonKind() and
       outer.getAnArgument() = compare.getExpr() and
-      i = outer.getAnArgument().getValue().toInt()
+      i = outer.getAnArgument().getIntValue()
     |
       outerKind.isEquality() and
       (

csharp/ql/lib/semmle/code/csharp/commons/Constants.qll

@@ -32,13 +32,13 @@ private module ConstantComparisonOperation {
 
   private int maxValue(Expr expr) {
     if convertedType(expr) instanceof IntegralType and exists(expr.getValue())
-    then result = expr.getValue().toInt()
+    then result = expr.getIntValue()
     else result = convertedType(expr).maxValue()
   }
 
   private int minValue(Expr expr) {
     if convertedType(expr) instanceof IntegralType and exists(expr.getValue())
-    then result = expr.getValue().toInt()
+    then result = expr.getIntValue()
     else result = convertedType(expr).minValue()
   }
 

csharp/ql/lib/semmle/code/csharp/commons/Strings.qll

@@ -29,7 +29,7 @@ class ImplicitToStringExpr extends Expr {
       m = p.getCallable()
     |
       m = any(SystemTextStringBuilderClass c).getAMethod() and
-      m.getName().regexpMatch("Append(Line)?") and
+      m.getName() = "Append" and
       not p.getType() instanceof ArrayType
       or
       p instanceof StringFormatItemParameter and

csharp/ql/lib/semmle/code/csharp/controlflow/BasicBlocks.qll

@@ -1,356 +0,0 @@
-/**
- * Provides classes representing basic blocks.
- */
-
-import csharp
-private import ControlFlow
-private import semmle.code.csharp.controlflow.internal.ControlFlowGraphImpl as CfgImpl
-private import CfgImpl::BasicBlocks as BasicBlocksImpl
-private import codeql.controlflow.BasicBlock as BB
-
-/**
- * A basic block, that is, a maximal straight-line sequence of control flow nodes
- * without branches or joins.
- */
-final class BasicBlock extends BasicBlocksImpl::BasicBlock {
-  /** Gets an immediate successor of this basic block of a given type, if any. */
-  BasicBlock getASuccessor(ControlFlow::SuccessorType t) { result = super.getASuccessor(t) }
-
-  /** DEPRECATED: Use `getASuccessor` instead. */
-  deprecated BasicBlock getASuccessorByType(ControlFlow::SuccessorType t) {
-    result = this.getASuccessor(t)
-  }
-
-  /** Gets an immediate predecessor of this basic block of a given type, if any. */
-  BasicBlock getAPredecessorByType(ControlFlow::SuccessorType t) {
-    result = this.getAPredecessor(t)
-  }
-
-  /**
-   * Gets an immediate `true` successor, if any.
-   *
-   * An immediate `true` successor is a successor that is reached when
-   * the condition that ends this basic block evaluates to `true`.
-   *
-   * Example:
-   *
-   * ```csharp
-   * if (x < 0)
-   *   x = -x;
-   * ```
-   *
-   * The basic block on line 2 is an immediate `true` successor of the
-   * basic block on line 1.
-   */
-  BasicBlock getATrueSuccessor() { result.getFirstNode() = this.getLastNode().getATrueSuccessor() }
-
-  /**
-   * Gets an immediate `false` successor, if any.
-   *
-   * An immediate `false` successor is a successor that is reached when
-   * the condition that ends this basic block evaluates to `false`.
-   *
-   * Example:
-   *
-   * ```csharp
-   * if (!(x >= 0))
-   *   x = -x;
-   * ```
-   *
-   * The basic block on line 2 is an immediate `false` successor of the
-   * basic block on line 1.
-   */
-  BasicBlock getAFalseSuccessor() {
-    result.getFirstNode() = this.getLastNode().getAFalseSuccessor()
-  }
-
-  BasicBlock getASuccessor() { result = super.getASuccessor() }
-
-  /** Gets the control flow node at a specific (zero-indexed) position in this basic block. */
-  ControlFlow::Node getNode(int pos) { result = super.getNode(pos) }
-
-  /** Gets a control flow node in this basic block. */
-  ControlFlow::Node getANode() { result = super.getANode() }
-
-  /** Gets the first control flow node in this basic block. */
-  ControlFlow::Node getFirstNode() { result = super.getFirstNode() }
-
-  /** Gets the last control flow node in this basic block. */
-  ControlFlow::Node getLastNode() { result = super.getLastNode() }
-
-  /** Gets the callable that this basic block belongs to. */
-  final Callable getCallable() { result = this.getFirstNode().getEnclosingCallable() }
-
-  /**
-   * Holds if this basic block immediately dominates basic block `bb`.
-   *
-   * That is, this basic block is the unique basic block satisfying:
-   * 1. This basic block strictly dominates `bb`
-   * 2. There exists no other basic block that is strictly dominated by this
-   *    basic block and which strictly dominates `bb`.
-   *
-   * All basic blocks, except entry basic blocks, have a unique immediate
-   * dominator.
-   *
-   * Example:
-   *
-   * ```csharp
-   * int M(string s) {
-   *   if (s == null)
-   *     throw new ArgumentNullException(nameof(s));
-   *   return s.Length;
-   * }
-   * ```
-   *
-   * The basic block starting on line 2 strictly dominates the
-   * basic block on line 4 (all paths from the entry point of `M`
-   * to `return s.Length;` must go through the null check).
-   */
-  predicate immediatelyDominates(BasicBlock bb) { super.immediatelyDominates(bb) }
-
-  /**
-   * Holds if this basic block strictly dominates basic block `bb`.
-   *
-   * That is, all paths reaching basic block `bb` from some entry point
-   * basic block must go through this basic block (which must be different
-   * from `bb`).
-   *
-   * Example:
-   *
-   * ```csharp
-   * int M(string s) {
-   *   if (s == null)
-   *     throw new ArgumentNullException(nameof(s));
-   *   return s.Length;
-   * }
-   * ```
-   *
-   * The basic block starting on line 2 strictly dominates the
-   * basic block on line 4 (all paths from the entry point of `M`
-   * to `return s.Length;` must go through the null check).
-   */
-  predicate strictlyDominates(BasicBlock bb) { super.strictlyDominates(bb) }
-
-  /**
-   * Holds if this basic block dominates basic block `bb`.
-   *
-   * That is, all paths reaching basic block `bb` from some entry point
-   * basic block must go through this basic block.
-   *
-   * Example:
-   *
-   * ```csharp
-   * int M(string s) {
-   *   if (s == null)
-   *     throw new ArgumentNullException(nameof(s));
-   *   return s.Length;
-   * }
-   * ```
-   *
-   * The basic block starting on line 2 dominates the basic
-   * block on line 4 (all paths from the entry point of `M` to
-   * `return s.Length;` must go through the null check).
-   *
-   * This predicate is *reflexive*, so for example `if (s == null)` dominates
-   * itself.
-   */
-  predicate dominates(BasicBlock bb) {
-    bb = this or
-    this.strictlyDominates(bb)
-  }
-
-  /**
-   * Holds if `df` is in the dominance frontier of this basic block.
-   * That is, this basic block dominates a predecessor of `df`, but
-   * does not dominate `df` itself.
-   *
-   * Example:
-   *
-   * ```csharp
-   * if (x < 0) {
-   *   x = -x;
-   *   if (x > 10)
-   *     x--;
-   * }
-   * Console.Write(x);
-   * ```
-   *
-   * The basic block on line 6 is in the dominance frontier
-   * of the basic block starting on line 2 because that block
-   * dominates the basic block on line 4, which is a predecessor of
-   * `Console.Write(x);`. Also, the basic block starting on line 2
-   * does not dominate the basic block on line 6.
-   */
-  predicate inDominanceFrontier(BasicBlock df) { super.inDominanceFrontier(df) }
-
-  /**
-   * Gets the basic block that immediately dominates this basic block, if any.
-   *
-   * That is, the result is the unique basic block satisfying:
-   * 1. The result strictly dominates this basic block.
-   * 2. There exists no other basic block that is strictly dominated by the
-   *    result and which strictly dominates this basic block.
-   *
-   * All basic blocks, except entry basic blocks, have a unique immediate
-   * dominator.
-   *
-   * Example:
-   *
-   * ```csharp
-   * int M(string s) {
-   *   if (s == null)
-   *     throw new ArgumentNullException(nameof(s));
-   *   return s.Length;
-   * }
-   * ```
-   *
-   * The basic block starting on line 2 is an immediate dominator of
-   * the basic block online 4 (all paths from the entry point of `M`
-   * to `return s.Length;` must go through the null check.
-   */
-  BasicBlock getImmediateDominator() { result = super.getImmediateDominator() }
-
-  /**
-   * Holds if the edge with successor type `s` out of this basic block is a
-   * dominating edge for `dominated`.
-   *
-   * That is, all paths reaching `dominated` from the entry point basic
-   * block must go through the `s` edge out of this basic block.
-   *
-   * Edge dominance is similar to node dominance except it concerns edges
-   * instead of nodes: A basic block is dominated by a _basic block_ `bb` if it
-   * can only be reached through `bb` and dominated by an _edge_ `e` if it can
-   * only be reached through `e`.
-   *
-   * Note that where all basic blocks (except the entry basic block) are
-   * strictly dominated by at least one basic block, a basic block may not be
-   * dominated by any edge. If an edge dominates a basic block `bb`, then
-   * both endpoints of the edge dominates `bb`. The converse is not the case,
-   * as there may be multiple paths between the endpoints with none of them
-   * dominating.
-   */
-  predicate edgeDominates(BasicBlock dominated, ControlFlow::SuccessorType s) {
-    super.edgeDominates(dominated, s)
-  }
-
-  /**
-   * Holds if this basic block strictly post-dominates basic block `bb`.
-   *
-   * That is, all paths reaching a normal exit point basic block from basic
-   * block `bb` must go through this basic block (which must be different
-   * from `bb`).
-   *
-   * Example:
-   *
-   * ```csharp
-   * int M(string s) {
-   *   try {
-   *     return s.Length;
-   *   }
-   *   finally {
-   *     Console.WriteLine("M");
-   *   }
-   * }
-   * ```
-   *
-   * The basic block on line 6 strictly post-dominates the basic block on
-   * line 3 (all paths to the exit point of `M` from `return s.Length;`
-   * must go through the `WriteLine` call).
-   */
-  predicate strictlyPostDominates(BasicBlock bb) { super.strictlyPostDominates(bb) }
-
-  /**
-   * Holds if this basic block post-dominates basic block `bb`.
-   *
-   * That is, all paths reaching a normal exit point basic block from basic
-   * block `bb` must go through this basic block.
-   *
-   * Example:
-   *
-   * ```csharp
-   * int M(string s) {
-   *   try {
-   *     return s.Length;
-   *   }
-   *   finally {
-   *     Console.WriteLine("M");
-   *   }
-   * }
-   * ```
-   *
-   * The basic block on line 6 post-dominates the basic block on line 3
-   * (all paths to the exit point of `M` from `return s.Length;` must go
-   * through the `WriteLine` call).
-   *
-   * This predicate is *reflexive*, so for example `Console.WriteLine("M");`
-   * post-dominates itself.
-   */
-  predicate postDominates(BasicBlock bb) { super.postDominates(bb) }
-
-  /**
-   * Holds if this basic block is in a loop in the control flow graph. This
-   * includes loops created by `goto` statements. This predicate may not hold
-   * even if this basic block is syntactically inside a `while` loop if the
-   * necessary back edges are unreachable.
-   */
-  predicate inLoop() { this.getASuccessor+() = this }
-}
-
-/**
- * An entry basic block, that is, a basic block whose first node is
- * an entry node.
- */
-final class EntryBasicBlock extends BasicBlock, BasicBlocksImpl::EntryBasicBlock { }
-
-/**
- * An annotated exit basic block, that is, a basic block that contains an
- * annotated exit node.
- */
-final class AnnotatedExitBasicBlock extends BasicBlock, BasicBlocksImpl::AnnotatedExitBasicBlock { }
-
-/**
- * An exit basic block, that is, a basic block whose last node is
- * an exit node.
- */
-final class ExitBasicBlock extends BasicBlock, BasicBlocksImpl::ExitBasicBlock { }
-
-/** A basic block with more than one predecessor. */
-final class JoinBlock extends BasicBlock, BasicBlocksImpl::JoinBasicBlock {
-  JoinBlockPredecessor getJoinBlockPredecessor(int i) { result = super.getJoinBlockPredecessor(i) }
-}
-
-/** A basic block that is an immediate predecessor of a join block. */
-final class JoinBlockPredecessor extends BasicBlock, BasicBlocksImpl::JoinPredecessorBasicBlock { }
-
-/**
- * A basic block that terminates in a condition, splitting the subsequent
- * control flow.
- */
-final class ConditionBlock extends BasicBlock, BasicBlocksImpl::ConditionBasicBlock {
-  /** DEPRECATED: Use `edgeDominates` instead. */
-  deprecated predicate immediatelyControls(BasicBlock succ, ConditionalSuccessor s) {
-    this.getASuccessor(s) = succ and
-    BasicBlocksImpl::dominatingEdge(this, succ)
-  }
-
-  /** DEPRECATED: Use `edgeDominates` instead. */
-  deprecated predicate controls(BasicBlock controlled, ConditionalSuccessor s) {
-    super.edgeDominates(controlled, s)
-  }
-}
-
-private class BasicBlockAlias = BasicBlock;
-
-private class EntryBasicBlockAlias = EntryBasicBlock;
-
-module Cfg implements BB::CfgSig<Location> {
-  class ControlFlowNode = ControlFlow::Node;
-
-  class BasicBlock = BasicBlockAlias;
-
-  class EntryBasicBlock = EntryBasicBlockAlias;
-
-  predicate dominatingEdge(BasicBlock bb1, BasicBlock bb2) {
-    BasicBlocksImpl::dominatingEdge(bb1, bb2)
-  }
-}

csharp/ql/lib/semmle/code/csharp/controlflow/ControlFlowElement.qll

@@ -4,20 +4,21 @@ import csharp
 private import semmle.code.csharp.ExprOrStmtParent
 private import semmle.code.csharp.commons.Compilation
 private import ControlFlow
-private import ControlFlow::BasicBlocks
 private import semmle.code.csharp.Caching
-private import internal.ControlFlowGraphImpl as Impl
+
+private class TControlFlowElementOrCallable = @callable or @control_flow_element;
+
+/** A `ControlFlowElement` or a `Callable`. */
+class ControlFlowElementOrCallable extends ExprOrStmtParent, TControlFlowElementOrCallable { }
 
 /**
  * A program element that can possess control flow. That is, either a statement or
  * an expression.
  *
- * A control flow element can be mapped to a control flow node (`ControlFlow::Node`)
- * via `getAControlFlowNode()`. There is a one-to-many relationship between
- * control flow elements and control flow nodes. This allows control flow
- * splitting, for example modeling the control flow through `finally` blocks.
+ * A control flow element can be mapped to a control flow node (`ControlFlowNode`)
+ * via `getControlFlowNode()`.
  */
-class ControlFlowElement extends ExprOrStmtParent, @control_flow_element {
+class ControlFlowElement extends ControlFlowElementOrCallable, @control_flow_element {
   /** Gets the enclosing callable of this element, if any. */
   Callable getEnclosingCallable() { none() }
 
@@ -30,41 +31,26 @@ class ControlFlowElement extends ExprOrStmtParent, @control_flow_element {
   }
 
   /**
+   * DEPRECATED: Use `getControlFlowNode()` instead.
+   *
    * Gets a control flow node for this element. That is, a node in the
    * control flow graph that corresponds to this element.
-   *
-   * Typically, there is exactly one `ControlFlow::Node` associated with a
-   * `ControlFlowElement`, but a `ControlFlowElement` may be split into
-   * several `ControlFlow::Node`s, for example to represent the continuation
-   * flow in a `try/catch/finally` construction.
    */
-  Nodes::ElementNode getAControlFlowNode() { result.getAstNode() = this }
+  deprecated ControlFlowNodes::ElementNode getAControlFlowNode() {
+    result = this.getControlFlowNode()
+  }
 
-  /** Gets the control flow node for this element. */
-  ControlFlow::Node getControlFlowNode() { result.getAstNode() = this }
+  /** Gets the control flow node for this element, if any. */
+  ControlFlowNode getControlFlowNode() { result.injects(this) }
 
   /** Gets the basic block in which this element occurs. */
-  BasicBlock getBasicBlock() { result = this.getAControlFlowNode().getBasicBlock() }
-
-  /**
-   * Gets a first control flow node executed within this element.
-   */
-  Nodes::ElementNode getAControlFlowEntryNode() {
-    result = Impl::getAControlFlowEntryNode(this).(ControlFlowElement).getAControlFlowNode()
-  }
-
-  /**
-   * Gets a potential last control flow node executed within this element.
-   */
-  Nodes::ElementNode getAControlFlowExitNode() {
-    result = Impl::getAControlFlowExitNode(this).(ControlFlowElement).getAControlFlowNode()
-  }
+  BasicBlock getBasicBlock() { result = this.getControlFlowNode().getBasicBlock() }
 
   /**
    * Holds if this element is live, that is this element can be reached
    * from the entry point of its enclosing callable.
    */
-  predicate isLive() { exists(this.getAControlFlowNode()) }
+  predicate isLive() { exists(this.getControlFlowNode()) }
 
   /** Holds if the current element is reachable from `src`. */
   // potentially very large predicate, so must be inlined
@@ -77,31 +63,13 @@ class ControlFlowElement extends ExprOrStmtParent, @control_flow_element {
   ControlFlowElement getAReachableElement() {
     // Reachable in same basic block
     exists(BasicBlock bb, int i, int j |
-      bb.getNode(i) = this.getAControlFlowNode() and
-      bb.getNode(j) = result.getAControlFlowNode() and
+      bb.getNode(i) = this.getControlFlowNode() and
+      bb.getNode(j) = result.getControlFlowNode() and
       i < j
     )
     or
     // Reachable in different basic blocks
-    this.getAControlFlowNode().getBasicBlock().getASuccessor+().getANode() =
-      result.getAControlFlowNode()
-  }
-
-  /**
-   * DEPRECATED: Use `Guard` class instead.
-   *
-   * Holds if basic block `controlled` is controlled by this control flow element
-   * with conditional value `s`. That is, `controlled` can only be reached from
-   * the callable entry point by going via the `s` edge out of *some* basic block
-   * ending with this element.
-   *
-   * `cb` records all of the possible condition blocks for this control flow element
-   * that a path from the callable entry point to `controlled` may go through.
-   */
-  deprecated predicate controlsBlock(
-    BasicBlock controlled, ConditionalSuccessor s, ConditionBlock cb
-  ) {
-    cb.getLastNode() = this.getAControlFlowNode() and
-    cb.edgeDominates(controlled, s)
+    this.getControlFlowNode().getBasicBlock().getASuccessor+().getANode() =
+      result.getControlFlowNode()
   }
 }

csharp/ql/lib/semmle/code/csharp/controlflow/ControlFlowGraph.qll

@@ -1,315 +1,577 @@
-import csharp
-
 /**
  * Provides classes representing the control flow graph within callables.
  */
-module ControlFlow {
-  private import semmle.code.csharp.controlflow.BasicBlocks as BBs
-  import semmle.code.csharp.controlflow.internal.SuccessorType
-  private import internal.ControlFlowGraphImpl as Impl
-  private import internal.Splitting as Splitting
 
-  /**
-   * A control flow node.
-   *
-   * Either a callable entry node (`EntryNode`), a callable exit node (`ExitNode`),
-   * or a control flow node for a control flow element, that is, an expression or a
-   * statement (`ElementNode`).
-   *
-   * A control flow node is a node in the control flow graph (CFG). There is a
-   * many-to-one relationship between `ElementNode`s and `ControlFlowElement`s.
-   * This allows control flow splitting, for example modeling the control flow
-   * through `finally` blocks.
-   *
-   * Only nodes that can be reached from the callable entry point are included in
-   * the CFG.
-   */
-  class Node extends Impl::Node {
-    /** Gets the control flow element that this node corresponds to, if any. */
-    final ControlFlowElement getAstNode() { result = super.getAstNode() }
+import csharp
+private import codeql.controlflow.ControlFlowGraph
+private import codeql.controlflow.SuccessorType
+private import semmle.code.csharp.commons.Compilation
+private import semmle.code.csharp.controlflow.internal.NonReturning as NonReturning
 
-    /** Gets the basic block that this control flow node belongs to. */
-    BasicBlock getBasicBlock() { result.getANode() = this }
+private module Cfg0 = Make0<Location, Ast>;
 
-    /**
-     * Holds if this node dominates `that` node.
-     *
-     * That is, all paths reaching `that` node from some callable entry
-     * node (`EntryNode`) must go through this node.
-     *
-     * Example:
-     *
-     * ```csharp
-     * int M(string s)
-     * {
-     *     if (s == null)
-     *         throw new ArgumentNullException(nameof(s));
-     *     return s.Length;
-     * }
-     * ```
-     *
-     * The node on line 3 dominates the node on line 5 (all paths from the
-     * entry point of `M` to `return s.Length;` must go through the null check).
-     *
-     * This predicate is *reflexive*, so for example `if (s == null)` dominates
-     * itself.
-     */
-    // potentially very large predicate, so must be inlined
-    pragma[inline]
-    predicate dominates(Node that) {
-      this.strictlyDominates(that)
-      or
-      this = that
-    }
+private module Cfg1 = Make1<Input>;
 
-    /**
-     * Holds if this node strictly dominates `that` node.
-     *
-     * That is, all paths reaching `that` node from some callable entry
-     * node (`EntryNode`) must go through this node (which must
-     * be different from `that` node).
-     *
-     * Example:
-     *
-     * ```csharp
-     * int M(string s)
-     * {
-     *     if (s == null)
-     *         throw new ArgumentNullException(nameof(s));
-     *     return s.Length;
-     * }
-     * ```
-     *
-     * The node on line 3 strictly dominates the node on line 5
-     * (all paths from the entry point of `M` to `return s.Length;` must go
-     * through the null check).
-     */
-    // potentially very large predicate, so must be inlined
-    pragma[inline]
-    predicate strictlyDominates(Node that) {
-      this.getBasicBlock().strictlyDominates(that.getBasicBlock())
-      or
-      exists(BasicBlock bb, int i, int j |
-        bb.getNode(i) = this and
-        bb.getNode(j) = that and
-        i < j
-      )
-    }
+private module Cfg2 = Make2<Input>;
 
-    /**
-     * Holds if this node post-dominates `that` node.
-     *
-     * That is, all paths reaching a normal callable exit node (an `AnnotatedExitNode`
-     * with a normal exit type) from `that` node must go through this node.
-     *
-     * Example:
-     *
-     * ```csharp
-     * int M(string s)
-     * {
-     *     try
-     *     {
-     *         return s.Length;
-     *     }
-     *     finally
-     *     {
-     *         Console.WriteLine("M");
-     *     }
-     * }
-     * ```
-     *
-     * The node on line 9 post-dominates the node on line 5 (all paths to the
-     * exit point of `M` from `return s.Length;` must go through the `WriteLine`
-     * call).
-     *
-     * This predicate is *reflexive*, so for example `Console.WriteLine("M");`
-     * post-dominates itself.
-     */
-    // potentially very large predicate, so must be inlined
-    pragma[inline]
-    predicate postDominates(Node that) {
-      this.strictlyPostDominates(that)
-      or
-      this = that
-    }
+private import Cfg0
+private import Cfg1
+private import Cfg2
+import Public
 
-    /**
-     * Holds if this node strictly post-dominates `that` node.
-     *
-     * That is, all paths reaching a normal callable exit node (an `AnnotatedExitNode`
-     * with a normal exit type) from `that` node must go through this node
-     * (which must be different from `that` node).
-     *
-     * Example:
-     *
-     * ```csharp
-     * int M(string s)
-     * {
-     *     try
-     *     {
-     *         return s.Length;
-     *     }
-     *     finally
-     *     {
-     *          Console.WriteLine("M");
-     *     }
-     * }
-     * ```
-     *
-     * The node on line 9 strictly post-dominates the node on line 5 (all
-     * paths to the exit point of `M` from `return s.Length;` must go through
-     * the `WriteLine` call).
-     */
-    // potentially very large predicate, so must be inlined
-    pragma[inline]
-    predicate strictlyPostDominates(Node that) {
-      this.getBasicBlock().strictlyPostDominates(that.getBasicBlock())
-      or
-      exists(BasicBlock bb, int i, int j |
-        bb.getNode(i) = this and
-        bb.getNode(j) = that and
-        i > j
-      )
-    }
+/** Provides an implementation of the AST signature for C#. */
+private module Ast implements AstSig<Location> {
+  private import csharp as CS
 
-    /** Gets a successor node of a given type, if any. */
-    Node getASuccessorByType(SuccessorType t) { result = this.getASuccessor(t) }
+  class AstNode = ControlFlowElementOrCallable;
 
-    /** Gets an immediate successor, if any. */
-    Node getASuccessor() { result = this.getASuccessorByType(_) }
-
-    /** Gets an immediate predecessor node of a given flow type, if any. */
-    Node getAPredecessorByType(SuccessorType t) { result.getASuccessorByType(t) = this }
-
-    /** Gets an immediate predecessor, if any. */
-    Node getAPredecessor() { result = this.getAPredecessorByType(_) }
-
-    /**
-     * Gets an immediate `true` successor, if any.
-     *
-     * An immediate `true` successor is a successor that is reached when
-     * this condition evaluates to `true`.
-     *
-     * Example:
-     *
-     * ```csharp
-     * if (x < 0)
-     *     x = -x;
-     * ```
-     *
-     * The node on line 2 is an immediate `true` successor of the node
-     * on line 1.
-     */
-    Node getATrueSuccessor() {
-      result = this.getASuccessorByType(any(BooleanSuccessor t | t.getValue() = true))
-    }
-
-    /**
-     * Gets an immediate `false` successor, if any.
-     *
-     * An immediate `false` successor is a successor that is reached when
-     * this condition evaluates to `false`.
-     *
-     * Example:
-     *
-     * ```csharp
-     * if (!(x >= 0))
-     *     x = -x;
-     * ```
-     *
-     * The node on line 2 is an immediate `false` successor of the node
-     * on line 1.
-     */
-    Node getAFalseSuccessor() {
-      result = this.getASuccessorByType(any(BooleanSuccessor t | t.getValue() = false))
-    }
-
-    /** Gets the enclosing callable of this control flow node. */
-    final Callable getEnclosingCallable() { result = Impl::getNodeCfgScope(this) }
+  additional predicate skipControlFlow(AstNode e) {
+    e instanceof TypeAccess and
+    not e instanceof TypeAccessPatternExpr
+    or
+    not e.getFile().fromSource()
   }
 
-  /** Provides different types of control flow nodes. */
-  module Nodes {
-    /** A node for a callable entry point. */
-    class EntryNode extends Node instanceof Impl::EntryNode {
-      /** Gets the callable that this entry applies to. */
-      Callable getCallable() { result = this.getScope() }
-
-      override BasicBlocks::EntryBlock getBasicBlock() { result = Node.super.getBasicBlock() }
-    }
-
-    /** A node for a callable exit point, annotated with the type of exit. */
-    class AnnotatedExitNode extends Node instanceof Impl::AnnotatedExitNode {
-      /** Holds if this node represent a normal exit. */
-      final predicate isNormal() { super.isNormal() }
-
-      /** Gets the callable that this exit applies to. */
-      Callable getCallable() { result = this.getScope() }
-
-      override BasicBlocks::AnnotatedExitBlock getBasicBlock() {
-        result = Node.super.getBasicBlock()
-      }
-    }
-
-    /** A control flow node indicating normal termination of a callable. */
-    class NormalExitNode extends AnnotatedExitNode instanceof Impl::NormalExitNode { }
-
-    /** A node for a callable exit point. */
-    class ExitNode extends Node instanceof Impl::ExitNode {
-      /** Gets the callable that this exit applies to. */
-      Callable getCallable() { result = this.getScope() }
-
-      override BasicBlocks::ExitBlock getBasicBlock() { result = Node.super.getBasicBlock() }
-    }
-
-    /**
-     * A node for a control flow element, that is, an expression or a statement.
-     *
-     * Each control flow element maps to zero or more `ElementNode`s: zero when
-     * the element is in unreachable (dead) code, and multiple when there are
-     * different splits for the element.
-     */
-    class ElementNode extends Node instanceof Impl::AstCfgNode {
-      /** Gets a comma-separated list of strings for each split in this node, if any. */
-      final string getSplitsString() { result = super.getSplitsString() }
-
-      /** Gets a split for this control flow node, if any. */
-      final Split getASplit() { result = super.getASplit() }
-    }
-
-    /** A control-flow node for an expression. */
-    class ExprNode extends ElementNode {
-      Expr e;
-
-      ExprNode() { e = unique(Expr e_ | e_ = this.getAstNode() | e_) }
-
-      /** Gets the expression that this control-flow node belongs to. */
-      Expr getExpr() { result = e }
-
-      /** Gets the value of this expression node, if any. */
-      string getValue() { result = e.getValue() }
-
-      /** Gets the type of this expression node. */
-      Type getType() { result = e.getType() }
-    }
-
-    class Split = Splitting::Split;
+  private AstNode getExprChild0(Expr e, int i) {
+    not e instanceof NameOfExpr and
+    not e instanceof AnonymousFunctionExpr and
+    not skipControlFlow(result) and
+    result = e.getChild(i)
   }
 
-  class BasicBlock = BBs::BasicBlock;
+  private AstNode getStmtChild0(Stmt s, int i) {
+    not s instanceof FixedStmt and
+    not s instanceof UsingBlockStmt and
+    result = s.getChild(i)
+    or
+    s =
+      any(FixedStmt fs |
+        result = fs.getVariableDeclExpr(i)
+        or
+        result = fs.getBody() and
+        i = max(int j | exists(fs.getVariableDeclExpr(j))) + 1
+      )
+    or
+    s =
+      any(UsingBlockStmt us |
+        result = us.getExpr() and
+        i = 0
+        or
+        result = us.getVariableDeclExpr(i)
+        or
+        result = us.getBody() and
+        i = max([1, count(us.getVariableDeclExpr(_))])
+      )
+  }
 
-  /** Provides different types of basic blocks. */
-  module BasicBlocks {
-    class EntryBlock = BBs::EntryBasicBlock;
+  AstNode getChild(AstNode n, int index) {
+    result = getStmtChild0(n, index)
+    or
+    result = getExprChild0(n, index)
+  }
 
-    class AnnotatedExitBlock = BBs::AnnotatedExitBasicBlock;
+  private AstNode getParent(AstNode n) { n = getChild(result, _) }
 
-    class ExitBlock = BBs::ExitBasicBlock;
+  Callable getEnclosingCallable(AstNode node) {
+    result = node.(ControlFlowElement).getEnclosingCallable() or
+    result.(ObjectInitMethod).initializes(getParent*(node)) or
+    Initializers::staticMemberInitializer(result, getParent*(node))
+  }
 
-    class JoinBlock = BBs::JoinBlock;
+  class Callable = CS::Callable;
 
-    class JoinBlockPredecessor = BBs::JoinBlockPredecessor;
+  AstNode callableGetBody(Callable c) {
+    not skipControlFlow(result) and
+    result = c.getBody()
+  }
 
-    class ConditionBlock = BBs::ConditionBlock;
+  class Stmt = CS::Stmt;
+
+  class Expr = CS::Expr;
+
+  class BlockStmt = CS::BlockStmt;
+
+  class ExprStmt = CS::ExprStmt;
+
+  class IfStmt = CS::IfStmt;
+
+  class LoopStmt = CS::LoopStmt;
+
+  class WhileStmt = CS::WhileStmt;
+
+  class DoStmt = CS::DoStmt;
+
+  final private class FinalForStmt = CS::ForStmt;
+
+  class ForStmt extends FinalForStmt {
+    Expr getInit(int index) { result = this.getInitializer(index) }
+  }
+
+  final private class FinalForeachStmt = CS::ForeachStmt;
+
+  class ForeachStmt extends FinalForeachStmt {
+    Expr getVariable() {
+      result = this.getVariableDeclExpr() or result = this.getVariableDeclTuple()
+    }
+
+    Expr getCollection() { result = this.getIterableExpr() }
+  }
+
+  class BreakStmt = CS::BreakStmt;
+
+  class ContinueStmt = CS::ContinueStmt;
+
+  class GotoStmt = CS::GotoStmt;
+
+  class ReturnStmt = CS::ReturnStmt;
+
+  class Throw = CS::ThrowElement;
+
+  final private class FinalTryStmt = CS::TryStmt;
+
+  class TryStmt extends FinalTryStmt {
+    Stmt getBody() { result = this.getBlock() }
+
+    CatchClause getCatch(int index) { result = this.getCatchClause(index) }
+
+    Stmt getFinally() { result = super.getFinally() }
+  }
+
+  final private class FinalCatchClause = CS::CatchClause;
+
+  class CatchClause extends FinalCatchClause {
+    AstNode getVariable() { result = this.(CS::SpecificCatchClause).getVariableDeclExpr() }
+
+    Expr getCondition() { result = this.getFilterClause() }
+
+    Stmt getBody() { result = this.getBlock() }
+  }
+
+  final private class FinalSwitch = CS::Switch;
+
+  class Switch extends FinalSwitch {
+    Case getCase(int index) { result = super.getCase(index) }
+
+    Stmt getStmt(int index) { result = this.(CS::SwitchStmt).getStmt(index) }
+  }
+
+  final private class FinalCase = CS::Case;
+
+  class Case extends FinalCase {
+    AstNode getAPattern() { result = this.getPattern() }
+
+    Expr getGuard() { result = this.getCondition() }
+
+    AstNode getBody() { result = super.getBody() }
+  }
+
+  class DefaultCase extends Case instanceof CS::DefaultCase { }
+
+  class ConditionalExpr = CS::ConditionalExpr;
+
+  class BinaryExpr = CS::BinaryOperation;
+
+  class LogicalAndExpr = CS::LogicalAndExpr;
+
+  class LogicalOrExpr = CS::LogicalOrExpr;
+
+  class NullCoalescingExpr = CS::NullCoalescingExpr;
+
+  class UnaryExpr = CS::UnaryOperation;
+
+  class LogicalNotExpr = CS::LogicalNotExpr;
+
+  class Assignment = CS::Assignment;
+
+  class AssignExpr = CS::AssignExpr;
+
+  class CompoundAssignment = CS::AssignOperation;
+
+  class AssignLogicalAndExpr extends CompoundAssignment {
+    AssignLogicalAndExpr() { none() }
+  }
+
+  class AssignLogicalOrExpr extends CompoundAssignment {
+    AssignLogicalOrExpr() { none() }
+  }
+
+  class AssignNullCoalescingExpr = CS::AssignCoalesceExpr;
+
+  final private class FinalBoolLiteral = CS::BoolLiteral;
+
+  class BooleanLiteral extends FinalBoolLiteral {
+    boolean getValue() { result = this.getBoolValue() }
+  }
+
+  final private class FinalIsExpr = CS::IsExpr;
+
+  class PatternMatchExpr extends FinalIsExpr {
+    AstNode getPattern() { result = super.getPattern() }
+  }
+}
+
+/**
+ * A compilation.
+ *
+ * Unlike the standard `Compilation` class, this class also supports buildless
+ * extraction.
+ */
+private newtype TCompilationExt =
+  TCompilation(Compilation c) { not extractionIsStandalone() } or
+  TBuildless() { extractionIsStandalone() }
+
+private class CompilationExt extends TCompilationExt {
+  string toString() {
+    exists(Compilation c |
+      this = TCompilation(c) and
+      result = c.toString()
+    )
+    or
+    this = TBuildless() and result = "buildless compilation"
+  }
+}
+
+/** Gets the compilation that source file `f` belongs to. */
+private CompilationExt getCompilation(File f) {
+  exists(Compilation c |
+    f = c.getAFileCompiled() and
+    result = TCompilation(c)
+  )
+  or
+  result = TBuildless()
+}
+
+private module Initializers {
+  private import semmle.code.csharp.ExprOrStmtParent as ExprOrStmtParent
+
+  /**
+   * The `expr_parent_top_level_adjusted()` relation restricted to exclude relations
+   * between properties and their getters' expression bodies in properties such as
+   * `int P => 0`.
+   *
+   * This is in order to only associate the expression body with one CFG scope, namely
+   * the getter (and not the declaration itself).
+   */
+  private predicate expr_parent_top_level_adjusted2(
+    Expr child, int i, @top_level_exprorstmt_parent parent
+  ) {
+    ExprOrStmtParent::expr_parent_top_level_adjusted(child, i, parent) and
+    not exists(Getter g |
+      g.getDeclaration() = parent and
+      i = 0
+    )
+  }
+
+  /**
+   * Holds if `init` is a static member initializer and `staticCtor` is the
+   * static constructor in the same declaring type. Hence, `staticCtor` can be
+   * considered to execute `init` prior to the execution of its body.
+   */
+  predicate staticMemberInitializer(Constructor staticCtor, Expr init) {
+    exists(Assignable a |
+      a.(Modifiable).isStatic() and
+      expr_parent_top_level_adjusted2(init, _, a) and
+      a.getDeclaringType() = staticCtor.getDeclaringType() and
+      staticCtor.isStatic()
+    )
+  }
+
+  /**
+   * Gets the `i`th static member initializer expression for static constructor `staticCtor`.
+   */
+  Expr initializedStaticMemberOrder(Constructor staticCtor, int i) {
+    result =
+      rank[i + 1](Expr init, Location l, string filepath, int startline, int startcolumn |
+        staticMemberInitializer(staticCtor, init) and
+        l = init.getLocation() and
+        l.hasLocationInfo(filepath, startline, startcolumn, _, _)
+      |
+        init order by startline, startcolumn, filepath
+      )
+  }
+
+  /**
+   * Gets the `i`th member initializer expression for object initializer method `obinit`.
+   */
+  AssignExpr initializedInstanceMemberOrder(ObjectInitMethod obinit, int i) {
+    result =
+      rank[i + 1](AssignExpr ae0, Location l, string filepath, int startline, int startcolumn |
+        obinit.initializes(ae0) and
+        l = ae0.getLocation() and
+        l.hasLocationInfo(filepath, startline, startcolumn, _, _)
+      |
+        ae0 order by startline, startcolumn, filepath
+      )
+  }
+}
+
+private module Exceptions {
+  private import semmle.code.csharp.commons.Assertions
+
+  private class Overflowable extends UnaryOperation {
+    Overflowable() {
+      not this instanceof UnaryBitwiseOperation and
+      this.getType() instanceof IntegralType
+    }
+  }
+
+  /** Holds if `cfe` is a control flow element that may throw an exception. */
+  predicate mayThrowException(ControlFlowElement cfe) {
+    cfe.(TriedControlFlowElement).mayThrowException()
+    or
+    cfe instanceof Assertion
+  }
+
+  /** A control flow element that is inside a `try` block. */
+  private class TriedControlFlowElement extends ControlFlowElement {
+    TriedControlFlowElement() {
+      this = any(TryStmt try).getATriedElement() and
+      not this instanceof NonReturning::NonReturningCall
+    }
+
+    /**
+     * Holds if this element may potentially throw an exception.
+     */
+    predicate mayThrowException() {
+      this instanceof Overflowable
+      or
+      this.(CastExpr).getType() instanceof IntegralType
+      or
+      invalidCastCandidate(this)
+      or
+      this instanceof Call
+      or
+      this =
+        any(MemberAccess ma |
+          not ma.isConditional() and
+          ma.getQualifier() = any(Expr e | not e instanceof TypeAccess)
+        )
+      or
+      this instanceof DelegateCreation
+      or
+      this instanceof ArrayCreation
+      or
+      this =
+        any(AddOperation ae |
+          ae.getType() instanceof StringType
+          or
+          ae.getType() instanceof IntegralType
+        )
+      or
+      this = any(SubOperation se | se.getType() instanceof IntegralType)
+      or
+      this = any(MulOperation me | me.getType() instanceof IntegralType)
+      or
+      this = any(DivOperation de | not de.getDenominator().getValue().toFloat() != 0)
+      or
+      this instanceof RemOperation
+      or
+      this instanceof DynamicExpr
+    }
+  }
+
+  pragma[nomagic]
+  private ValueOrRefType getACastExprBaseType(CastExpr ce) {
+    result = ce.getType().(ValueOrRefType).getABaseType()
+    or
+    result = getACastExprBaseType(ce).getABaseType()
+  }
+
+  pragma[nomagic]
+  private predicate invalidCastCandidate(CastExpr ce) {
+    ce.getExpr().getType() = getACastExprBaseType(ce)
+  }
+}
+
+private module Input implements InputSig1, InputSig2 {
+  predicate cfgCachedStageRef() { CfgCachedStage::ref() }
+
+  predicate catchAll(Ast::CatchClause catch) { catch instanceof GeneralCatchClause }
+
+  predicate matchAll(Ast::Case c) { c instanceof DefaultCase or c.(SwitchCaseExpr).matchesAll() }
+
+  private newtype TLabel =
+    TLblGoto(string label) { any(GotoLabelStmt goto).getLabel() = label } or
+    TLblSwitchCase(string value) { any(GotoCaseStmt goto).getLabel() = value } or
+    TLblSwitchDefault()
+
+  class Label extends TLabel {
+    string toString() {
+      this = TLblGoto(result)
+      or
+      this = TLblSwitchCase(result)
+      or
+      this = TLblSwitchDefault() and result = "default"
+    }
+  }
+
+  predicate hasLabel(Ast::AstNode n, Label l) {
+    l = TLblGoto(n.(GotoLabelStmt).getLabel())
+    or
+    l = TLblSwitchCase(n.(GotoCaseStmt).getLabel())
+    or
+    l = TLblSwitchDefault() and n instanceof GotoDefaultStmt
+    or
+    l = TLblGoto(n.(LabelStmt).getLabel())
+  }
+
+  class CallableBodyPartContext = CompilationExt;
+
+  pragma[nomagic]
+  Ast::AstNode callableGetBodyPart(Callable c, CallableBodyPartContext ctx, int index) {
+    not Ast::skipControlFlow(result) and
+    ctx = getCompilation(result.getFile()) and
+    (
+      result = Initializers::initializedInstanceMemberOrder(c, index)
+      or
+      result = Initializers::initializedStaticMemberOrder(c, index)
+      or
+      exists(Constructor ctor, int i, int staticMembers |
+        c = ctor and
+        staticMembers = count(Expr init | Initializers::staticMemberInitializer(ctor, init)) and
+        index = staticMembers + i + 1
+      |
+        i = 0 and result = ctor.getObjectInitializerCall()
+        or
+        i = 1 and result = ctor.getInitializer()
+        or
+        i = 2 and result = ctor.getBody()
+      )
+    )
+  }
+
+  private Expr getQualifier(QualifiableExpr qe) {
+    result = qe.getQualifier() or
+    result = qe.(ExtensionMethodCall).getArgument(0)
+  }
+
+  predicate inConditionalContext(Ast::AstNode n, ConditionKind kind) {
+    kind.isNullness() and
+    exists(QualifiableExpr qe | qe.isConditional() | n = getQualifier(qe))
+  }
+
+  predicate postOrInOrder(Ast::AstNode n) { n instanceof YieldStmt or n instanceof Call }
+
+  predicate beginAbruptCompletion(
+    Ast::AstNode ast, PreControlFlowNode n, AbruptCompletion c, boolean always
+  ) {
+    // `yield break` behaves like a return statement
+    ast instanceof YieldBreakStmt and
+    n.isIn(ast) and
+    c.asSimpleAbruptCompletion() instanceof ReturnSuccessor and
+    always = true
+    or
+    Exceptions::mayThrowException(ast) and
+    n.isIn(ast) and
+    c.asSimpleAbruptCompletion() instanceof ExceptionSuccessor and
+    always = false
+    or
+    ast instanceof NonReturning::NonReturningCall and
+    n.isIn(ast) and
+    c.asSimpleAbruptCompletion() instanceof ExceptionSuccessor and
+    always = true
+  }
+
+  predicate endAbruptCompletion(Ast::AstNode ast, PreControlFlowNode n, AbruptCompletion c) {
+    exists(SwitchStmt switch, Label l, Ast::Case case |
+      ast.(Stmt).getParent() = switch and
+      c.getSuccessorType() instanceof GotoSuccessor and
+      c.hasLabel(l) and
+      n.isAfterValue(case, any(MatchingSuccessor t | t.getValue() = true))
+    |
+      exists(string value, ConstCase cc |
+        l = TLblSwitchCase(value) and
+        switch.getAConstCase() = cc and
+        cc.getLabel() = value and
+        cc = case
+      )
+      or
+      l = TLblSwitchDefault() and switch.getDefaultCase() = case
+    )
+  }
+
+  predicate step(PreControlFlowNode n1, PreControlFlowNode n2) {
+    exists(QualifiableExpr qe | qe.isConditional() |
+      n1.isBefore(qe) and n2.isBefore(getQualifier(qe))
+      or
+      exists(NullnessSuccessor t | n1.isAfterValue(getQualifier(qe), t) |
+        if t.isNull()
+        then (
+          // if `q` is null in `q?.f = x` then the assignment is skipped. This
+          // holds for both regular, compound, and null-coalescing assignments.
+          // On the other hand, the CFG definition for the assignment can treat
+          // the LHS the same regardless of whether it's a conditionally
+          // qualified access or not, as it just connects to the "before" and
+          // "after" nodes of the LHS, and the "after" node is skipped in this
+          // case.
+          exists(AssignableDefinition def |
+            def.getTargetAccess() = qe and
+            n2.isAfterValue(def.getExpr(), t)
+          )
+          or
+          not qe instanceof AssignableWrite and
+          n2.isAfterValue(qe, t)
+        ) else (
+          n2.isBefore(Ast::getChild(qe, 0))
+          or
+          n2.isIn(qe) and not exists(Ast::getChild(qe, 0))
+        )
+      )
+      or
+      exists(int i | i >= 0 and n1.isAfter(Ast::getChild(qe, i)) |
+        n2.isBefore(Ast::getChild(qe, i + 1))
+        or
+        not exists(Ast::getChild(qe, i + 1)) and n2.isIn(qe)
+      )
+      or
+      n1.isIn(qe) and n2.isAfter(qe) and not beginAbruptCompletion(qe, n1, _, true)
+    )
+    or
+    exists(ObjectCreation oc |
+      n1.isBefore(oc) and n2.isBefore(oc.getArgument(0))
+      or
+      n1.isBefore(oc) and n2.isIn(oc) and not exists(oc.getAnArgument())
+      or
+      exists(int i | n1.isAfter(oc.getArgument(i)) |
+        n2.isBefore(oc.getArgument(i + 1))
+        or
+        not exists(oc.getArgument(i + 1)) and n2.isIn(oc)
+      )
+      or
+      n1.isIn(oc) and n2.isBefore(oc.getInitializer())
+      or
+      n1.isIn(oc) and n2.isAfter(oc) and not exists(oc.getInitializer())
+      or
+      n1.isAfter(oc.getInitializer()) and n2.isAfter(oc)
+    )
+  }
+}
+
+/** Provides different types of control flow nodes. */
+module ControlFlowNodes {
+  /**
+   * A node for a control flow element, that is, an expression or a statement.
+   *
+   * Each control flow element maps to zero or one `ElementNode`s: zero when
+   * the element is in unreachable (dead) code, and otherwise one.
+   */
+  class ElementNode extends ControlFlowNode {
+    ElementNode() { exists(this.asExpr()) or exists(this.asStmt()) }
+  }
+
+  /** A control-flow node for an expression. */
+  class ExprNode extends ElementNode {
+    Expr e;
+
+    ExprNode() { e = this.asExpr() }
+
+    /** Gets the expression that this control-flow node belongs to. */
+    Expr getExpr() { result = e }
+
+    /** Gets the value of this expression node, if any. */
+    string getValue() { result = e.getValue() }
+
+    /** Gets the type of this expression node. */
+    Type getType() { result = e.getType() }
   }
 }

csharp/ql/lib/semmle/code/csharp/controlflow/ControlFlowReachability.qll

@@ -4,16 +4,13 @@
 
 import csharp
 private import codeql.controlflow.ControlFlowReachability
-private import semmle.code.csharp.controlflow.BasicBlocks
 private import semmle.code.csharp.controlflow.Guards as Guards
 private import semmle.code.csharp.ExprOrStmtParent
 
-private module ControlFlowInput implements
-  InputSig<Location, ControlFlow::Node, ControlFlow::BasicBlock>
-{
+private module ControlFlowInput implements InputSig<Location, ControlFlowNode, BasicBlock> {
   private import csharp as CS
 
-  AstNode getEnclosingAstNode(ControlFlow::Node node) {
+  AstNode getEnclosingAstNode(ControlFlowNode node) {
     node.getAstNode() = result
     or
     not exists(node.getAstNode()) and result = node.getEnclosingCallable()

csharp/ql/lib/semmle/code/csharp/controlflow/Guards.qll

@@ -7,20 +7,16 @@ private import ControlFlow
 private import semmle.code.csharp.commons.Assertions
 private import semmle.code.csharp.commons.ComparisonTest
 private import semmle.code.csharp.commons.StructuralComparison as SC
-private import semmle.code.csharp.controlflow.BasicBlocks
-private import semmle.code.csharp.controlflow.internal.Completion
 private import semmle.code.csharp.frameworks.System
 private import semmle.code.csharp.frameworks.system.Linq
 private import semmle.code.csharp.frameworks.system.Collections
 private import semmle.code.csharp.frameworks.system.collections.Generic
 private import codeql.controlflow.Guards as SharedGuards
 
-private module GuardsInput implements
-  SharedGuards::InputSig<Location, ControlFlow::Node, ControlFlow::BasicBlock>
-{
+private module GuardsInput implements SharedGuards::InputSig<Location, ControlFlowNode, BasicBlock> {
   private import csharp as CS
 
-  class NormalExitNode = ControlFlow::Nodes::NormalExitNode;
+  class NormalExitNode = ControlFlow::NormalExitNode;
 
   class AstNode = ControlFlowElement;
 
@@ -60,25 +56,16 @@ private module GuardsInput implements
     override boolean asBooleanValue() { boolConst(this, result) }
   }
 
-  private predicate intConst(Expr e, int i) {
-    e.getValue().toInt() = i and
-    (
-      e.getType() instanceof Enum
-      or
-      e.getType() instanceof IntegralType
-    )
-  }
-
   private class IntegerConstant extends ConstantExpr {
-    IntegerConstant() { intConst(this, _) }
+    IntegerConstant() { exists(this.getIntValue()) }
 
-    override int asIntegerValue() { intConst(this, result) }
+    override int asIntegerValue() { result = this.getIntValue() }
   }
 
   private class EnumConst extends ConstantExpr {
     EnumConst() { this.getType() instanceof Enum and this.hasValue() }
 
-    override int asIntegerValue() { result = this.getValue().toInt() }
+    override int asIntegerValue() { result = this.getIntValue() }
   }
 
   private class StringConstant extends ConstantExpr instanceof StringLiteral {
@@ -96,21 +83,14 @@ private module GuardsInput implements
 
     ConstantExpr asConstantCase() { super.getPattern() = result }
 
-    private predicate hasEdge(BasicBlock bb1, BasicBlock bb2, MatchingCompletion c) {
-      exists(PatternExpr pe |
-        super.getPattern() = pe and
-        c.isValidFor(pe) and
-        bb1.getLastNode() = pe.getAControlFlowNode() and
-        bb1.getASuccessor(c.getAMatchingSuccessorType()) = bb2
-      )
-    }
-
     predicate matchEdge(BasicBlock bb1, BasicBlock bb2) {
-      exists(MatchingCompletion c | this.hasEdge(bb1, bb2, c) and c.isMatch())
+      bb1.getASuccessor(any(MatchingSuccessor s | s.getValue() = true)) = bb2 and
+      bb1.getLastNode() = AstNode.super.getControlFlowNode()
     }
 
     predicate nonMatchEdge(BasicBlock bb1, BasicBlock bb2) {
-      exists(MatchingCompletion c | this.hasEdge(bb1, bb2, c) and c.isNonMatch())
+      bb1.getASuccessor(any(MatchingSuccessor s | s.getValue() = false)) = bb2 and
+      bb1.getLastNode() = AstNode.super.getControlFlowNode()
     }
   }
 
@@ -136,7 +116,7 @@ private module GuardsInput implements
     IdExpr() { this instanceof AssignExpr or this instanceof CastExpr }
 
     Expr getEqualChildExpr() {
-      result = this.(AssignExpr).getRValue()
+      result = this.(AssignExpr).getRightOperand()
       or
       result = this.(CastExpr).getExpr()
     }
@@ -322,7 +302,7 @@ class Guard extends Guards::Guard {
    * In case `cfn` or `sub` access an SSA variable in their left-most qualifier, then
    * so must the other (accessing the same SSA variable).
    */
-  predicate controlsNode(ControlFlow::Nodes::ElementNode cfn, AccessOrCallExpr sub, GuardValue v) {
+  predicate controlsNode(ControlFlowNodes::ElementNode cfn, AccessOrCallExpr sub, GuardValue v) {
     isGuardedByNode(cfn, this, sub, v)
   }
 
@@ -332,7 +312,7 @@ class Guard extends Guards::Guard {
    * Note: This predicate is inlined.
    */
   pragma[inline]
-  predicate controlsNode(ControlFlow::Nodes::ElementNode cfn, GuardValue v) {
+  predicate controlsNode(ControlFlowNodes::ElementNode cfn, GuardValue v) {
     guardControls(this, cfn.getBasicBlock(), v)
   }
 
@@ -450,7 +430,8 @@ class DereferenceableExpr extends Expr {
   predicate guardSuggestsMaybeNull(Guards::Guard guard) {
     not nonNullValueImplied(this) and
     (
-      exists(NullnessCompletion c | c.isValidFor(this) and c.isNull() and guard = this)
+      exists(guard.getControlFlowNode().getASuccessor(any(NullnessSuccessor n | n.isNull()))) and
+      guard = this
       or
       LogicInput::additionalNullCheck(guard, _, this, true)
       or
@@ -517,35 +498,35 @@ class EnumerableCollectionExpr extends Expr {
           |
             // x.Length == 0
             ct.getComparisonKind().isEquality() and
-            ct.getAnArgument().getValue().toInt() = 0 and
+            ct.getAnArgument().getIntValue() = 0 and
             branch = isEmpty
             or
             // x.Length == k, k > 0
             ct.getComparisonKind().isEquality() and
-            ct.getAnArgument().getValue().toInt() > 0 and
+            ct.getAnArgument().getIntValue() > 0 and
             branch = true and
             isEmpty = false
             or
             // x.Length != 0
             ct.getComparisonKind().isInequality() and
-            ct.getAnArgument().getValue().toInt() = 0 and
+            ct.getAnArgument().getIntValue() = 0 and
             branch = isEmpty.booleanNot()
             or
             // x.Length != k, k != 0
             ct.getComparisonKind().isInequality() and
-            ct.getAnArgument().getValue().toInt() != 0 and
+            ct.getAnArgument().getIntValue() != 0 and
             branch = false and
             isEmpty = false
             or
             // x.Length > k, k >= 0
             ct.getComparisonKind().isLessThan() and
-            ct.getFirstArgument().getValue().toInt() >= 0 and
+            ct.getFirstArgument().getIntValue() >= 0 and
             branch = true and
             isEmpty = false
             or
             // x.Length >= k, k > 0
             ct.getComparisonKind().isLessThanEquals() and
-            ct.getFirstArgument().getValue().toInt() > 0 and
+            ct.getFirstArgument().getIntValue() > 0 and
             branch = true and
             isEmpty = false
           )
@@ -605,7 +586,7 @@ class AccessOrCallExpr extends Expr {
    * An expression can have more than one SSA qualifier in the presence
    * of control flow splitting.
    */
-  Ssa::Definition getAnSsaQualifier(ControlFlow::Node cfn) { result = getAnSsaQualifier(this, cfn) }
+  Ssa::Definition getAnSsaQualifier(ControlFlowNode cfn) { result = getAnSsaQualifier(this, cfn) }
 }
 
 private Declaration getDeclarationTarget(Expr e) {
@@ -613,14 +594,14 @@ private Declaration getDeclarationTarget(Expr e) {
   result = e.(Call).getTarget()
 }
 
-private Ssa::Definition getAnSsaQualifier(Expr e, ControlFlow::Node cfn) {
+private Ssa::Definition getAnSsaQualifier(Expr e, ControlFlowNode cfn) {
   e = getATrackedAccess(result, cfn)
   or
   not e = getATrackedAccess(_, _) and
   result = getAnSsaQualifier(e.(QualifiableExpr).getQualifier(), cfn)
 }
 
-private AssignableAccess getATrackedAccess(Ssa::Definition def, ControlFlow::Node cfn) {
+private AssignableAccess getATrackedAccess(Ssa::Definition def, ControlFlowNode cfn) {
   result = def.getAReadAtNode(cfn)
   or
   result = def.(Ssa::ExplicitDefinition).getADefinition().getTargetAccess() and
@@ -729,7 +710,7 @@ class GuardedExpr extends AccessOrCallExpr {
  * In the example above, the node for `x.ToString()` is null-guarded in the
  * split `b == true`, but not in the split `b == false`.
  */
-class GuardedControlFlowNode extends ControlFlow::Nodes::ElementNode {
+class GuardedControlFlowNode extends ControlFlowNodes::ElementNode {
   private Guard g;
   private AccessOrCallExpr sub0;
   private GuardValue v0;
@@ -785,7 +766,7 @@ class GuardedDataFlowNode extends DataFlow::ExprNode {
   private GuardValue v0;
 
   GuardedDataFlowNode() {
-    exists(ControlFlow::Nodes::ElementNode cfn | exists(this.getExprAtNode(cfn)) |
+    exists(ControlFlowNodes::ElementNode cfn | exists(this.getExprAtNode(cfn)) |
       g.controlsNode(cfn, sub0, v0)
     )
   }
@@ -836,7 +817,7 @@ module Internal {
 
   /** Holds if expression `e2` is a `null` value whenever `e1` is. */
   predicate nullValueImpliedUnary(Expr e1, Expr e2) {
-    e1 = e2.(AssignExpr).getRValue()
+    e1 = e2.(AssignExpr).getRightOperand()
     or
     e1 = e2.(Cast).getExpr()
     or
@@ -923,7 +904,7 @@ module Internal {
   /** Holds if expression `e2` is a non-`null` value whenever `e1` is. */
   predicate nonNullValueImpliedUnary(Expr e1, Expr e2) {
     e1 = e2.(CastExpr).getExpr() or
-    e1 = e2.(AssignExpr).getRValue() or
+    e1 = e2.(AssignExpr).getRightOperand() or
     e1 = e2.(NullCoalescingOperation).getAnOperand()
   }
 
@@ -1083,7 +1064,7 @@ module Internal {
       candidateAux(x, d, bb) and
       y =
         any(AccessOrCallExpr e |
-          e.getAControlFlowNode().getBasicBlock() = bb and
+          e.getControlFlowNode().getBasicBlock() = bb and
           e.getTarget() = d
         )
     )
@@ -1115,11 +1096,11 @@ module Internal {
 
     pragma[nomagic]
     private predicate nodeIsGuardedBySameSubExpr0(
-      ControlFlow::Node guardedCfn, BasicBlock guardedBB, AccessOrCallExpr guarded, Guard g,
+      ControlFlowNode guardedCfn, BasicBlock guardedBB, AccessOrCallExpr guarded, Guard g,
       AccessOrCallExpr sub, GuardValue v
     ) {
       Stages::GuardsStage::forceCachingInSameStage() and
-      guardedCfn = guarded.getAControlFlowNode() and
+      guardedCfn = guarded.getControlFlowNode() and
       guardedBB = guardedCfn.getBasicBlock() and
       guardControls(g, guardedBB, v) and
       guardControlsSubSame(g, guardedBB, sub) and
@@ -1128,7 +1109,7 @@ module Internal {
 
     pragma[nomagic]
     private predicate nodeIsGuardedBySameSubExpr(
-      ControlFlow::Node guardedCfn, BasicBlock guardedBB, AccessOrCallExpr guarded, Guard g,
+      ControlFlowNode guardedCfn, BasicBlock guardedBB, AccessOrCallExpr guarded, Guard g,
       AccessOrCallExpr sub, GuardValue v
     ) {
       nodeIsGuardedBySameSubExpr0(guardedCfn, guardedBB, guarded, g, sub, v) and
@@ -1137,8 +1118,8 @@ module Internal {
 
     pragma[nomagic]
     private predicate nodeIsGuardedBySameSubExprSsaDef0(
-      ControlFlow::Node cfn, BasicBlock guardedBB, AccessOrCallExpr guarded, Guard g,
-      ControlFlow::Node subCfn, BasicBlock subCfnBB, AccessOrCallExpr sub, GuardValue v,
+      ControlFlowNode cfn, BasicBlock guardedBB, AccessOrCallExpr guarded, Guard g,
+      ControlFlowNode subCfn, BasicBlock subCfnBB, AccessOrCallExpr sub, GuardValue v,
       Ssa::Definition def
     ) {
       nodeIsGuardedBySameSubExpr(cfn, guardedBB, guarded, g, sub, v) and
@@ -1148,7 +1129,7 @@ module Internal {
 
     pragma[nomagic]
     private predicate nodeIsGuardedBySameSubExprSsaDef(
-      ControlFlow::Node guardedCfn, AccessOrCallExpr guarded, Guard g, ControlFlow::Node subCfn,
+      ControlFlowNode guardedCfn, AccessOrCallExpr guarded, Guard g, ControlFlowNode subCfn,
       AccessOrCallExpr sub, GuardValue v, Ssa::Definition def
     ) {
       exists(BasicBlock guardedBB, BasicBlock subCfnBB |
@@ -1162,15 +1143,13 @@ module Internal {
     private predicate isGuardedByExpr0(
       AccessOrCallExpr guarded, Guard g, AccessOrCallExpr sub, GuardValue v
     ) {
-      forex(ControlFlow::Node cfn | cfn = guarded.getAControlFlowNode() |
-        nodeIsGuardedBySameSubExpr(cfn, _, guarded, g, sub, v)
-      )
+      nodeIsGuardedBySameSubExpr(guarded.getControlFlowNode(), _, guarded, g, sub, v)
     }
 
     cached
     predicate isGuardedByExpr(AccessOrCallExpr guarded, Guard g, AccessOrCallExpr sub, GuardValue v) {
       isGuardedByExpr0(guarded, g, sub, v) and
-      forall(ControlFlow::Node subCfn, Ssa::Definition def |
+      forall(ControlFlowNode subCfn, Ssa::Definition def |
         nodeIsGuardedBySameSubExprSsaDef(_, guarded, g, subCfn, sub, v, def)
       |
         def = guarded.getAnSsaQualifier(_)
@@ -1179,17 +1158,14 @@ module Internal {
 
     cached
     predicate isGuardedByNode(
-      ControlFlow::Nodes::ElementNode guarded, Guard g, AccessOrCallExpr sub, GuardValue v
+      ControlFlowNodes::ElementNode guarded, Guard g, AccessOrCallExpr sub, GuardValue v
     ) {
       nodeIsGuardedBySameSubExpr(guarded, _, _, g, sub, v) and
-      forall(ControlFlow::Node subCfn, Ssa::Definition def |
+      forall(ControlFlowNode subCfn, Ssa::Definition def |
         nodeIsGuardedBySameSubExprSsaDef(guarded, _, g, subCfn, sub, v, def)
       |
         def =
-          guarded
-              .getAstNode()
-              .(AccessOrCallExpr)
-              .getAnSsaQualifier(guarded.getBasicBlock().getANode())
+          guarded.asExpr().(AccessOrCallExpr).getAnSsaQualifier(guarded.getBasicBlock().getANode())
       )
     }
   }

csharp/ql/lib/semmle/code/csharp/controlflow/internal/Completion.qll

@@ -1,896 +0,0 @@
-/**
- * INTERNAL: Do not use.
- *
- * Provides classes representing control flow completions.
- *
- * A completion represents how a statement or expression terminates.
- *
- * There are six kinds of completions: normal completion,
- * `return` completion, `break` completion, `continue` completion,
- * `goto` completion, and `throw` completion.
- *
- * Normal completions are further subdivided into Boolean completions and all
- * other normal completions. A Boolean completion adds the information that the
- * expression terminated with the given boolean value due to a subexpression
- * terminating with the other given Boolean value. This is only relevant for
- * conditional contexts in which the value controls the control-flow successor.
- *
- * Goto successors are further subdivided into label gotos, case gotos, and
- * default gotos.
- */
-
-import csharp
-private import semmle.code.csharp.commons.Assertions
-private import semmle.code.csharp.commons.Constants
-private import semmle.code.csharp.frameworks.System
-private import ControlFlowGraphImpl
-private import NonReturning
-private import SuccessorType
-
-private newtype TCompletion =
-  TSimpleCompletion() or
-  TBooleanCompletion(boolean b) { b = true or b = false } or
-  TNullnessCompletion(boolean isNull) { isNull = true or isNull = false } or
-  TMatchingCompletion(boolean isMatch) { isMatch = true or isMatch = false } or
-  TEmptinessCompletion(boolean isEmpty) { isEmpty = true or isEmpty = false } or
-  TReturnCompletion() or
-  TBreakCompletion() or
-  TContinueCompletion() or
-  TGotoCompletion(string label) { label = any(GotoStmt gs).getLabel() } or
-  TThrowCompletion(ExceptionClass ec) or
-  TExitCompletion() or
-  TNestedCompletion(Completion inner, Completion outer, int nestLevel) {
-    inner = TBreakCompletion() and
-    outer instanceof NonNestedNormalCompletion and
-    nestLevel = 0
-    or
-    inner instanceof NormalCompletion and
-    nestedFinallyCompletion(outer, nestLevel)
-  }
-
-pragma[nomagic]
-private int getAFinallyNestLevel() { result = any(Statements::TryStmtTree t).nestLevel() }
-
-pragma[nomagic]
-private predicate nestedFinallyCompletion(Completion outer, int nestLevel) {
-  (
-    outer = TReturnCompletion()
-    or
-    outer = TBreakCompletion()
-    or
-    outer = TContinueCompletion()
-    or
-    outer = TGotoCompletion(_)
-    or
-    outer = TThrowCompletion(_)
-    or
-    outer = TExitCompletion()
-  ) and
-  nestLevel = getAFinallyNestLevel()
-}
-
-pragma[noinline]
-private predicate completionIsValidForStmt(Stmt s, Completion c) {
-  s instanceof BreakStmt and
-  c = TBreakCompletion()
-  or
-  s instanceof ContinueStmt and
-  c = TContinueCompletion()
-  or
-  s instanceof GotoStmt and
-  c = TGotoCompletion(s.(GotoStmt).getLabel())
-  or
-  s instanceof ReturnStmt and
-  c = TReturnCompletion()
-  or
-  s instanceof YieldBreakStmt and
-  // `yield break` behaves like a return statement
-  c = TReturnCompletion()
-  or
-  mustHaveEmptinessCompletion(s) and
-  c = TEmptinessCompletion(_)
-}
-
-/**
- * A completion of a statement or an expression.
- */
-abstract class Completion extends TCompletion {
-  /**
-   * Holds if this completion is valid for control flow element `cfe`.
-   *
-   * If `cfe` is part of a `try` statement and `cfe` may throw an exception, this
-   * completion can be a throw completion.
-   *
-   * If `cfe` is used in a Boolean context, this completion is a Boolean completion,
-   * otherwise it is a normal non-Boolean completion.
-   */
-  predicate isValidFor(ControlFlowElement cfe) {
-    this = cfe.(NonReturningCall).getACompletion()
-    or
-    this = TThrowCompletion(cfe.(TriedControlFlowElement).getAThrownException())
-    or
-    cfe instanceof ThrowElement and
-    this = TThrowCompletion(cfe.(ThrowElement).getThrownExceptionType())
-    or
-    this = assertionCompletion(cfe, _)
-    or
-    completionIsValidForStmt(cfe, this)
-    or
-    mustHaveBooleanCompletion(cfe) and
-    (
-      exists(boolean value | isBooleanConstant(cfe, value) | this = TBooleanCompletion(value))
-      or
-      not isBooleanConstant(cfe, _) and
-      this = TBooleanCompletion(_)
-      or
-      // Corner case: In `if (x ?? y) { ... }`, `x` must have both a `true`
-      // completion, a `false` completion, and a `null` completion (but not a
-      // non-`null` completion)
-      mustHaveNullnessCompletion(cfe) and
-      this = TNullnessCompletion(true)
-    )
-    or
-    mustHaveNullnessCompletion(cfe) and
-    not mustHaveBooleanCompletion(cfe) and
-    (
-      exists(boolean value | isNullnessConstant(cfe, value) | this = TNullnessCompletion(value))
-      or
-      not isNullnessConstant(cfe, _) and
-      this = TNullnessCompletion(_)
-    )
-    or
-    mustHaveMatchingCompletion(cfe) and
-    (
-      exists(boolean value | isMatchingConstant(cfe, value) | this = TMatchingCompletion(value))
-      or
-      not isMatchingConstant(cfe, _) and
-      this = TMatchingCompletion(_)
-    )
-    or
-    not cfe instanceof NonReturningCall and
-    not cfe instanceof ThrowElement and
-    not cfe instanceof BreakStmt and
-    not cfe instanceof ContinueStmt and
-    not cfe instanceof GotoStmt and
-    not cfe instanceof ReturnStmt and
-    not cfe instanceof YieldBreakStmt and
-    not mustHaveBooleanCompletion(cfe) and
-    not mustHaveNullnessCompletion(cfe) and
-    not mustHaveMatchingCompletion(cfe) and
-    not mustHaveEmptinessCompletion(cfe) and
-    this = TSimpleCompletion()
-  }
-
-  /**
-   * Holds if this completion will continue a loop when it is the completion
-   * of a loop body.
-   */
-  predicate continuesLoop() {
-    this instanceof NormalCompletion or
-    this instanceof ContinueCompletion
-  }
-
-  /**
-   * Gets the inner completion. This is either the inner completion,
-   * when the completion is nested, or the completion itself.
-   */
-  Completion getInnerCompletion() { result = this }
-
-  /**
-   * Gets the outer completion. This is either the outer completion,
-   * when the completion is nested, or the completion itself.
-   */
-  Completion getOuterCompletion() { result = this }
-
-  /** Gets a successor type that matches this completion. */
-  abstract SuccessorType getAMatchingSuccessorType();
-
-  /** Gets a textual representation of this completion. */
-  abstract string toString();
-}
-
-/** Holds if expression `e` has the Boolean constant value `value`. */
-private predicate isBooleanConstant(Expr e, boolean value) {
-  mustHaveBooleanCompletion(e) and
-  (
-    e.getValue() = "true" and
-    value = true
-    or
-    e.getValue() = "false" and
-    value = false
-    or
-    isConstantComparison(e, value)
-    or
-    exists(Method m, Call c, Expr expr |
-      m = any(SystemStringClass s).getIsNullOrEmptyMethod() and
-      c.getTarget() = m and
-      e = c and
-      expr = c.getArgument(0) and
-      expr.hasValue() and
-      if expr.getValue().length() > 0 and not expr instanceof NullLiteral
-      then value = false
-      else value = true
-    )
-  )
-}
-
-/**
- * Holds if expression `e` is constantly `null` (`value = true`) or constantly
- * non-`null` (`value = false`).
- */
-private predicate isNullnessConstant(Expr e, boolean value) {
-  mustHaveNullnessCompletion(e) and
-  exists(Expr stripped | stripped = e.stripCasts() |
-    stripped.getType() =
-      any(ValueType t |
-        not t instanceof NullableType and
-        // Extractor bug: the type of `x?.Length` is reported as `int`, but it should
-        // be `int?`
-        not getQualifier*(stripped).(QualifiableExpr).isConditional()
-      ) and
-    value = false
-    or
-    stripped instanceof NullLiteral and
-    value = true
-    or
-    stripped.hasValue() and
-    not stripped instanceof NullLiteral and
-    value = false
-  )
-}
-
-private Expr getQualifier(QualifiableExpr e) {
-  // `e.getQualifier()` does not work for calls to extension methods
-  result = e.getChildExpr(-1)
-}
-
-pragma[noinline]
-private predicate typePatternMustHaveMatchingCompletion(
-  TypePatternExpr tpe, Type t, Type strippedType
-) {
-  exists(Expr e, Expr stripped | mustHaveMatchingCompletion(e, tpe) |
-    stripped = e.stripCasts() and
-    t = tpe.getCheckedType() and
-    strippedType = stripped.getType() and
-    not t.containsTypeParameters() and
-    not strippedType.containsTypeParameters()
-  )
-}
-
-pragma[noinline]
-private Type typePatternCommonSubTypeLeft(Type t) {
-  typePatternMustHaveMatchingCompletion(_, t, _) and
-  result.isImplicitlyConvertibleTo(t) and
-  not result instanceof DynamicType
-}
-
-pragma[noinline]
-private Type typePatternCommonSubTypeRight(Type strippedType) {
-  typePatternMustHaveMatchingCompletion(_, _, strippedType) and
-  result.isImplicitlyConvertibleTo(strippedType) and
-  not result instanceof DynamicType
-}
-
-pragma[noinline]
-private predicate typePatternCommonSubType(Type t, Type strippedType) {
-  typePatternCommonSubTypeLeft(t) = typePatternCommonSubTypeRight(strippedType)
-}
-
-/**
- * Holds if pattern expression `pe` constantly matches (`value = true`) or
- * constantly non-matches (`value = false`).
- */
-private predicate isMatchingConstant(PatternExpr pe, boolean value) {
-  exists(Expr e, string exprValue, string patternValue |
-    mustHaveMatchingCompletion(e, pe) and
-    exprValue = e.stripCasts().getValue() and
-    patternValue = pe.getValue() and
-    if exprValue = patternValue then value = true else value = false
-  )
-  or
-  pe instanceof DiscardPatternExpr and
-  value = true
-  or
-  exists(Type t, Type strippedType |
-    not t instanceof UnknownType and
-    not strippedType instanceof UnknownType and
-    typePatternMustHaveMatchingCompletion(pe, t, strippedType) and
-    not typePatternCommonSubType(t, strippedType) and
-    value = false
-  )
-}
-
-private class Overflowable extends UnaryOperation {
-  Overflowable() {
-    not this instanceof UnaryBitwiseOperation and
-    this.getType() instanceof IntegralType
-  }
-}
-
-/** A control flow element that is inside a `try` block. */
-private class TriedControlFlowElement extends ControlFlowElement {
-  TriedControlFlowElement() {
-    this = any(TryStmt try).getATriedElement() and
-    not this instanceof NonReturningCall
-  }
-
-  /**
-   * Gets an exception class that is potentially thrown by this element, if any.
-   */
-  Class getAThrownException() {
-    this instanceof Overflowable and
-    result instanceof SystemOverflowExceptionClass
-    or
-    this.(CastExpr).getType() instanceof IntegralType and
-    result instanceof SystemOverflowExceptionClass
-    or
-    invalidCastCandidate(this) and
-    result instanceof SystemInvalidCastExceptionClass
-    or
-    this instanceof Call and
-    result instanceof SystemExceptionClass
-    or
-    this =
-      any(MemberAccess ma |
-        not ma.isConditional() and
-        ma.getQualifier() = any(Expr e | not e instanceof TypeAccess) and
-        result instanceof SystemNullReferenceExceptionClass
-      )
-    or
-    this instanceof DelegateCreation and
-    result instanceof SystemOutOfMemoryExceptionClass
-    or
-    this instanceof ArrayCreation and
-    result instanceof SystemOutOfMemoryExceptionClass
-    or
-    this =
-      any(AddOperation ae |
-        ae.getType() instanceof StringType and
-        result instanceof SystemOutOfMemoryExceptionClass
-        or
-        ae.getType() instanceof IntegralType and
-        result instanceof SystemOverflowExceptionClass
-      )
-    or
-    this =
-      any(SubOperation se |
-        se.getType() instanceof IntegralType and
-        result instanceof SystemOverflowExceptionClass
-      )
-    or
-    this =
-      any(MulOperation me |
-        me.getType() instanceof IntegralType and
-        result instanceof SystemOverflowExceptionClass
-      )
-    or
-    this =
-      any(DivOperation de |
-        not de.getDenominator().getValue().toFloat() != 0 and
-        result instanceof SystemDivideByZeroExceptionClass
-      )
-    or
-    this instanceof RemOperation and
-    result instanceof SystemDivideByZeroExceptionClass
-    or
-    this instanceof DynamicExpr and
-    result instanceof SystemExceptionClass
-  }
-}
-
-pragma[nomagic]
-private ValueOrRefType getACastExprBaseType(CastExpr ce) {
-  result = ce.getType().(ValueOrRefType).getABaseType()
-  or
-  result = getACastExprBaseType(ce).getABaseType()
-}
-
-pragma[nomagic]
-private predicate invalidCastCandidate(CastExpr ce) {
-  ce.getExpr().getType() = getACastExprBaseType(ce)
-}
-
-/** Gets a valid completion when argument `i` fails in assertion `a`. */
-Completion assertionCompletion(Assertion a, int i) {
-  exists(AssertMethod am | am = a.getAssertMethod() |
-    if am.getAssertionFailure(i).isExit()
-    then result = TExitCompletion()
-    else
-      exists(Class c |
-        am.getAssertionFailure(i).isException(c) and
-        result = TThrowCompletion(c)
-      )
-  )
-}
-
-/**
- * Holds if a normal completion of `e` must be a Boolean completion.
- */
-private predicate mustHaveBooleanCompletion(Expr e) {
-  inBooleanContext(e) and
-  not e instanceof NonReturningCall
-}
-
-/**
- * Holds if `e` is used in a Boolean context. That is, whether the value
- * that `e` evaluates to determines a true/false branch successor.
- */
-private predicate inBooleanContext(Expr e) {
-  e = any(IfStmt is).getCondition()
-  or
-  e = any(LoopStmt ls).getCondition()
-  or
-  e = any(Case c).getCondition()
-  or
-  e = any(SpecificCatchClause scc).getFilterClause()
-  or
-  e = any(LogicalNotExpr lne | inBooleanContext(lne)).getAnOperand()
-  or
-  exists(LogicalAndExpr lae |
-    lae.getLeftOperand() = e
-    or
-    inBooleanContext(lae) and
-    lae.getRightOperand() = e
-  )
-  or
-  exists(LogicalOrExpr lae |
-    lae.getLeftOperand() = e
-    or
-    inBooleanContext(lae) and
-    lae.getRightOperand() = e
-  )
-  or
-  exists(ConditionalExpr ce |
-    ce.getCondition() = e
-    or
-    inBooleanContext(ce) and
-    e in [ce.getThen(), ce.getElse()]
-  )
-  or
-  e = any(NullCoalescingOperation nce | inBooleanContext(nce)).getAnOperand()
-  or
-  e = any(SwitchExpr se | inBooleanContext(se)).getACase()
-  or
-  e = any(SwitchCaseExpr sce | inBooleanContext(sce)).getBody()
-}
-
-/**
- * Holds if a normal completion of `e` must be a nullness completion.
- */
-private predicate mustHaveNullnessCompletion(Expr e) {
-  inNullnessContext(e) and
-  not e instanceof NonReturningCall
-}
-
-/**
- * Holds if `e` is used in a nullness context. That is, whether the value
- * that `e` evaluates to determines a `null`/non-`null` branch successor.
- */
-private predicate inNullnessContext(Expr e) {
-  e = any(NullCoalescingOperation nce).getLeftOperand()
-  or
-  exists(QualifiableExpr qe | qe.isConditional() | e = qe.getChildExpr(-1))
-  or
-  exists(ConditionalExpr ce | inNullnessContext(ce) | (e = ce.getThen() or e = ce.getElse()))
-  or
-  exists(NullCoalescingOperation nce | inNullnessContext(nce) | e = nce.getRightOperand())
-  or
-  e = any(SwitchExpr se | inNullnessContext(se)).getACase()
-  or
-  e = any(SwitchCaseExpr sce | inNullnessContext(sce)).getBody()
-}
-
-/**
- * Holds if `pe` is the pattern inside case `c`, belonging to `switch` `s`, that
- * has the matching completion.
- */
-predicate switchMatching(Switch s, Case c, PatternExpr pe) {
-  s.getACase() = c and
-  pe = c.getPattern()
-}
-
-/**
- * Holds if a normal completion of `cfe` must be a matching completion. Thats is,
- * whether `cfe` determines a match in a `switch/if` statement or `catch` clause.
- */
-private predicate mustHaveMatchingCompletion(ControlFlowElement cfe) {
-  switchMatching(_, _, cfe)
-  or
-  cfe instanceof SpecificCatchClause
-  or
-  cfe = any(IsExpr ie | inBooleanContext(ie)).getPattern()
-  or
-  cfe = any(RecursivePatternExpr rpe).getAChildExpr()
-  or
-  cfe = any(PositionalPatternExpr ppe).getPattern(_)
-  or
-  cfe = any(PropertyPatternExpr ppe).getPattern(_)
-  or
-  cfe = any(UnaryPatternExpr upe | mustHaveMatchingCompletion(upe)).getPattern()
-  or
-  cfe = any(BinaryPatternExpr bpe).getAnOperand()
-}
-
-/**
- * Holds if `pe` must have a matching completion, and `e` is the expression
- * that is being matched.
- */
-private predicate mustHaveMatchingCompletion(Expr e, PatternExpr pe) {
-  exists(Switch s |
-    switchMatching(s, _, pe) and
-    e = s.getExpr()
-  )
-  or
-  e = any(IsExpr ie | pe = ie.getPattern()).getExpr() and
-  mustHaveMatchingCompletion(pe)
-  or
-  exists(PatternExpr mid | mustHaveMatchingCompletion(e, mid) |
-    pe = mid.(UnaryPatternExpr).getPattern()
-    or
-    pe = mid.(RecursivePatternExpr).getAChildExpr()
-    or
-    pe = mid.(BinaryPatternExpr).getAnOperand()
-  )
-}
-
-/**
- * Holds if `cfe` is the element inside foreach statement `fs` that has the emptiness
- * completion.
- */
-predicate foreachEmptiness(ForeachStmt fs, ControlFlowElement cfe) {
-  cfe = fs // use `foreach` statement itself to represent the emptiness test
-}
-
-/**
- * Holds if a normal completion of `cfe` must be an emptiness completion. Thats is,
- * whether `cfe` determines whether to execute the body of a `foreach` statement.
- */
-private predicate mustHaveEmptinessCompletion(ControlFlowElement cfe) { foreachEmptiness(_, cfe) }
-
-/**
- * A completion that represents normal evaluation of a statement or an
- * expression.
- */
-abstract class NormalCompletion extends Completion { }
-
-abstract private class NonNestedNormalCompletion extends NormalCompletion { }
-
-/** A simple (normal) completion. */
-class SimpleCompletion extends NonNestedNormalCompletion, TSimpleCompletion {
-  override DirectSuccessor getAMatchingSuccessorType() { any() }
-
-  override string toString() { result = "normal" }
-}
-
-/**
- * A completion that represents evaluation of an expression, whose value determines
- * the successor. Either a Boolean completion (`BooleanCompletion`), a nullness
- * completion (`NullnessCompletion`), a matching completion (`MatchingCompletion`),
- * or an emptiness completion (`EmptinessCompletion`).
- */
-abstract class ConditionalCompletion extends NonNestedNormalCompletion {
-  /** Gets the Boolean value of this completion. */
-  abstract boolean getValue();
-
-  /** Gets the dual completion. */
-  abstract ConditionalCompletion getDual();
-}
-
-/**
- * A completion that represents evaluation of an expression
- * with a Boolean value.
- */
-class BooleanCompletion extends ConditionalCompletion {
-  private boolean value;
-
-  BooleanCompletion() { this = TBooleanCompletion(value) }
-
-  override boolean getValue() { result = value }
-
-  override BooleanCompletion getDual() { result = TBooleanCompletion(value.booleanNot()) }
-
-  override BooleanSuccessor getAMatchingSuccessorType() { result.getValue() = value }
-
-  override string toString() { result = value.toString() }
-}
-
-/** A Boolean `true` completion. */
-class TrueCompletion extends BooleanCompletion {
-  TrueCompletion() { this.getValue() = true }
-}
-
-/** A Boolean `false` completion. */
-class FalseCompletion extends BooleanCompletion {
-  FalseCompletion() { this.getValue() = false }
-}
-
-/**
- * A completion that represents evaluation of an expression that is either
- * `null` or non-`null`.
- */
-class NullnessCompletion extends ConditionalCompletion, TNullnessCompletion {
-  private boolean value;
-
-  NullnessCompletion() { this = TNullnessCompletion(value) }
-
-  /** Holds if the last sub expression of this expression evaluates to `null`. */
-  predicate isNull() { value = true }
-
-  /** Holds if the last sub expression of this expression evaluates to a non-`null` value. */
-  predicate isNonNull() { value = false }
-
-  override boolean getValue() { result = value }
-
-  override NullnessCompletion getDual() { result = TNullnessCompletion(value.booleanNot()) }
-
-  override NullnessSuccessor getAMatchingSuccessorType() { result.getValue() = value }
-
-  override string toString() { if this.isNull() then result = "null" else result = "non-null" }
-}
-
-/**
- * A completion that represents matching, for example a `case` statement in a
- * `switch` statement.
- */
-class MatchingCompletion extends ConditionalCompletion, TMatchingCompletion {
-  private boolean value;
-
-  MatchingCompletion() { this = TMatchingCompletion(value) }
-
-  /** Holds if there is a match. */
-  predicate isMatch() { value = true }
-
-  /** Holds if there is not a match. */
-  predicate isNonMatch() { value = false }
-
-  override boolean getValue() { result = value }
-
-  override MatchingCompletion getDual() { result = TMatchingCompletion(value.booleanNot()) }
-
-  override MatchingSuccessor getAMatchingSuccessorType() { result.getValue() = value }
-
-  override string toString() { if this.isMatch() then result = "match" else result = "no-match" }
-}
-
-/**
- * A completion that represents evaluation of an emptiness test, for example
- * a test in a `foreach` statement.
- */
-class EmptinessCompletion extends ConditionalCompletion, TEmptinessCompletion {
-  private boolean value;
-
-  EmptinessCompletion() { this = TEmptinessCompletion(value) }
-
-  /** Holds if the emptiness test evaluates to `true`. */
-  predicate isEmpty() { value = true }
-
-  override boolean getValue() { result = value }
-
-  override EmptinessCompletion getDual() { result = TEmptinessCompletion(value.booleanNot()) }
-
-  override EmptinessSuccessor getAMatchingSuccessorType() { result.getValue() = value }
-
-  override string toString() { if this.isEmpty() then result = "empty" else result = "non-empty" }
-}
-
-/**
- * A nested completion. For example, in
- *
- * ```csharp
- * void M(bool b1, bool b2)
- * {
- *     try
- *     {
- *         if (b1)
- *            throw new Exception();
- *     }
- *     finally
- *     {
- *         if (b2)
- *             System.Console.WriteLine("M called");
- *     }
- * }
- * ```
- *
- * `b2` has an outer throw completion (inherited from `throw new Exception`)
- * and an inner `false` completion. `b2` also has a (normal) `true` completion.
- */
-class NestedCompletion extends Completion, TNestedCompletion {
-  Completion inner;
-  Completion outer;
-  int nestLevel;
-
-  NestedCompletion() { this = TNestedCompletion(inner, outer, nestLevel) }
-
-  /** Gets a completion that is compatible with the inner completion. */
-  Completion getAnInnerCompatibleCompletion() {
-    result.getOuterCompletion() = this.getInnerCompletion()
-  }
-
-  /** Gets the level of this nested completion. */
-  int getNestLevel() { result = nestLevel }
-
-  override Completion getInnerCompletion() { result = inner }
-
-  override Completion getOuterCompletion() { result = outer }
-
-  override SuccessorType getAMatchingSuccessorType() { none() }
-
-  override string toString() { result = outer + " [" + inner + "] (" + nestLevel + ")" }
-}
-
-/**
- * A nested completion for a loop that exists with a `break`.
- *
- * This completion is added for technical reasons only: when a loop
- * body can complete with a break completion, the loop itself completes
- * normally. However, if we choose `TSimpleCompletion` as the completion
- * of the loop, we lose the information that the last element actually
- * completed with a break, meaning that the control flow edge out of the
- * breaking node cannot be marked with a `break` label.
- *
- * Example:
- *
- * ```csharp
- * while (...) {
- *    ...
- *    break;
- * }
- * return;
- * ```
- *
- * The `break` on line 3 completes with a `TBreakCompletion`, therefore
- * the `while` loop can complete with a `NestedBreakCompletion`, so we
- * get an edge `break --break--> return`. (If we instead used a
- * `TSimpleCompletion`, we would get a less precise edge
- * `break --normal--> return`.)
- */
-class NestedBreakCompletion extends NormalCompletion, NestedCompletion {
-  NestedBreakCompletion() {
-    inner = TBreakCompletion() and
-    outer instanceof NonNestedNormalCompletion
-  }
-
-  override BreakCompletion getInnerCompletion() { result = inner }
-
-  override NonNestedNormalCompletion getOuterCompletion() { result = outer }
-
-  override Completion getAnInnerCompatibleCompletion() {
-    result = inner and
-    outer = TSimpleCompletion()
-    or
-    result = TNestedCompletion(outer, inner, _)
-  }
-
-  override SuccessorType getAMatchingSuccessorType() {
-    outer instanceof SimpleCompletion and
-    result instanceof BreakSuccessor
-    or
-    result = outer.(ConditionalCompletion).getAMatchingSuccessorType()
-  }
-}
-
-/**
- * A completion that represents evaluation of a statement or an
- * expression resulting in a return from a callable.
- */
-class ReturnCompletion extends Completion {
-  ReturnCompletion() {
-    this = TReturnCompletion() or
-    this = TNestedCompletion(_, TReturnCompletion(), _)
-  }
-
-  override ReturnSuccessor getAMatchingSuccessorType() { any() }
-
-  override string toString() {
-    // `NestedCompletion` defines `toString()` for the other case
-    this = TReturnCompletion() and result = "return"
-  }
-}
-
-/**
- * A completion that represents evaluation of a statement or an
- * expression resulting in a break (in a loop or in a `switch`
- * statement).
- */
-class BreakCompletion extends Completion {
-  BreakCompletion() {
-    this = TBreakCompletion() or
-    this = TNestedCompletion(_, TBreakCompletion(), _)
-  }
-
-  override BreakSuccessor getAMatchingSuccessorType() { any() }
-
-  override string toString() {
-    // `NestedCompletion` defines `toString()` for the other case
-    this = TBreakCompletion() and result = "break"
-  }
-}
-
-/**
- * A completion that represents evaluation of a statement or an
- * expression resulting in a loop continuation (a `continue`
- * statement).
- */
-class ContinueCompletion extends Completion {
-  ContinueCompletion() {
-    this = TContinueCompletion() or
-    this = TNestedCompletion(_, TContinueCompletion(), _)
-  }
-
-  override ContinueSuccessor getAMatchingSuccessorType() { any() }
-
-  override string toString() {
-    // `NestedCompletion` defines `toString()` for the other case
-    this = TContinueCompletion() and result = "continue"
-  }
-}
-
-/**
- * A completion that represents evaluation of a statement or an
- * expression resulting in a `goto` jump.
- */
-class GotoCompletion extends Completion {
-  private string label;
-
-  GotoCompletion() {
-    this = TGotoCompletion(label) or
-    this = TNestedCompletion(_, TGotoCompletion(label), _)
-  }
-
-  /** Gets the label of the `goto` completion. */
-  string getLabel() { result = label }
-
-  override GotoSuccessor getAMatchingSuccessorType() { any() }
-
-  override string toString() {
-    // `NestedCompletion` defines `toString()` for the other case
-    this = TGotoCompletion(label) and result = "goto(" + label + ")"
-  }
-}
-
-/**
- * A completion that represents evaluation of a statement or an
- * expression resulting in a thrown exception.
- */
-class ThrowCompletion extends Completion {
-  private ExceptionClass ec;
-
-  ThrowCompletion() {
-    this = TThrowCompletion(ec) or
-    this = TNestedCompletion(_, TThrowCompletion(ec), _)
-  }
-
-  /** Gets the type of the exception being thrown. */
-  ExceptionClass getExceptionClass() { result = ec }
-
-  override ExceptionSuccessor getAMatchingSuccessorType() { any() }
-
-  override string toString() {
-    // `NestedCompletion` defines `toString()` for the other case
-    this = TThrowCompletion(ec) and result = "throw(" + ec + ")"
-  }
-}
-
-/**
- * A completion that represents evaluation of a statement or an
- * expression resulting in a program exit, for example
- * `System.Environment.Exit(0)`.
- *
- * An exit completion is different from a `return` completion; the former
- * exits the whole application, and exists inside `try` statements skip
- * `finally` blocks.
- */
-class ExitCompletion extends Completion {
-  ExitCompletion() {
-    this = TExitCompletion() or
-    this = TNestedCompletion(_, TExitCompletion(), _)
-  }
-
-  override ExitSuccessor getAMatchingSuccessorType() { any() }
-
-  override string toString() {
-    // `NestedCompletion` defines `toString()` for the other case
-    this = TExitCompletion() and result = "exit"
-  }
-}

csharp/ql/lib/semmle/code/csharp/controlflow/internal/NonReturning.qll

@@ -9,13 +9,9 @@ import csharp
 private import semmle.code.csharp.ExprOrStmtParent
 private import semmle.code.csharp.commons.Assertions
 private import semmle.code.csharp.frameworks.System
-private import Completion
 
 /** A call that definitely does not return (conservative analysis). */
-abstract class NonReturningCall extends Call {
-  /** Gets a valid completion for this non-returning call. */
-  abstract Completion getACompletion();
-}
+abstract class NonReturningCall extends Call { }
 
 private class ExitingCall extends NonReturningCall {
   ExitingCall() {
@@ -23,36 +19,21 @@ private class ExitingCall extends NonReturningCall {
     or
     this = any(FailingAssertion fa | fa.getAssertionFailure().isExit())
   }
-
-  override ExitCompletion getACompletion() { not result instanceof NestedCompletion }
 }
 
 private class ThrowingCall extends NonReturningCall {
-  private ThrowCompletion c;
-
   ThrowingCall() {
-    not c instanceof NestedCompletion and
-    (
-      c = this.getTarget().(ThrowingCallable).getACallCompletion()
-      or
-      this.(FailingAssertion).getAssertionFailure().isException(c.getExceptionClass())
-      or
-      this =
-        any(MethodCall mc |
-          mc.getTarget()
-              .hasFullyQualifiedName("System.Runtime.ExceptionServices", "ExceptionDispatchInfo",
-                "Throw") and
-          (
-            mc.hasNoArguments() and
-            c.getExceptionClass() instanceof SystemExceptionClass
-            or
-            c.getExceptionClass() = mc.getArgument(0).getType()
-          )
-        )
-    )
+    this.getTarget() instanceof ThrowingCallable
+    or
+    this.(FailingAssertion).getAssertionFailure().isException(_)
+    or
+    this =
+      any(MethodCall mc |
+        mc.getTarget()
+            .hasFullyQualifiedName("System.Runtime.ExceptionServices", "ExceptionDispatchInfo",
+              "Throw")
+      )
   }
-
-  override ThrowCompletion getACompletion() { result = c }
 }
 
 /** Holds if accessor `a` has an auto-implementation. */
@@ -107,44 +88,35 @@ private Stmt getAnExitingStmt() {
 
 private class ThrowingCallable extends NonReturningCallable {
   ThrowingCallable() {
-    forex(ControlFlowElement body | body = this.getBody() | body = getAThrowingElement(_))
+    forex(ControlFlowElement body | body = this.getBody() | body = getAThrowingElement())
   }
-
-  /** Gets a valid completion for a call to this throwing callable. */
-  ThrowCompletion getACallCompletion() { this.getBody() = getAThrowingElement(result) }
 }
 
-private predicate directlyThrows(ThrowElement te, ThrowCompletion c) {
-  c.getExceptionClass() = te.getThrownExceptionType() and
-  not c instanceof NestedCompletion and
+private predicate directlyThrows(ThrowElement te) {
   // For stub implementations, there may exist proper implementations that are not seen
   // during compilation, so we conservatively rule those out
   not isStub(te)
 }
 
-private ControlFlowElement getAThrowingElement(ThrowCompletion c) {
-  c = result.(ThrowingCall).getACompletion()
+private ControlFlowElement getAThrowingElement() {
+  result instanceof ThrowingCall
   or
-  directlyThrows(result, c)
+  directlyThrows(result)
   or
-  result = getAThrowingStmt(c)
+  result = getAThrowingStmt()
 }
 
-private Stmt getAThrowingStmt(ThrowCompletion c) {
-  directlyThrows(result, c)
+private Stmt getAThrowingStmt() {
+  directlyThrows(result)
   or
-  result.(ExprStmt).getExpr() = getAThrowingElement(c)
+  result.(ExprStmt).getExpr() = getAThrowingElement()
   or
-  result.(BlockStmt).getFirstStmt() = getAThrowingStmt(c)
+  result.(BlockStmt).getFirstStmt() = getAThrowingStmt()
   or
-  exists(IfStmt ifStmt, ThrowCompletion c1, ThrowCompletion c2 |
+  exists(IfStmt ifStmt |
     result = ifStmt and
-    ifStmt.getThen() = getAThrowingStmt(c1) and
-    ifStmt.getElse() = getAThrowingStmt(c2)
-  |
-    c = c1
-    or
-    c = c2
+    ifStmt.getThen() = getAThrowingStmt() and
+    ifStmt.getElse() = getAThrowingStmt()
   )
 }
 

csharp/ql/lib/semmle/code/csharp/controlflow/internal/Splitting.qll

@@ -1,124 +0,0 @@
-/**
- * INTERNAL: Do not use.
- *
- * Provides classes and predicates relevant for splitting the control flow graph.
- */
-
-import csharp
-private import Completion as Comp
-private import Comp
-private import ControlFlowGraphImpl
-private import semmle.code.csharp.controlflow.ControlFlowGraph::ControlFlow as Cfg
-
-cached
-private module Cached {
-  private import semmle.code.csharp.Caching
-
-  cached
-  newtype TSplitKind = TConditionalCompletionSplitKind()
-
-  cached
-  newtype TSplit = TConditionalCompletionSplit(ConditionalCompletion c)
-}
-
-import Cached
-
-/**
- * A split for a control flow element. For example, a tag that determines how to
- * continue execution after leaving a `finally` block.
- */
-class Split extends TSplit {
-  /** Gets a textual representation of this split. */
-  string toString() { none() }
-}
-
-module ConditionalCompletionSplitting {
-  /**
-   * A split for conditional completions. For example, in
-   *
-   * ```csharp
-   * void M(int i)
-   * {
-   *     if (x && !y)
-   *         System.Console.WriteLine("true")
-   * }
-   * ```
-   *
-   * we record whether `x`, `y`, and `!y` evaluate to `true` or `false`, and restrict
-   * the edges out of `!y` and `x && !y` accordingly.
-   */
-  class ConditionalCompletionSplit extends Split, TConditionalCompletionSplit {
-    ConditionalCompletion completion;
-
-    ConditionalCompletionSplit() { this = TConditionalCompletionSplit(completion) }
-
-    ConditionalCompletion getCompletion() { result = completion }
-
-    override string toString() { result = completion.toString() }
-  }
-
-  private class ConditionalCompletionSplitKind_ extends SplitKind, TConditionalCompletionSplitKind {
-    override int getListOrder() { result = 0 }
-
-    override predicate isEnabled(AstNode cfe) { this.appliesTo(cfe) }
-
-    override string toString() { result = "ConditionalCompletion" }
-  }
-
-  module ConditionalCompletionSplittingInput {
-    private import Completion as Comp
-
-    class ConditionalCompletion = Comp::ConditionalCompletion;
-
-    class ConditionalCompletionSplitKind extends ConditionalCompletionSplitKind_, TSplitKind { }
-
-    class ConditionalCompletionSplit = ConditionalCompletionSplitting::ConditionalCompletionSplit;
-
-    bindingset[parent, parentCompletion]
-    predicate condPropagateExpr(
-      AstNode parent, ConditionalCompletion parentCompletion, AstNode child,
-      ConditionalCompletion childCompletion
-    ) {
-      child = parent.(LogicalNotExpr).getOperand() and
-      childCompletion.getDual() = parentCompletion
-      or
-      childCompletion = parentCompletion and
-      (
-        child = parent.(LogicalAndExpr).getAnOperand()
-        or
-        child = parent.(LogicalOrExpr).getAnOperand()
-        or
-        parent = any(ConditionalExpr ce | child = [ce.getThen(), ce.getElse()])
-        or
-        child = parent.(SwitchExpr).getACase()
-        or
-        child = parent.(SwitchCaseExpr).getBody()
-        or
-        parent =
-          any(NullCoalescingOperation nce |
-            if childCompletion instanceof NullnessCompletion
-            then child = nce.getRightOperand()
-            else child = nce.getAnOperand()
-          )
-      )
-      or
-      child = parent.(NotPatternExpr).getPattern() and
-      childCompletion.getDual() = parentCompletion
-      or
-      child = parent.(IsExpr).getPattern() and
-      parentCompletion.(BooleanCompletion).getValue() =
-        childCompletion.(MatchingCompletion).getValue()
-      or
-      childCompletion = parentCompletion and
-      (
-        child = parent.(AndPatternExpr).getAnOperand()
-        or
-        child = parent.(OrPatternExpr).getAnOperand()
-        or
-        child = parent.(RecursivePatternExpr).getAChildExpr()
-        or
-        child = parent.(PropertyPatternExpr).getPattern(_)
-      )
-    }
-  }
-}

csharp/ql/lib/semmle/code/csharp/dataflow/Nullness.qll

@@ -31,7 +31,7 @@ private Expr maybeNullExpr(Expr reason) {
   or
   result instanceof AsExpr and reason = result
   or
-  result.(AssignExpr).getRValue() = maybeNullExpr(reason)
+  result.(AssignExpr).getRightOperand() = maybeNullExpr(reason)
   or
   result.(CastExpr).getExpr() = maybeNullExpr(reason)
   or
@@ -126,7 +126,7 @@ private predicate nonNullDef(Ssa::ExplicitDefinition def) {
 /**
  * Holds if `node` is a dereference `d` of SSA definition `def`.
  */
-private predicate dereferenceAt(ControlFlow::Node node, Ssa::Definition def, Dereference d) {
+private predicate dereferenceAt(ControlFlowNode node, Ssa::Definition def, Dereference d) {
   d = def.getAReadAtNode(node)
 }
 
@@ -192,9 +192,7 @@ private predicate isNullDefaultArgument(Ssa::ImplicitParameterDefinition def, Al
 }
 
 /** Holds if `def` is an SSA definition that may be `null`. */
-private predicate defMaybeNull(
-  Ssa::Definition def, ControlFlow::Node node, string msg, Element reason
-) {
+private predicate defMaybeNull(Ssa::Definition def, ControlFlowNode node, string msg, Element reason) {
   not nonNullDef(def) and
   (
     // A variable compared to `null` might be `null`
@@ -224,7 +222,7 @@ private predicate defMaybeNull(
     or
     // If the source of a variable is `null` then the variable may be `null`
     exists(AssignableDefinition adef | adef = def.(Ssa::ExplicitDefinition).getADefinition() |
-      adef.getSource() = maybeNullExpr(node.getAstNode()) and
+      adef.getSource() = maybeNullExpr(node.asExpr()) and
       reason = adef.getExpr() and
       msg = "because of $@ assignment"
     )
@@ -256,19 +254,19 @@ private Ssa::Definition getAnUltimateDefinition(Ssa::Definition def) {
  * through an intermediate dereference that always throws a null reference
  * exception.
  */
-private predicate defReaches(Ssa::Definition def, ControlFlow::Node cfn) {
+private predicate defReaches(Ssa::Definition def, ControlFlowNode cfn) {
   exists(def.getAFirstReadAtNode(cfn))
   or
-  exists(ControlFlow::Node mid | defReaches(def, mid) |
+  exists(ControlFlowNode mid | defReaches(def, mid) |
     SsaImpl::adjacentReadPairSameVar(_, mid, cfn) and
-    not mid = any(Dereference d | d.isAlwaysNull(def.getSourceVariable())).getAControlFlowNode()
+    not mid = any(Dereference d | d.isAlwaysNull(def.getSourceVariable())).getControlFlowNode()
   )
 }
 
 private module NullnessConfig implements ControlFlowReachability::ConfigSig {
-  predicate source(ControlFlow::Node node, Ssa::Definition def) { defMaybeNull(def, node, _, _) }
+  predicate source(ControlFlowNode node, Ssa::Definition def) { defMaybeNull(def, node, _, _) }
 
-  predicate sink(ControlFlow::Node node, Ssa::Definition def) {
+  predicate sink(ControlFlowNode node, Ssa::Definition def) {
     exists(Dereference d |
       dereferenceAt(node, def, d) and
       not d instanceof NonNullExpr
@@ -283,9 +281,7 @@ private module NullnessConfig implements ControlFlowReachability::ConfigSig {
 private module NullnessFlow = ControlFlowReachability::Flow<NullnessConfig>;
 
 predicate maybeNullDeref(Dereference d, Ssa::SourceVariable v, string msg, Element reason) {
-  exists(
-    Ssa::Definition origin, Ssa::Definition ssa, ControlFlow::Node src, ControlFlow::Node sink
-  |
+  exists(Ssa::Definition origin, Ssa::Definition ssa, ControlFlowNode src, ControlFlowNode sink |
     defMaybeNull(origin, src, msg, reason) and
     NullnessFlow::flow(src, origin, sink, ssa) and
     ssa.getSourceVariable() = v and
@@ -388,6 +384,6 @@ class Dereference extends G::DereferenceableExpr {
    */
   predicate isFirstAlwaysNull(Ssa::SourceVariable v) {
     this.isAlwaysNull(v) and
-    defReaches(v.getAnSsaDefinition(), this.getAControlFlowNode())
+    defReaches(v.getAnSsaDefinition(), this.getControlFlowNode())
   }
 }

csharp/ql/lib/semmle/code/csharp/dataflow/SSA.qll

@@ -164,10 +164,8 @@ module Ssa {
    */
   class Definition extends SsaImpl::Definition {
     /** Gets the control flow node of this SSA definition. */
-    final ControlFlow::Node getControlFlowNode() {
-      exists(ControlFlow::BasicBlock bb, int i | this.definesAt(_, bb, i) |
-        result = bb.getNode(0.maximum(i))
-      )
+    final ControlFlowNode getControlFlowNode() {
+      exists(BasicBlock bb, int i | this.definesAt(_, bb, i) | result = bb.getNode(0.maximum(i)))
     }
 
     /**
@@ -176,9 +174,7 @@ module Ssa {
      * point it is still live, without crossing another SSA definition of the
      * same source variable.
      */
-    final predicate isLiveAtEndOfBlock(ControlFlow::BasicBlock bb) {
-      SsaImpl::isLiveAtEndOfBlock(this, bb)
-    }
+    final predicate isLiveAtEndOfBlock(BasicBlock bb) { SsaImpl::isLiveAtEndOfBlock(this, bb) }
 
     /**
      * Gets a read of the source variable underlying this SSA definition that
@@ -236,7 +232,7 @@ module Ssa {
      * - The reads of `this.Field` on lines 10 and 11 can be reached from the phi
      *   node between lines 9 and 10.
      */
-    final AssignableRead getAReadAtNode(ControlFlow::Node cfn) {
+    final AssignableRead getAReadAtNode(ControlFlowNode cfn) {
       result = SsaImpl::getAReadAtNode(this, cfn)
     }
 
@@ -310,72 +306,9 @@ module Ssa {
      * Subsequent reads can be found by following the steps defined by
      * `AssignableRead.getANextRead()`.
      */
-    final AssignableRead getAFirstReadAtNode(ControlFlow::Node cfn) {
+    final AssignableRead getAFirstReadAtNode(ControlFlowNode cfn) {
       SsaImpl::firstReadSameVar(this, cfn) and
-      result.getAControlFlowNode() = cfn
-    }
-
-    /**
-     * Gets a last read of the source variable underlying this SSA definition.
-     * That is, a read that can reach the end of the enclosing callable, or
-     * another SSA definition for the source variable, without passing through
-     * any other read. Example:
-     *
-     * ```csharp
-     * int Field;
-     *
-     * void SetField(int i) {
-     *   this.Field = i;
-     *   Use(this.Field);
-     *   if (i > 0)
-     *     this.Field = i - 1;
-     *   else if (i < 0)
-     *     SetField(1);
-     *   Use(this.Field);
-     *   Use(this.Field);
-     * }
-     * ```
-     *
-     * - The reads of `i` on lines 7 and 8 are the last reads for the implicit
-     *   parameter definition on line 3.
-     * - The read of `this.Field` on line 5 is a last read of the definition on
-     *   line 4.
-     * - The read of `this.Field` on line 11 is a last read of the phi node
-     *   between lines 9 and 10.
-     */
-    deprecated final AssignableRead getALastRead() { result = this.getALastReadAtNode(_) }
-
-    /**
-     * Gets a last read of the source variable underlying this SSA definition at
-     * control flow node `cfn`. That is, a read that can reach the end of the
-     * enclosing callable, or another SSA definition for the source variable,
-     * without passing through any other read. Example:
-     *
-     * ```csharp
-     * int Field;
-     *
-     * void SetField(int i) {
-     *   this.Field = i;
-     *   Use(this.Field);
-     *   if (i > 0)
-     *     this.Field = i - 1;
-     *   else if (i < 0)
-     *     SetField(1);
-     *   Use(this.Field);
-     *   Use(this.Field);
-     * }
-     * ```
-     *
-     * - The reads of `i` on lines 7 and 8 are the last reads for the implicit
-     *   parameter definition on line 3.
-     * - The read of `this.Field` on line 5 is a last read of the definition on
-     *   line 4.
-     * - The read of `this.Field` on line 11 is a last read of the phi node
-     *   between lines 9 and 10.
-     */
-    deprecated final AssignableRead getALastReadAtNode(ControlFlow::Node cfn) {
-      SsaImpl::lastReadSameVar(this, cfn) and
-      result.getAControlFlowNode() = cfn
+      result.getControlFlowNode() = cfn
     }
 
     /**
@@ -426,7 +359,9 @@ module Ssa {
      * This is either an expression, for example `x = 0`, a parameter, or a
      * callable. Phi nodes have no associated syntax element.
      */
-    Element getElement() { result = this.getControlFlowNode().getAstNode() }
+    Element getElement() {
+      result.(ControlFlowElement).getControlFlowNode() = this.getControlFlowNode()
+    }
 
     /** Gets the callable to which this SSA definition belongs. */
     final Callable getEnclosingCallable() {
@@ -484,7 +419,7 @@ module Ssa {
      * `M2` via the call on line 6.
      */
     deprecated final predicate isCapturedVariableDefinitionFlowIn(
-      ImplicitEntryDefinition def, ControlFlow::Nodes::ElementNode c, boolean additionalCalls
+      ImplicitEntryDefinition def, ControlFlowNodes::ElementNode c, boolean additionalCalls
     ) {
       none()
     }
@@ -520,9 +455,7 @@ module Ssa {
 
     override Element getElement() { result = ad.getElement() }
 
-    override string toString() {
-      result = SsaImpl::getToStringPrefix(this) + "SSA def(" + this.getSourceVariable() + ")"
-    }
+    override string toString() { result = "SSA def(" + this.getSourceVariable() + ")" }
 
     override Location getLocation() { result = ad.getLocation() }
   }
@@ -536,7 +469,7 @@ module Ssa {
    */
   class ImplicitDefinition extends Definition, SsaImpl::WriteDefinition {
     ImplicitDefinition() {
-      exists(ControlFlow::BasicBlock bb, SourceVariable v, int i | this.definesAt(v, bb, i) |
+      exists(BasicBlock bb, SourceVariable v, int i | this.definesAt(v, bb, i) |
         SsaImpl::implicitEntryDefinition(bb, v) and
         i = -1
         or
@@ -554,25 +487,21 @@ module Ssa {
    */
   class ImplicitEntryDefinition extends ImplicitDefinition {
     ImplicitEntryDefinition() {
-      exists(ControlFlow::BasicBlock bb, SourceVariable v |
+      exists(BasicBlock bb, SourceVariable v |
         this.definesAt(v, bb, -1) and
         SsaImpl::implicitEntryDefinition(bb, v)
       )
     }
 
     /** Gets the callable that this entry definition belongs to. */
-    final Callable getCallable() { result = this.getBasicBlock().getCallable() }
+    final Callable getCallable() { result = this.getBasicBlock().getEnclosingCallable() }
 
     override Element getElement() { result = this.getCallable() }
 
     override string toString() {
       if this.getSourceVariable().getAssignable() instanceof LocalScopeVariable
-      then
-        result =
-          SsaImpl::getToStringPrefix(this) + "SSA capture def(" + this.getSourceVariable() + ")"
-      else
-        result =
-          SsaImpl::getToStringPrefix(this) + "SSA entry def(" + this.getSourceVariable() + ")"
+      then result = "SSA capture def(" + this.getSourceVariable() + ")"
+      else result = "SSA entry def(" + this.getSourceVariable() + ")"
     }
 
     override Location getLocation() { result = this.getCallable().getLocation() }
@@ -582,7 +511,7 @@ module Ssa {
     class C = ImplicitParameterDefinition;
 
     predicate relevantLocations(ImplicitParameterDefinition def, Location l1, Location l2) {
-      not def.getBasicBlock() instanceof ControlFlow::BasicBlocks::EntryBlock and
+      not def.getBasicBlock() instanceof EntryBasicBlock and
       l1 = def.getParameter().getALocation() and
       l2 = def.getBasicBlock().getLocation()
     }
@@ -614,7 +543,7 @@ module Ssa {
     override Element getElement() { result = this.getParameter() }
 
     override string toString() {
-      result = SsaImpl::getToStringPrefix(this) + "SSA param(" + this.getParameter() + ")"
+      result = "SSA param(" + pragma[only_bind_out](this.getParameter()) + ")"
     }
 
     override Location getLocation() {
@@ -634,7 +563,7 @@ module Ssa {
     private Call c;
 
     ImplicitCallDefinition() {
-      exists(ControlFlow::BasicBlock bb, SourceVariable v, int i |
+      exists(BasicBlock bb, SourceVariable v, int i |
         this.definesAt(v, bb, i) and
         SsaImpl::updatesNamedFieldOrProp(bb, i, c, v, _)
       )
@@ -656,9 +585,7 @@ module Ssa {
       )
     }
 
-    override string toString() {
-      result = SsaImpl::getToStringPrefix(this) + "SSA call def(" + this.getSourceVariable() + ")"
-    }
+    override string toString() { result = "SSA call def(" + this.getSourceVariable() + ")" }
 
     override Location getLocation() { result = this.getCall().getLocation() }
   }
@@ -671,9 +598,7 @@ module Ssa {
     private Definition q;
 
     ImplicitQualifierDefinition() {
-      exists(
-        ControlFlow::BasicBlock bb, int i, SourceVariables::QualifiedFieldOrPropSourceVariable v
-      |
+      exists(BasicBlock bb, int i, SourceVariables::QualifiedFieldOrPropSourceVariable v |
         this.definesAt(v, bb, i)
       |
         SsaImpl::variableWriteQualifier(bb, i, v, _) and
@@ -684,10 +609,7 @@ module Ssa {
     /** Gets the SSA definition for the qualifier. */
     final Definition getQualifierDefinition() { result = q }
 
-    override string toString() {
-      result =
-        SsaImpl::getToStringPrefix(this) + "SSA qualifier def(" + this.getSourceVariable() + ")"
-    }
+    override string toString() { result = "SSA qualifier def(" + this.getSourceVariable() + ")" }
 
     override Location getLocation() { result = this.getQualifierDefinition().getLocation() }
   }
@@ -723,13 +645,11 @@ module Ssa {
     final Definition getAnInput() { this.hasInputFromBlock(result, _) }
 
     /** Holds if `inp` is an input to this phi node along the edge originating in `bb`. */
-    predicate hasInputFromBlock(Definition inp, ControlFlow::BasicBlock bb) {
+    predicate hasInputFromBlock(Definition inp, BasicBlock bb) {
       inp = SsaImpl::phiHasInputFromBlock(this, bb)
     }
 
-    override string toString() {
-      result = SsaImpl::getToStringPrefix(this) + "SSA phi(" + this.getSourceVariable() + ")"
-    }
+    override string toString() { result = "SSA phi(" + this.getSourceVariable() + ")" }
 
     /*
      * The location of a phi node is the same as the location of the first node