Francis Alexander
19872e9aed
More Feedback integration
2021-01-26 17:24:17 +05:30
Taus
4c0f54f5d3
Merge pull request #5007 from yoff/python-disregard-comp-args
2021-01-26 12:53:33 +01:00
Rasmus Lerchedahl Petersen
e253855999
Python: Add comment about reverse reads.
2021-01-26 12:11:21 +01:00
CodeQL CI
0be0929693
Merge pull request #4958 from asgerf/js/angular2
...
Approved by erik-krogh
2021-01-26 02:53:33 -08:00
Rasmus Lerchedahl Petersen
e44f1813fa
Python: Add TODO comment
2021-01-26 11:29:14 +01:00
Tamás Vajk
e4ed050c87
Merge pull request #4970 from tamasvajk/feature/extraction-errors
...
C#: Fix extraction errors
2021-01-26 11:28:39 +01:00
Rasmus Lerchedahl Petersen
2c58643fd1
Python: Test for parameters without nodes.
2021-01-26 11:28:31 +01:00
Tamás Vajk
3ece8c3a01
Merge pull request #4835 from tamasvajk/feature/cil-fnptr
...
C#: Extract function pointer types from CIL
2021-01-26 11:28:02 +01:00
Asger Feldthaus
e6d9cd1905
JS: Add clause to getReturn/getInstance
2021-01-26 10:14:12 +00:00
CodeQL CI
c1726ed868
Merge pull request #5014 from RasmusWL/typetracking-test-track-self
...
Approved by tausbn
2021-01-26 02:10:52 -08:00
Asger Feldthaus
d59ccb7687
JS: Remove unhelpful mat-table load step
2021-01-26 09:27:48 +00:00
Asger Feldthaus
89225e222c
JS: Remove confusing comment
2021-01-26 09:25:12 +00:00
Tom Hvitved
71d25c1f8b
C#: Fix join-orders in ControlFlowTree::last()
2021-01-26 09:58:01 +01:00
Rasmus Lerchedahl Petersen
7b9ca7171a
Python: update test expectations
2021-01-26 09:47:48 +01:00
Rasmus Lerchedahl Petersen
dacc21d0b5
Python: update test expectation
2021-01-26 09:45:41 +01:00
Tom Hvitved
cd8155c201
C#: Teach CFG about ExceptionDispatchInfo::Throw
2021-01-26 09:16:53 +01:00
Tom Hvitved
07a96c3596
C#: Add CFG tests for ExceptionDispatchInfo::Throw
2021-01-26 09:01:06 +01:00
Owen Mansel-Chan
b76ff0d233
Merge pull request #461 from owen-mc/avoid-unused-barrier-guards-in-scope
...
Move reused barrier guards into separate files
2021-01-26 06:08:29 +00:00
luchua-bc
fee0b94cd4
Use isRequestGetParamMethod as the source
2021-01-26 04:41:44 +00:00
Robert Marsh
44bc6d7fdb
C++/C#: add NonPhiMemoryOperand union type
...
This fixes a performance issue where the whole MemoryOperand table was
scanned in some predicates that used only NonPhiMemoryOperand
2021-01-25 17:03:19 -08:00
yoff
09bb3001d6
Apply suggestions from code review
...
Co-authored-by: Taus <tausbn@github.com >
2021-01-25 21:58:20 +01:00
yoff
7ba0939239
Merge pull request #4995 from RasmusWL/tornado-model-http-sinks
...
Python: model HTTP sink in Tornado
2021-01-25 21:53:44 +01:00
Francis Alexander
985d3d469a
PR feedback integration
2021-01-25 23:26:36 +05:30
Tom Hvitved
d19053deda
Merge pull request #105 from github/hvitved/vcall
2021-01-25 18:41:36 +01:00
Owen Mansel-Chan
bf0f0aff5e
Move reused barrier guards into separate files
...
This way only the barrier guards that are used will be imported.
This is important because of the comment above BarrierGuard, which
warns about the potential danger of having classes that extend
BarrierGuard in scope which are not used.
2021-01-25 17:07:18 +00:00
Rasmus Wriedt Larsen
91caa13f48
Merge pull request #5004 from github/erik-krogh/ignore-venv
...
add .venv/ to .gitignore
2021-01-25 18:06:28 +01:00
Owen Mansel-Chan
e55db63184
Merge pull request #462 from owen-mc/make-path-containment-check-more-specific
...
Make PathContainmentCheck more specific
2021-01-25 16:46:33 +00:00
Joe Farebrother
d69ecde5c1
Java: Add additional flow steps for guava collection methods and more unit tests
2021-01-25 16:37:40 +00:00
Joe Farebrother
7e11d8ed07
Java: Add modelling for guava Sets
2021-01-25 16:37:40 +00:00
Joe Farebrother
d1427fcd93
Java: Add modelling for Guava's collection classes
2021-01-25 16:37:40 +00:00
Rasmus Lerchedahl Petersen
96b7f75905
Python: add postupdate nodes for kwargs
...
drops remaining reverse read failures on saltstack.
2021-01-25 17:34:49 +01:00
Rasmus Wriedt Larsen
a8186be2fa
Python: Add test of type-tracking self in methods
2021-01-25 17:20:11 +01:00
Sauyon Lee
3ed9e66c7a
Add gokit models
2021-01-25 08:15:14 -08:00
Rasmus Lerchedahl Petersen
ad39bfb2ff
Python: Add postupdate nodes for subscripts.
...
This drops reverse read inconsistencies on saltstack from 14909 to 1353.
2021-01-25 17:01:25 +01:00
Rasmus Lerchedahl Petersen
361bee851a
Python: Tests inspired by reverse read check
2021-01-25 17:01:25 +01:00
Rasmus Lerchedahl Petersen
4ff2c6d85a
Python: fix test expectation
...
probably a copy-paste error..
2021-01-25 16:49:51 +01:00
Tom Hvitved
2c6b9eceda
Move vcall into internal/Variable.qll
2021-01-25 16:26:11 +01:00
Tom Hvitved
ce74208317
Merge pull request #97 from github/hvitved/var-access-categorization
...
Categorize variable accesses into reads and (implicit or explicit) writes
2021-01-25 16:25:35 +01:00
Tom Hvitved
979da623ed
Merge pull request #103 from github/hvitved/cfg/params
...
CFG: Replace special parameters with their identifiers
2021-01-25 16:24:10 +01:00
Tom Hvitved
7c9a6064cf
C#: Get rid of ReadKind
2021-01-25 16:20:14 +01:00
CodeQL CI
4601eb9c7c
Merge pull request #4706 from max-schaefer/issue-247
...
Approved by asgerf
2021-01-25 07:11:35 -08:00
Owen Mansel-Chan
71d52500f7
Make PathContainmentCheck more specific
...
Recent changes to Property.checkOn mean that in the code
err == nil && <unrelated-condition>
PathContainmentCheck matches the first condition and the whole &&
expression. Originally it would have only matched the first condition,
and this commit restores that behaviour. This pattern appears 3 times in
the tests, which all still pass.
2021-01-25 15:05:57 +00:00
Tom Hvitved
6ffeaf8c2a
C#: Adjust flow into phi nodes
2021-01-25 15:44:37 +01:00
Max Schaefer
bc74bcec21
Merge pull request #459 from owen-mc/update-barrier-guard-comment
...
Make comment on BarrierGuard more specific
2021-01-25 14:34:20 +00:00
Owen Mansel-Chan
f8c3fbf845
Merge pull request #454 from owen-mc/default-taint-sanitizer-guard-equality-test-guard
...
Make EqualityTestGuard a default taint sanitizer guard
2021-01-25 14:24:08 +00:00
Tom Hvitved
38b0f743cb
C#: Add test that illustrates problem with flow through phi nodes
2021-01-25 14:20:27 +01:00
Artem Smotrakov
8d701e604a
Simplified JexlInjectionLib.qll
...
- Merged multiple method definitions to DirectJexlEvaluationMethod
- Don't use TaintPropagatingJexlMethodCall field in JexlInjectionConfig
- Better variable names in JexlEvaluationSink
2021-01-25 14:17:51 +01:00
Owen Mansel-Chan
06c6ceda50
Make comment on BarrierGuard more specific
...
The problem that this comment is trying to warn about is the following:
say you have two subclasses of BarrierGuard BG1 and BG2, both of which
contain some node g. Also assume that you have a configuration C which
specifies BG1 as a barrier guard, but not BG2. Because g is contained in
both classes, you will then still get the barrier guard definition from
BG2 due to the way dynamic dispatch works in QL.
2021-01-25 13:16:23 +00:00
Tom Hvitved
36ad6b3432
Merge pull request #5001 from hvitved/csharp/ssa/read-kind
...
C#: Remove `ReadKind` from the shared SSA library
2021-01-25 14:11:54 +01:00
Tom Hvitved
221aebc833
C#: Fix bug in AssignOperationWithExpandedAssignment::last
2021-01-25 14:01:31 +01:00