hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-01-30 06:42:57 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #459 from owen-mc/update-barrier-guard-comment

Browse Source 
Make comment on BarrierGuard more specific
This commit is contained in:
Max Schaefer
2021-01-25 14:34:20 +00:00
committed by GitHub
parent f8c3fbf845 06c6ceda50
commit bc74bcec21
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
ql/src/semmle/go/dataflow/internal/DataFlowUtil.qll
View File

@@ -1115,7 +1115,10 @@ predicate localFlow(Node source, Node sink) { localFlowStep*(source, sink) }
* characteristic predicate precisely specifying the guard, and override
* `checks` to specify what is being validated and in which branch.
*
* It is important that all extending classes in scope are disjoint.
* When using a data-flow or taint-flow configuration `cfg`, it is important
* that any classes extending BarrierGuard in scope which are not used in `cfg`
* are disjoint from any classes extending BarrierGuard in scope which are used
* in `cfg`.
*/
abstract class BarrierGuard extends Node {
/** Holds if this guard validates `e` upon evaluating to `branch`. */