Max Schaefer
ee62706ad2
JavaScript: Split up a predicate to avoid bad join order.
2020-03-19 11:47:53 +00:00
Max Schaefer
d91e6a4893
JavaScript: Avoid a few bad join orders.
2020-03-19 11:47:53 +00:00
semmle-qlci
2821b01017
Merge pull request #2915 from tausbn/python-add-points-to-for-missing-builtin-return-types
...
Approved by RasmusWL
2020-03-19 11:02:46 +00:00
Rasmus Wriedt Larsen
f4e5079dd3
Merge pull request #2991 from BekaValentine/python-objectapi-to-valueapi-unguardednextingenerator
...
Python: ObjectAPI to ValueAPI: UnguardedNextInGenerator
2020-03-19 10:33:32 +01:00
Rebecca Valentine
06f0947318
Update python/ql/src/Exceptions/UnguardedNextInGenerator.ql
...
Co-Authored-By: Rasmus Wriedt Larsen <rasmuswriedtlarsen@gmail.com >
2020-03-18 14:16:00 -07:00
Rebecca Valentine
9560c804b8
Update python/ql/test/query-tests/Exceptions/generators/test.py
...
Co-Authored-By: Rasmus Wriedt Larsen <rasmuswriedtlarsen@gmail.com >
2020-03-18 14:15:49 -07:00
Robert Marsh
a30954599d
Merge pull request #3085 from jbj/inStaticInitializer-AggregateLiteral
...
C++: Manual magic in inStaticInitializer
2020-03-18 13:23:04 -07:00
Rasmus Wriedt Larsen
9a0b2b1843
Merge pull request #2989 from BekaValentine/python-objectapi-to-valueapi-incorrectexceptorder
...
Python: ObjectAPI to ValueAPI: IncorrectExceptOrder
2020-03-18 18:03:25 +01:00
Taus
ae1268f241
Merge branch 'master' into python-add-points-to-for-missing-builtin-return-types
2020-03-18 17:59:17 +01:00
Rasmus Wriedt Larsen
290e33a912
Merge pull request #2922 from tausbn/python-fix-multi-assign-points-to
...
Python: Fix bug in `multi_assignment_points_to`.
2020-03-18 17:50:37 +01:00
Rasmus Wriedt Larsen
b0303158a5
Merge pull request #3088 from tausbn/python-prepare-autoformatting
...
Python: Prepare for autoformatting.
2020-03-18 17:48:46 +01:00
Jonas Jensen
a23077af11
C++: Comments for future maintainers
2020-03-18 14:11:37 +01:00
Taus Brock-Nannestad
57af7b84aa
Python: Prepare for autoformatting.
...
Mostly fixes up a bunch of comments that were made wonky by the autoformatter.
2020-03-18 13:59:38 +01:00
Jonas Jensen
f1ad0dafdc
Merge pull request #2849 from geoffw0/model-gets
...
C++: Model for gets
2020-03-18 11:06:23 +01:00
Jonas Jensen
260bfe7b1d
C++: Manual magic in inStaticInitializer
...
Since `runtimeExprInStaticInitializer` only looks at expressions at the
top level of an initializer or directly below some number of top-level
aggregate literals, there is no need for `inStaticInitializer` to
include expressions strictly below those in the AST.
I tested this on Wireshark, which has very large static initializers,
but found no measureable difference in run time. There are some
differences in tuple counts and iteration counts, though:
- `inStaticInitializer` changes from 6,241,153 rows (86 iterations) to
5,031,617 rows (7 iterations).
- `runtimeExprInStaticInitializer` changes from 386,350 rows to 4,705
rows.
- `hasDynamicInitialization` has 410 rows both before and after, which
suggests that this change does not affect results.
Even though there is no impact on this snapshot at this time, things
might look different if/when the restriction on aggregate literals to
100 children is removed in the extractor.
2020-03-18 09:28:45 +01:00
Jonas Jensen
93c6f8f1f7
Merge pull request #3056 from dbartol/dbartol/static-locals
...
C++: Model dynamic initialization of static local variables in IR
2020-03-18 08:16:21 +01:00
Dave Bartolomeo
309ccf3daf
C++: Factor out common code to avoid recursion
2020-03-17 18:44:29 -04:00
Dave Bartolomeo
772324fafa
C++: Add comment with IR for dynamic init of static var
2020-03-17 18:44:00 -04:00
Dave Bartolomeo
709757f7f2
Merge remote-tracking branch 'upstream/master' into dbartol/static-locals
2020-03-17 18:35:13 -04:00
Taus
46567a5842
Merge pull request #3029 from BekaValentine/python-objectapi-to-valueapi-handles
...
Python: ObjectAPI to ValueAPI: Handles
2020-03-17 22:37:27 +01:00
Rebecca Valentine
f351916418
Merge branch 'master' into testmerge
2020-03-17 12:32:45 -07:00
Taus
ca26feefbf
Merge pull request #2978 from BekaValentine/python-objectapi-to-valueapi-illegalexceptionhandlertype
...
Python: ObjectAPI to ValueAPI: IllegalExceptionHandlerType
2020-03-17 17:56:34 +01:00
Rebecca Valentine
a7a64952e2
Python: ObjectAPI.qll: Fixes docstring
2020-03-17 09:48:54 -07:00
Robert Marsh
84a74f406a
Merge pull request #3002 from theopolis/cpp-linux-drop-privileges-outoforder
...
CPP: Add query for CWE-273 that detects out-of-order setuid
2020-03-17 09:10:51 -07:00
semmle-qlci
8792d0d248
Merge pull request #3070 from erik-krogh/DataPerf
...
Approved by asgerf
2020-03-17 13:47:09 +00:00
semmle-qlci
fa08258c14
Merge pull request #3036 from erik-krogh/CustomTrack
...
Approved by asgerf
2020-03-17 13:44:51 +00:00
semmle-qlci
ea46873bfe
Merge pull request #3065 from erik-krogh/PathSinks
...
Approved by esbena
2020-03-17 13:00:00 +00:00
Pavel Avgustinov
1472bf0c11
Merge pull request #3078 from jbj/contributing-supported-2
...
Docs: refactor guidelines for new queries
2020-03-17 12:46:28 +00:00
Erik Krogh Kristensen
9403026fff
add change note
2020-03-17 11:48:02 +01:00
Erik Krogh Kristensen
1dfe9e9c2a
changes based on review
2020-03-17 11:28:29 +01:00
Erik Krogh Kristensen
9a3176d3cc
Apply suggestions from code review
...
Co-Authored-By: Esben Sparre Andreasen <esbena@github.com >
2020-03-17 11:26:35 +01:00
Erik Krogh Kristensen
095d4d711a
change import to an absolute import to fix warning
2020-03-17 11:21:46 +01:00
Erik Krogh Kristensen
d7b69fcfea
autoformat
2020-03-17 09:52:08 +01:00
Jonas Jensen
9899d46999
Docs: refactor guidelines for new queries
2020-03-17 08:24:03 +01:00
Rebecca Valentine
ff6e0ce35c
Python: UnguardedNextInGenerator.ql: Excludes next with default value
2020-03-16 17:08:06 -07:00
Rebecca Valentine
68c455cd97
Python: IncorrectExceptOrder.ql: Autoformats w/ new QL indentation
2020-03-16 16:52:48 -07:00
Rebecca Valentine
c7a2925620
Python: Exceptions.qll: Clean up handleObject again
2020-03-16 14:52:51 -07:00
Rebecca Valentine
34ab4efeda
Python: ObjectAPI.qll: getOrigin now returns a CFG
2020-03-16 14:52:23 -07:00
Rebecca Valentine
45e47b92a0
Python: IllegalExceptionHandlerType.ql: Autoformats
2020-03-16 14:48:05 -07:00
Esben Sparre Andreasen
7dc80664e6
Merge pull request #3045 from Semmle/esbena-patch-2
...
JS: loosen qldoc for `barrierGuardIsRelevant`
2020-03-16 22:28:22 +01:00
Rebecca Valentine
5d55db116b
Python: Exceptions.qll: Updates handledObject to use getOrigin
2020-03-16 11:24:55 -07:00
Rebecca Valentine
787b80f9ae
Python: ObjectAPI.qll: Adds getOrigin predicate
2020-03-16 11:24:22 -07:00
Erik Krogh Kristensen
7145a57db3
refactor StepSummary into an internal .qll
2020-03-16 17:52:04 +01:00
Jonas Jensen
b7dc26e27d
Merge pull request #3072 from geoffw0/gezero2
...
C++: Improvement to cpp/unsigned-comparison-zero
2020-03-16 17:00:38 +01:00
Geoffrey White
44c66a3b09
C++: Fixup test .expected files after merge.
2020-03-16 15:45:29 +00:00
Erik Krogh Kristensen
cd6fe8115d
Update javascript/ql/src/semmle/javascript/Promises.qll
...
Co-Authored-By: Asger F <asgerf@github.com >
2020-03-16 16:27:50 +01:00
Geoffrey White
034f7cc948
Merge branch 'master' into model-gets
2020-03-16 15:12:36 +00:00
Calum Grant
945418869d
Merge pull request #3022 from hvitved/csharp/autobuild/dotnet-clean-try
...
C#: Ignore `dotnet clean` exit code in autobuilder
2020-03-16 15:10:32 +00:00
Taus Brock-Nannestad
c724b17368
Python: Fix up regression comment.
2020-03-16 16:01:05 +01:00
Geoffrey White
40db92bfd1
C++: Change note.
2020-03-16 13:22:00 +00:00