Owen Mansel-Chan
ab5e1f8a69
Fix models for min and max and improve tests
...
Although the documentation makes them look variadic (and generic), they
are actually special-cased in the compiler. Like all built-in functions
they don't have a signature type, but the type of `min(a, b, c)` is
`func(int, int, int) int` and not `func(int, ...int) int`.
Go doesn't allow open-ended ranges for argument indices in
models-as-data specifications (though Ruby and Python do), so I've used
`1..1000`.
2024-05-14 14:40:56 +01:00
Owen Mansel-Chan
f7e6bf7ef5
Two tests have different paths but same results
2024-05-10 23:41:00 +01:00
Owen Mansel-Chan
f8e17fe8cc
Accept expected test changes
2024-05-10 23:40:59 +01:00
Owen Mansel-Chan
76946184de
Accept MaD renumbering for edge provenance
2024-05-10 23:40:58 +01:00
Owen Mansel-Chan
e1c85e3581
Fix elementWrite to include flow summaries
2024-05-10 23:40:58 +01:00
Owen Mansel-Chan
8cc9838628
Add change note
2024-05-10 23:40:57 +01:00
Owen Mansel-Chan
d5aa08dbf3
Local flow steps for flow summaries for built-in functions
2024-05-10 23:40:57 +01:00
Owen Mansel-Chan
86e2b845f3
Add tests for copy (taint passes, value fails)
2024-05-10 23:40:56 +01:00
Owen Mansel-Chan
eab1569342
Update ExternalValueFlow to use value flow
2024-05-10 23:40:56 +01:00
Owen Mansel-Chan
c816412795
Create copy of ExternalTaintFlow called ExternalValueFlow
2024-05-10 23:40:55 +01:00
Owen Mansel-Chan
84b7319688
Rename test folder ExternalFlow to ExternalTaintFlow
2024-05-10 23:40:54 +01:00
Owen Mansel-Chan
f95ccd242f
Remove old-style models of built-in functions
2024-05-10 23:40:54 +01:00
Owen Mansel-Chan
fcdac0aeb0
Add models for min and max built-in functions
2024-05-10 23:40:53 +01:00
Owen Mansel-Chan
1322ce35d6
Add model for built-in function copy
2024-05-10 23:40:53 +01:00
Owen Mansel-Chan
e857eedd4a
Fix model for append - it is variadic
2024-05-10 23:40:52 +01:00
Ian Lynagh
e7092b403b
Merge pull request #16401 from igfoo/igfoo/vars
...
Java/Kotlin: Remove support for some deprecated environment variables
2024-05-10 13:37:55 +01:00
Erik Krogh Kristensen
bcddef8f32
Merge pull request #16131 from erik-krogh/cpp-path
...
C++: Improve the cpp/path-injection qhelp
2024-05-09 22:21:51 +02:00
Owen Mansel-Chan
e721399eec
Merge pull request #16464 from owen-mc/go/fix-broken-test
...
Go: Fix test expectations
2024-05-09 16:46:04 +01:00
Owen Mansel-Chan
674e65e134
Fix test expectations
2024-05-09 16:26:30 +01:00
Ian Lynagh
4d54c09a6f
Java: Add changenote for dropping support for some old variables
2024-05-09 15:59:47 +01:00
Ian Lynagh
b5d6bb9097
Kotlin: Remove unused var SEMMLE_PLATFORM_TOOLS
2024-05-09 15:59:47 +01:00
Ian Lynagh
cfc419b639
Kotlin: Remove unused ODASA_HOME variable
2024-05-09 15:59:47 +01:00
Ian Lynagh
304ad33837
Kotlin: Remove unused ODASA_TOOLS variable
2024-05-09 15:59:47 +01:00
Ian Lynagh
231918f612
Kotlin: Remove redundant variable ODASA_JAVA_LAYOUT
2024-05-09 15:59:47 +01:00
Owen Mansel-Chan
526204dc43
Merge pull request #16458 from owen-mc/go/fix-mad-for-builtin-functions
...
Go: fix `hasQualifiedName` and models-as-data for built-in functions
2024-05-09 15:06:07 +01:00
Jeroen Ketema
4dfcdbccd7
Merge pull request #16459 from jketema/handler-fix
...
C++: Fix destructor translation for handlers
2024-05-09 10:23:07 +02:00
Sarita Iyer
aab5da0435
Merge pull request #16320 from github/subatoi/deprecate-codeql-for-vs-code
...
[8th May 2024] Add deprecation notices to CodeQL for VS Code documentation
2024-05-08 17:00:42 -04:00
Jeroen Ketema
9e09c5a6cf
C++: Fix copy and paste error in comment
2024-05-08 22:11:19 +02:00
Owen Mansel-Chan
279b2c7a95
Merge pull request #16457 from owen-mc/go/fix-implicitvarargsslice-type
...
Go: Fix `getType` on `ImplicitVarArgsSlice`
2024-05-08 20:52:01 +01:00
erik-krogh
a51d24cbab
apply suggestions from code review, and the examples to the test
2024-05-08 19:34:50 +02:00
Jeroen Ketema
d68d2cca41
C++: Fix destructor translation for handlers
2024-05-08 19:26:56 +02:00
Jeroen Ketema
0cbedfb28c
Merge pull request #16455 from jketema/if-fix
...
C++: Ensure destructors for ifs are called after both branches and for both if and constexpr if
2024-05-08 19:15:28 +02:00
Geoffrey White
49aba25852
Merge pull request #16445 from geoffw0/qhelp4
...
C++: Improve qhelp for DoubleFree.
2024-05-08 18:02:12 +01:00
Geoffrey White
53d4a10108
Update cpp/ql/src/Critical/DoubleFree.qhelp
...
Co-authored-by: Ben Ahmady <32935794+subatoi@users.noreply.github.com >
2024-05-08 17:15:08 +01:00
Mathias Vorreiter Pedersen
59fb9cc862
Merge pull request #16299 from MathiasVP/remove-base-address-as-ipa-key
...
C++: Remove an unnecessary column
2024-05-08 16:43:30 +01:00
Owen Mansel-Chan
4f10cb5fa0
Local flow tests: do not list summary models
...
This is so that when we don't change the test results every time we add
a summary model for a built-in function.
2024-05-08 16:13:37 +01:00
Owen Mansel-Chan
57ff30c5f3
Update tests: built-in models now work
2024-05-08 16:07:02 +01:00
Owen Mansel-Chan
1ccea884ff
Add change note
2024-05-08 15:37:25 +01:00
Owen Mansel-Chan
f6f594e4b5
parse empty string as package name
2024-05-08 15:33:19 +01:00
Owen Mansel-Chan
fb74a2a170
Use "" in qualified name for entities without a package
2024-05-08 15:33:19 +01:00
Owen Mansel-Chan
4d42a88c3c
Add change note
2024-05-08 15:31:22 +01:00
Owen Mansel-Chan
9842445b52
Fix getType on ImplicitVarArgsSlice
...
It was not defined for built-in functions or for functions called via
a function variable.
2024-05-08 15:22:27 +01:00
Rasmus Wriedt Larsen
694b3b0fce
Merge pull request #16452 from RasmusWL/fix-warning
...
misc: Fix docstring warning
2024-05-08 16:07:10 +02:00
Michael B. Gale
8cba06a25c
Merge pull request #16454 from github/mbg/go/fix/shadowed-variable
2024-05-08 14:13:18 +01:00
Geoffrey White
088f8297b6
C++: Use nullptr.
2024-05-08 14:04:21 +01:00
Jeroen Ketema
1a53b923a6
C++: Ensure destructors for ifs are called after both branches
2024-05-08 14:48:28 +02:00
Michael B. Gale
896fb87d1d
Go: Fix err being shadowed in RunListWithEnv
2024-05-08 13:29:28 +01:00
Michael B. Gale
724d026238
Go: Move go list functions to toolchain package
2024-05-08 13:29:28 +01:00
Jeroen Ketema
52db1c1253
C++: Introduce abstract class to share code between if and constexpr if
2024-05-08 14:16:19 +02:00
Jeroen Ketema
fa06d88642
C++: Add forgotten getLastChild to TranslatedConstExprIfStmt
2024-05-08 14:07:29 +02:00