Michael B. Gale
c0d2b89de0
Go: Respect GOTOOLCHAIN in GetEnvGoVersion if already set
2024-04-15 16:28:24 +01:00
Owen Mansel-Chan
5ec3934ac8
Merge branch 'main' into go/extractor/no-intermediate-string-values
2024-04-10 14:51:22 +01:00
Owen Mansel-Chan
b4829addf7
Add comments with link to online doc
2024-04-10 10:48:23 +01:00
Owen Mansel-Chan
32ea94e625
Merge pull request #16123 from owen-mc/go/misc-trivial-fixes
...
Go: miscellaneous trivial fixes
2024-04-04 21:09:15 +01:00
Owen Mansel-Chan
7fc5265168
Misc small tidy-ups mostly suggested by linter
2024-04-04 10:51:22 +01:00
Owen Mansel-Chan
68321dd9ec
Use nil for optional argument to packages.Visit
2024-04-04 10:51:13 +01:00
Owen Mansel-Chan
d9fe39d5ae
Extractor: add comment about tw.Package.TypesInfo.Defs
2024-04-04 10:37:31 +01:00
Owen Mansel-Chan
698debfa20
Extractor: explicitly deal with extracting x.(type) in type switches
2024-04-03 13:58:58 +01:00
Michael B. Gale
55fa245194
Go: Revert go version call in LoadGoModules
2024-04-02 15:20:56 +01:00
Michael B. Gale
73f71d8ace
Merge pull request #15979 from github/mbg/go/deal-with-incorrect-versions
2024-03-28 14:16:14 +00:00
Michael B. Gale
f6c22d466f
Update toolchain_test.go
...
Co-authored-by: Owen Mansel-Chan <62447351+owen-mc@users.noreply.github.com >
2024-03-28 13:32:02 +00:00
Michael B. Gale
977ac71b26
Update toolchain_test.go
...
Co-authored-by: Owen Mansel-Chan <62447351+owen-mc@users.noreply.github.com >
2024-03-28 11:15:30 +00:00
Michael B. Gale
45b41bb506
Go: Mirror stdout/stderr output in InstallVersion
2024-03-27 15:18:24 +00:00
Michael B. Gale
6ea99825be
Go: Add unit test to sanity check HasGoVersion
2024-03-27 15:15:40 +00:00
Michael B. Gale
ab255d70b5
Go: Fix semver-related logic bugs
2024-03-27 15:15:20 +00:00
Michael B. Gale
86bf4fbbc0
Go: Make diagnostic names static
2024-03-27 14:22:58 +00:00
Michael B. Gale
c74d6348f9
Go: Run go with a valid toolchain version if we have found an invalid one
2024-03-20 13:55:37 +00:00
Michael B. Gale
0d527b2f75
Go: Keep track of all installed toolchains that we know of
2024-03-20 13:52:06 +00:00
Michael B. Gale
96a6dd72cd
Go: Move go version command construction into its own function
2024-03-20 13:08:59 +00:00
Michael B. Gale
06134467e9
Go: Make CODEQL_EXTRACTOR_GO_FAST_PACKAGE_INFO true by default
2024-03-20 12:01:49 +00:00
Michael B. Gale
be027e217e
Go: Emit diagnostic for invalid toolchain versions
2024-03-19 16:26:06 +00:00
Owen Mansel-Chan
da8cc13506
go extractor: avoid long string concatenations
...
When we see "a" + "b" + "c" + "d", do not add a
row to the constvalues table for the intermiediate
strings "ab" and "abc". We still have entries for
the string literals ("a", "b", "c", and "d") and
the whole string concatenation ("abcd").
2024-03-11 10:53:26 +00:00
Michael B. Gale
ac394dc80c
Go: Better check for path prefixes
2024-03-05 13:46:33 +00:00
Michael B. Gale
b1e0bc03ab
Go: Fix check for whether it is safe to initialise a go.mod file in a given directory
2024-03-05 12:48:21 +00:00
Michael B. Gale
367ecf75d5
Go: Use import path for auto-generated Go module names
2024-03-05 12:48:21 +00:00
Michael B. Gale
2aa093c95c
Go: Move getImportPath to shared util package
2024-03-05 12:48:19 +00:00
Michael B. Gale
9b5bf519a1
Update go/extractor/project/project.go
...
Co-authored-by: Owen Mansel-Chan <62447351+owen-mc@users.noreply.github.com >
2024-03-04 12:25:40 +00:00
Michael B. Gale
acf2f761a6
Go: Improve log message for InitGoModForLegacyProject
2024-03-04 12:14:24 +00:00
Michael B. Gale
1a13a0e4c9
Go: Log discovered Go modules in case workspace files can't be read/parsed
2024-03-04 12:14:24 +00:00
Michael B. Gale
52b273ae23
Go: Include workspace count in success message
2024-03-04 12:14:24 +00:00
Michael B. Gale
8055c5d9e3
Go: Avoid extra loop to track unsuccessfulProjects
2024-03-04 12:14:23 +00:00
Michael B. Gale
020eb4aed7
Go: Use slices.Concat for bazelPaths
2024-03-04 12:14:23 +00:00
Michael B. Gale
040a288bb3
Go: Update comment to replace Go.mod with go.mod
2024-03-04 12:14:23 +00:00
Michael B. Gale
37212737fb
Go: Delete unused AnyGoFilesOutsideDirs
2024-03-04 12:14:22 +00:00
Michael B. Gale
4dd23d4767
Merge pull request #15791 from github/mbg/go/use-1.22-for-extractor
...
Go: Use Go 1.22 for the extractor
2024-03-04 11:53:37 +00:00
Michael B. Gale
0e9a7c84d1
Go: Update go.work.sum
2024-03-04 10:59:23 +00:00
Michael B. Gale
ff82eb95f5
Go: Use 1.22 in go.mod
2024-03-04 10:58:51 +00:00
Michael B. Gale
6563414370
Go: Allow 1.22 as a supported version
2024-03-04 10:56:03 +00:00
Michael B. Gale
0c93641b54
Merge pull request #15361 from github/mbg/go/legacy-gopath-mode-deprecated
...
Go: Update autobuilder to deal with the upcoming deprecation of the legacy GOPATH mode
2024-03-04 10:23:37 +00:00
Michael B. Gale
bda8a804ec
Go: Add go.work file
2024-03-01 14:50:00 +00:00
Michael B. Gale
008585eeba
Go: Include arguments in RunCmd error messages
2024-02-16 15:17:24 +00:00
Michael B. Gale
8886092cd0
Go: Try to ignore errors in go mod vendor calls
2024-02-16 15:15:58 +00:00
Michael B. Gale
4d28c0d2a9
Go: Call go mod vendor to synchronise vendor directory when it exists
2024-02-15 16:19:07 +00:00
Michael B. Gale
6267506a77
Go: Postpone go.mod creation until necessary
2024-02-14 19:12:36 +00:00
Michael B. Gale
1055e773ef
Go: Export InitGoModForLegacyProject
2024-02-14 19:12:35 +00:00
Michael B. Gale
4387c73d12
Go: Fix missing word in comment for discoverWorkspace
2024-02-14 19:12:35 +00:00
Michael B. Gale
6dbb5c5fdb
Go: Refactor Autobuild to use pairs of scripts and tools from a reusable array
2024-02-14 19:12:35 +00:00
Michael B. Gale
e2c673417f
Go: Only call EmitNewerGoVersionNeeded at most once
2024-02-14 19:12:35 +00:00
Michael B. Gale
6eac48caba
Go: Refactor greatest version logic into dedicated function
2024-02-14 19:12:34 +00:00
Michael B. Gale
058bf32ad0
Go: Initialise Go modules for stray source files outside of existing modules
2024-02-14 19:12:34 +00:00
