Jonas Jensen
7485cc76b2
C++: Edit Recommendation section
...
1. The two last examples were misleading at best. The first of those two
recommended casting to non-negative `int`s to `unsigned int` and then
checking if their addition would overflow, but overflow was
impossible because their sum (on 32-bit two's complement) could be at
most 2^32 - 2. The second example could lead to the wrong condition
(unsigned overflow) being checked if taken literally. Instead of
keeping that example, I reworeded the first paragraph of the
Recommendation section.
2. The assumptions about `delta` being positive was relaxed to
non-negative.
3. There was no need to assume that an unsigned short was non-negative.
4. Some of the suggestions were missing `i >`.
2019-11-15 11:05:00 +01:00
Jonas Jensen
73d9cc2e7b
Merge pull request #2309 from geoffw0/cpp418
...
CPP: QLDoc enhancements
2019-11-15 08:46:08 +01:00
Tom Hvitved
74b464ded9
Merge pull request #2321 from calumgrant/cs/netcore-3.0b
...
C#: Upgrade extractor to .NET Core 3.0
2019-11-15 06:21:17 +01:00
Dave Bartolomeo
81262d5948
Merge pull request #2328 from geoffw0/routinetest
...
CPP: Add a quick test of RoutineType.
2019-11-14 15:49:13 -07:00
Esben Sparre Andreasen
2ea7d141c8
Merge pull request #2310 from max-schaefer/js/insufficient-url-scheme-check
...
JavaScript: Add query `IncompleteUrlSchemeCheck`
2019-11-14 22:13:02 +01:00
semmle-qlci
0638907825
Merge pull request #2324 from esbena/js/torrent-as-remote-source
...
Approved by max-schaefer
2019-11-14 20:28:07 +00:00
Calum Grant
f3c92c5527
C#: Address review comment
2019-11-14 17:14:51 +00:00
Calum Grant
09356a377f
C#: Improved CIL instruction types to pass type consistency checks
2019-11-14 17:14:51 +00:00
Calum Grant
051dd6b3dc
C#: Update qltests.
2019-11-14 17:14:51 +00:00
Calum Grant
a2e0ae1e79
C#: Update project files to netcoreapp3.0
2019-11-14 17:14:51 +00:00
Max Schaefer
3b1e6c362c
JavaScript: Address review comments.
2019-11-14 17:11:59 +00:00
Geoffrey White
7408726f41
Merge pull request #2312 from jbj/pointer-wraparound-query
...
C++: New query: Pointer overflow check
2019-11-14 16:13:04 +00:00
Taus
d5edb651e1
Merge pull request #2329 from RasmusWL/python-codeowners
...
CODEOWNERS: Add python team
2019-11-14 17:00:46 +01:00
Rasmus Wriedt Larsen
54f89c8eda
CODEOWNERS: Add python team
...
(and reorder cpp, so it all follows the same pattern)
2019-11-14 16:42:12 +01:00
Geoffrey White
f2b7af7437
CPP: Add example code for RoutineType.
2019-11-14 15:25:00 +00:00
Geoffrey White
dc34fa366c
CPP: Add a test of RoutineType.
2019-11-14 15:13:52 +00:00
James Fletcher
4b35d35eed
Merge pull request #2326 from shati-patel/docs/snapshot
...
Docs: Use "database" consistently
2019-11-14 14:05:03 +00:00
Henning Makholm
e46d9158db
Merge pull request #2314 from Semmle/lgtm.com
...
Mergback lgtm.com branch into master
2019-11-14 14:55:26 +01:00
Jonas Jensen
c35229f062
Merge pull request #2327 from nickrolfe/missing_backtick
...
C++: add missing backtick in qldoc comment
2019-11-14 14:40:12 +01:00
Nick Rolfe
f5513342d6
C++: add missing backtick in qldoc comment
2019-11-14 13:20:41 +00:00
Shati Patel
f64633b2fe
Docs: Use "database"
2019-11-14 13:11:40 +00:00
Esben Sparre Andreasen
cc768345d0
JS: add security tests for malicious torrents
2019-11-14 13:54:19 +01:00
Esben Sparre Andreasen
bea59ec8ad
JS: add some parsed torrent properties as remote flow sources
2019-11-14 13:54:19 +01:00
Geoffrey White
beb3602253
Update cpp/ql/src/semmle/code/cpp/exprs/BuiltInOperations.qll
...
Co-Authored-By: Jonas Jensen <jbj@github.com >
2019-11-14 12:49:02 +00:00
Geoffrey White
6724632413
Update cpp/ql/src/semmle/code/cpp/exprs/BuiltInOperations.qll
...
Co-Authored-By: Jonas Jensen <jbj@github.com >
2019-11-14 12:48:50 +00:00
Rasmus Wriedt Larsen
1159344972
Merge pull request #2320 from tausbn/python-add-walrus-support
...
Python: Add AST classes for walrus operator.
2019-11-14 13:48:05 +01:00
Geoffrey White
45cc6c445c
Update cpp/ql/src/semmle/code/cpp/exprs/BuiltInOperations.qll
...
Co-Authored-By: Jonas Jensen <jbj@github.com >
2019-11-14 12:48:05 +00:00
Geoffrey White
0bb37c17f2
CPP: Delete parenthesized comment.
2019-11-14 12:46:43 +00:00
James Fletcher
f085b81e51
Merge pull request #2323 from shati-patel/docs/rename
...
Docs: Tidy up links in relevant topics
2019-11-14 12:44:54 +00:00
Geoffrey White
8b30baf656
CPP: Delete 'compiler-generated'.
2019-11-14 12:43:54 +00:00
Geoffrey White
f96cffa1f3
Update cpp/ql/src/semmle/code/cpp/exprs/BuiltInOperations.qll
...
Co-Authored-By: Jonas Jensen <jbj@github.com >
2019-11-14 12:41:10 +00:00
Geoffrey White
82c6ff02b2
Update cpp/ql/src/semmle/code/cpp/exprs/BuiltInOperations.qll
...
Co-Authored-By: Jonas Jensen <jbj@github.com >
2019-11-14 12:40:53 +00:00
Geoffrey White
6262cee27d
Update cpp/ql/src/semmle/code/cpp/exprs/BuiltInOperations.qll
...
Co-Authored-By: Jonas Jensen <jbj@github.com >
2019-11-14 12:40:41 +00:00
Geoffrey White
fe5bd42203
Update cpp/ql/src/semmle/code/cpp/exprs/BuiltInOperations.qll
...
Co-Authored-By: Jonas Jensen <jbj@github.com >
2019-11-14 12:40:29 +00:00
Geoffrey White
d8aeedfe01
Update cpp/ql/src/semmle/code/cpp/exprs/BuiltInOperations.qll
...
Co-Authored-By: Jonas Jensen <jbj@github.com >
2019-11-14 12:40:11 +00:00
Geoffrey White
877e9ba6d8
Update cpp/ql/src/semmle/code/cpp/exprs/BuiltInOperations.qll
...
Co-Authored-By: Jonas Jensen <jbj@github.com >
2019-11-14 12:39:54 +00:00
Geoffrey White
acefadda8c
Update cpp/ql/src/semmle/code/cpp/exprs/Assignment.qll
...
Co-Authored-By: Jonas Jensen <jbj@github.com >
2019-11-14 12:35:15 +00:00
Geoffrey White
b1dfc60422
Update cpp/ql/src/semmle/code/cpp/exprs/Cast.qll
...
Co-Authored-By: Jonas Jensen <jbj@github.com >
2019-11-14 12:34:13 +00:00
Shati Patel
557b95ccb1
Docs: Tidy up links in relevant topics
2019-11-14 12:32:21 +00:00
Anders Schack-Mulligen
6a2edce040
Merge pull request #2205 from rneatherway/java/hamcrest-nullness
...
Java: Respect Hamcrest assertThat(X, notNullValue())
2019-11-14 13:09:56 +01:00
Jonas Jensen
c7176e50ca
C++: Tweak wording in docs
2019-11-14 13:03:34 +01:00
James Fletcher
2eaf91e1fb
Merge pull request #2322 from shati-patel/docs/typo
...
Docs: Typo fix
2019-11-14 11:56:39 +00:00
Shati Patel
3cdaef7211
Docs: Typo fix
2019-11-14 11:50:43 +00:00
Geoffrey White
79a000d88f
Update cpp/ql/src/semmle/code/cpp/exprs/Expr.qll
...
Co-Authored-By: Jonas Jensen <jbj@github.com >
2019-11-14 11:31:27 +00:00
Geoffrey White
0f2a2cb956
Update cpp/ql/src/semmle/code/cpp/exprs/Expr.qll
...
Co-Authored-By: Jonas Jensen <jbj@github.com >
2019-11-14 11:31:01 +00:00
Geoffrey White
25db90021b
Update cpp/ql/src/semmle/code/cpp/exprs/Expr.qll
...
Co-Authored-By: Jonas Jensen <jbj@github.com >
2019-11-14 11:29:03 +00:00
Geoffrey White
01b25199d0
CPP: Lesser than -> Less than.
2019-11-14 11:27:15 +00:00
Geoffrey White
238918c394
Update cpp/ql/src/semmle/code/cpp/Type.qll
...
Co-Authored-By: Jonas Jensen <jbj@github.com >
2019-11-14 11:24:54 +00:00
Geoffrey White
b3bda421bc
Update cpp/ql/src/semmle/code/cpp/Type.qll
...
Co-Authored-By: Jonas Jensen <jbj@github.com >
2019-11-14 11:24:15 +00:00
Geoffrey White
90909d211c
Update cpp/ql/src/semmle/code/cpp/Type.qll
...
Co-Authored-By: Jonas Jensen <jbj@github.com >
2019-11-14 11:24:00 +00:00