Dave Bartolomeo
36b27add24
Simplify ordering of children with conversions using rank
...
In `getChild(int childIndex)`, the actual values of `childIndex` don't matter, as long as they are in the correct order. Rather than doing complicated math to compute the indices for the synthesized `.getFullyConverted()` children, just use the `rank` aggregate to order all children first by whether or not the child is a conversion, then by the original child index.
2020-10-30 10:00:23 -04:00
Cornelius Riemenschneider
cf8f802310
C++: Rename predicate.
2020-10-30 12:51:19 +01:00
Cornelius Riemenschneider
ab42ddb0dc
C++: Adjust code for the conversions PR, provide correct childIndexes for the new nodes.
2020-10-30 12:48:53 +01:00
Cornelius Riemenschneider
4276d1f3e5
C++: Add missing comment and update test results.
2020-10-29 14:49:06 +01:00
Cornelius Riemenschneider
7e667b9bec
C++: Add comment to FunctionNode.
2020-10-29 14:49:06 +01:00
Cornelius Riemenschneider
668764ce40
C++: Make new predicates private.
2020-10-29 14:49:06 +01:00
Cornelius Riemenschneider
8c925a20a7
C++: Provide the predicates that can be used to traverse the AST as metadata.
2020-10-29 14:48:47 +01:00
Jonas Jensen
fa344d216f
Merge pull request #4493 from criemen/fix-4278-printast-conversions
...
Fix C++ Print AST handling of Conversions
2020-10-29 13:48:15 +01:00
CodeQL CI
7856e784e1
Merge pull request #4566 from asgerf/js/classnames
...
Approved by erik-krogh
2020-10-29 11:00:06 +00:00
Cornelius Riemenschneider
59dd892748
C++: Address review, fix bug related to Conversions.
2020-10-29 11:40:31 +01:00
Jonas Jensen
0af62b8431
Merge pull request #4515 from geoffw0/modelchanges1
...
C++: Changes to models library.
2020-10-29 11:21:56 +01:00
Tamás Vajk
64dcfbd7fc
Merge pull request #4484 from tamasvajk/feature/custom-assert-methods
...
C#: Add support for custom assert methods (DoesNotReturnIfAttribute)
2020-10-29 09:10:09 +01:00
Asger Feldthaus
4343fbff0e
Merge branch 'js/classnames' of github.com:asgerf/codeql into js/classnames
2020-10-28 17:00:14 +00:00
Asger Feldthaus
469767d279
JS: Fix test output
2020-10-28 17:00:05 +00:00
Geoffrey White
ae84d1383e
Merge pull request #4565 from MathiasVP/instruction-tag-for-this-addr-and-load-fix
...
C++: Fix spelling in getInstructionTagId
2020-10-28 16:53:55 +00:00
Asger F
056ce38dad
Update javascript/ql/src/semmle/javascript/frameworks/Classnames.qll
...
Co-authored-by: Erik Krogh Kristensen <erik-krogh@github.com >
2020-10-28 14:35:37 +00:00
Tamas Vajk
410af42d2b
C#: Adjust PR feedback on assertion methods
2020-10-28 15:09:50 +01:00
Asger Feldthaus
081017ea8a
JS: Autoformat
2020-10-28 13:58:02 +00:00
Asger Feldthaus
3c437d319a
JS: Change note
2020-10-28 13:56:35 +00:00
Asger Feldthaus
3d86e855f3
JS: Add model of classnames and clsx
2020-10-28 13:56:35 +00:00
Tamás Vajk
59d9be48a7
Merge pull request #4438 from tamasvajk/feature/ast-fixes
...
C#: Fixes for AST printing
2020-10-28 14:52:24 +01:00
yoff
c8bb0509e5
Merge pull request #4563 from tausbn/python-remove-refersto-from-regex-libs
...
Python: Remove `refersTo` from `regex.qll`
2020-10-28 13:37:14 +01:00
Mathias Vorreiter Pedersen
614e2ba851
C++: Fix spelling
2020-10-28 13:05:37 +01:00
Mathias Vorreiter Pedersen
8c9f09195d
Merge pull request #4561 from criemen/varargs-hierarchy
...
C++: Make BuiltInVarArgs* classes subclasses of VarArgsExpr.
2020-10-28 13:03:57 +01:00
Tom Hvitved
2fea6f05f1
Merge pull request #4489 from hvitved/csharp/cil-to-string
...
C#: Simplify `toString()` for CIL entities
2020-10-28 12:56:10 +01:00
CodeQL CI
8e57f57643
Merge pull request #4559 from erik-krogh/redis
...
Approved by asgerf
2020-10-28 11:47:12 +00:00
Taus Brock-Nannestad
1503c5ea16
Python: Remove refersTo from regex.qll
...
This was causing the old `Object` API stuff to be evaluated when using
our new library models (specifically the Django model).
2020-10-28 12:41:17 +01:00
Tamas Vajk
1830eea50a
C#: Cleanup TypeMentions in AST printing
2020-10-28 12:34:12 +01:00
Tamas Vajk
444b100c51
Minor fix in definitions.qll
2020-10-28 12:23:12 +01:00
Tamas Vajk
a9e93e5681
C#: Fix GenericType locations in jump-to-definition
2020-10-28 12:07:27 +01:00
Anders Schack-Mulligen
f3e2bd0fd9
Merge pull request #3141 from pwntester/InsecureBeanValidation
...
Insecure Bean Validation query
2020-10-28 12:04:12 +01:00
Erik Krogh Kristensen
75d996a0f9
make promisify smaller
2020-10-28 11:59:21 +01:00
Erik Krogh Kristensen
bce06d3194
add test that promisify is not imprecise
2020-10-28 11:59:03 +01:00
Erik Krogh Kristensen
c49d5081cc
Update javascript/ql/src/semmle/javascript/frameworks/NoSQL.qll
...
Co-authored-by: Asger F <asgerf@github.com >
2020-10-28 11:45:58 +01:00
Tamas Vajk
64b584b4a3
C#: Fix PR review findings in NamespaceDeclaration
2020-10-28 11:30:17 +01:00
Tamas Vajk
9cc7424cd0
C#: Simplify TypeMentions in PrintAST
2020-10-28 11:28:06 +01:00
Tamas Vajk
c2e8d3fb3b
C#: Minor fix in TypeMention
2020-10-28 11:28:06 +01:00
Tom Hvitved
92461d41e0
C#: Add change note
2020-10-28 11:02:12 +01:00
Tom Hvitved
28607927ee
C#: Update CIL tests
2020-10-28 10:57:01 +01:00
Cornelius Riemenschneider
f1f64fb7df
C++: Make BuiltInVarArgs* classes subclasses of VarArgsExpr.
2020-10-28 10:48:00 +01:00
Tamás Vajk
7c3964a388
Merge pull request #4543 from tamasvajk/feature/configureawait
...
C#: Add flow summary for 'Task.ConfigureAwait()'
2020-10-28 10:42:44 +01:00
Erik Krogh Kristensen
2e514c4d7b
add model for Node Redis
2020-10-28 09:52:54 +01:00
Anders Schack-Mulligen
34ae6e0576
Apply suggestions from code review
...
Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com >
2020-10-28 09:15:08 +01:00
Tom Hvitved
02ca8fe3b7
Merge pull request #4556 from hvitved/csharp/dataflow/tuple-perf
...
C#: Fix bad join-order in `System.Tuple` flow-summaries
2020-10-28 08:50:37 +01:00
Tamas Vajk
7a1e1996e4
C#: Remove unneded class from CompilerServices.qll
2020-10-28 08:42:20 +01:00
Dave Bartolomeo
27ad7bc297
Merge pull request #4560 from MathiasVP/instruction-tag-for-this-addr-and-load
...
C++: Make sure getInstructionTagId has a result for `this` related IPA branches
2020-10-27 21:01:09 -04:00
Mathias Vorreiter Pedersen
ad9e7b7343
C++: Give getInstructionTagId a result when tag is ThisAddressTag or ThisLoadTag
2020-10-27 22:16:01 +01:00
Alvaro Muñoz
77b551b693
Update java/ql/src/Security/CWE/CWE-094/InsecureBeanValidation.qhelp
...
Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com >
2020-10-27 21:12:17 +01:00
Alvaro Muñoz
b9c75ea462
Update java/ql/src/Security/CWE/CWE-094/InsecureBeanValidation.qhelp
...
Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com >
2020-10-27 21:12:00 +01:00
Alvaro Muñoz
ac116da0dc
Update java/ql/src/Security/CWE/CWE-094/InsecureBeanValidation.qhelp
...
Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com >
2020-10-27 21:11:48 +01:00