Mathias Vorreiter Pedersen
499ab0892f
C++: Currently, to catch flow in an example such as:
...
```cpp
char* source();
void sink(const char*);
int sprintf(char *, const char *, ...);
void call_sprintf(char* path, char* data) {
sprintf(path, "%s", "abc"); // (1)
sprintf(path, "%s", data); // (2)
}
void foo() {
char path[10];
call_sprintf(path, source()); // (3)
sink(path);
}
```
we identify that the `*path [post update]` node at `// (2)` is a
`ReturnNodeExt` and since `*data` flows to that node flow will be carried
out to `*path [post update]` at // (3) and thus reach `sink(path)`.
The reason `*path [post update]` at `// 2` is recognized as a `ReturnNodeExt`
is because it satisfies the following condition (which is identified by the
shared dataflow library):
There is flow from the parameter node `*path` to the pre-update node of the
post-update node `*path [post update]` at `// (2)`.
However, when we start recognizing that the call to `sprintf(path, ...)` at
`// (1)` overrides the value of `*path` and no longer provide use-use flow out
of `*path` the `*path [post update]` node at `// (2)` is no longer recognized
as a `ReturnNodeExt` (because it doesn't satisfy the above criteria).
Thus, we need to identify the flow above without relying on the dataflow
library's summary mechanism. That is, instead of relying on the dataflow
library's mechanism to summarize the `*data -> *path` flow for `call_sprintf`
we need to:
- Ensure that the write to `*path` at `// (2)` is recognized as the "final"
write to the parameter, and
- Ensure that there's flow out of that parameter and back to
`*path [post update]` at `// (3)`.
Luckiky, we do all of this already to support flow out of writes to parameters
that don't have post-update nodes. For example, in something like:
```cpp
void set(int* x, int y) {
*x = y;
}
void test() {
int x;
set(&x, source());
sink(x);
}
```
So in order to make the original example work, all we need to do is to remove
the restrictions on this mechanism so that the same mechanism that makes the
above example work also makes the original example work!
2024-02-16 13:09:45 +01:00
Mathias Vorreiter Pedersen
7e9bf2a880
C++: Add a model for 'partial updating' and extend models appropriately.
2024-02-16 12:56:19 +01:00
Mathias Vorreiter Pedersen
24a63ae94d
C++: Block flow by default.
2024-02-16 12:56:19 +01:00
Mathias Vorreiter Pedersen
625c47fa9c
C++: Add a testcase.
2024-02-16 12:56:19 +01:00
Mathias Vorreiter Pedersen
c19ed4c17e
Merge pull request #15626 from MathiasVP/fix-constness-checking
...
C++: Don't strip specifiers away in `TFinalParameterUse`
2024-02-16 10:09:43 +01:00
Benjamin Rodes
d6b0746b30
The non-constant format query is now a path query. Minor changes to the output alert to be more precise on what is being alerted. Minor changes to the query itself to avoid redundancies with argv.
2024-02-15 12:14:52 -05:00
Jeroen Ketema
da3ff4813f
Merge pull request #15612 from jketema/destructors4a
...
C++: Support `constexpr if` in the IR
2024-02-15 17:29:56 +01:00
Benjamin Rodes
9e50fc6893
Updating tests to account for removing const char* heuristic.
2024-02-15 09:54:03 -05:00
Benjamin Rodes
caf2ee27fa
Adding false negative tests for future work.
2024-02-15 09:43:26 -05:00
Mathias Vorreiter Pedersen
532e8dac45
C++: Don't strip specifiers in 'TFinalParameterUse'.
2024-02-15 14:08:12 +01:00
Jeroen Ketema
33413129a5
C++: For unnamed local variable declaration entries consider the name of the variable
2024-02-14 15:03:04 +01:00
Jeroen Ketema
46bc311111
C++: Support constexpr if in the IR
2024-02-14 13:37:56 +01:00
Jeroen Ketema
c79cc493e8
C++: Accept more test changes
2024-02-13 21:53:51 +01:00
Jeroen Ketema
a3b3aa4f25
C++: Update tests after extractor changes
2024-02-13 21:31:21 +01:00
Jeroen Ketema
caf09e0735
C++: Update IR comment that no longer applies
2024-02-13 21:30:58 +01:00
Jeroen Ketema
b3aea0f893
C++: Do not print the qualifier of OverloadedPointerDereferenceExpr twice in PrintAST
2024-02-13 21:29:21 +01:00
Jeroen Ketema
b776cbe668
Merge pull request #15597 from jketema/destructors2
...
C++: Update test results of `constexpr if` destructors
2024-02-13 19:59:19 +01:00
Benjamin Rodes
5c508553f3
Efficiency improvement (force a better join order)
2024-02-13 09:42:08 -08:00
Robert Marsh
7e23ccd383
Merge branch 'main' into rdmarsh2/cpp/ir-synthetic-destructors
2024-02-13 15:45:51 +00:00
Robert Marsh
128bc99f90
C++: delete some FIXMEs that turned out fine
2024-02-13 15:34:36 +00:00
Mathias Vorreiter Pedersen
fb4bd53ec5
Revert "Merge pull request #15528 from MathiasVP/flow-barrier-interface"
...
This reverts commit c5dc88345d781486172e
2024-02-13 13:42:58 +00:00
Mathias Vorreiter Pedersen
cb7fe16ced
Revert "Merge pull request #15537 from MathiasVP/swap-also-clears-first-argument"
...
This reverts commit 23677b23c2c5dc88345d
2024-02-13 13:42:58 +00:00
Jeroen Ketema
f3e55a46ee
C++: Update test results of constexpr if destructors
2024-02-13 13:37:59 +01:00
Mathias Vorreiter Pedersen
048b3727f5
Merge pull request #15587 from MathiasVP/fix-memset-model
...
C++: Fix `memset` model
2024-02-13 10:45:08 +00:00
Jeroen Ketema
fb072a5156
C++: Add additional IR tests for init statements
2024-02-13 10:44:24 +01:00
Jeroen Ketema
8aeb75675a
C++: Add constructor and destructor for vector to IR test
2024-02-13 10:39:27 +01:00
Jeroen Ketema
b509645e02
C++: Bump language version in IR tests to C++20
2024-02-13 10:18:31 +01:00
Robert Marsh
b9785ea7b2
C++: autoformat
2024-02-13 01:07:41 +00:00
Robert Marsh
f791b0ebbf
C++: Model for smart pointer destructors
2024-02-13 01:00:46 +00:00
Robert Marsh
b6cf64cff3
C++: simplify TranslatedBlock::getLastChild
2024-02-13 00:46:53 +00:00
Robert Marsh
7d8872bb99
C++: Fix for multiple for-loop variables with destructors
2024-02-13 00:40:19 +00:00
Robert Marsh
6663420d39
C++: test for multiple for loop variables with destructors
2024-02-13 00:35:56 +00:00
Robert Marsh
b94c4a6e1b
C++: fix for destructor of while-loop condition
2024-02-13 00:13:22 +00:00
Robert Marsh
bac7e46b0f
C++: tests for destructors after a while-loop condition
2024-02-12 23:55:42 +00:00
Mathias Vorreiter Pedersen
a799399639
C++: Accept test changes.
2024-02-12 16:51:25 +00:00
Mathias Vorreiter Pedersen
70c7c1a5e7
C++: Add flow from the fill character to the output pointer.
2024-02-12 16:51:16 +00:00
Mathias Vorreiter Pedersen
8635b5d316
C++: Add test with missing flow.
2024-02-12 16:44:38 +00:00
Benjamin Rodes
091416131b
Removing 'const' specifier filtering after discussions with the team. We will test if this causes undesirable cases in DCA and then choose which approach is best.
2024-02-12 09:38:00 -05:00
Robert Marsh
d1160f86e1
C++: Autoformat for named destructors in IR
2024-02-09 22:35:12 +00:00
Robert Marsh
1b571f8992
C++: Accept test changes
2024-02-09 22:32:08 +00:00
Geoffrey White
0c3aa7b7f2
C++: Add an inline test for interpretElement matching.
2024-02-09 18:57:05 +00:00
Geoffrey White
8bdb67cc15
C++: Allow member variables to be picked as input nodes.
2024-02-09 14:24:37 +00:00
Mathias Vorreiter Pedersen
4eae191430
C++: Accept test changes.
2024-02-09 14:07:57 +00:00
Mathias Vorreiter Pedersen
4728cf5a12
C++: Allow the 'x' in 'x = source()' to be marked as a sink in MaD.
2024-02-09 14:07:48 +00:00
Mathias Vorreiter Pedersen
cd41a1ca8c
C++: Accept test changes.
2024-02-09 13:27:40 +00:00
Mathias Vorreiter Pedersen
3719e10ce8
C++: Add a case for global or namespace variables in 'interpretElement0'.
2024-02-09 13:27:32 +00:00
Mathias Vorreiter Pedersen
52a1d905f1
C++: Qualified import of 'cpp' to make the file compile.
2024-02-09 13:25:17 +00:00
Anders Schack-Mulligen
566351a49a
Merge pull request #15549 from aschackmull/dataflow/empty-provenance
...
Dataflow: Add empty provenance column to PathGraph.
2024-02-09 12:58:09 +01:00
Mathias Vorreiter Pedersen
a42c845b32
Merge pull request #15559 from MathiasVP/fix-constness-type
...
C++: Don't strip specifiers in `Node.getType`
2024-02-09 11:00:13 +00:00
Anders Schack-Mulligen
7eb5e1833d
C++: Add empty provenance column to expected files.
2024-02-09 11:32:08 +01:00
