hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-23 15:55:18 +02:00
Code Issues Packages Projects Releases Wiki Activity

Removing 'const' specifier filtering after discussions with the team. We will test if this causes undesirable cases in DCA and then choose which approach is best.

Browse Source
This commit is contained in:
Benjamin Rodes
2024-02-12 09:38:00 -05:00
parent d4bc2ceb37
commit 091416131b
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
cpp/ql/src/Likely Bugs/Format/NonConstantFormat.ql
View File

@@ -65,7 +65,7 @@ predicate isNonConst(DataFlow::Node node) {
or
// Parameters of uncalled functions that aren't const
exists(UncalledFunction f, Parameter p |
not hasConstSpecifier(p.getType()) and
//not hasConstSpecifier(p.getType()) and
f.getAParameter() = p and
p = node.asParameter()
)
@@ -78,11 +78,13 @@ predicate isNonConst(DataFlow::Node node) {
// The function's output must also not be const to be considered a non-const source
exists(Call c |
exists(Expr arg | c.getAnArgument() = arg |
arg = node.asDefiningArgument() and
not hasConstSpecifier(arg.getType())
arg = node.asDefiningArgument()
// and
// not hasConstSpecifier(arg.getType())
)
or
c = node.asIndirectExpr() and not hasConstSpecifier(c.getType())
c = node.asIndirectExpr()
// and not hasConstSpecifier(c.getType())
) and
not exists(Function func, FunctionInput input, FunctionOutput output, CallInstruction call |
// NOTE: we must include dataflow and taintflow. e.g., including only dataflow we will find sprintf