tiferet
210644e87d
Delete StandardEndpointFilters.
...
All remaining functionality in `StandardEndpointFilters` is only being used in `EndpointCharacteristics`, so it can be moved there as a small set of helper predicates.
2022-11-28 11:34:34 -08:00
tiferet
15121931b4
Delete CoreKnowledge.
...
All remaining functionality in `CoreKnowledge` is only being used in `EndpointCharacteristics`, so it can be moved there as a small set of helper predicates.
2022-11-28 11:34:34 -08:00
tiferet
1c679378e7
FilteringReason is no longer being used and can be deleted
2022-11-28 11:34:33 -08:00
tiferet
99de397a5f
Remove redundant code
...
`isOtherModeledArgument` and `isArgumentToBuiltinFunction` contained the old logic for selecting negative endpoints for training.
These can now be deleted, and replaced by a single base class that collects all EndpointCharacteristics that are currently used to indicate negative training samples: `OtherModeledArgumentCharacteristic`.
This in turn lets us delete code from `StandardEndpointFilters` that effectively said that endpoints that are high-confidence non-sinks shouldn't be scored at inference time, either.
2022-11-28 11:34:33 -08:00
tiferet
7b0269c999
Fix British spelling that code scanning didn't like.
...
I've been working with Brits for too long :)
2022-11-28 11:28:08 -08:00
Tiferet Gazit
72c46c662c
Merge pull request #11462 from github/tiferet/endpoint-filters-sidebar
...
Endpoint filters added commits
2022-11-28 11:18:53 -08:00
tiferet
963407de4c
Update the documentation
2022-11-28 11:16:06 -08:00
tiferet
03b8e649f1
Filter endpoints by confidence
...
Select endpoints to score at inference time base purely on their confidence level, and not on whether they fit the historical definition of endpoint filters.
2022-11-23 10:46:27 -08:00
tiferet
1c9545e49a
Address comment from code review:
...
Make `SyntacticHeuristics` an explicit import
2022-11-21 08:00:31 -08:00
tiferet
8d22fd25f1
Suggestions from code review
2022-11-18 15:57:46 -08:00
tiferet
4a1382925e
Remove some imports that are no longer used
2022-11-16 14:01:16 -08:00
tiferet
ccbf1ca2a9
Add a comment
2022-11-16 13:05:06 -08:00
tiferet
38c40a7192
isEffectiveSink can't be final because ExtractMisclassifiedEndpointFeatures overrides it.
2022-11-16 12:12:50 -08:00
tiferet
8fee9cb0d5
Fix CodeQL warnings
2022-11-16 12:06:52 -08:00
tiferet
c2035e85d2
Be explicit in requiring that each ATM config set its endpoint type.
2022-11-16 11:55:23 -08:00
tiferet
0fd013f9fd
Update the reason names in FilteredTruePositives.expected.
...
This is needed because we changed the names of three endpoint filters that were all called "not a direct argument to a likely external library call or a heuristic sink" in order to disambiguate them (fc56c5a022
2022-11-16 11:54:10 -08:00
tiferet
eab270eb84
Move the definitions of isEffectiveSink and getAReasonSinkExcluded to the base class.
...
They can now be implemented generically for all sink types.
2022-11-16 11:47:24 -08:00
tiferet
fc56c5a022
Implement the type-specific endpoint filters as EndpointCharacteristics.
...
Also disambiguate three filters from three different sink types that all have the same name, "not a direct argument to a likely external library call or a heuristic sink".
2022-11-16 11:14:25 -08:00
tiferet
13cb0ab554
Fix CodeQL warning
2022-11-15 17:32:30 -08:00
tiferet
2ecdfd1ff6
Delete some code that's no longer in use
2022-11-15 17:29:03 -08:00
tiferet
fedb98ddb5
Implement the standard getAReasonSinkExcluded using StandardEndpointFilterCharacteristics
2022-11-15 17:22:00 -08:00
tiferet
cf4e37a0ab
Implement the standard endpoint filters as EndpointCharacteristics
2022-11-15 17:20:20 -08:00
tiferet
cb632b3534
Delete the file ExtractEndpointData.expected which was leftover in the last PR
2022-11-15 17:11:34 -08:00
Tiferet Gazit
710b215c38
Merge pull request #11263 from github/tiferet/extract-training-data
...
ATM: Extract training data
2022-11-15 12:08:13 -08:00
tiferet
fc078a47fd
Apply suggestion from code review
2022-11-15 11:14:01 -08:00
Tiferet Gazit
092e019de9
Apply suggestions from code review
...
Co-authored-by: Stephan Brandauer <kaeluka@github.com >
2022-11-15 10:48:32 -08:00
Andrew Eisenberg
2ffb4b6480
Merge pull request #11279 from github/aeisenberg/atm-readme
...
Add more information about ATM queries for external users
2022-11-15 10:46:03 -08:00
Andrew Eisenberg
88750a7000
Add more information about ATM queries for external users
2022-11-15 10:17:56 -08:00
AlexDenisov
f069802abb
Merge pull request #11277 from github/redsun82/swift-remove-ipa-from-dbscheme-cpp
...
Swift: remove IPA classes from `cppgen`
2022-11-15 18:34:59 +01:00
AlexDenisov
eb2f1ff559
Merge pull request #11274 from github/redsun82/swift-remove-double-newlines-in-schema
...
Swift: remove double newlines in schema
2022-11-15 18:34:32 +01:00
Erik Krogh Kristensen
6f4fd3ef72
Merge pull request #11175 from erik-krogh/erb
...
JS: extract .erb files as html
2022-11-15 18:21:48 +01:00
Jeroen Ketema
d79c722d95
Merge pull request #11278 from jketema/dataflow-test-typo
...
C++: Fix typo in dataflow test comment
2022-11-15 17:33:06 +01:00
Jeroen Ketema
98176007d8
C++: Fix type in dataflow test comment
2022-11-15 17:18:08 +01:00
erik-krogh
cec5045b52
Merge branch 'main' into erb
2022-11-15 17:16:05 +01:00
Erik Krogh Kristensen
68e513c6a4
Merge pull request #11246 from erik-krogh/java-redosMod
...
Java: use the shared regex pack
2022-11-15 17:12:52 +01:00
Paolo Tranquilli
56b207e41f
Swift: remove IPA classes from cppgen
2022-11-15 17:07:52 +01:00
Tony Torralba
89a8ccb828
Merge pull request #11273 from atorralba/atorralba/swift/string-utf8-step
...
Swift: Add `AdditionalTaintStep`
2022-11-15 16:46:26 +01:00
Tony Torralba
0570610765
Merge pull request #11138 from atorralba/atorralba/swift/xxe-query-aexml-sinks
...
Swift: Add AEXML sinks to XXE query
2022-11-15 16:42:17 +01:00
Erik Krogh Kristensen
f7b5a4d170
Merge pull request #11203 from erik-krogh/shouldBePath
...
C#: update cs/assembly-path-injection cs/hardcoded-key to path-problems
2022-11-15 16:24:05 +01:00
Tony Torralba
8ca004fde1
Add AdditionalTaintStep
2022-11-15 16:14:22 +01:00
Paolo Tranquilli
635391eae8
Swift: autopep8 integration tests
2022-11-15 15:43:05 +01:00
Paolo Tranquilli
c2171c01e1
Swift: remove double newlines in schema
...
While PEP8 mandates those, they look bad in the schema file.
`autopep8` already ignores those, and they were single newlines at some
point until an overeager IDE has "fixed" them at some point without me
realizing.
Also, the pre-commit configuration was updated to take `schema.py` into
account.
2022-11-15 15:00:30 +01:00
Asger F
dc440aaee6
Merge pull request #11255 from asgerf/js/dynamic-import-type-expr
...
JS: Handle DynamicImport in the context of a type
2022-11-15 13:31:08 +01:00
Stephan Brandauer
4b9b35d1c2
Merge pull request #11267 from github/atm/fix-non-sink-characteristics-hierarchy
...
ATM: remove superfluous class in EndpointCharacteristics hierarchy
2022-11-15 12:59:42 +01:00
erik-krogh
dff7b475fb
make the top-level comment in SuperlinearBackTracking.qll a QLDoc
2022-11-15 11:46:44 +01:00
Nick Rolfe
8d854e0a6b
Merge pull request #11252 from github/nickrolfe/active_support_enumerable
...
Ruby: add flow summary for Enumerable#index_by
2022-11-15 10:40:42 +00:00
Stephan Brandauer
ec3578364e
remove superfluous class in EndpointCharacteristics hierarchy
2022-11-15 10:17:38 +01:00
tiferet
9ecff0723c
Fix non-ascii character in docs
2022-11-14 16:34:24 -08:00
tiferet
6b7612fed7
Fix import errors in DebugResultInclusion.ql
2022-11-14 15:33:46 -08:00
tiferet
b47723d607
Delete ExtractEndpointData.
...
Also remove the associated test files.
2022-11-14 14:57:59 -08:00
