Max Schaefer
3ed40d5da1
Merge branch 'master' into range-analysis
2018-11-30 09:36:40 +00:00
semmle-qlci
1c5322274a
Merge pull request #557 from esben-semmle/js/unused-react-variable
...
Approved by xiemaisi
2018-11-30 09:35:36 +00:00
Max Schaefer
dcad2a3431
JavaScript: Simplify an if condition.
...
By pulling this out of the condition we can avoid computing its negation for the `else` branch, which could previously lead to quite an enormous pipeline.
2018-11-30 09:32:31 +00:00
Tom Hvitved
610be85c8c
C#: Add CFG test for multiple-field Boolean splitting
2018-11-30 10:32:08 +01:00
Jonas Jensen
9babb4366b
Merge remote-tracking branch 'upstream/master' into mergeback-20181130
2018-11-30 10:13:33 +01:00
semmle-qlci
adc15cad07
Merge pull request #574 from xiemaisi/js/avoid-materialisation
...
Approved by esben-semmle
2018-11-30 08:30:14 +00:00
Jonas Jensen
dd3791490a
Merge pull request #580 from geoffw0/av-79-perf
...
CPP: Fix performance issue with AV Rule 79.ql.
2018-11-30 08:39:38 +01:00
Felicity Chapman
586eaef270
Update for feedback
2018-11-29 18:20:34 +00:00
Mark Shannon
9aa59fd419
Fix spelling.
2018-11-29 18:11:57 +00:00
Tom Hvitved
8bd8975795
Merge pull request #568 from calumgrant/cs/index-out-of-bounds
...
C#: Fix false-positives in cs/index-out-of-bounds
2018-11-29 18:40:05 +01:00
Jonas Jensen
b98452ddb1
Merge pull request #474 from rdmarsh2/rdmarsh/cpp/call-side-effect
...
C++: Initital aliased SSA with Chi nodes and function side effects
2018-11-29 18:31:29 +01:00
Geoffrey White
4744cece7b
Merge pull request #576 from jbj/bbEntryReachesLocally-perf
...
C++: Fix performance of bbEntryReachesLocally (1.19)
2018-11-29 17:12:47 +00:00
Asger F
f85e30aa6c
Merge pull request #571 from xiemaisi/js/numeric-constant-interpreted-as-code
...
JavaScript: Add new query `HardcodedDataInterpretedAsCode`.
2018-11-29 17:07:48 +00:00
Mark Shannon
931122971d
Python points-to: Improve performance by factoring out handling of tuples in class tests.
2018-11-29 16:27:50 +00:00
Taus
1956cd802f
Merge pull request #577 from markshannon/python-fix-performance-regression-dependencies
...
Python: Fix performance regression in dependency analysis
2018-11-29 16:41:58 +01:00
Geoffrey White
e09ce77678
CPP: Fix performance issue with AV Rule 79.ql.
2018-11-29 15:16:01 +00:00
Tom Hvitved
a12a72e90f
C#: Fix bug in guards library when the guarded expression is in a loop
...
Follow-up on 03e69e9945 .
2018-11-29 15:53:03 +01:00
Mark Shannon
11ca7b74a3
Merge pull request #572 from geoffw0/deprecate-cpython
...
CPP: Delete CPython queries
2018-11-29 14:50:06 +00:00
Jonas Jensen
90ad5cfac5
Merge pull request #569 from geoffw0/deprecate-pointsto-debug
...
CPP: Deprecate the PointsTo debug queries.
2018-11-29 15:28:07 +01:00
Mark Shannon
8414d46a87
Python: Fix accidentally introduced cartesian product.
2018-11-29 14:19:47 +00:00
Jonas Jensen
62d478eab3
C++: Fix performance of bbEntryReachesLocally
...
This predicate was fast with the queries and engine from 1.18. With the
queries from `master` it got a bad join order in the
`UninitializedLocal.ql` query, which made it take 2m34s on Wireshark.
This commit decomposes `bbEntryReachesLocally` into two predicates that
together take only 4s.
2018-11-29 15:11:32 +01:00
Jonas Jensen
8654ebcbbd
C++: Avoid using nullValue predicate
...
The `nullValue` predicate performs a slow custom data-flow analysis to
find possible null values. It's so slow that it timed out after 1200s on
Wireshark.
In `UnsafeCreateProcessCall.ql`, the values found with `nullValue` were
used as sources in another data-flow analysis. By using the `NullValue`
class as sink instead of `nullValue`, we avoid the slow-down of doing
data flow twice. The `NullValue` class is essentially the base case of
`nullValue`. Confusing names, yes.
2018-11-29 13:33:45 +01:00
calum
6a1ab51d66
C#: Address review comments.
2018-11-29 11:39:10 +00:00
Asger F
d4023fe95a
JS: address review
2018-11-29 11:37:38 +00:00
Asger F
b2a82ae598
JS: add 1.20 change note
2018-11-29 11:26:31 +00:00
Max Schaefer
73ce0f17d6
JavaScript: Americanise change note spelling.
2018-11-29 11:23:47 +00:00
Asger F
959776b775
JS: add test case
2018-11-29 11:22:15 +00:00
Asger F
d69e584cc2
JS: fix bug in foldedComparisonEdge
2018-11-29 11:22:15 +00:00
Asger F
8fd3a417c2
JS: address comments
2018-11-29 11:22:15 +00:00
Asger F
2c51f86f1b
JS: avoid joining on =0
2018-11-29 11:22:14 +00:00
Asger F
6d7ac885ec
JS: add to correctness-more suite
2018-11-29 11:22:14 +00:00
Asger F
477be260f3
JS: rename UselessRangeCheck -> UselessComparisonTest
2018-11-29 11:22:14 +00:00
Asger F
2e65f6b660
JS: address some style comments
2018-11-29 11:22:14 +00:00
Asger F
2870209299
JS: fix links in qhelp file
2018-11-29 11:22:14 +00:00
Asger F
76a69f4ff2
JS: address review comments
2018-11-29 11:22:14 +00:00
Asger F
f3020f776e
JS: avoid extending self-edges
2018-11-29 11:22:14 +00:00
Asger F
4a367d3fdb
JS: more efficient encoding of unary constraints
2018-11-29 11:22:14 +00:00
Asger F
5283c6cd48
JS: only warn about dead code
2018-11-29 11:22:14 +00:00
Asger F
2d6bf0aff3
JS: improve join ordering in extendedEdge
2018-11-29 11:22:14 +00:00
Asger F
84ea4cf1d1
JS: manually reorder extendedEdge and negativeEdge
2018-11-29 11:22:14 +00:00
Asger F
344bec3865
JS: Add UselessRangeCheck.ql
2018-11-29 11:22:14 +00:00
Asger F
d813635f3e
JS: Restrict constraint generation to relevant nodes
2018-11-29 11:22:14 +00:00
Asger F
43df9538bf
JS: be conservative in presence of NaN comments
2018-11-29 11:22:14 +00:00
Asger F
feb8a8c4fd
JS: restrict bias to 30-bit range to avoid overflow
2018-11-29 11:22:14 +00:00
Asger F
20aa4e1f6d
JS: handle sharp inequalities directly
2018-11-29 11:22:14 +00:00
Asger F
9d8d953292
JS: perform widening when adding operands of very different magnitude
2018-11-29 11:22:14 +00:00
Asger F
6c53ad80c7
JS: add constant constraints in range analysis
2018-11-29 11:22:13 +00:00
Asger F
064b1099eb
JS: range analysis through phi nodes
2018-11-29 11:22:13 +00:00
Asger F
09ca6652fb
JS: Support return value of x++
2018-11-29 11:22:13 +00:00
Asger F
73cbdee691
JS: Compound assignments and update exprs in range analysis
2018-11-29 11:22:13 +00:00