Commit Graph

29908 Commits

Author SHA1 Message Date
Felicity Chapman
62dc486190 Add query ids and update descriptions 2018-12-04 16:40:54 +00:00
semmle-qlci
d05b11f00d Merge pull request #587 from asger-semmle/incorrect-suffix-check
Approved by mc-semmle, xiemaisi
2018-12-04 16:18:42 +00:00
Taus
8493518135 Merge pull request #599 from markshannon/python-fix-essa-nonlocal
Python ESSA: Fix definition of ESSA non-local variables.
2018-12-04 17:06:30 +01:00
Taus
3b6c7d6f2e Merge pull request #582 from markshannon/python-faster-points-to-2
Python points-to: Improve performance of subclass test predicates on large DBs
2018-12-04 16:51:21 +01:00
Dave Bartolomeo
e11b4b6c40 C++: Fix IR Dataflow PR feedback 2018-12-04 07:31:13 -08:00
yh-semmle
0ba7633e4d Merge pull request #553 from aschackmull/java/double-checked-locking
Java: Add two double-checked-locking queries.
2018-12-04 10:23:46 -05:00
Taus
5c3ff8aadd Merge pull request #604 from markshannon/python-faster-essa-computation
Python : Speed up ESSA computation
2018-12-04 16:20:49 +01:00
Tom Hvitved
3bb3de23ce C#: Update change note 2018-12-04 16:08:41 +01:00
semmle-qlci
732874b236 Merge pull request #610 from Semmle/xiemaisi-patch-1
Approved by esben-semmle
2018-12-04 14:44:49 +00:00
Max Schaefer
2e45c50067 JavaScript: Correct change note for new query.
"Hard-coded data interpreted as code" is run, but not shown by default.
2018-12-04 14:40:03 +00:00
Geoffrey White
a7f45bb59d Merge pull request #608 from jbj/assignment-this-templates
C++: Fix "Overloaded assignment does not return 'this'" for templates
2018-12-04 14:12:56 +00:00
james
bdda3ae477 fix typo 2018-12-04 14:01:11 +00:00
Tom Hvitved
ad77afef04 C#: Autobuilder fixes
This commit fixes a few issues that were identified during the last dist upgrade,
and which were introduced/revealed on 836daaf07b.

- Expand environment variables that are passed from `lgtm.yml` to the autobuilder,
  for example `solution: $LGTM_SRC/mysolution.sln`.
- Distinguish between when a build rule is applied automatically and when it is applied
  manually via `lgtm.yml`.
- Catch `FileNotFoundException`s when parsing project files and solution files.
2018-12-04 14:03:39 +01:00
Aditya Sharad
3caf4e52a7 Merge rc/1.19 into next. 2018-12-04 12:39:41 +00:00
Jonas Jensen
6239455a91 C++: Remove extra type check in AV Rule 82
These type checks were overlapping with `assignOperatorWithWrongType` is
are no longer needed now that `assignOperatorWithWrongType` is improved.
They were causing FPs and misleading error messages on uninstantiated
templates.
2018-12-04 12:59:21 +01:00
james
26f030045a address anders' feedback 2018-12-04 11:07:17 +00:00
Asger F
7121a18eba JS: address comments 2018-12-04 10:40:43 +00:00
Jonas Jensen
8ac427c387 C++: Add missing getUnspecifiedType in AV Rule 82
Adding this call to `getUnspecifiedType` makes the error message better
in the presence of typedefs and qualifiers on an assignment operator
return type. It's also needed to avoid losing valid results in the
commit that comes after this.
2018-12-04 11:13:11 +01:00
Taus
a23f7a6b0e Merge pull request #592 from markshannon/python-windows-import-root
Python: Fix up computation of import root path
2018-12-04 11:11:59 +01:00
Jonas Jensen
a78ded7551 C++: Demonstrate FP in AV Rule 82
The added test is a reduced version of a FP observed in the wild.
2018-12-04 11:09:35 +01:00
Mark Shannon
8cd497890a Merge pull request #546 from adityasharad/python/vs-workspace-settings
Python: Add QL for VS workspace settings file.
2018-12-04 10:00:09 +00:00
Esben Sparre Andreasen
b418968efb JS: add change note for improved React model 2018-12-04 10:55:24 +01:00
Esben Sparre Andreasen
679db191f5 JS: move shared conjunct up 2018-12-04 10:55:24 +01:00
Esben Sparre Andreasen
a342fa36c6 JS: support React getSnapshotBeforeUpdate 2018-12-04 10:48:35 +01:00
Esben Sparre Andreasen
67b1487384 JS: support React shouldComponentUpdate 2018-12-04 10:48:35 +01:00
Esben Sparre Andreasen
417dac7ad6 JS: support React getDerivedStateFromProps 2018-12-04 10:48:35 +01:00
Esben Sparre Andreasen
9ff3d2ef1f JS: introduce ReactComponent::getStaticMethod 2018-12-04 10:48:35 +01:00
Esben Sparre Andreasen
0d62191d84 JS: add more React tests 2018-12-04 10:48:35 +01:00
Felicity Chapman
da1bf0601f Sort tables alphabetically 2018-12-04 09:28:42 +00:00
Anders Schack-Mulligen
e836fa7512 Java: Update metadata. 2018-12-04 10:12:56 +01:00
ian-semmle
47e15a6f75 Merge pull request #605 from nickrolfe/agg_init
C++: fix expected test output for improved extraction of aggregate initialisers
2018-12-03 23:30:00 +00:00
Mark Shannon
a5b79e92a5 Python: Fix off-by-one error in regex parsing. 2018-12-03 16:50:47 +00:00
semmle-qlci
3d058a2895 Merge pull request #603 from xiemaisi/js/fix-inconsistent-new
Approved by asger-semmle, esben-semmle
2018-12-03 16:48:55 +00:00
Nick Rolfe
a637eb651f C++: fix expected test output for improved extraction of agg. inits. 2018-12-03 16:45:53 +00:00
ian-semmle
a43125c3e0 Merge pull request #591 from nickrolfe/CPP-298
C++: we now process operands for vacuous destructor calls through pointers
2018-12-03 16:42:00 +00:00
Geoffrey White
436ee553a6 Merge pull request #589 from jbj/1.19-change-notes
C++: add missing 1.19 change notes
2018-12-03 15:56:18 +00:00
Mark Shannon
68440f7f77 Python ESSA: Speed up ESSA computation by refactoring ADT to match class hierarchy making it more transparent to the optimizer. 2018-12-03 15:08:56 +00:00
Jonas Jensen
b80cf30cee Merge pull request #562 from geoffw0/cpp-308
CPP: Fix FPs for 'Resource not released in destructor' involving virtual method calls
2018-12-03 15:57:11 +01:00
Tom Hvitved
4739a6334e C#: Fix a bug and generalize guards implication logic 2018-12-03 15:33:00 +01:00
semmle-qlci
b58c263fd0 Merge pull request #602 from esben-semmle/js/additional-route-handlers-from-context
Approved by xiemaisi
2018-12-03 14:31:10 +00:00
Taus
76b1bbc56a Merge pull request #565 from markshannon/python-analysis-queries-qhelp
Python: Delete some misleading qhelp and rename a couple of queries.
2018-12-03 14:42:03 +01:00
Geoffrey White
d8c7537557 CPP: * -> + 2018-12-03 13:11:52 +00:00
Geoffrey White
dfbccc4bcf CPP: Additional test cases. 2018-12-03 13:11:52 +00:00
calumgrant
43d14ce011 Merge pull request #586 from hvitved/csharp/cfg/field-split
C#: Handle multiple-field Boolean CFG splitting
2018-12-03 12:52:43 +00:00
Max Schaefer
8627ddbe4b JavaScript: Adjust alert message. 2018-12-03 12:38:00 +00:00
Nick Rolfe
fc91ff1a69 C++: we now process operands for vacuous destructor calls thru pointers 2018-12-03 12:16:35 +00:00
Jonas Jensen
8f60c09804 C++: Clarify cpp/virtual-destructor changelog 2018-12-03 13:04:24 +01:00
Mark Shannon
d32e6b8501 Python tests: Make sure stdlib can be found. 2018-12-03 11:55:57 +00:00
Asger F
1130d0c6f9 JS: add comment about arrays 2018-12-03 11:23:02 +00:00
Asger F
374f7ab65d JS: address comments 2018-12-03 11:23:02 +00:00