Dave Bartolomeo
53cd5e9994
C++: Fix bug introduced by earlier commit
2018-11-27 14:57:58 -08:00
Dave Bartolomeo
7e6e6f00c1
C++: Fix IR for designated array initializers
2018-11-27 14:57:23 -08:00
Dave Bartolomeo
0a20f9ffbf
C++: Print field names and element indices for aggregate literals in PrintAST
2018-11-27 13:26:18 -08:00
Dave Bartolomeo
90b79eb5f3
C++: Accept GVN test expectations with Chi nodes
2018-11-27 12:56:23 -08:00
Geoffrey White
7107cec503
CPP: Add test cases.
2018-11-27 17:20:14 +00:00
Jonas Jensen
c403bb1cad
Merge pull request #541 from kevinbackhouse/CppPostDominators
...
Add post-dominators
2018-11-27 08:23:43 +01:00
Dave Bartolomeo
689002a22e
C++: Fix handling of Chi instructions in sign analysis
2018-11-26 16:46:39 -08:00
Robert Marsh
f4ce7b9648
C++: respond to further PR review comments
2018-11-26 16:16:46 -08:00
Robert Marsh
7ef0d5e98d
C++: respond to technical nits
2018-11-26 15:47:47 -08:00
Dave Bartolomeo
2b9afe95e8
C++: Accept test output after rebase
2018-11-26 12:08:19 -08:00
Robert Marsh
799eb06eea
C++: add AliasedDefinition for aliased SSA
2018-11-26 12:08:19 -08:00
Robert Marsh
3ee033d96e
C++: IR sanity fixes for Chi nodes
2018-11-26 12:08:19 -08:00
Robert Marsh
b401cd97f2
C++: use UnmodeledDefinition in UnmodeledUse
2018-11-26 12:08:19 -08:00
Robert Marsh
927f935e62
C++: hook ChiInstructions into the operand graph
2018-11-26 12:08:19 -08:00
Robert Marsh
a33b59103a
C++: insert Chi nodes in the IR successor relation
...
This commit adds Chi nodes to the successor relation and accounts for
them in the CFG, but does not add them to the SSA data graph. Chi nodes
are inserted for partial writes to any VirtualVariable, regardless of
whether the partial write reaches any uses.
2018-11-26 12:08:18 -08:00
Dave Bartolomeo
1fb36ff7e7
C++: Add conservative side effects for function calls
2018-11-26 12:08:18 -08:00
Robert Marsh
f9ed39915f
C++: recompute IRBlock membership at each stage
...
This enables the addition of new instructions in later phases of IR
construction; in particular, aliasing write instructions and inference
instructions.
2018-11-26 12:08:18 -08:00
Geoffrey White
f034abc275
CPP: Add the Semmle security tests.
2018-11-26 17:52:34 +00:00
Aditya Sharad
7aef8fa945
Merge pull request #547 from pavgust/fix/cwe-497-performance
...
C++: Refactor CWE-497 for clarity and performance
2018-11-26 17:13:27 +00:00
Kevin Backhouse
4877659578
Fix names.
2018-11-26 14:56:35 +00:00
Jonas Jensen
fcd53ae631
Merge pull request #540 from geoffw0/cpp-296
...
CPP: Fix false positive from AutoGeneratedFile.qll.
2018-11-26 15:03:21 +01:00
Kevin Backhouse
bc752e1a98
Add post-dominators.
2018-11-24 18:23:27 +00:00
Geoffrey White
f338a4f0d6
CPP: Fix false positive from AutoGeneratedFile.qll.
2018-11-23 17:34:18 +00:00
Aditya Sharad
c20b688a3f
Merge master into next.
2018-11-23 16:36:31 +00:00
Pavel Avgustinov
d4b2c01634
Lift out intermediate helper predicate.
2018-11-23 14:22:44 +00:00
Geoffrey White
0855543ac4
CPP: Tag the JPL_C LOC-4 queries.
2018-11-23 10:31:37 +00:00
Geoffrey White
e6dddd90b7
CPP: Add a test of FunctionPointerConversions.ql.
2018-11-23 10:31:36 +00:00
Geoffrey White
0a27022dd4
Merge pull request #523 from jbj/placement-new-never-freed
...
C++: Detect non-allocating placement new in cpp/memory-never-freed
2018-11-23 09:40:11 +00:00
Jonas Jensen
4ad59235d8
Merge pull request #524 from geoffw0/cpp-299
...
CPP: Add (partial) dataflow to OverflowStatic.ql
2018-11-23 08:46:07 +01:00
semmle-qlci
816a94eaa9
Merge pull request #525 from jbj/uninit-badast-mergefix
...
Approved by geoffw0, ian-semmle
2018-11-22 21:05:54 +00:00
Geoffrey White
5d8e34a55f
CPP: Add a test of NonConstFunctionPointer.ql.
2018-11-22 17:48:40 +00:00
Geoffrey White
17560cf92e
CPP: Tag the JPL_C LOC-3 queries.
2018-11-22 17:48:35 +00:00
Geoffrey White
9cc39ae875
CPP: Tag the JPL_C LOC-2 queries.
2018-11-22 16:31:08 +00:00
Geoffrey White
a47db56a68
CPP: Tag DuplicateBlock.ql.
2018-11-22 16:31:08 +00:00
Geoffrey White
cb609f4be0
CPP: Be conservative where there are multiple flow sources.
2018-11-22 15:50:13 +00:00
Geoffrey White
d57574e92c
CPP: localFlowStep* -> localFlow.
2018-11-22 15:50:13 +00:00
Geoffrey White
ea56a5d9ce
CPP: Add local dataflow to (one bit of) OverflowStatic.ql.
2018-11-22 15:49:13 +00:00
Geoffrey White
01ba635e1d
CPP: Add some test cases involving dataflow.
2018-11-22 15:49:13 +00:00
Geoffrey White
dc224c5c94
Merge pull request #521 from felicity-semmle/cpp/update-qhelp
...
C++: Update qhelp for consistency
2018-11-22 15:31:34 +00:00
Pavel Avgustinov
b9a3a71406
Merge pull request #518 from jbj/vcs-deprecate-queries
...
C++: Deprecate queries using VCS.qll
2018-11-22 15:07:19 +00:00
Jonas Jensen
da26b4f856
C++: Accept test changes for IR
...
This test was failing due to a semantic merge conflict between #509 ,
which added `UninitializedInstruction`, and #517 , which added new test
code that would get `UninitializedInstruction`s in it after merging with #509 .
2018-11-22 13:52:33 +01:00
Jonas Jensen
75873bb4a6
C++: Detect non-allocating placement new
...
This adds a `NewOrNewArrayExpr.getPlacementPointer` predicate and uses
it in `Alloc.qll` to detect when a `new`-expression is not an
allocation.
User-defined replacements for `operator new` may not be allocations
either, but the code continues to assume that they are. It's possible
that we want to change this assumption in the future or leave it up to
individual queries to decide on which side to err. It's hard to
statically tell whether `operator new` has been overloaded in a
particular file because it can be overloaded by a definition that is not
in scope but is only linked together with that file.
2018-11-22 11:31:19 +01:00
Felicity Chapman
8cad0b6ef1
Update qhelp for consistency
2018-11-22 10:25:41 +00:00
Jonas Jensen
a17debac3e
C++: Placement-new tests for MemoryNeverFreed.ql
2018-11-22 10:48:18 +01:00
Jonas Jensen
e062851709
Merge pull request #517 from dave-bartolomeo/dave/IRFilter
...
C++: Don't generate IR for functions with bad ASTs
2018-11-22 10:02:18 +01:00
Jonas Jensen
220487bb32
C++: Deprecate queries using VCS.qll
...
One query imported VCS.qll for no reason, so I removed the import
instead of deprecating the query.
2018-11-22 08:21:49 +01:00
Jonas Jensen
70e9d11fd2
Merge pull request #509 from dave-bartolomeo/dave/ConditionDeclExpr
...
C++: IR support for ConditionDeclExpr
2018-11-22 08:03:14 +01:00
Dave Bartolomeo
beb9c9c054
C++: Sync identical files
2018-11-21 16:51:47 -08:00
Dave Bartolomeo
97fd7b46cc
C++: Add tests for filtering bad ASTs
2018-11-21 16:39:08 -08:00
Dave Bartolomeo
7db36b2a22
C++: Skip IR translation for functions with invalid ASTs
...
An slightly invalid AST can cause IR construction to generate extremely bad IR. This change provides a single place to detect invalid ASTs, and to skip IR construction for the affected functions.
2018-11-21 16:01:19 -08:00
