hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 11:15:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

C++: Add tests for filtering bad ASTs

Browse Source
This commit is contained in:
Dave Bartolomeo
2018-11-21 16:39:08 -08:00
parent 7db36b2a22
commit 97fd7b46cc
6 changed files with 303 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

136
cpp/ql/test/library-tests/ir/ir/PrintAST.expected
View File

@@ -34,6 +34,142 @@
#-----| Type = unsigned long
#-----| 1: p#1
#-----| Type = align_val_t
bad_asts.cpp:
# 5| Bad::S::operator=(S &&) -> S &
# 5| params:
#-----| 0: p#0
#-----| Type = S &&
# 5| Bad::S::operator=(const S &) -> S &
# 5| params:
#-----| 0: p#0
#-----| Type = const S &
# 9| Bad::S::MemberFunction(int) -> int
# 9| params:
# 9| 0: y
# 9| Type = int
# 9| body: { ... }
# 10| 0: return ...
# 10| 0: ... + ...
# 10| Type = int
# 10| ValueCategory = prvalue
# 10| 0: ... + ...
# 10| Type = int
# 10| ValueCategory = prvalue
# 10| 0: Unknown literal
# 10| Type = int
# 10| ValueCategory = prvalue
# 10| 1: x
# 10| Type = int
# 10| ValueCategory = prvalue(load)
#-----| -1: this
#-----| Type = S *
#-----| ValueCategory = prvalue(load)
# 10| 1: y
# 10| Type = int
# 10| ValueCategory = prvalue(load)
# 9| MemberFunction(int) -> int
# 9| params:
# 9| 0: y
# 9| Type = int
# 9| body: { ... }
# 10| 0: return ...
# 10| 0: ... + ...
# 10| Type = int
# 10| ValueCategory = prvalue
# 10| 0: ... + ...
# 10| Type = int
# 10| ValueCategory = prvalue
# 10| 0: 6
# 10| Type = int
# 10| Value = 6
# 10| ValueCategory = prvalue
# 10| 1: x
# 10| Type = int
# 10| ValueCategory = prvalue(load)
#-----| -1: this
#-----| Type = S *
#-----| ValueCategory = prvalue(load)
# 10| 1: y
# 10| Type = int
# 10| ValueCategory = prvalue(load)
# 14| Bad::CallBadMemberFunction() -> void
# 14| params:
# 14| body: { ... }
# 15| 0: declaration
# 15| 0: definition of s
# 15| Type = S
# 15| init: initializer for s
# 15| expr: {...}
# 15| Type = S
# 15| ValueCategory = prvalue
# 16| 1: ExprStmt
# 16| 0: call to MemberFunction
# 16| Type = int
# 16| ValueCategory = prvalue
# 16| -1: s
# 16| Type = S
# 16| ValueCategory = lvalue
# 16| 0: 1
# 16| Type = int
# 16| Value = 1
# 16| ValueCategory = prvalue
# 17| 2: return ...
# 19| Bad::Point::Point(Point &&) -> void
# 19| params:
#-----| 0: p#0
#-----| Type = Point &&
# 19| Bad::Point::Point(const Point &) -> void
# 19| params:
#-----| 0: p#0
#-----| Type = const Point &
# 19| initializations:
# 19| 0: constructor init of field x
# 19| Type = int
# 19| ValueCategory = prvalue
# 19| 0: Unknown literal
# 19| Type = int
# 19| ValueCategory = prvalue
# 19| 1: constructor init of field y
# 19| Type = int
# 19| ValueCategory = prvalue
# 19| 0: Unknown literal
# 19| Type = int
# 19| ValueCategory = prvalue
# 19| body: { ... }
# 19| 0: return ...
# 19| Bad::Point::operator=(Point &&) -> Point &
# 19| params:
#-----| 0: p#0
#-----| Type = Point &&
# 19| Bad::Point::operator=(const Point &) -> Point &
# 19| params:
#-----| 0: p#0
#-----| Type = const Point &
# 22| Bad::Point::Point() -> void
# 22| params:
# 22| initializations:
# 22| body: { ... }
# 23| 0: return ...
# 26| Bad::CallCopyConstructor(const Point &) -> void
# 26| params:
# 26| 0: a
# 26| Type = const Point &
# 26| body: { ... }
# 27| 0: declaration
# 27| 0: definition of b
# 27| Type = Point
# 27| init: initializer for b
# 27| expr: (Point)...
# 27| Conversion = glvalue conversion
# 27| Type = Point
# 27| ValueCategory = prvalue(load)
# 27| expr: (reference dereference)
# 27| Type = const Point
# 27| ValueCategory = lvalue
# 27| expr: a
# 27| Type = const Point &
# 27| ValueCategory = prvalue(load)
# 28| 1: return ...
ir.cpp:
# 1| Constants() -> void
# 1| params:

45
cpp/ql/test/library-tests/ir/ir/aliased_ssa_ir.expected
View File

@@ -1,3 +1,48 @@
bad_asts.cpp:
# 14| Bad::CallBadMemberFunction() -> void
# 14| Block 0
# 14| v0_0(void) = EnterFunction :
# 14| mu0_1(unknown) = UnmodeledDefinition :
# 15| r0_2(glval<S>) = VariableAddress[s] :
# 15| r0_3(glval<int>) = FieldAddress[x] : r0_2
# 15| r0_4(int) = Constant[0] :
# 15| mu0_5(int) = Store : r0_3, r0_4
# 16| r0_6(glval<S>) = VariableAddress[s] :
# 16| r0_7(glval<unknown>) = FunctionAddress[MemberFunction] :
# 16| r0_8(int) = Constant[1] :
# 16| r0_9(int) = Call : r0_7, this:r0_6, r0_8
# 17| v0_10(void) = NoOp :
# 14| v0_11(void) = ReturnVoid :
# 14| v0_12(void) = UnmodeledUse : mu*
# 14| v0_13(void) = ExitFunction :
# 22| Bad::Point::Point() -> void
# 22| Block 0
# 22| v0_0(void) = EnterFunction :
# 22| mu0_1(unknown) = UnmodeledDefinition :
# 22| r0_2(glval<Point>) = InitializeThis :
# 23| v0_3(void) = NoOp :
# 22| v0_4(void) = ReturnVoid :
# 22| v0_5(void) = UnmodeledUse : mu*
# 22| v0_6(void) = ExitFunction :
# 26| Bad::CallCopyConstructor(const Point &) -> void
# 26| Block 0
# 26| v0_0(void) = EnterFunction :
# 26| mu0_1(unknown) = UnmodeledDefinition :
# 26| r0_2(glval<Point &>) = VariableAddress[a] :
# 26| m0_3(Point &) = InitializeParameter[a] : r0_2
# 27| r0_4(glval<Point>) = VariableAddress[b] :
# 27| r0_5(glval<Point &>) = VariableAddress[a] :
# 27| r0_6(Point &) = Load : r0_5, m0_3
# 27| r0_7(glval<Point>) = Convert : r0_6
# 27| r0_8(Point) = Load : r0_7, mu0_1
# 27| m0_9(Point) = Store : r0_4, r0_8
# 28| v0_10(void) = NoOp :
# 26| v0_11(void) = ReturnVoid :
# 26| v0_12(void) = UnmodeledUse : mu*
# 26| v0_13(void) = ExitFunction :
ir.cpp:
# 1| Constants() -> void
# 1| Block 0

29
cpp/ql/test/library-tests/ir/ir/bad_asts.cpp Normal file
View File

@@ -0,0 +1,29 @@
// semmle-extractor-options: -std=c++17
// Test cases that illustrate known bad ASTs that we have to work around in IR generation.
namespace Bad {
struct S {
int x;
template<int t>
int MemberFunction(int y) {
return t + x + y;
}
};
void CallBadMemberFunction() {
S s = {};
s.MemberFunction<6>(1); // Not marked as member function in AST.
}
struct Point {
int x;
int y;
Point() {
}
};
void CallCopyConstructor(const Point& a) {
Point b = a; // Copy constructor contains literal expressions with no values.
}
}

45
cpp/ql/test/library-tests/ir/ir/raw_ir.expected
View File

@@ -1,3 +1,48 @@
bad_asts.cpp:
# 14| Bad::CallBadMemberFunction() -> void
# 14| Block 0
# 14| v0_0(void) = EnterFunction :
# 14| mu0_1(unknown) = UnmodeledDefinition :
# 15| r0_2(glval<S>) = VariableAddress[s] :
# 15| r0_3(glval<int>) = FieldAddress[x] : r0_2
# 15| r0_4(int) = Constant[0] :
# 15| mu0_5(int) = Store : r0_3, r0_4
# 16| r0_6(glval<S>) = VariableAddress[s] :
# 16| r0_7(glval<unknown>) = FunctionAddress[MemberFunction] :
# 16| r0_8(int) = Constant[1] :
# 16| r0_9(int) = Call : r0_7, this:r0_6, r0_8
# 17| v0_10(void) = NoOp :
# 14| v0_11(void) = ReturnVoid :
# 14| v0_12(void) = UnmodeledUse : mu*
# 14| v0_13(void) = ExitFunction :
# 22| Bad::Point::Point() -> void
# 22| Block 0
# 22| v0_0(void) = EnterFunction :
# 22| mu0_1(unknown) = UnmodeledDefinition :
# 22| r0_2(glval<Point>) = InitializeThis :
# 23| v0_3(void) = NoOp :
# 22| v0_4(void) = ReturnVoid :
# 22| v0_5(void) = UnmodeledUse : mu*
# 22| v0_6(void) = ExitFunction :
# 26| Bad::CallCopyConstructor(const Point &) -> void
# 26| Block 0
# 26| v0_0(void) = EnterFunction :
# 26| mu0_1(unknown) = UnmodeledDefinition :
# 26| r0_2(glval<Point &>) = VariableAddress[a] :
# 26| mu0_3(Point &) = InitializeParameter[a] : r0_2
# 27| r0_4(glval<Point>) = VariableAddress[b] :
# 27| r0_5(glval<Point &>) = VariableAddress[a] :
# 27| r0_6(Point &) = Load : r0_5, mu0_1
# 27| r0_7(glval<Point>) = Convert : r0_6
# 27| r0_8(Point) = Load : r0_7, mu0_1
# 27| mu0_9(Point) = Store : r0_4, r0_8
# 28| v0_10(void) = NoOp :
# 26| v0_11(void) = ReturnVoid :
# 26| v0_12(void) = UnmodeledUse : mu*
# 26| v0_13(void) = ExitFunction :
ir.cpp:
# 1| Constants() -> void
# 1| Block 0

3
cpp/ql/test/library-tests/ir/ir/ssa_block_count.expected
View File

@@ -8,6 +8,8 @@
| IR: C | 1 |
| IR: Call | 1 |
| IR: CallAdd | 1 |
| IR: CallBadMemberFunction | 1 |
| IR: CallCopyConstructor | 1 |
| IR: CallMethods | 1 |
| IR: CallMin | 1 |
| IR: CallNestedTemplateFunc | 1 |
@@ -73,6 +75,7 @@
| IR: OperatorNew | 1 |
| IR: OperatorNewArray | 1 |
| IR: Parameters | 1 |
| IR: Point | 1 |
| IR: PointerCompare | 1 |
| IR: PointerCrement | 1 |
| IR: PointerOps | 1 |

45
cpp/ql/test/library-tests/ir/ir/unaliased_ssa_ir.expected
View File

@@ -1,3 +1,48 @@
bad_asts.cpp:
# 14| Bad::CallBadMemberFunction() -> void
# 14| Block 0
# 14| v0_0(void) = EnterFunction :
# 14| mu0_1(unknown) = UnmodeledDefinition :
# 15| r0_2(glval<S>) = VariableAddress[s] :
# 15| r0_3(glval<int>) = FieldAddress[x] : r0_2
# 15| r0_4(int) = Constant[0] :
# 15| mu0_5(int) = Store : r0_3, r0_4
# 16| r0_6(glval<S>) = VariableAddress[s] :
# 16| r0_7(glval<unknown>) = FunctionAddress[MemberFunction] :
# 16| r0_8(int) = Constant[1] :
# 16| r0_9(int) = Call : r0_7, this:r0_6, r0_8
# 17| v0_10(void) = NoOp :
# 14| v0_11(void) = ReturnVoid :
# 14| v0_12(void) = UnmodeledUse : mu*
# 14| v0_13(void) = ExitFunction :
# 22| Bad::Point::Point() -> void
# 22| Block 0
# 22| v0_0(void) = EnterFunction :
# 22| mu0_1(unknown) = UnmodeledDefinition :
# 22| r0_2(glval<Point>) = InitializeThis :
# 23| v0_3(void) = NoOp :
# 22| v0_4(void) = ReturnVoid :
# 22| v0_5(void) = UnmodeledUse : mu*
# 22| v0_6(void) = ExitFunction :
# 26| Bad::CallCopyConstructor(const Point &) -> void
# 26| Block 0
# 26| v0_0(void) = EnterFunction :
# 26| mu0_1(unknown) = UnmodeledDefinition :
# 26| r0_2(glval<Point &>) = VariableAddress[a] :
# 26| m0_3(Point &) = InitializeParameter[a] : r0_2
# 27| r0_4(glval<Point>) = VariableAddress[b] :
# 27| r0_5(glval<Point &>) = VariableAddress[a] :
# 27| r0_6(Point &) = Load : r0_5, m0_3
# 27| r0_7(glval<Point>) = Convert : r0_6
# 27| r0_8(Point) = Load : r0_7, mu0_1
# 27| m0_9(Point) = Store : r0_4, r0_8
# 28| v0_10(void) = NoOp :
# 26| v0_11(void) = ReturnVoid :
# 26| v0_12(void) = UnmodeledUse : mu*
# 26| v0_13(void) = ExitFunction :
ir.cpp:
# 1| Constants() -> void
# 1| Block 0