Owen Mansel-Chan
da8cc13506
go extractor: avoid long string concatenations
...
When we see "a" + "b" + "c" + "d", do not add a
row to the constvalues table for the intermiediate
strings "ab" and "abc". We still have entries for
the string literals ("a", "b", "c", and "d") and
the whole string concatenation ("abcd").
2024-03-11 10:53:26 +00:00
Michael B. Gale
ac394dc80c
Go: Better check for path prefixes
2024-03-05 13:46:33 +00:00
Michael B. Gale
b1e0bc03ab
Go: Fix check for whether it is safe to initialise a go.mod file in a given directory
2024-03-05 12:48:21 +00:00
Michael B. Gale
367ecf75d5
Go: Use import path for auto-generated Go module names
2024-03-05 12:48:21 +00:00
Michael B. Gale
2aa093c95c
Go: Move getImportPath to shared util package
2024-03-05 12:48:19 +00:00
Michael B. Gale
9b5bf519a1
Update go/extractor/project/project.go
...
Co-authored-by: Owen Mansel-Chan <62447351+owen-mc@users.noreply.github.com >
2024-03-04 12:25:40 +00:00
Michael B. Gale
acf2f761a6
Go: Improve log message for InitGoModForLegacyProject
2024-03-04 12:14:24 +00:00
Michael B. Gale
1a13a0e4c9
Go: Log discovered Go modules in case workspace files can't be read/parsed
2024-03-04 12:14:24 +00:00
Michael B. Gale
52b273ae23
Go: Include workspace count in success message
2024-03-04 12:14:24 +00:00
Michael B. Gale
8055c5d9e3
Go: Avoid extra loop to track unsuccessfulProjects
2024-03-04 12:14:23 +00:00
Michael B. Gale
020eb4aed7
Go: Use slices.Concat for bazelPaths
2024-03-04 12:14:23 +00:00
Michael B. Gale
040a288bb3
Go: Update comment to replace Go.mod with go.mod
2024-03-04 12:14:23 +00:00
Michael B. Gale
37212737fb
Go: Delete unused AnyGoFilesOutsideDirs
2024-03-04 12:14:22 +00:00
Michael B. Gale
4dd23d4767
Merge pull request #15791 from github/mbg/go/use-1.22-for-extractor
...
Go: Use Go 1.22 for the extractor
2024-03-04 11:53:37 +00:00
Michael B. Gale
0e9a7c84d1
Go: Update go.work.sum
2024-03-04 10:59:23 +00:00
Michael B. Gale
ff82eb95f5
Go: Use 1.22 in go.mod
2024-03-04 10:58:51 +00:00
Michael B. Gale
6563414370
Go: Allow 1.22 as a supported version
2024-03-04 10:56:03 +00:00
Michael B. Gale
0c93641b54
Merge pull request #15361 from github/mbg/go/legacy-gopath-mode-deprecated
...
Go: Update autobuilder to deal with the upcoming deprecation of the legacy GOPATH mode
2024-03-04 10:23:37 +00:00
Michael B. Gale
bda8a804ec
Go: Add go.work file
2024-03-01 14:50:00 +00:00
Michael B. Gale
008585eeba
Go: Include arguments in RunCmd error messages
2024-02-16 15:17:24 +00:00
Michael B. Gale
8886092cd0
Go: Try to ignore errors in go mod vendor calls
2024-02-16 15:15:58 +00:00
Michael B. Gale
4d28c0d2a9
Go: Call go mod vendor to synchronise vendor directory when it exists
2024-02-15 16:19:07 +00:00
Michael B. Gale
6267506a77
Go: Postpone go.mod creation until necessary
2024-02-14 19:12:36 +00:00
Michael B. Gale
1055e773ef
Go: Export InitGoModForLegacyProject
2024-02-14 19:12:35 +00:00
Michael B. Gale
4387c73d12
Go: Fix missing word in comment for discoverWorkspace
2024-02-14 19:12:35 +00:00
Michael B. Gale
6dbb5c5fdb
Go: Refactor Autobuild to use pairs of scripts and tools from a reusable array
2024-02-14 19:12:35 +00:00
Michael B. Gale
e2c673417f
Go: Only call EmitNewerGoVersionNeeded at most once
2024-02-14 19:12:35 +00:00
Michael B. Gale
6eac48caba
Go: Refactor greatest version logic into dedicated function
2024-02-14 19:12:34 +00:00
Michael B. Gale
058bf32ad0
Go: Initialise Go modules for stray source files outside of existing modules
2024-02-14 19:12:34 +00:00
Michael B. Gale
d99ad01efa
Go: Add module files which don't belong to a workspace, if there are workspaces
2024-02-14 19:12:34 +00:00
Michael B. Gale
251888a0bd
Go: Tell extractor to extract subdirectories as well
2024-02-14 19:12:33 +00:00
Michael B. Gale
925e99cdb2
Go: Use GoFilesOutsideDirs to find stray source files
2024-02-14 19:12:33 +00:00
Michael B. Gale
f0df7cd5c5
Go: Add GoFilesOutsideDirs function
2024-02-14 19:12:33 +00:00
Michael B. Gale
d4ea45bdaf
Go: Add comment to AnyGoFilesOutsideDirs and use slices.Contains
2024-02-14 19:12:33 +00:00
Michael B. Gale
843f7694fd
Go: Only relocate project to temp dir if there is only one workspace
2024-02-14 19:12:32 +00:00
Michael B. Gale
3a982de16f
Go: Workspaces only support mod=readonly
2024-02-14 19:12:32 +00:00
Michael B. Gale
9c3667dbf7
Go: Improve go.work file(s) found log message
2024-02-14 19:12:32 +00:00
Michael B. Gale
fd54350ba8
Go: Fix comment for getBuildRoots
2024-02-14 19:12:32 +00:00
Michael B. Gale
f084829154
Go: Only fail autobuilder if all projects cannot be extracted
2024-02-14 19:12:31 +00:00
Michael B. Gale
fbd7946cfd
Go: Fall back to ./... if there are no modules
...
Fixes issues for `dep` and `glide`
2024-02-14 19:12:31 +00:00
Michael B. Gale
0b8a917584
Go: Fix crash if WorkspaceFile.Go is nil
2024-02-14 19:12:30 +00:00
Michael B. Gale
a961e276c1
Go: Initialise filesToRemove to an empty array
2024-02-14 19:12:30 +00:00
Michael B. Gale
51eb487022
Go: Handle filepath.Rel failure
2024-02-14 19:12:30 +00:00
Michael B. Gale
c96735e17a
Go: Remove auto-generated go.mod files when done
2024-02-14 19:12:30 +00:00
Michael B. Gale
e79f5905e7
Go: Fix checks for dep and glide not working correctly
2024-02-14 19:12:29 +00:00
Michael B. Gale
ec902827f6
Go: Initialise go.mod for stray source files
2024-02-14 19:12:29 +00:00
Michael B. Gale
b9e96e4a27
Fixup: closing curly brace
2024-02-14 19:12:29 +00:00
Michael B. Gale
21fbb1b051
Go: Only initialise module if there are source files
2024-02-14 19:12:28 +00:00
Michael B. Gale
f48b1e57d7
Go: Check for relative paths warning even if go mod tidy is successful
2024-02-14 19:12:28 +00:00
Michael B. Gale
aa5e14f59f
Go: Replace BuildInfo with GoWorkspace
2024-02-14 19:12:28 +00:00
