hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-17 01:03:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #15085 from michaelnebel/csharp/telemetrycalls

Browse Source 
C#: Telemetry should only count calls in source.
This commit is contained in:
Michael Nebel
2023-12-13 13:46:16 +01:00
committed by GitHub
parent 16e86134f3 8218f80154
commit ffc36e4ccd
6 changed files with 12 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
csharp/ql/src/Telemetry/ExternalApi.qll
View File

@@ -134,7 +134,8 @@ module Results<relevantApi/1 getRelevantUsages> {
strictcount(Call c, ExternalApi api |
c.getTarget().getUnboundDeclaration() = api and
apiName = api.getApiName() and
getRelevantUsages(api)
getRelevantUsages(api) and
c.fromSource()
)
}

3
csharp/ql/src/Telemetry/ExternalLibraryUsage.ql
View File

@@ -14,7 +14,8 @@ private predicate getRelevantUsages(string namespace, int usages) {
usages =
strictcount(Call c, ExternalApi api |
c.getTarget().getUnboundDeclaration() = api and
api.getNamespace() = namespace
api.getNamespace() = namespace and
c.fromSource()
)
}

2
csharp/ql/test/query-tests/Telemetry/LibraryUsage/options Normal file
View File

@@ -0,0 +1,2 @@
semmle-extractor-options: /nostdlib /noconfig
semmle-extractor-options: --load-sources-from-project:${testdir}/../../../resources/stubs/_frameworks/Microsoft.NETCore.App/Microsoft.NETCore.App.csproj

3
csharp/ql/test/query-tests/Telemetry/SupportedExternalApis/options
View File

@@ -1,2 +1,3 @@
semmle-extractor-options: /r:System.Collections.Specialized.dll
semmle-extractor-options: /nostdlib /noconfig
semmle-extractor-options: --load-sources-from-project:${testdir}/../../../resources/stubs/_frameworks/Microsoft.NETCore.App/Microsoft.NETCore.App.csproj
semmle-extractor-options: ${testdir}/../../../resources/stubs/System.Web.cs

3
csharp/ql/test/query-tests/Telemetry/SupportedExternalSinks/options
View File

@@ -1,2 +1,3 @@
semmle-extractor-options: /r:System.Collections.Specialized.dll
semmle-extractor-options: /nostdlib /noconfig
semmle-extractor-options: --load-sources-from-project:${testdir}/../../../resources/stubs/_frameworks/Microsoft.NETCore.App/Microsoft.NETCore.App.csproj
semmle-extractor-options: ${testdir}/../../../resources/stubs/System.Web.cs

2
csharp/ql/test/query-tests/Telemetry/SupportedExternalSources/options Normal file
View File

@@ -0,0 +1,2 @@
semmle-extractor-options: /nostdlib /noconfig
semmle-extractor-options: --load-sources-from-project:${testdir}/../../../resources/stubs/_frameworks/Microsoft.NETCore.App/Microsoft.NETCore.App.csproj