mirror of
https://github.com/github/codeql.git
synced 2025-12-17 01:03:14 +01:00
Address review comments
This commit is contained in:
@@ -619,7 +619,7 @@ private predicate typeEquality(AstNode n1, TypePath prefix1, AstNode n2, TypePat
|
||||
)
|
||||
)
|
||||
or
|
||||
// an array list expression (`[1, 2, 3]`) has the type of the element
|
||||
// an array list expression with only one element (such as `[1]`) has type from that element
|
||||
n1 =
|
||||
any(ArrayListExpr ale |
|
||||
ale.getAnExpr() = n2 and
|
||||
|
||||
@@ -2730,8 +2730,8 @@ mod if_expr {
|
||||
S(2)
|
||||
};
|
||||
|
||||
// This code exhibits an explosion in type inference when type information is propagated
|
||||
// from an `if` expression to its branches.
|
||||
// This code would result in an explosion in type inference, if type information was
|
||||
// propagated between branches.
|
||||
let x = S(1);
|
||||
if b {
|
||||
let x = x.m2(); // $ target=m2
|
||||
|
||||
Reference in New Issue
Block a user