hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 03:05:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix comments

Browse Source
This commit is contained in:
Slavomir
2020-04-06 21:40:29 +03:00
parent 6d2c5be196
commit fd9e3a005e
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
ql/src/Security/CWE-681/IncorrectNumericConversion.ql
View File

@@ -118,13 +118,13 @@ predicate comparisonGreaterOperandIsEqualOrLess(
) {
conv.getTypeName() = typeName and
(
// exclude cases like: if parsed < math.MaxInt8 { int8(parsed)}
// exclude cases like: if parsed < math.MaxInt8 {return int8(parsed)}
ifExpr.getComparison().getGreaterOperand().getNumericValue() = value and
// and lesser is the conversion operand:
ifExpr.getComparison().getLesserOperand().getGlobalValueNumber() =
conv.getOperand().getGlobalValueNumber()
or
// exclude cases like: if err == nil && parsed < math.MaxInt8 { int8(parsed)}
// exclude cases like: if err == nil && parsed < math.MaxInt8 {return int8(parsed)}
exists(RelationalComparisonExpr andExpr |
andExpr = ifExpr.getLandExpr().getAnOperand().(RelationalComparisonExpr)
|