hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-26 17:25:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Tom Hvitved <hvitved@github.com>
This commit is contained in:
Alex Ford
2021-06-24 11:36:29 +01:00
committed by Alex Ford
parent 7415503772
commit fc8db88b66
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
ql/src/codeql_ruby/controlflow/CfgNodes.qll
View File

@@ -362,9 +362,9 @@ module ExprNodes {
}
/** A control-flow node that wraps an `ElementReference` AST expression. */
class ElementReferenceCfgNode extends ExprCfgNode {
override ElementReference e;
class ElementReferenceCfgNode extends MethodCallCfgNode {
ElementReferenceCfgNode() { e instanceof ElementReference }
final override ElementReference getExpr() { result = ExprCfgNode.super.getExpr() }
final override ElementReference getExpr() { result = super.getExpr() }
}
}

2
ql/src/codeql_ruby/dataflow/internal/TaintTrackingPrivate.qll
View File

@@ -32,6 +32,6 @@ predicate defaultAdditionalTaintStep(DataFlow::Node nodeFrom, DataFlow::Node nod
// element reference from nodeFrom
exists(CfgNodes::ExprNodes::ElementReferenceCfgNode ref |
ref = nodeTo.asExpr() and
ref.getExpr().getReceiver() = nodeFrom.asExpr().getExpr()
ref.getReceiver() = nodeFrom.asExpr()
)
}

2
ql/src/queries/security/cwe-089/SqlInjection.ql
View File

@@ -24,7 +24,7 @@ class SQLInjectionConfiguration extends TaintTracking::Configuration {
override predicate isSource(DataFlow::Node source) { source instanceof RemoteFlowSource }
override predicate isSink(DataFlow::Node sink) { sink = any(SqlExecution e) }
override predicate isSink(DataFlow::Node sink) { sink instanceof SqlExecution }
override predicate isSanitizerGuard(DataFlow::BarrierGuard guard) {
guard instanceof StringConstCompare or