hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-17 01:03:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #14815 from hvitved/type-tracking/param-consistency-checks

Browse Source 
Type tracking: Parameterize consistency checks
This commit is contained in:
Tom Hvitved
2023-11-20 11:05:06 +01:00
committed by GitHub
parent cf696f2639 40a07de566
commit fab6813a49
2 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
shared/typetracking/codeql/typetracking/TypeTracking.qll
View File

@@ -124,7 +124,9 @@ private import internal.TypeTrackingImpl as Impl
module TypeTracking<TypeTrackingInput I> {
private module MkImpl = Impl::TypeTracking<I>;
deprecated module ConsistencyChecks = MkImpl::ConsistencyChecks;
private module ConsistencyChecksInput implements MkImpl::ConsistencyChecksInputSig { }
deprecated module ConsistencyChecks = MkImpl::ConsistencyChecks<ConsistencyChecksInput>;
class TypeTracker = MkImpl::TypeTracker;

12
shared/typetracking/codeql/typetracking/internal/TypeTrackingImpl.qll
View File

@@ -17,8 +17,16 @@ private import codeql.typetracking.TypeTracking
module TypeTracking<TypeTrackingInput I> {
private import I
signature module ConsistencyChecksInputSig {
/** Holds if `n` should be excluded from the consistency test `unreachableNode`. */
default predicate unreachableNodeExclude(Node n) { none() }
/** Holds if `n` should be excluded from the consistency test `nonSourceStoreTarget`. */
default predicate nonSourceStoreTargetExclude(Node n) { none() }
}
/** Provides consistency checks for the type-tracker step relations. */
module ConsistencyChecks {
module ConsistencyChecks<ConsistencyChecksInputSig ConsistencyChecksInput> {
private predicate stepEntry(Node n, string kind) {
simpleLocalSmallStep(n, _) and kind = "simpleLocalSmallStep"
or
@@ -34,6 +42,7 @@ module TypeTracking<TypeTrackingInput I> {
* `LocalSourceNode`.
*/
query predicate unreachableNode(Node n, string msg) {
not ConsistencyChecksInput::unreachableNodeExclude(n) and
exists(string kind |
stepEntry(n, kind) and
not flowsTo(_, n) and
@@ -46,6 +55,7 @@ module TypeTracking<TypeTrackingInput I> {
* backtracking store target feature isn't enabled.
*/
query predicate nonSourceStoreTarget(Node n, string msg) {
not ConsistencyChecksInput::nonSourceStoreTargetExclude(n) and
not hasFeatureBacktrackStoreTarget() and
not n instanceof LocalSourceNode and
(storeStep(_, n, _) or loadStoreStep(_, n, _, _)) and