hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-16 08:43:11 +01:00
Code Issues Packages Projects Releases Wiki Activity

DataFlow: Don't become overlay informed if the flow is diff informed but no diff.

Browse Source
This commit is contained in:
Alex Eyers-Taylor
2025-08-27 16:45:04 +01:00
parent 9f3ab970ab
commit faa2d3cac3
1 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
shared/dataflow/codeql/dataflow/internal/DataFlowImplStage1.qll
View File

@@ -179,9 +179,8 @@ module MakeImplStage1<LocationSig Location, InputSig<Location> Lang> {
// configuration. In that case, the results of this configuration
// are typically in the same file as the final alert.
if
Config::observeDiffInformedIncrementalMode() and
AlertFiltering::diffInformationAvailable()
then AlertFiltering::locationIsInDiff(Config::getASelectedSourceLocation(source))
Config::observeDiffInformedIncrementalMode()
then AlertFiltering::diffInformationAvailable() implies AlertFiltering::locationIsInDiff(Config::getASelectedSourceLocation(source))
else (
// If we are in base-only global evaluation, do not filter out any sources.
not isEvaluatingInOverlay()
@@ -200,15 +199,18 @@ module MakeImplStage1<LocationSig Location, InputSig<Location> Lang> {
Config::isSink(sink)
) and
// See the comments in `isFilteredSource` for the reasoning behind the following.
if
Config::observeDiffInformedIncrementalMode() and
AlertFiltering::diffInformationAvailable()
then AlertFiltering::locationIsInDiff(Config::getASelectedSinkLocation(sink))
if
Config::observeDiffInformedIncrementalMode()
then AlertFiltering::diffInformationAvailable() implies AlertFiltering::locationIsInDiff(Config::getASelectedSinkLocation(sink))
else (
// If we are in base-only global evaluation, do not filter out any sources.
not isEvaluatingInOverlay()
or
// If we are in global evaluation with an overlay present, restrict
// sources to those visible in the overlay or
isOverlayNode(sink)
)
}
private predicate hasFilteredSource() { isFilteredSource(_) }