hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-17 01:03:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #20546 from github/idrissrio/ql-constant

Browse Source 
Java: Fix false positives in evaluation-to-constant query for ErrorType
This commit is contained in:
Idriss Riouak
2025-09-30 14:24:28 +02:00
committed by GitHub
parent 90a7a58929 63771110a5
commit fa8cbeeb44
5 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

0
java/ql/integration-tests/java/evaluation-to-constant-errortype/ConstantExpAppearsNonConstant.expected Normal file
View File

2
java/ql/integration-tests/java/evaluation-to-constant-errortype/ConstantExpAppearsNonConstant.qlref Normal file
View File

@@ -0,0 +1,2 @@
query: Likely Bugs/Arithmetic/ConstantExpAppearsNonConstant.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql

7
java/ql/integration-tests/java/evaluation-to-constant-errortype/Test.java Normal file
View File

@@ -0,0 +1,7 @@
class Test {
public static void updateFlashlights(Minecraft mc){
if(mc.world != null){
}
}
}

2
java/ql/integration-tests/java/evaluation-to-constant-errortype/test.py Normal file
View File

@@ -0,0 +1,2 @@
def test(codeql, java):
codeql.database.create(build_mode="none")

2
java/ql/src/Likely Bugs/Arithmetic/ConstantExpAppearsNonConstant.ql
View File

@@ -19,7 +19,7 @@ predicate isConstantExp(Expr e) {
// A literal is constant.
e instanceof Literal
or
e instanceof TypeAccess
e instanceof TypeAccess and not e.(TypeAccess).getType() instanceof ErrorType
or
e instanceof ArrayTypeAccess
or