hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 11:15:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

Kotlin: Use trace (silently for now) rather than info for writing TRAP files

Browse Source 
The on-demand "Writing trap file for: " messages are drowning out
everything else while running the tests.
This commit is contained in:
Ian Lynagh
2021-10-27 18:05:50 +01:00
parent d6692e434a
commit f95934a0c5
2 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
java/kotlin-extractor/src/main/java/com/semmle/extractor/java/OdasaOutput.java
View File

@@ -278,13 +278,13 @@ public class OdasaOutput {
if (!currVersion.isValid()) {
log.warn("Not rewriting trap file for: " + sym + " " + trapVersion + " " + currVersion + " " + trap);
} else if (currVersion.newerThan(trapVersion)) {
log.info("Rewriting trap file for: " + sym + " " + trapVersion + " " + currVersion + " " + trap);
log.trace("Rewriting trap file for: " + sym + " " + trapVersion + " " + currVersion + " " + trap);
deleteTrapFileAndDependencies(sym);
} else {
return null;
}
} else {
log.info("Writing trap file for: " + sym.getName() + " " + currVersion + " " + trap);
log.trace("Writing trap file for: " + sym.getName() + " " + currVersion + " " + trap);
}
return trapWriter(trap, sym);
}

6
java/kotlin-extractor/src/main/kotlin/utils/Logger.kt
View File

@@ -43,13 +43,15 @@ open class Logger(val logCounter: LogCounter, open val tw: TrapWriter) {
println(fullMsg)
}
fun trace(msg: String) {
info(msg)
if(false) {
info(msg)
}
}
fun debug(msg: String) {
info(msg)
}
fun trace(msg: String, exn: Exception) {
info(msg + " // " + exn)
trace(msg + " // " + exn)
}
fun warn(severity: Severity, msg: String, locationString: String? = null, locationId: Label<DbLocation> = tw.unknownLocation, stackIndex: Int = 2) {
val st = Exception().stackTrace