hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-20 14:17:11 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: QLDoc and test for HeuristicConnectEntryPoint

Browse Source
This commit is contained in:
Asger Feldthaus
2021-02-15 14:39:51 +00:00
parent 4f04901d96
commit f8fefd5d1e
4 changed files with 16 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
javascript/ql/src/semmle/javascript/frameworks/Redux.qll
View File

@@ -1134,9 +1134,11 @@ module Redux {
}
/**
* An entry point in the API graphs corresponding to functions named `mapDispatchToProps`,
* used to catch cases where the call to `connect` was not found (usually because of it being
* wrapped in another function, which API graphs won't look through).
* An API entry point corresponding to a `connect` function which we couldn't recognize exactly.
*
* The `connect` call is recognized based on an argument being named either `mapStateToProps` or `mapDispatchToProps`.
* Used to catch cases where the `connect` function was not recognized by API graphs (usually because of it being
* wrapped in another function, which API graphs won't look through).
*/
private class HeuristicConnectEntryPoint extends API::EntryPoint {
HeuristicConnectEntryPoint() { this = "react-redux-connect" }

5
javascript/ql/test/library-tests/frameworks/Redux/react-redux.jsx
View File

@@ -92,3 +92,8 @@ function mapStateToProps(state) {
const mapDispatchToProps = { toolkitAction, manualAction };
const ConnectedComponent = connect(mapStateToProps, mapDispatchToProps)(MyComponent);
function connectLike(f, g) {
return c => somethingWeirdAndComplicated(f, g)(c);
}
const ConnectedComponent2 = connectLike(mapStateToProps, mapDispatchToProps)(MyComponent);

4
javascript/ql/test/library-tests/frameworks/Redux/test.expected
View File

@@ -112,6 +112,10 @@ taintFlow
| react-redux.jsx:69:31:69:38 | source() | react-redux.jsx:75:10:75:36 | props.p ... Action2 |
| react-redux.jsx:69:31:69:38 | source() | react-redux.jsx:76:10:76:36 | props.p ... Action3 |
| react-redux.jsx:70:30:70:37 | source() | react-redux.jsx:77:10:77:28 | props.propFromAsync |
reactComponentRef
| react-redux.jsx:64:1:80:1 | functio ... r}}/>\\n} | react-redux.jsx:64:1:80:1 | functio ... r}}/>\\n} |
| react-redux.jsx:64:1:80:1 | functio ... r}}/>\\n} | react-redux.jsx:94:28:94:84 | connect ... ponent) |
| react-redux.jsx:64:1:80:1 | functio ... r}}/>\\n} | react-redux.jsx:97:12:97:12 | c |
getAffectedStateAccessPath
| react-redux.jsx:12:33:17:9 | (state, ... } | toolkit |
| react-redux.jsx:18:41:23:9 | (state, ... } | toolkit |

2
javascript/ql/test/library-tests/frameworks/Redux/test.ql
View File

@@ -59,3 +59,5 @@ class BasicTaint extends TaintTracking::Configuration {
query predicate taintFlow(DataFlow::Node source, DataFlow::Node sink) {
any(BasicTaint cfg).hasFlow(source, sink)
}
query DataFlow::SourceNode reactComponentRef(ReactComponent component) { result = component.getAComponentCreatorReference() }