hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 03:05:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

C++: Fixed incorrect comments in testcases

Browse Source
This commit is contained in:
Mathias Vorreiter Pedersen
2020-01-10 12:24:43 +01:00
parent d9f931da3c
commit f80c13abd7
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
cpp/ql/test/query-tests/Likely Bugs/Likely Typos/AssignWhereCompareMeant/test.cpp
View File

@@ -126,7 +126,7 @@ void f2() {
}
void f3(int x, int y) {
if(x == 1 && (y = 2)) { // GOOD [FALSE POSITIVE]: the programmer seems to be okay with unparenthesized
if(x == 1 && (y = 2)) { // GOOD: the programmer seems to be okay with unparenthesized
// comparison operands, so the parenthesis was used to mark this
// as an assignment
}
@@ -138,13 +138,13 @@ void f3(int x, int y) {
if(((z == 42) || (y = 2)) && (x == 1)) { // BAD
}
if((y = 2) && (x == z || x == 1)) { // GOOD [FALSE POSITIVE]
if((y = 2) && (x == z || x == 1)) { // GOOD
}
if(((x == 42) || x == 1) && (y = 2)) { // BAD
}
if(x == 10 || (x == 42 && x == 1) && (y = 2)) { // GOOD [FALSE POSITIVE]
if(x == 10 || (x == 42 && x == 1) && (y = 2)) { // GOOD
}
if(x == 10 || ((x == 42) && (y = 2)) && (z == 1)) { // BAD