Address review comments.

This commit is contained in:
Sauyon Lee
2020-03-25 03:27:30 -07:00
parent bd5f0b01cf
commit f77d46f296

View File

@@ -30,15 +30,6 @@ module OpenUrlRedirect {
override predicate isBarrier(DataFlow::Node node) { node instanceof Barrier }
override predicate isAdditionalFlowStep(DataFlow::Node pred, DataFlow::Node succ) {
// A write to URL.Host
exists(Write write, Field f, DataFlow::SsaNode var |
write.writesField(var.getAUse(), f, pred) and
succ = var.getAUse() and
write.getASuccessor+() = succ.asInstruction() and
f.getName() = "Host" and
var.getType().hasQualifiedName("net/url", "URL")
)
or
// taint steps that do not include flow through fields
TaintTracking::localTaintStep(pred, succ) and not TaintTracking::fieldReadStep(pred, succ)
or