mirror of
https://github.com/github/codeql.git
synced 2026-01-30 06:42:57 +01:00
Address review comments.
This commit is contained in:
@@ -30,15 +30,6 @@ module OpenUrlRedirect {
|
||||
override predicate isBarrier(DataFlow::Node node) { node instanceof Barrier }
|
||||
|
||||
override predicate isAdditionalFlowStep(DataFlow::Node pred, DataFlow::Node succ) {
|
||||
// A write to URL.Host
|
||||
exists(Write write, Field f, DataFlow::SsaNode var |
|
||||
write.writesField(var.getAUse(), f, pred) and
|
||||
succ = var.getAUse() and
|
||||
write.getASuccessor+() = succ.asInstruction() and
|
||||
f.getName() = "Host" and
|
||||
var.getType().hasQualifiedName("net/url", "URL")
|
||||
)
|
||||
or
|
||||
// taint steps that do not include flow through fields
|
||||
TaintTracking::localTaintStep(pred, succ) and not TaintTracking::fieldReadStep(pred, succ)
|
||||
or
|
||||
|
||||
Reference in New Issue
Block a user